date:20180920

[jira] [Commented] (SCB-932) Time jump cause the new request injected

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623028#comment-16623028
 ] 

ASF GitHub Bot commented on SCB-932:


wujimin commented on a change in pull request #919: [SCB-932]Time jump cause 
the new request injected
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/919#discussion_r219376212
 
 

 ##
 File path: 
handlers/handler-flowcontrol-qps/src/main/java/org/apache/servicecomb/qps/QpsController.java
 ##
 @@ -57,7 +57,8 @@ public void setQpsLimit(Integer qpsLimit) {
   public boolean isLimitNewRequest() {
 long newCount = requestCount.incrementAndGet();
 long msNow = System.currentTimeMillis();
-if (msNow - msCycleBegin > CYCLE_LENGTH) {
+//时间跳变(9/21->9/20)会导致本不该拒绝的请求被拒绝
 
 Review comment:
   new code comments better to be english


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Time jump cause the new request injected
> 
>
> Key: SCB-932
> URL: https://issues.apache.org/jira/browse/SCB-932
> Project: Apache ServiceComb
>  Issue Type: Task
>Reporter: laijianbin
>Assignee: laijianbin
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-836) Support the nesting SagaStart

2018-09-20 Thread Willem Jiang (JIRA)



 [ 
https://issues.apache.org/jira/browse/SCB-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-836:
-
Description: 
We can take the 
[nesting-lras|https://github.com/eclipse/microprofile-lra/blob/master/spec/src/main/asciidoc/microprofile-lra-spec.adoc#323-nesting-lras]
 from the microprofile as an example. 


An activity can be scoped within an existing Saga using the @SagaStart 
annotation. Invoking a method marked with this annotation will start a new Saga 
whose outcome depends upon whether the enclosing Saga is closed or cancelled.

* If the nested Saga is closed but the outer Saga is cancelled then the 
participants registered with the nested Saga will be told to compensate.

* If the nested Saga is cancelled the outer Saga can be still closed.

  was:
We can take the 
[nesting-lras|https://github.com/eclipse/microprofile-lra/blob/master/spec/src/main/asciidoc/microprofile-lra-spec.adoc#323-nesting-lras]
 from the microprofile as an example. 


An activity can be scoped within an existing Saga using the @NestedSaga 
annotation. Invoking a method marked with this annotation will start a new Saga 
whose outcome depends upon whether the enclosing Saga is closed or cancelled.

* If the nested Saga is closed but the outer Saga is cancelled then the 
participants registered with the nested Saga will be told to compensate.

* If the nested Saga is cancelled the outer Saga can be still closed.


> Support the nesting SagaStart
> -
>
> Key: SCB-836
> URL: https://issues.apache.org/jira/browse/SCB-836
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Saga
>Reporter: Willem Jiang
>Priority: Major
>
> We can take the 
> [nesting-lras|https://github.com/eclipse/microprofile-lra/blob/master/spec/src/main/asciidoc/microprofile-lra-spec.adoc#323-nesting-lras]
>  from the microprofile as an example. 
> An activity can be scoped within an existing Saga using the @SagaStart 
> annotation. Invoking a method marked with this annotation will start a new 
> Saga whose outcome depends upon whether the enclosing Saga is closed or 
> cancelled.
> * If the nested Saga is closed but the outer Saga is cancelled then the 
> participants registered with the nested Saga will be told to compensate.
> * If the nested Saga is cancelled the outer Saga can be still closed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-932) Time jump cause the new request injected

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622988#comment-16622988
 ] 

ASF GitHub Bot commented on SCB-932:


laijianbin closed pull request #918: 【SCB-932】Time jump cause the new request 
injected
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/918
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/handlers/handler-flowcontrol-qps/src/main/java/org/apache/servicecomb/qps/QpsController.java
 
b/handlers/handler-flowcontrol-qps/src/main/java/org/apache/servicecomb/qps/QpsController.java
index 8bc147b8c..8ca7dc648 100644
--- 
a/handlers/handler-flowcontrol-qps/src/main/java/org/apache/servicecomb/qps/QpsController.java
+++ 
b/handlers/handler-flowcontrol-qps/src/main/java/org/apache/servicecomb/qps/QpsController.java
@@ -57,7 +57,8 @@ public void setQpsLimit(Integer qpsLimit) {
   public boolean isLimitNewRequest() {
 long newCount = requestCount.incrementAndGet();
 long msNow = System.currentTimeMillis();
-if (msNow - msCycleBegin > CYCLE_LENGTH) {
+//时间跳变(9/21->9/20)会导致本不该拒绝的请求被拒绝
+if (msNow - msCycleBegin > CYCLE_LENGTH || msNow - msCycleBegin < 
-CYCLE_LENGTH) {
   // 新周期
   // 会有多线程竞争，互相覆盖的问题，不过无所谓，不会有什么后果
   lastRequestCount = newCount;


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Time jump cause the new request injected
> 
>
> Key: SCB-932
> URL: https://issues.apache.org/jira/browse/SCB-932
> Project: Apache ServiceComb
>  Issue Type: Task
>Reporter: laijianbin
>Assignee: laijianbin
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-915) saga alpha event scanner optimization

2018-09-20 Thread FuChenGeng (JIRA)



 [ 
https://issues.apache.org/jira/browse/SCB-915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

FuChenGeng updated SCB-915:
---
Description: 
1.the compensate logic for retry scenarios is not perfect, in some place it do 
not considering retry scenarios.

2.do one compensation in one event scanner cycle,it mean that if there are 1000 
aborted event, it will cost at lest 500s to compensate it. And it has some bugs 
like

[https://github.com/apache/incubator-servicecomb-saga/issues/253]

3.all hot and cold data are in the same table

4. omega do not send every try event to alpha.omega do it's try logic by itself.

  was:
1.the compensate logic for retry scenarios is not perfect, in some place it do 
not considering retry scenarios.

2.do one compensation in one event scanner cycle,it mean that if there are 1000 
aborted event, it will cost at lest 500s to compensate it. And it has some bugs 
like

[https://github.com/apache/incubator-servicecomb-saga/issues/253]

3.all hot and cold data are in the same table


> saga alpha event scanner optimization
> -
>
> Key: SCB-915
> URL: https://issues.apache.org/jira/browse/SCB-915
> Project: Apache ServiceComb
>  Issue Type: Improvement
>Reporter: FuChenGeng
>Assignee: FuChenGeng
>Priority: Major
>
> 1.the compensate logic for retry scenarios is not perfect, in some place it 
> do not considering retry scenarios.
> 2.do one compensation in one event scanner cycle,it mean that if there are 
> 1000 aborted event, it will cost at lest 500s to compensate it. And it has 
> some bugs like
> [https://github.com/apache/incubator-servicecomb-saga/issues/253]
> 3.all hot and cold data are in the same table
> 4. omega do not send every try event to alpha.omega do it's try logic by 
> itself.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SCB-932) Time jump cause the new request injected

2018-09-20 Thread laijianbin (JIRA)

laijianbin created SCB-932:
--

 Summary: Time jump cause the new request injected
 Key: SCB-932
 URL: https://issues.apache.org/jira/browse/SCB-932
 Project: Apache ServiceComb
  Issue Type: Task
Reporter: laijianbin
Assignee: laijianbin






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-932) Time jump cause the new request injected

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622991#comment-16622991
 ] 

ASF GitHub Bot commented on SCB-932:


laijianbin commented on issue #918: 【SCB-932】Time jump cause the new request 
injected
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/918#issuecomment-423398044
 
 
   Using  msNow < msCycleBegin  more reasonable


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Time jump cause the new request injected
> 
>
> Key: SCB-932
> URL: https://issues.apache.org/jira/browse/SCB-932
> Project: Apache ServiceComb
>  Issue Type: Task
>Reporter: laijianbin
>Assignee: laijianbin
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-909) Add fault tolerance for service comb TCC

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623002#comment-16623002
 ] 

ASF GitHub Bot commented on SCB-909:


cherrylzhao commented on a change in pull request #302: SCB-909 Add fault 
tolerance for service comb TCC  (WIP)
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/302#discussion_r219373357
 
 

 ##
 File path: 
omega/omega-connector/omega-connector-grpc/src/test/java/org/apache/servicecomb/saga/omega/connector/grpc/tcc/LoadBalanceContextBuilderTest.java
 ##
 @@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+
+package org.apache.servicecomb.saga.omega.connector.grpc.tcc;
+
+import static com.seanyinx.github.unit.scaffolding.Randomness.uniquify;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.is;
+import static org.hamcrest.core.IsInstanceOf.instanceOf;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+import com.google.common.collect.Lists;
+import io.grpc.ManagedChannel;
+import io.grpc.inprocess.InProcessServerBuilder;
+import io.grpc.testing.GrpcCleanupRule;
+import java.io.IOException;
+import java.util.ArrayList;
+import org.apache.servicecomb.saga.omega.connector.grpc.AlphaClusterConfig;
+import org.apache.servicecomb.saga.omega.context.ServiceConfig;
+import 
org.apache.servicecomb.saga.omega.transaction.tcc.CoordinateMessageHandler;
+import org.apache.servicecomb.saga.omega.transaction.tcc.TccMessageHandler;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+
+public class LoadBalanceContextBuilderTest {
+
+  @Rule
+  public final GrpcCleanupRule grpcCleanup = new GrpcCleanupRule();
+
+  private final AlphaClusterConfig clusterConfig = 
mock(AlphaClusterConfig.class);
+  private final TccMessageHandler tccMessageHandler = 
mock(CoordinateMessageHandler.class);
+  private final String serverName = uniquify("serviceName");
+  private final ServiceConfig serviceConfig = new ServiceConfig(serverName);
+  protected final String[] addresses = {"localhost:8080", "localhost:8090"};
+
+  private  LoadBalanceContextBuilder tccLoadBalanceContextBuilder;
+  private  LoadBalanceContextBuilder sagaLoadBalanceContextBuilder;
+
+  @Before
+  public void setup() throws IOException {
+// Create a server, add service, start, and register for automatic 
graceful shutdown.
+
grpcCleanup.register(InProcessServerBuilder.forName("localhost:8080").directExecutor().build().start());
+
grpcCleanup.register(InProcessServerBuilder.forName("localhost:8090").directExecutor().build().start());
+
when(clusterConfig.getAddresses()).thenReturn(Lists.newArrayList(addresses));
+when(clusterConfig.getTccMessageHandler()).thenReturn(tccMessageHandler);
+tccLoadBalanceContextBuilder =
+new LoadBalanceContextBuilder(TransactionType.TCC, clusterConfig, 
serviceConfig, 30);
+sagaLoadBalanceContextBuilder =
+new LoadBalanceContextBuilder(TransactionType.SAGA, clusterConfig, 
serviceConfig, 30);
+  }
+
+  @After
+  public void teardown() {
+  }
+
+  @Test
+  public void buildTccLoadBalanceContextWithoutSsl() {
+when(clusterConfig.isEnableSSL()).thenReturn(false);
+
+LoadBalanceContext loadContext = tccLoadBalanceContextBuilder.build();
+assertThat(loadContext.getPendingTaskRunner().getReconnectDelay(), is(30));
+assertThat(loadContext.getSenders().size(), is(2));
+assertThat(loadContext.getSenders().keySet().iterator().next(), 
instanceOf(TccMessageSender.class));
+assertThat(loadContext.getSenders().values().iterator().next(), is(0l));
+assertThat(loadContext.getChannels().size(), is(2));
+loadContext.getSenders().keySet().iterator().next().close();
+shutdownChannels(loadContext);
+  }
+
+  @Test
+  public void buildTccLoadBalanceContextWithSsl() {
+when(clusterConfig.isEnableSSL()).thenReturn(true);
+
when(clusterConfig.getCert()).thenReturn(getClass().getClassLoader().getResource("client.crt").getFile());
+

[jira] [Commented] (SCB-909) Add fault tolerance for service comb TCC

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623006#comment-16623006
 ] 

ASF GitHub Bot commented on SCB-909:


cherrylzhao commented on a change in pull request #302: SCB-909 Add fault 
tolerance for service comb TCC  (WIP)
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/302#discussion_r219373530
 
 

 ##
 File path: 
omega/omega-connector/omega-connector-grpc/src/main/java/org/apache/servicecomb/saga/omega/connector/grpc/tcc/GrpcCoordinateStreamObserver.java
 ##
 @@ -6,33 +6,34 @@
  * (the "License"); you may not use this file except in compliance with
 
 Review comment:
   sorry, I haven't understand what it mean.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add fault tolerance for service comb TCC
> 
>
> Key: SCB-909
> URL: https://issues.apache.org/jira/browse/SCB-909
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Saga
>Affects Versions: saga-0.3.0
>Reporter: cherrylzhao
>Assignee: cherrylzhao
>Priority: Major
> Fix For: saga-0.3.0
>
>
> TCC fault tolerance incude following point.
> # omega can switch to another available alpha when sending message failed.
> # if omega resend logic (different alpha) failed, omega can rollback local 
> data automatically.
> # alpha do resend logic (same omega) when ACK failed, if resend failed, dirty 
> data can left in database, this will be handled by scanner.
> # design transaction timeout mechanics, if scanner found event won't 
> completed within expected time, sending componsate command to omega, it has 
> different type compare with normal.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-915) saga alpha event scanner optimization

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623009#comment-16623009
 ] 

ASF GitHub Bot commented on SCB-915:


oliugian closed pull request #299: SCB-915:saga alpha event scanner optimization
URL: https://github.com/apache/incubator-servicecomb-saga/pull/299
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/AlphaException.java
 
b/alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/AlphaException.java
index a7bb7564..1f63b14d 100644
--- 
a/alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/AlphaException.java
+++ 
b/alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/AlphaException.java
@@ -18,6 +18,7 @@
 package org.apache.servicecomb.saga.alpha.core;
 
 public class AlphaException extends RuntimeException {
+
   public AlphaException(String cause) {
 super(cause);
   }
diff --git 
a/alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/Command.java
 
b/alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/Command.java
index 6c8f3708..3c222c67 100644
--- 
a/alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/Command.java
+++ 
b/alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/Command.java
@@ -85,7 +85,8 @@ public Command(long id,
   String compensationMethod,
   byte[] payloads) {
 
-this(id, serviceName, instanceId, globalTxId, localTxId, parentTxId, 
compensationMethod, payloads, NEW.name());
+this(id, serviceName, instanceId, globalTxId, localTxId, parentTxId, 
compensationMethod,
+payloads, NEW.name());
   }
 
   public Command(TxEvent event) {
diff --git 
a/alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/CommandRepository.java
 
b/alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/CommandRepository.java
index 2bbea774..6e50619b 100644
--- 
a/alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/CommandRepository.java
+++ 
b/alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/CommandRepository.java
@@ -21,11 +21,15 @@
 
 public interface CommandRepository {
 
-  void saveCompensationCommands(String globalTxId);
+  void saveCompensationCommands(String globalTxId, String localTxId);
 
   void markCommandAsDone(String globalTxId, String localTxId);
 
+  void markCommandAsPending(String globalTxId, String localTxId);
+
   List findUncompletedCommands(String globalTxId);
 
-  List findFirstCommandToCompensate();
+  List findAllCommandsToCompensate();
+
+  List findPendingCommands();
 }
diff --git 
a/alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/CompositeOmegaCallback.java
 
b/alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/CompositeOmegaCallbackRunner.java
similarity index 50%
rename from 
alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/CompositeOmegaCallback.java
rename to 
alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/CompositeOmegaCallbackRunner.java
index 54e78f7b..058e570c 100644
--- 
a/alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/CompositeOmegaCallback.java
+++ 
b/alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/CompositeOmegaCallbackRunner.java
@@ -20,22 +20,35 @@
 import static java.util.Collections.emptyMap;
 
 import java.lang.invoke.MethodHandles;
+import java.util.ArrayList;
+import java.util.List;
 import java.util.Map;
+import java.util.concurrent.Callable;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public class CompositeOmegaCallback implements OmegaCallback {
+public class CompositeOmegaCallbackRunner implements OmegaCallback, 
Callable> {
+
   private static final Logger LOG = 
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
   private final Map> callbacks;
+  private final List txEvents;
 
-  public CompositeOmegaCallback(Map> 
callbacks) {
+  public CompositeOmegaCallbackRunner(Map> 
callbacks,
+  List txEvents) {
 this.callbacks = callbacks;
+this.txEvents = txEvents;
+  }
+
+  @Override
+  public List call() {
+return compensateAllEvents(txEvents);
   }
 
   @Override
   public void compensate(TxEvent event) {
-Map serviceCallbacks = 
callbacks.getOrDefault(event.serviceName(), emptyMap());
+Map serviceCallbacks = callbacks
+.getOrDefault(event.serviceName(), emptyMap());
 
 if (serviceCallbacks.isEmpty()) {
   throw new AlphaException("No such omega callback found for service " + 
event.serviceName());
@@ -43,7 +56,8 @@ public

[jira] [Commented] (SCB-932) Time jump cause the new request injected

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623010#comment-16623010
 ] 

ASF GitHub Bot commented on SCB-932:


coveralls commented on issue #919: [SCB-932]Time jump cause the new request 
injected
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/919#issuecomment-423401348
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/19116613/badge)](https://coveralls.io/builds/19116613)
   
   Coverage decreased (-0.004%) to 86.203% when pulling 
**74f11ff8e0aa503613080691ccd6fc36361d9df4 on laijianbin:patch-6** into 
**20627dd0af924dcdf51fe529afe49e51864dc18c on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Time jump cause the new request injected
> 
>
> Key: SCB-932
> URL: https://issues.apache.org/jira/browse/SCB-932
> Project: Apache ServiceComb
>  Issue Type: Task
>Reporter: laijianbin
>Assignee: laijianbin
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-925) Springmvc, when have defaultValue, required should be false

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622957#comment-16622957
 ] 

ASF GitHub Bot commented on SCB-925:


coveralls commented on issue #914: [SCB-925] Springmvc, when have defaultValue, 
required should be false
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/914#issuecomment-423389803
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/19116059/badge)](https://coveralls.io/builds/19116059)
   
   Coverage decreased (-0.07%) to 86.138% when pulling 
**94840274699059c104f4db9627fb82850825fd05 on weichao666:defaultvalue** into 
**20627dd0af924dcdf51fe529afe49e51864dc18c on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Springmvc, when have defaultValue, required should be false
> ---
>
> Key: SCB-925
> URL: https://issues.apache.org/jira/browse/SCB-925
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Java-Chassis
>Reporter: WeiChao
>Assignee: WeiChao
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-923) Provide API to access the TCC events

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623001#comment-16623001
 ] 

ASF GitHub Bot commented on SCB-923:


WillemJiang commented on issue #310: SCB-923 Add Restful API for Alpha TCC 
Service
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/310#issuecomment-423399710
 
 
   @cherrylzhao @Chenhaoqing @oliugian Please take a look at this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Provide API to access the TCC events 
> -
>
> Key: SCB-923
> URL: https://issues.apache.org/jira/browse/SCB-923
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Saga
>Reporter: Willem Jiang
>Assignee: Willem Jiang
>Priority: Major
> Fix For: saga-0.3.0
>
>
> As a part to integration test, we need to know what kind of event that Alpha 
> get.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-909) Add fault tolerance for service comb TCC

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623023#comment-16623023
 ] 

ASF GitHub Bot commented on SCB-909:


coveralls edited a comment on issue #302: SCB-909 Add fault tolerance for 
service comb TCC  (WIP)
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/302#issuecomment-422360764
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/19116607/badge)](https://coveralls.io/builds/19116607)
   
   Coverage decreased (-0.4%) to 91.856% when pulling 
**1e87c41e667fec52b2db49fc03e1303029685e9d on cherrylzhao:master** into 
**cc38fe9dca2a4c2f09d949117a61fa0ee2586a5f on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add fault tolerance for service comb TCC
> 
>
> Key: SCB-909
> URL: https://issues.apache.org/jira/browse/SCB-909
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Saga
>Affects Versions: saga-0.3.0
>Reporter: cherrylzhao
>Assignee: cherrylzhao
>Priority: Major
> Fix For: saga-0.3.0
>
>
> TCC fault tolerance incude following point.
> # omega can switch to another available alpha when sending message failed.
> # if omega resend logic (different alpha) failed, omega can rollback local 
> data automatically.
> # alpha do resend logic (same omega) when ACK failed, if resend failed, dirty 
> data can left in database, this will be handled by scanner.
> # design transaction timeout mechanics, if scanner found event won't 
> completed within expected time, sending componsate command to omega, it has 
> different type compare with normal.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-909) Add fault tolerance for service comb TCC

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622977#comment-16622977
 ] 

ASF GitHub Bot commented on SCB-909:


WillemJiang commented on a change in pull request #302: SCB-909 Add fault 
tolerance for service comb TCC  (WIP)
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/302#discussion_r219368991
 
 

 ##
 File path: 
omega/omega-connector/omega-connector-grpc/src/test/java/org/apache/servicecomb/saga/omega/connector/grpc/tcc/LoadBalanceContextBuilderTest.java
 ##
 @@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+
+package org.apache.servicecomb.saga.omega.connector.grpc.tcc;
+
+import static com.seanyinx.github.unit.scaffolding.Randomness.uniquify;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.is;
+import static org.hamcrest.core.IsInstanceOf.instanceOf;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+import com.google.common.collect.Lists;
+import io.grpc.ManagedChannel;
+import io.grpc.inprocess.InProcessServerBuilder;
+import io.grpc.testing.GrpcCleanupRule;
+import java.io.IOException;
+import java.util.ArrayList;
+import org.apache.servicecomb.saga.omega.connector.grpc.AlphaClusterConfig;
+import org.apache.servicecomb.saga.omega.context.ServiceConfig;
+import 
org.apache.servicecomb.saga.omega.transaction.tcc.CoordinateMessageHandler;
+import org.apache.servicecomb.saga.omega.transaction.tcc.TccMessageHandler;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+
+public class LoadBalanceContextBuilderTest {
+
+  @Rule
+  public final GrpcCleanupRule grpcCleanup = new GrpcCleanupRule();
+
+  private final AlphaClusterConfig clusterConfig = 
mock(AlphaClusterConfig.class);
+  private final TccMessageHandler tccMessageHandler = 
mock(CoordinateMessageHandler.class);
+  private final String serverName = uniquify("serviceName");
+  private final ServiceConfig serviceConfig = new ServiceConfig(serverName);
+  protected final String[] addresses = {"localhost:8080", "localhost:8090"};
+
+  private  LoadBalanceContextBuilder tccLoadBalanceContextBuilder;
+  private  LoadBalanceContextBuilder sagaLoadBalanceContextBuilder;
+
+  @Before
+  public void setup() throws IOException {
+// Create a server, add service, start, and register for automatic 
graceful shutdown.
+
grpcCleanup.register(InProcessServerBuilder.forName("localhost:8080").directExecutor().build().start());
+
grpcCleanup.register(InProcessServerBuilder.forName("localhost:8090").directExecutor().build().start());
+
when(clusterConfig.getAddresses()).thenReturn(Lists.newArrayList(addresses));
+when(clusterConfig.getTccMessageHandler()).thenReturn(tccMessageHandler);
+tccLoadBalanceContextBuilder =
+new LoadBalanceContextBuilder(TransactionType.TCC, clusterConfig, 
serviceConfig, 30);
+sagaLoadBalanceContextBuilder =
+new LoadBalanceContextBuilder(TransactionType.SAGA, clusterConfig, 
serviceConfig, 30);
+  }
+
+  @After
+  public void teardown() {
+  }
+
+  @Test
+  public void buildTccLoadBalanceContextWithoutSsl() {
+when(clusterConfig.isEnableSSL()).thenReturn(false);
+
+LoadBalanceContext loadContext = tccLoadBalanceContextBuilder.build();
+assertThat(loadContext.getPendingTaskRunner().getReconnectDelay(), is(30));
+assertThat(loadContext.getSenders().size(), is(2));
+assertThat(loadContext.getSenders().keySet().iterator().next(), 
instanceOf(TccMessageSender.class));
+assertThat(loadContext.getSenders().values().iterator().next(), is(0l));
+assertThat(loadContext.getChannels().size(), is(2));
+loadContext.getSenders().keySet().iterator().next().close();
+shutdownChannels(loadContext);
+  }
+
+  @Test
+  public void buildTccLoadBalanceContextWithSsl() {
+when(clusterConfig.isEnableSSL()).thenReturn(true);
+
when(clusterConfig.getCert()).thenReturn(getClass().getClassLoader().getResource("client.crt").getFile());
+

[jira] [Commented] (SCB-909) Add fault tolerance for service comb TCC

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622976#comment-16622976
 ] 

ASF GitHub Bot commented on SCB-909:


WillemJiang commented on a change in pull request #302: SCB-909 Add fault 
tolerance for service comb TCC  (WIP)
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/302#discussion_r219367862
 
 

 ##
 File path: 
omega/omega-connector/omega-connector-grpc/src/main/java/org/apache/servicecomb/saga/omega/connector/grpc/tcc/GrpcCoordinateStreamObserver.java
 ##
 @@ -6,33 +6,34 @@
  * (the "License"); you may not use this file except in compliance with
 
 Review comment:
   Hi, I think You need to change the template.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add fault tolerance for service comb TCC
> 
>
> Key: SCB-909
> URL: https://issues.apache.org/jira/browse/SCB-909
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Saga
>Affects Versions: saga-0.3.0
>Reporter: cherrylzhao
>Assignee: cherrylzhao
>Priority: Major
> Fix For: saga-0.3.0
>
>
> TCC fault tolerance incude following point.
> # omega can switch to another available alpha when sending message failed.
> # if omega resend logic (different alpha) failed, omega can rollback local 
> data automatically.
> # alpha do resend logic (same omega) when ACK failed, if resend failed, dirty 
> data can left in database, this will be handled by scanner.
> # design transaction timeout mechanics, if scanner found event won't 
> completed within expected time, sending componsate command to omega, it has 
> different type compare with normal.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-923) Provide API to access the TCC events

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622975#comment-16622975
 ] 

ASF GitHub Bot commented on SCB-923:


coveralls edited a comment on issue #310: SCB-923 Add Restful API for Alpha TCC 
Service
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/310#issuecomment-423256896
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/19116180/badge)](https://coveralls.io/builds/19116180)
   
   Coverage decreased (-0.7%) to 91.549% when pulling 
**302c1e285c2f614c7856027c78a8d381ad629a67 on SCB-923** into 
**cc38fe9dca2a4c2f09d949117a61fa0ee2586a5f on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Provide API to access the TCC events 
> -
>
> Key: SCB-923
> URL: https://issues.apache.org/jira/browse/SCB-923
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Saga
>Reporter: Willem Jiang
>Assignee: Willem Jiang
>Priority: Major
> Fix For: saga-0.3.0
>
>
> As a part to integration test, we need to know what kind of event that Alpha 
> get.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (SCB-710) If failed to get SC instance ,autoDiscoveryInited should be "false"

2018-09-20 Thread laijianbin (JIRA)



 [ 
https://issues.apache.org/jira/browse/SCB-710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

laijianbin closed SCB-710.
--
Resolution: Fixed

> If failed to get SC instance ,autoDiscoveryInited should be "false"
> ---
>
> Key: SCB-710
> URL: https://issues.apache.org/jira/browse/SCB-710
> Project: Apache ServiceComb
>  Issue Type: Task
>Reporter: laijianbin
>Assignee: laijianbin
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (SCB-884) already return, no need else

2018-09-20 Thread laijianbin (JIRA)



 [ 
https://issues.apache.org/jira/browse/SCB-884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

laijianbin closed SCB-884.
--
Resolution: Fixed

> already return, no need else
> 
>
> Key: SCB-884
> URL: https://issues.apache.org/jira/browse/SCB-884
> Project: Apache ServiceComb
>  Issue Type: Task
>Reporter: laijianbin
>Assignee: laijianbin
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-915) saga alpha event scanner optimization

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623007#comment-16623007
 ] 

ASF GitHub Bot commented on SCB-915:


oliugian commented on issue #311: SCB-915:saga alpha event scanner optimization
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/311#issuecomment-423400520
 
 
   All tests have been successful
   The functionality of ForwardRecovery has been incorporated into 
defaultRecovery, so delete it and its test code. There is a test code 
equivalent to ForwardRecover in TransactionAspectTest.
   (-1) means infinite retry, but it can also be interrupted, throwing an 
InterruptedException, which is consistent with the logic in the previous 
ForwardRecovery


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> saga alpha event scanner optimization
> -
>
> Key: SCB-915
> URL: https://issues.apache.org/jira/browse/SCB-915
> Project: Apache ServiceComb
>  Issue Type: Improvement
>Reporter: FuChenGeng
>Assignee: FuChenGeng
>Priority: Major
>
> 1.the compensate logic for retry scenarios is not perfect, in some place it 
> do not considering retry scenarios.
> 2.do one compensation in one event scanner cycle,it mean that if there are 
> 1000 aborted event, it will cost at lest 500s to compensate it. And it has 
> some bugs like
> [https://github.com/apache/incubator-servicecomb-saga/issues/253]
> 3.all hot and cold data are in the same table
> 4. omega do not send every try event to alpha.omega do it's try logic by 
> itself.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-932) Time jump cause the new request injected

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622979#comment-16622979
 ] 

ASF GitHub Bot commented on SCB-932:


laijianbin opened a new pull request #918: 【SCB-932】Time jump cause the new 
request injected
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/918
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Time jump cause the new request injected
> 
>
> Key: SCB-932
> URL: https://issues.apache.org/jira/browse/SCB-932
> Project: Apache ServiceComb
>  Issue Type: Task
>Reporter: laijianbin
>Assignee: laijianbin
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-932) Time jump cause the new request injected

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622995#comment-16622995
 ] 

ASF GitHub Bot commented on SCB-932:


laijianbin opened a new pull request #919: [SCB-932]Time jump cause the new 
request injected
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/919
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Time jump cause the new request injected
> 
>
> Key: SCB-932
> URL: https://issues.apache.org/jira/browse/SCB-932
> Project: Apache ServiceComb
>  Issue Type: Task
>Reporter: laijianbin
>Assignee: laijianbin
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-932) Time jump cause the new request injected

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622994#comment-16622994
 ] 

ASF GitHub Bot commented on SCB-932:


coveralls commented on issue #918: 【SCB-932】Time jump cause the new request 
injected
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/918#issuecomment-423398318
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/19116456/badge)](https://coveralls.io/builds/19116456)
   
   Coverage remained the same at 86.207% when pulling 
**4d537c8af63ac0fb6fa051670870687dc33f3a3d on laijianbin:patch-4** into 
**20627dd0af924dcdf51fe529afe49e51864dc18c on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Time jump cause the new request injected
> 
>
> Key: SCB-932
> URL: https://issues.apache.org/jira/browse/SCB-932
> Project: Apache ServiceComb
>  Issue Type: Task
>Reporter: laijianbin
>Assignee: laijianbin
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (SCB-920) Remove duplicate dependencies

2018-09-20 Thread laijianbin (JIRA)



 [ 
https://issues.apache.org/jira/browse/SCB-920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

laijianbin closed SCB-920.
--
Resolution: Fixed

I make a mistake, there is no need to modify

> Remove duplicate dependencies
> -
>
> Key: SCB-920
> URL: https://issues.apache.org/jira/browse/SCB-920
> Project: Apache ServiceComb
>  Issue Type: Task
>  Components: Java-Chassis
>Reporter: laijianbin
>Assignee: laijianbin
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-932) Time jump cause the new request injected

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622980#comment-16622980
 ] 

ASF GitHub Bot commented on SCB-932:


laijianbin commented on issue #918: 【SCB-932】Time jump cause the new request 
injected
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/918#issuecomment-423395166
 
 
   
   ![time 
jump](https://user-images.githubusercontent.com/26161527/45857190-35c46500-bd8a-11e8-9da4-5da256008960.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Time jump cause the new request injected
> 
>
> Key: SCB-932
> URL: https://issues.apache.org/jira/browse/SCB-932
> Project: Apache ServiceComb
>  Issue Type: Task
>Reporter: laijianbin
>Assignee: laijianbin
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-915) saga alpha event scanner optimization

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622984#comment-16622984
 ] 

ASF GitHub Bot commented on SCB-915:


oliugian opened a new pull request #311: SCB-915:saga alpha event scanner 
optimization
URL: https://github.com/apache/incubator-servicecomb-saga/pull/311
 
 
   omega do not send every try event to alpha.omega do it's try logic by itself.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> saga alpha event scanner optimization
> -
>
> Key: SCB-915
> URL: https://issues.apache.org/jira/browse/SCB-915
> Project: Apache ServiceComb
>  Issue Type: Improvement
>Reporter: FuChenGeng
>Assignee: FuChenGeng
>Priority: Major
>
> 1.the compensate logic for retry scenarios is not perfect, in some place it 
> do not considering retry scenarios.
> 2.do one compensation in one event scanner cycle,it mean that if there are 
> 1000 aborted event, it will cost at lest 500s to compensate it. And it has 
> some bugs like
> [https://github.com/apache/incubator-servicecomb-saga/issues/253]
> 3.all hot and cold data are in the same table
> 4. omega do not send every try event to alpha.omega do it's try logic by 
> itself.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-923) Provide API to access the TCC events

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623024#comment-16623024
 ] 

ASF GitHub Bot commented on SCB-923:


coveralls edited a comment on issue #310: SCB-923 Add Restful API for Alpha TCC 
Service
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/310#issuecomment-423256896
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/19116599/badge)](https://coveralls.io/builds/19116599)
   
   Coverage decreased (-0.7%) to 91.549% when pulling 
**d6a6e51a1020ce0fc44bab2955d1b469bf4bff3b on SCB-923** into 
**cc38fe9dca2a4c2f09d949117a61fa0ee2586a5f on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Provide API to access the TCC events 
> -
>
> Key: SCB-923
> URL: https://issues.apache.org/jira/browse/SCB-923
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Saga
>Reporter: Willem Jiang
>Assignee: Willem Jiang
>Priority: Major
> Fix For: saga-0.3.0
>
>
> As a part to integration test, we need to know what kind of event that Alpha 
> get.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-922) collect Getter/Setter from pojo

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621578#comment-16621578
 ] 

ASF GitHub Bot commented on SCB-922:


coveralls commented on issue #916: [SCB-922] Collect getter setter from pojo
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/916#issuecomment-423061611
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/19095928/badge)](https://coveralls.io/builds/19095928)
   
   Coverage increased (+0.002%) to 86.209% when pulling 
**f28941bf1710fc102c59be699ae296443d138665 on 
wujimin:collect-getter-setter-from-pojo** into 
**20627dd0af924dcdf51fe529afe49e51864dc18c on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> collect Getter/Setter from pojo
> ---
>
> Key: SCB-922
> URL: https://issues.apache.org/jira/browse/SCB-922
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-927) The latest Lager is not compatible

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621613#comment-16621613
 ] 

ASF GitHub Bot commented on SCB-927:


codecov-io commented on issue #445: SCB-927 The latest Lager is not compatible
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/445#issuecomment-423075953
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445?src=pr=h1)
 Report
   > Merging 
[#445](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/3404f76e89342c8291d4e18eea63a183e0afe567?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `87.5%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/graphs/tree.svg?width=650=GAaF7zrg8R=150=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #445  +/-   ##
   ==
   + Coverage   59.74%   59.78%   +0.03% 
   ==
 Files 149  149  
 Lines   1316713166   -1 
   ==
   + Hits 7867 7871   +4 
   + Misses   4729 4726   -3 
   + Partials  571  569   -2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/log/log\_go19.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr=tree#diff-cGtnL2xvZy9sb2dfZ28xOS5nbw==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[server/service/util/dependency\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5X3V0aWwuZ28=)
 | `51.21% <100%> (+0.29%)` | :arrow_up: |
   | 
[pkg/log/logger.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr=tree#diff-cGtnL2xvZy9sb2dnZXIuZ28=)
 | `95.74% <100%> (ø)` | :arrow_up: |
   | 
[pkg/log/zap.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr=tree#diff-cGtnL2xvZy96YXAuZ28=)
 | `89.42% <66.66%> (+2.5%)` | :arrow_up: |
   | 
[server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==)
 | `83.87% <0%> (-0.65%)` | :arrow_down: |
   | 
[server/govern/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv)
 | `73.66% <0%> (+0.33%)` | :arrow_up: |
   | 
[pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==)
 | `84.37% <0%> (+3.12%)` | :arrow_up: |
   | 
[server/plugin/infra/registry/etcd/tracing.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9yZWdpc3RyeS9ldGNkL3RyYWNpbmcuZ28=)
 | `81.81% <0%> (+9.09%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445?src=pr=footer).
 Last update 
[3404f76...7bc1a5d](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The latest Lager is not compatible
> --
>
> Key: SCB-927
> URL: https://issues.apache.org/jira/browse/SCB-927
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-927) The latest Lager is not compatible

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621616#comment-16621616
 ] 

ASF GitHub Bot commented on SCB-927:


coveralls commented on issue #445: SCB-927 The latest Lager is not compatible
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/445#issuecomment-423076231
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/19096536/badge)](https://coveralls.io/builds/19096536)
   
   Coverage increased (+0.06%) to 62.314% when pulling 
**7bc1a5d9f235bfcb27bc009301f8acaf160e0ec0 on little-cui:lager** into 
**3404f76e89342c8291d4e18eea63a183e0afe567 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The latest Lager is not compatible
> --
>
> Key: SCB-927
> URL: https://issues.apache.org/jira/browse/SCB-927
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SCB-930) Service Center Frontend stops responding in Schema test if Schema has '\"' character in the description

2018-09-20 Thread Mohammad Asif Siddiqui (JIRA)

Mohammad Asif Siddiqui created SCB-930:
--

 Summary: Service Center Frontend stops responding in Schema test 
if Schema has '\"' character in the description
 Key: SCB-930
 URL: https://issues.apache.org/jira/browse/SCB-930
 Project: Apache ServiceComb
  Issue Type: Bug
  Components: Service-Center
Affects Versions: service-center-1.0.0
Reporter: Mohammad Asif Siddiqui
Assignee: Mohammad Asif Siddiqui
 Fix For: service-center-1.1.0


Service Center Frontend stops responding in Schema test if Schema has '\"' 
character in the description.

Solution :  Update the Regex for eliminating the new line character



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-930) Service Center Frontend stops responding in Schema test if Schema has '\"' character in the description

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621839#comment-16621839
 ] 

ASF GitHub Bot commented on SCB-930:


asifdxtreme opened a new pull request #447: SCB-930 Make Regex more stringent 
to remove new line char from Schema
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/447
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Service Center Frontend stops responding in Schema test if Schema has '\"' 
> character in the description
> ---
>
> Key: SCB-930
> URL: https://issues.apache.org/jira/browse/SCB-930
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Affects Versions: service-center-1.0.0
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.1.0
>
>
> Service Center Frontend stops responding in Schema test if Schema has '\"' 
> character in the description.
> Solution :  Update the Regex for eliminating the new line character



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-930) Service Center Frontend stops responding in Schema test if Schema has '\"' character in the description

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621849#comment-16621849
 ] 

ASF GitHub Bot commented on SCB-930:


codecov-io commented on issue #447: SCB-930 Make Regex more stringent to remove 
new line char from Schema
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/447#issuecomment-423148833
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/447?src=pr=h1)
 Report
   > Merging 
[#447](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/447?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/5a0c8d33247246c0498d8879f3c2eaf241998fdc?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/447/graphs/tree.svg?width=650=GAaF7zrg8R=150=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/447?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #447  +/-   ##
   ==
   + Coverage   59.75%   59.76%   +<.01% 
   ==
 Files 149  149  
 Lines   1317513175  
   ==
   + Hits 7873 7874   +1 
 Misses   4730 4730  
   + Partials  572  571   -1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/447?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/util/tag\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/447/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==)
 | `61.53% <0%> (-3.85%)` | :arrow_down: |
   | 
[server/govern/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/447/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv)
 | `73.66% <0%> (+0.33%)` | :arrow_up: |
   | 
[server/plugin/infra/registry/etcd/tracing.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/447/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9yZWdpc3RyeS9ldGNkL3RyYWNpbmcuZ28=)
 | `81.81% <0%> (+9.09%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/447?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/447?src=pr=footer).
 Last update 
[5a0c8d3...b1ea593](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/447?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Service Center Frontend stops responding in Schema test if Schema has '\"' 
> character in the description
> ---
>
> Key: SCB-930
> URL: https://issues.apache.org/jira/browse/SCB-930
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Affects Versions: service-center-1.0.0
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.1.0
>
>
> Service Center Frontend stops responding in Schema test if Schema has '\"' 
> character in the description.
> Solution :  Update the Regex for eliminating the new line character



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-929) Concurrent error in update resource APIs

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621834#comment-16621834
 ] 

ASF GitHub Bot commented on SCB-929:


asifdxtreme closed pull request #446: SCB-929 Concurrent error in update 
resource APIs
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/446
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/server/service/instance.go b/server/service/instance.go
index f33fe486..d147cf58 100644
--- a/server/service/instance.go
+++ b/server/service/instance.go
@@ -653,9 +653,10 @@ func (s *InstanceService) UpdateStatus(ctx 
context.Context, in *pb.UpdateInstanc
}, nil
}
 
-   instance.Status = in.Status
+   copyInstanceRef := *instance
+   copyInstanceRef.Status = in.Status
 
-   if err := serviceUtil.UpdateInstance(ctx, domainProject, instance); err 
!= nil {
+   if err := serviceUtil.UpdateInstance(ctx, domainProject, 
); err != nil {
log.Errorf(err, "update instance status failed, %s", 
updateStatusFlag)
resp := {
Response: pb.CreateResponseWithSCErr(err),
@@ -696,9 +697,10 @@ func (s *InstanceService) UpdateInstanceProperties(ctx 
context.Context, in *pb.U
}, nil
}
 
-   instance.Properties = in.Properties
+   copyInstanceRef := *instance
+   copyInstanceRef.Properties = in.Properties
 
-   if err := serviceUtil.UpdateInstance(ctx, domainProject, instance); err 
!= nil {
+   if err := serviceUtil.UpdateInstance(ctx, domainProject, 
); err != nil {
log.Errorf(err, "update instance properties failed, %s", 
instanceFlag)
resp := {
Response: pb.CreateResponseWithSCErr(err),
diff --git a/server/service/microservice.go b/server/service/microservice.go
index d93c537b..cbde70fc 100644
--- a/server/service/microservice.go
+++ b/server/service/microservice.go
@@ -518,13 +518,12 @@ func (s *MicroServiceService) UpdateProperties(ctx 
context.Context, in *pb.Updat
Response: pb.CreateResponse(scerr.ErrServiceNotExists, 
"service does not exist."),
}, nil
}
-   service.Properties = make(map[string]string)
-   for propertyKey := range in.Properties {
-   service.Properties[propertyKey] = in.Properties[propertyKey]
-   }
-   service.ModTimestamp = strconv.FormatInt(time.Now().Unix(), 10)
 
-   data, err := json.Marshal(service)
+   copyServiceRef := *service
+   copyServiceRef.Properties = in.Properties
+   copyServiceRef.ModTimestamp = strconv.FormatInt(time.Now().Unix(), 10)
+
+   data, err := json.Marshal(copyServiceRef)
if err != nil {
log.Errorf(err, "update service properties failed, serviceId is 
%s: json marshal service failed.", in.ServiceId)
return {
diff --git a/server/service/rule.go b/server/service/rule.go
index 40ca4bdc..ad3efc70 100644
--- a/server/service/rule.go
+++ b/server/service/rule.go
@@ -199,23 +199,24 @@ func (s *MicroServiceService) UpdateRule(ctx 
context.Context, in *pb.UpdateServi
}, nil
}
 
-   oldRulePatten := rule.Pattern
-   oldRuleAttr := rule.Attribute
+   copyRuleRef := *rule
+   oldRulePatten := copyRuleRef.Pattern
+   oldRuleAttr := copyRuleRef.Attribute
isChangeIndex := false
-   if rule.Attribute != in.GetRule().Attribute {
+   if copyRuleRef.Attribute != in.GetRule().Attribute {
isChangeIndex = true
-   rule.Attribute = in.GetRule().Attribute
+   copyRuleRef.Attribute = in.GetRule().Attribute
}
-   if rule.Pattern != in.GetRule().Pattern {
+   if copyRuleRef.Pattern != in.GetRule().Pattern {
isChangeIndex = true
-   rule.Pattern = in.GetRule().Pattern
+   copyRuleRef.Pattern = in.GetRule().Pattern
}
-   rule.RuleType = in.GetRule().RuleType
-   rule.Description = in.GetRule().Description
-   rule.ModTimestamp = strconv.FormatInt(time.Now().Unix(), 10)
+   copyRuleRef.RuleType = in.GetRule().RuleType
+   copyRuleRef.Description = in.GetRule().Description
+   copyRuleRef.ModTimestamp = strconv.FormatInt(time.Now().Unix(), 10)
 
key := apt.GenerateServiceRuleKey(domainProject, in.ServiceId, 
in.RuleId)
-   data, err := json.Marshal(rule)
+   data, err := json.Marshal(copyRuleRef)
if err != nil {
log.Errorf(err, "update rule failed, serviceId is %s, ruleId is 
%s: marshal service rule failed.", in.ServiceId, in.RuleId)
return {
@@ -225,8 +226,8

[jira] [Commented] (SCB-930) Service Center Frontend stops responding in Schema test if Schema has '\"' character in the description

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621850#comment-16621850
 ] 

ASF GitHub Bot commented on SCB-930:


coveralls commented on issue #447: SCB-930 Make Regex more stringent to remove 
new line char from Schema
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/447#issuecomment-423149092
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/19100091/badge)](https://coveralls.io/builds/19100091)
   
   Coverage increased (+0.2%) to 62.297% when pulling 
**b1ea5933421d728ebcbd6baf4ecf3ebbcd0d41ee on asifdxtreme:master** into 
**5a0c8d33247246c0498d8879f3c2eaf241998fdc on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Service Center Frontend stops responding in Schema test if Schema has '\"' 
> character in the description
> ---
>
> Key: SCB-930
> URL: https://issues.apache.org/jira/browse/SCB-930
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Affects Versions: service-center-1.0.0
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.1.0
>
>
> Service Center Frontend stops responding in Schema test if Schema has '\"' 
> character in the description.
> Solution :  Update the Regex for eliminating the new line character



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-930) Service Center Frontend stops responding in Schema test if Schema has '\"' character in the description

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621962#comment-16621962
 ] 

ASF GitHub Bot commented on SCB-930:


asifdxtreme commented on a change in pull request #447: SCB-930 Make Regex more 
stringent to remove new line char from Schema
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/447#discussion_r219150034
 
 

 ##
 File path: frontend/app/scripts/modules/serviceCenter/controllers/schemaCtrl.js
 ##
 @@ -146,7 +146,7 @@ angular.module('serviceCenter.sc')
 httpService.apiRequest(url, method, null, headers, 
"nopopup").then(function(response) {
 if (response && response.data && response.data.schema) {
 $scope.template = response.data.schema;
-$scope.template = $scope.template.replace(/\\/g, "");
+$scope.template = $scope.template.replace(/\\\s/g, "");
 
 Review comment:
   This will replace the '\' character with nothing only when it is the last 
character in the line :  
   
   For Example : 
   ```
   description: "body返回： {\"body\":{},\"statusCode\":\"120\",\"errorMsg\" \
  :\"没有为此用户分配有效的坐席\"}"
   ```
   In this , it will just replace the last '\' in the first line, 
   after replacing it becomes
   ```
   description: "body返回： {\"body\":{},\"statusCode\":\"120\",\"errorMsg\" 
:\"没有为此用户分配有效的坐席\"}"
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Service Center Frontend stops responding in Schema test if Schema has '\"' 
> character in the description
> ---
>
> Key: SCB-930
> URL: https://issues.apache.org/jira/browse/SCB-930
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Affects Versions: service-center-1.0.0
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.1.0
>
>
> Service Center Frontend stops responding in Schema test if Schema has '\"' 
> character in the description.
> Solution :  Update the Regex for eliminating the new line character



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-930) Service Center Frontend stops responding in Schema test if Schema has '\"' character in the description

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621949#comment-16621949
 ] 

ASF GitHub Bot commented on SCB-930:


little-cui commented on a change in pull request #447: SCB-930 Make Regex more 
stringent to remove new line char from Schema
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/447#discussion_r219147134
 
 

 ##
 File path: frontend/app/scripts/modules/serviceCenter/controllers/schemaCtrl.js
 ##
 @@ -146,7 +146,7 @@ angular.module('serviceCenter.sc')
 httpService.apiRequest(url, method, null, headers, 
"nopopup").then(function(response) {
 if (response && response.data && response.data.schema) {
 $scope.template = response.data.schema;
-$scope.template = $scope.template.replace(/\\/g, "");
+$scope.template = $scope.template.replace(/\\\s/g, "");
 
 Review comment:
   it will replace the space to empty now. The description of schema maybe 
changed to unreadable. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Service Center Frontend stops responding in Schema test if Schema has '\"' 
> character in the description
> ---
>
> Key: SCB-930
> URL: https://issues.apache.org/jira/browse/SCB-930
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Affects Versions: service-center-1.0.0
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.1.0
>
>
> Service Center Frontend stops responding in Schema test if Schema has '\"' 
> character in the description.
> Solution :  Update the Regex for eliminating the new line character



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-930) Service Center Frontend stops responding in Schema test if Schema has '\"' character in the description

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621970#comment-16621970
 ] 

ASF GitHub Bot commented on SCB-930:


little-cui closed pull request #447: SCB-930 Make Regex more stringent to 
remove new line char from Schema
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/447
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/frontend/app/scripts/modules/serviceCenter/controllers/schemaCtrl.js 
b/frontend/app/scripts/modules/serviceCenter/controllers/schemaCtrl.js
index 31b9a15c..ab24663a 100644
--- a/frontend/app/scripts/modules/serviceCenter/controllers/schemaCtrl.js
+++ b/frontend/app/scripts/modules/serviceCenter/controllers/schemaCtrl.js
@@ -146,7 +146,7 @@ angular.module('serviceCenter.sc')
 httpService.apiRequest(url, method, null, headers, 
"nopopup").then(function(response) {
 if (response && response.data && response.data.schema) {
 $scope.template = response.data.schema;
-$scope.template = $scope.template.replace(/\\/g, "");
+$scope.template = $scope.template.replace(/\\\s/g, "");
 $scope.json = YAML.parse($scope.template);
 const ui = SwaggerUIBundle({
 spec: $scope.json,
@@ -270,7 +270,7 @@ angular.module('serviceCenter.sc')
 var ip = highway[1].substring(2, 
highway[1].length) + ":" + highway[2].substring(0, 4);
 }
 var schema = response.data.schema;
-schema = schema.replace(/\\/g, "");
+schema = schema.replace(/\\\s/g, "");
 var json = YAML.parse(schema);
 json.basePath = "/testSchema" + 
json.basePath;
 json.instanceIP = ip;
@@ -306,4 +306,4 @@ angular.module('serviceCenter.sc')
 
 
 }
-]);
\ No newline at end of file
+]);


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Service Center Frontend stops responding in Schema test if Schema has '\"' 
> character in the description
> ---
>
> Key: SCB-930
> URL: https://issues.apache.org/jira/browse/SCB-930
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Affects Versions: service-center-1.0.0
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.1.0
>
>
> Service Center Frontend stops responding in Schema test if Schema has '\"' 
> character in the description.
> Solution :  Update the Regex for eliminating the new line character



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-931) upgrade vert.x to fix some know issues

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621979#comment-16621979
 ] 

ASF GitHub Bot commented on SCB-931:


liubao68 opened a new pull request #917: [SCB-931]upgrade vert.x to 3.5.3 to 
fix some know issues
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/917
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> upgrade vert.x to fix some know issues
> --
>
> Key: SCB-931
> URL: https://issues.apache.org/jira/browse/SCB-931
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis
>Reporter: liubao
>Assignee: liubao
>Priority: Major
>
> Know issues:
>  # excpeptionHandler not property executed.  
> [https://github.com/eclipse-vertx/vert.x/issues/2368]
>  
>  # route handler concurrent problems.   
> [https://github.com/vert-x3/vertx-web/pull/739]
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SCB-931) upgrade vert.x to fix some know issues

2018-09-20 Thread liubao (JIRA)

liubao created SCB-931:
--

 Summary: upgrade vert.x to fix some know issues
 Key: SCB-931
 URL: https://issues.apache.org/jira/browse/SCB-931
 Project: Apache ServiceComb
  Issue Type: Improvement
  Components: Java-Chassis
Reporter: liubao
Assignee: liubao


Know issues:
 # excpeptionHandler not property executed.  
[https://github.com/eclipse-vertx/vert.x/issues/2368]

 
 # route handler concurrent problems.   
[https://github.com/vert-x3/vertx-web/pull/739]

 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-923) Provide API to access the TCC events

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622271#comment-16622271
 ] 

ASF GitHub Bot commented on SCB-923:


WillemJiang opened a new pull request #310: SCB-923 Add Restful API for Alpha 
TCC Service
URL: https://github.com/apache/incubator-servicecomb-saga/pull/310
 
 
   1. Provided events restful service for test
   2. Refactored the TccEventService to make the code simple
   3. Added some unit tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Provide API to access the TCC events 
> -
>
> Key: SCB-923
> URL: https://issues.apache.org/jira/browse/SCB-923
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Saga
>Reporter: Willem Jiang
>Assignee: Willem Jiang
>Priority: Major
> Fix For: saga-0.3.0
>
>
> As a part to integration test, we need to know what kind of event that Alpha 
> get.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-927) The latest Lager is not compatible

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621793#comment-16621793
 ] 

ASF GitHub Bot commented on SCB-927:


coveralls edited a comment on issue #445: SCB-927 The latest Lager is not 
compatible
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/445#issuecomment-423076231
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/19098987/badge)](https://coveralls.io/builds/19098987)
   
   Coverage decreased (-0.04%) to 62.221% when pulling 
**d7cc9f542297c5173bafb5018bf109c40f70dc71 on little-cui:lager** into 
**3404f76e89342c8291d4e18eea63a183e0afe567 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The latest Lager is not compatible
> --
>
> Key: SCB-927
> URL: https://issues.apache.org/jira/browse/SCB-927
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-927) The latest Lager is not compatible

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621794#comment-16621794
 ] 

ASF GitHub Bot commented on SCB-927:


codecov-io edited a comment on issue #445: SCB-927 The latest Lager is not 
compatible
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/445#issuecomment-423075953
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445?src=pr=h1)
 Report
   > Merging 
[#445](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/3404f76e89342c8291d4e18eea63a183e0afe567?src=pr=desc)
 will **increase** coverage by `0.01%`.
   > The diff coverage is `87.5%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/graphs/tree.svg?width=650=GAaF7zrg8R=150=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #445  +/-   ##
   ==
   + Coverage   59.74%   59.76%   +0.01% 
   ==
 Files 149  149  
 Lines   1316713166   -1 
   ==
   + Hits 7867 7869   +2 
   + Misses   4729 4726   -3 
 Partials  571  571
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/util/dependency\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5X3V0aWwuZ28=)
 | `51.21% <100%> (+0.29%)` | :arrow_up: |
   | 
[pkg/log/logger.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr=tree#diff-cGtnL2xvZy9sb2dnZXIuZ28=)
 | `95.74% <100%> (ø)` | :arrow_up: |
   | 
[pkg/log/zap.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr=tree#diff-cGtnL2xvZy96YXAuZ28=)
 | `89.42% <66.66%> (+2.5%)` | :arrow_up: |
   | 
[pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==)
 | `73.58% <0%> (-0.95%)` | :arrow_down: |
   | 
[server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==)
 | `83.87% <0%> (-0.65%)` | :arrow_down: |
   | 
[server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv)
 | `68.94% <0%> (+0.62%)` | :arrow_up: |
   | 
[server/plugin/infra/registry/etcd/tracing.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9yZWdpc3RyeS9ldGNkL3RyYWNpbmcuZ28=)
 | `81.81% <0%> (+9.09%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445?src=pr=footer).
 Last update 
[3404f76...d7cc9f5](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The latest Lager is not compatible
> --
>
> Key: SCB-927
> URL: https://issues.apache.org/jira/browse/SCB-927
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-923) Provide API to access the TCC events

2018-09-20 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/SCB-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622336#comment-16622336
 ] 

ASF GitHub Bot commented on SCB-923:


coveralls commented on issue #310: SCB-923 Add Restful API for Alpha TCC Service
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/310#issuecomment-423256896
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/19106387/badge)](https://coveralls.io/builds/19106387)
   
   Coverage decreased (-0.7%) to 91.519% when pulling 
**6e76608d5451a9f262b2d73158c281a9477f425c on SCB-923** into 
**cc38fe9dca2a4c2f09d949117a61fa0ee2586a5f on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Provide API to access the TCC events 
> -
>
> Key: SCB-923
> URL: https://issues.apache.org/jira/browse/SCB-923
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Saga
>Reporter: Willem Jiang
>Assignee: Willem Jiang
>Priority: Major
> Fix For: saga-0.3.0
>
>
> As a part to integration test, we need to know what kind of event that Alpha 
> get.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

43 matches

Mail list logo