[jira] [Commented] (SCB-317) Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351282#comment-16351282
 ] 

ASF GitHub Bot commented on SCB-317:


coveralls commented on issue #273: SCB-317 Update the cors license
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/273#issuecomment-362648705
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15356336/badge)](https://coveralls.io/builds/15356336)
   
   Coverage decreased (-0.01%) to 73.876% when pulling 
**063d95119bdfb4d7be6a522aae147e4e9a5dcb87 on asifdxtreme:cors** into 
**e9a498a5475549fe8a2b4c60d4e005b1bf0c3b00 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Prepare the release for Service-Center-1.0.0-m1
> ---
>
> Key: SCB-317
> URL: https://issues.apache.org/jira/browse/SCB-317
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: Service-Center
>Affects Versions: service-center-1.0.0-m1
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-317) Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351281#comment-16351281
 ] 

ASF GitHub Bot commented on SCB-317:


codecov-io commented on issue #273: SCB-317 Update the cors license
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/273#issuecomment-362648774
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/273?src=pr=h1)
 Report
   > Merging 
[#273](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/273?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/e9a498a5475549fe8a2b4c60d4e005b1bf0c3b00?src=pr=desc)
 will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/273/graphs/tree.svg?width=650=GAaF7zrg8R=150=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/273?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #273  +/-   ##
   ==
   + Coverage   70.33%   70.36%   +0.02% 
   ==
 Files  17   17  
 Lines3418 3418  
   ==
   + Hits 2404 2405   +1 
 Misses846  846  
   + Partials  168  167   -1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/273?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/service\_dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/273/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvc2VydmljZV9kZXBlbmRlbmN5Lmdv)
 | `73.04% <0%> (ø)` | :arrow_up: |
   | 
[server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/273/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==)
 | `76.82% <0%> (ø)` | :arrow_up: |
   | 
[server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/273/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv)
 | `71.28% <0%> (+0.16%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/273?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/273?src=pr=footer).
 Last update 
[e9a498a...063d951](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/273?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Prepare the release for Service-Center-1.0.0-m1
> ---
>
> Key: SCB-317
> URL: https://issues.apache.org/jira/browse/SCB-317
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: Service-Center
>Affects Versions: service-center-1.0.0-m1
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-317) Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351280#comment-16351280
 ] 

ASF GitHub Bot commented on SCB-317:


coveralls commented on issue #273: SCB-317 Update the cors license
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/273#issuecomment-362648705
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15356329/badge)](https://coveralls.io/builds/15356329)
   
   Coverage increased (+0.1%) to 73.998% when pulling 
**063d95119bdfb4d7be6a522aae147e4e9a5dcb87 on asifdxtreme:cors** into 
**e9a498a5475549fe8a2b4c60d4e005b1bf0c3b00 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Prepare the release for Service-Center-1.0.0-m1
> ---
>
> Key: SCB-317
> URL: https://issues.apache.org/jira/browse/SCB-317
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: Service-Center
>Affects Versions: service-center-1.0.0-m1
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-317) Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351278#comment-16351278
 ] 

ASF GitHub Bot commented on SCB-317:


asifdxtreme commented on issue #272: SCB-317 Use CDN Servers to resolve 
front-end dependencies
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/272#issuecomment-362785641
 
 
   This PR removes all the bower_components which were earlier added to the 
code to make the development faster and also to reduce the load time of the 
page.
   Currently all the bower_components dependencies can be resolved using CDN 
Servers, this will increase the load time of the page but this is the better 
way to handle the dependencies as server will not have overhead to send the 
scripts to client, all the dependencies will be directly downloaded on the 
client side by internet hence reducing the traffic to server.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Prepare the release for Service-Center-1.0.0-m1
> ---
>
> Key: SCB-317
> URL: https://issues.apache.org/jira/browse/SCB-317
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: Service-Center
>Affects Versions: service-center-1.0.0-m1
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-317) Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351276#comment-16351276
 ] 

ASF GitHub Bot commented on SCB-317:


asifdxtreme commented on issue #273: SCB-317 Update the cors license
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/273#issuecomment-362785354
 
 
   @WillemJiang Thanks for the suggestion, I have removed the ASl header and 
added a comment that original code was modified to suit the Service-Center use 
case


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Prepare the release for Service-Center-1.0.0-m1
> ---
>
> Key: SCB-317
> URL: https://issues.apache.org/jira/browse/SCB-317
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: Service-Center
>Affects Versions: service-center-1.0.0-m1
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-327) Update metrics publish data module

2018-02-02 Thread Willem Jiang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SCB-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-327:
-
Summary: Update metrics publish data module  (was: Feature adjustment for 
1.0.0-m1 publish,Update default Publish)

> Update metrics publish data module
> --
>
> Key: SCB-327
> URL: https://issues.apache.org/jira/browse/SCB-327
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> Change data publish from RegistryMetric model to map



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-320) Remove custom metrics implementation

2018-02-02 Thread Willem Jiang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SCB-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-320:
-
Summary: Remove custom metrics implementation  (was: Feature adjustment for 
1.0.0-m1 publish,remove custom metrics )

> Remove custom metrics implementation
> 
>
> Key: SCB-320
> URL: https://issues.apache.org/jira/browse/SCB-320
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> Because the support of custom metrics is still adjusting in current version
> We will provide a better mechanism later (1.0.0-m2)
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-326) Using the EventManager directly without creating another wrapper

2018-02-02 Thread Willem Jiang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SCB-326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-326:
-
Summary: Using the  EventManager directly without creating another wrapper  
(was: Feature adjustment for 1.0.0-m1 publish,replace EventBus with 
EventManager)

> Using the  EventManager directly without creating another wrapper
> -
>
> Key: SCB-326
> URL: https://issues.apache.org/jira/browse/SCB-326
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> Remove custom EventBus because old EventManager with google EventBus is good 
> enough



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SCB-229) support rxJava Observable

2018-02-02 Thread Yang Bo (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SCB-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yang Bo reassigned SCB-229:
---

Assignee: Yang Bo

> support rxJava Observable
> -
>
> Key: SCB-229
> URL: https://issues.apache.org/jira/browse/SCB-229
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: Yang Bo
>Priority: Major
>
> just like CompletableFuture



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-317) Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351268#comment-16351268
 ] 

ASF GitHub Bot commented on SCB-317:


coveralls commented on issue #274: SCB-317 Use the ServiceComb/paas-lager.
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/274#issuecomment-362783873
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15356169/badge)](https://coveralls.io/builds/15356169)
   
   Coverage increased (+0.07%) to 74.065% when pulling 
**9f03eb73bc6139ee7b24a6d00786f0cbce3c2664 on little-cui:master** into 
**f69a5cf2174c79c453ff05d45018dd51a4260b1c on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Prepare the release for Service-Center-1.0.0-m1
> ---
>
> Key: SCB-317
> URL: https://issues.apache.org/jira/browse/SCB-317
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: Service-Center
>Affects Versions: service-center-1.0.0-m1
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-317) Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351266#comment-16351266
 ] 

ASF GitHub Bot commented on SCB-317:


little-cui opened a new pull request #274: SCB-317 Use the 
ServiceComb/paas-lager.
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/274
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Prepare the release for Service-Center-1.0.0-m1
> ---
>
> Key: SCB-317
> URL: https://issues.apache.org/jira/browse/SCB-317
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: Service-Center
>Affects Versions: service-center-1.0.0-m1
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-320) Feature adjustment for 1.0.0-m1 publish,remove custom metrics

2018-02-02 Thread yangyongzheng (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SCB-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

yangyongzheng updated SCB-320:
--
Description: 
Because the support of custom metrics is still adjusting in current version

We will provide a better mechanism later (1.0.0-m2)

 

  was:
Because support of custom metrics not so prefect temporary remove it

We will provide a better mechanism later (1.0.0-m2)

 


> Feature adjustment for 1.0.0-m1 publish,remove custom metrics 
> --
>
> Key: SCB-320
> URL: https://issues.apache.org/jira/browse/SCB-320
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> Because the support of custom metrics is still adjusting in current version
> We will provide a better mechanism later (1.0.0-m2)
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-317) Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351264#comment-16351264
 ] 

ASF GitHub Bot commented on SCB-317:


little-cui closed pull request #271:  SCB-317 Prepare the release for 
Service-Center-1.0.0-m1
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/271
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/NOTICE b/NOTICE
index 7572044b..7fe2cb6d 100644
--- a/NOTICE
+++ b/NOTICE
@@ -4,6 +4,29 @@ Copyright 2017-2018 The Apache Software Foundation
 This product includes software developed at
 The Apache Software Foundation (http://www.apache.org/).
 
+
+The Apache License Version 2.0
+
+The following components are provided under the  Apache License Version 2.0  
(http://www.apache.org/licenses/). See project link for details.
+
+github.com/astaxie/beego
+github.com/cockroachdb/cmux
+github.com/coreos/etcd
+github.com/coreos/go-semver/semver
+github.com/coreos/go-systemd/journal
+github.com/coreos/pkg/capnslog
+google.golang.org/genproto/googleapis/rpc/status
+google.golang.org/grpc
+gopkg.in/yaml.v2
+github.com/google/btree
+github.com/grpc-ecosystem/go-grpc-prometheus
+github.com/jonboulle/clockwork
+github.com/matttproud/golang_protobuf_extensions/pbutil
+github.com/prometheus/client_golang/prometheus
+github.com/prometheus/client_model/go
+github.com/prometheus/common
+github.com/prometheus/procfs/xfs
+
 
 The MIT License
 
@@ -15,6 +38,10 @@ github.com/boltdb/bolt
 github.com/satori/go.uuid
 AngularJS v1.6.6 (http://angularjs.org)
 Bootstrap v3.3.7 (http://getbootstrap.com)
+Chart.js (https://github.com/chartjs/Chart.js)
+jquery (https://github.com/jquery/jquery)
+JSZip (https://github.com/Stuk/jszip)
+yaml.js (https://github.com/jeremyfa/yaml.js)
 
 
 The BSD Licenses
@@ -68,3 +95,100 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, 
DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
+
+
+Notice for coreos/etcd
+
+CoreOS Project
+Copyright 2014 CoreOS, Inc
+
+This product includes software developed at CoreOS, Inc.
+(http://www.coreos.com/).
+
+
+Notice for coreos/go-systemd
+
+CoreOS Project
+Copyright 2018 CoreOS, Inc
+
+This product includes software developed at CoreOS, Inc.
+(http://www.coreos.com/).
+
+
+Notice for coreos/go-semver
+
+CoreOS Project
+Copyright 2018 CoreOS, Inc
+
+This product includes software developed at CoreOS, Inc.
+(http://www.coreos.com/).
+
+
+Notice for coreos/pkg
+
+CoreOS Project
+Copyright 2014 CoreOS, Inc
+
+This product includes software developed at CoreOS, Inc.
+(http://www.coreos.com/).
+
+
+Notice for matttproud/golang_protobuf_extensions
+
+Copyright 2012 Matt T. Proud (matt.pr...@gmail.com)
+
+
+Notice for prometheus/client_golang
+
+Prometheus instrumentation library for Go applications
+Copyright 2012-2015 The Prometheus Authors
+
+This product includes software developed at
+SoundCloud Ltd. (http://soundcloud.com/).
+
+
+The following components are included in this product:
+
+perks - a fork of https://github.com/bmizerany/perks
+https://github.com/beorn7/perks
+Copyright 2013-2015 Blake Mizerany, Björn Rabenstein
+See https://github.com/beorn7/perks/blob/master/README.md for license details.
+
+Go support for Protocol Buffers - Google's data interchange format
+http://github.com/golang/protobuf/
+Copyright 2010 The Go Authors
+See source code for license details.
+
+Support for streaming Protocol Buffer messages for the Go language (golang).
+https://github.com/matttproud/golang_protobuf_extensions
+Copyright 2013 Matt T. Proud
+Licensed under the Apache License, Version 2.0
+
+
+Notice for prometheus/client_model
+
+Data model artifacts for Prometheus.
+Copyright 2012-2015 The Prometheus Authors
+
+This product includes software developed at
+SoundCloud Ltd. (http://soundcloud.com/).

[jira] [Commented] (SCB-315) As a SDK user, i want to custom netty dns resovl properties so that the ServiceComb has to add config support

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351263#comment-16351263
 ] 

ASF GitHub Bot commented on SCB-315:


WillemJiang closed pull request #546: SCB-315 Config Center module can't get 
config by DynamicPropertyFacto…
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/546
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
 
b/dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
index 306cf7f04..0ca5668e9 100644
--- 
a/dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
+++ 
b/dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
@@ -147,7 +147,9 @@ private void refreshMembers(MemberDiscovery 
memberDiscovery) {
   }
 });
 SignRequest signReq = createSignRequest(request.method().toString(),
-configCenter + URIConst.MEMBERS, new HashMap<>(), null);
+configCenter + URIConst.MEMBERS,
+new HashMap<>(),
+null);
 if (ConfigCenterConfig.INSTANCE.getToken() != null) {
   request.headers().add("X-Auth-Token", 
ConfigCenterConfig.INSTANCE.getToken());
 }
@@ -159,7 +161,8 @@ private void refreshMembers(MemberDiscovery 
memberDiscovery) {
 
   private void deployConfigClient() throws InterruptedException {
 VertxOptions vertxOptions = new VertxOptions();
-
vertxOptions.setAddressResolverOptions(AddressResolverConfig.getAddressResover(SSL_KEY));
+
vertxOptions.setAddressResolverOptions(AddressResolverConfig.getAddressResover(SSL_KEY,
+ConfigCenterConfig.INSTANCE.getConcurrentCompositeConfiguration()));
 Vertx vertx = VertxUtils.getOrCreateVertxByName("config-center", 
vertxOptions);
 
 HttpClientOptions httpClientOptions = createHttpClientOptions();
@@ -245,7 +248,9 @@ public void doWatch(String configCenter)
 authHeaderProviders.forEach(provider -> 
authHeaders.putAll(provider.getSignAuthHeaders(
 createSignRequest(null, configCenter + url, headers, null;
 
-client.websocket(refreshPort, ipPort.getHostOrIp(), url,
+client.websocket(refreshPort,
+ipPort.getHostOrIp(),
+url,
 new CaseInsensitiveHeaders().addAll(headers)
 .addAll(authHeaders),
 ws -> {
@@ -284,7 +289,9 @@ public void doWatch(String configCenter)
 
 private void startHeartBeatThread(WebSocket ws) {
   heartbeatTask = Executors.newScheduledThreadPool(1);
-  heartbeatTask.scheduleWithFixedDelay(() -> sendHeartbeat(ws), 
HEARTBEAT_INTERVAL, HEARTBEAT_INTERVAL,
+  heartbeatTask.scheduleWithFixedDelay(() -> sendHeartbeat(ws),
+  HEARTBEAT_INTERVAL,
+  HEARTBEAT_INTERVAL,
   TimeUnit.MILLISECONDS);
 }
 
@@ -338,7 +345,9 @@ public void refreshConfig(String configcenter) {
 request.headers().addAll(headers);
 authHeaderProviders.forEach(provider -> request.headers()
 
.addAll(provider.getSignAuthHeaders(createSignRequest(request.method().toString(),
-configcenter + path, headers, null;
+configcenter + path,
+headers,
+null;
 request.exceptionHandler(e -> {
   LOGGER.error("config refresh fail {}", e.getMessage());
 });
diff --git 
a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/AddressResolverConfig.java
 
b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/AddressResolverConfig.java
index 698178dba..1b1a80481 100644
--- 
a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/AddressResolverConfig.java
+++ 
b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/AddressResolverConfig.java
@@ -20,108 +20,135 @@
 import java.util.Arrays;
 import java.util.List;
 
+import org.apache.commons.configuration.Configuration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import com.netflix.config.DynamicPropertyFactory;
 
 import io.vertx.core.dns.AddressResolverOptions;
 
 public class AddressResolverConfig {
 
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(AddressResolverConfig.class);
+
   /**
* get the target endpoints with custom address resolve config
* @param tag config tag, such as sc.consumer or cc.consumer
* @return AddressResolverOptions
*/
   public static AddressResolverOptions

[jira] [Updated] (SCB-320) Feature adjustment for 1.0.0-m1 publish,temporary disable custom metricsremove

2018-02-02 Thread yangyongzheng (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SCB-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

yangyongzheng updated SCB-320:
--
Description: 
Because support of custom metrics not so prefect temporary remove it

We will provide a better mechanism later (1.0.0-m2)

 

  was:
Because support of custom metrics not so prefect temporary disable it

 

Summary: Feature adjustment for 1.0.0-m1 publish,temporary disable 
custom metricsremove  (was: Feature adjustment for 1.0.0-m1 publish,temporary 
disable custom metrics)

> Feature adjustment for 1.0.0-m1 publish,temporary disable custom metricsremove
> --
>
> Key: SCB-320
> URL: https://issues.apache.org/jira/browse/SCB-320
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> Because support of custom metrics not so prefect temporary remove it
> We will provide a better mechanism later (1.0.0-m2)
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-320) Feature adjustment for 1.0.0-m1 publish,remove custom metrics

2018-02-02 Thread yangyongzheng (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SCB-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

yangyongzheng updated SCB-320:
--
Summary: Feature adjustment for 1.0.0-m1 publish,remove custom metrics   
(was: Feature adjustment for 1.0.0-m1 publish,temporary disable custom 
metricsremove)

> Feature adjustment for 1.0.0-m1 publish,remove custom metrics 
> --
>
> Key: SCB-320
> URL: https://issues.apache.org/jira/browse/SCB-320
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> Because support of custom metrics not so prefect temporary remove it
> We will provide a better mechanism later (1.0.0-m2)
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-315) As a SDK user, i want to custom netty dns resovl properties so that the ServiceComb has to add config support

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351239#comment-16351239
 ] 

ASF GitHub Bot commented on SCB-315:


coveralls commented on issue #546: SCB-315 Config Center module can't get 
config by DynamicPropertyFacto…
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/546#issuecomment-362558547
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15355721/badge)](https://coveralls.io/builds/15355721)
   
   Coverage decreased (-0.02%) to 87.295% when pulling 
**4eb6af5cc443593e113fe5e76ed407c50b5f3e5a on jeho0815:Branch_SCB-315** into 
**769dc9dd52f3c003f763ddaacd5d601a37ed273e on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> As a SDK user, i want to custom netty dns resovl properties so that the 
> ServiceComb has to add config support
> -
>
> Key: SCB-315
> URL: https://issues.apache.org/jira/browse/SCB-315
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: jeho0815
>Assignee: jeho0815
>Priority: Major
>
> Default DNS resovl use the machine config, but sometimes the application want 
> to set by themselves to adapt to diffrent local or cloud enviroments



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-315) As a SDK user, i want to custom netty dns resovl properties so that the ServiceComb has to add config support

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351227#comment-16351227
 ] 

ASF GitHub Bot commented on SCB-315:


wujimin commented on a change in pull request #546: SCB-315 Config Center 
module can't get config by DynamicPropertyFacto…
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/546#discussion_r165803612
 
 

 ##
 File path: 
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/AddressResolverConfig.java
 ##
 @@ -32,96 +34,113 @@
* @return AddressResolverOptions
*/
   public static AddressResolverOptions getAddressResover(String tag) {
+return getAddressResover(tag, null);
+  }
+
+  /**
+   * get the target endpoints with custom address resolve config
+   * @param tag config tag, such as sc.consumer or cc.consumer
+   * @param configSource get config from special config source
+   * @return AddressResolverOptions
+   */
+  public static AddressResolverOptions getAddressResover(String tag, 
Configuration configSource) {
 AddressResolverOptions addressResolverOptions = new 
AddressResolverOptions();
 addressResolverOptions
-
.setServers(getStringListProperty(AddressResolverOptions.DEFAULT_SEACH_DOMAINS,
+.setServers(getStringListProperty(configSource,
+AddressResolverOptions.DEFAULT_SEACH_DOMAINS,
 "addressResolver." + tag + ".servers",
 "addressResolver.servers"));
 addressResolverOptions
-
.setOptResourceEnabled(getBooleanProperty(AddressResolverOptions.DEFAULT_OPT_RESOURCE_ENABLED,
+.setOptResourceEnabled(getBooleanProperty(configSource,
+AddressResolverOptions.DEFAULT_OPT_RESOURCE_ENABLED,
 "addressResolver." + tag + ".optResourceEnabled",
 "addressResolver.optResourceEnabled"));
 addressResolverOptions
-
.setCacheMinTimeToLive(getIntProperty(AddressResolverOptions.DEFAULT_CACHE_MIN_TIME_TO_LIVE,
+.setCacheMinTimeToLive(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_CACHE_MIN_TIME_TO_LIVE,
 "addressResolver." + tag + ".cacheMinTimeToLive",
 "addressResolver.cacheMinTimeToLive"));
 addressResolverOptions
-
.setCacheMaxTimeToLive(getIntProperty(AddressResolverOptions.DEFAULT_CACHE_MAX_TIME_TO_LIVE,
+.setCacheMaxTimeToLive(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_CACHE_MAX_TIME_TO_LIVE,
 "addressResolver." + tag + ".cacheMaxTimeToLive",
 "addressResolver.cacheMaxTimeToLive"));
 addressResolverOptions
-
.setCacheNegativeTimeToLive(getIntProperty(AddressResolverOptions.DEFAULT_CACHE_NEGATIVE_TIME_TO_LIVE,
+.setCacheNegativeTimeToLive(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_CACHE_NEGATIVE_TIME_TO_LIVE,
 "addressResolver." + tag + ".cacheNegativeTimeToLive",
 "addressResolver.cacheNegativeTimeToLive"));
 addressResolverOptions
-
.setQueryTimeout(getIntProperty(AddressResolverOptions.DEFAULT_QUERY_TIMEOUT,
+.setQueryTimeout(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_QUERY_TIMEOUT,
 "addressResolver." + tag + ".queryTimeout",
 "addressResolver.queryTimeout"));
 addressResolverOptions
-
.setMaxQueries(getIntProperty(AddressResolverOptions.DEFAULT_MAX_QUERIES,
+.setMaxQueries(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_MAX_QUERIES,
 "addressResolver." + tag + ".maxQueries",
 "addressResolver.maxQueries"));
 addressResolverOptions
-.setRdFlag(getBooleanProperty(AddressResolverOptions.DEFAULT_RD_FLAG,
+.setRdFlag(getBooleanProperty(configSource,
+AddressResolverOptions.DEFAULT_RD_FLAG,
 "addressResolver." + tag + ".rdFlag",
 "addressResolver.rdFlag"));
 addressResolverOptions
-
.setSearchDomains(getStringListProperty(AddressResolverOptions.DEFAULT_SEACH_DOMAINS,
+.setSearchDomains(getStringListProperty(configSource,
+AddressResolverOptions.DEFAULT_SEACH_DOMAINS,
 "addressResolver." + tag + ".searchDomains",
 "addressResolver.searchDomains"));
 addressResolverOptions
-
.setNdots(getIntProperty(AddressResolverOptions.DEFAULT_CACHE_MIN_TIME_TO_LIVE,
+.setNdots(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_CACHE_MIN_TIME_TO_LIVE,
 "addressResolver." + tag + ".ndots",
 "addressResolver.ndots"));
 addressResolverOptions
-
.setRotateServers(getBooleanProperty(AddressResolverOptions.DEFAULT_ROTATE_SERVERS,
+.setRotateServers(getBooleanProperty(configSource,
+AddressResolverOptions.DEFAULT_ROTATE_SERVERS,
 "addressResolver."

[jira] [Commented] (SCB-315) As a SDK user, i want to custom netty dns resovl properties so that the ServiceComb has to add config support

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351223#comment-16351223
 ] 

ASF GitHub Bot commented on SCB-315:


jeho0815 commented on a change in pull request #546: SCB-315 Config Center 
module can't get config by DynamicPropertyFacto…
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/546#discussion_r165803480
 
 

 ##
 File path: 
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/AddressResolverConfig.java
 ##
 @@ -32,96 +34,113 @@
* @return AddressResolverOptions
*/
   public static AddressResolverOptions getAddressResover(String tag) {
+return getAddressResover(tag, null);
+  }
+
+  /**
+   * get the target endpoints with custom address resolve config
+   * @param tag config tag, such as sc.consumer or cc.consumer
+   * @param configSource get config from special config source
+   * @return AddressResolverOptions
+   */
+  public static AddressResolverOptions getAddressResover(String tag, 
Configuration configSource) {
 AddressResolverOptions addressResolverOptions = new 
AddressResolverOptions();
 addressResolverOptions
-
.setServers(getStringListProperty(AddressResolverOptions.DEFAULT_SEACH_DOMAINS,
+.setServers(getStringListProperty(configSource,
+AddressResolverOptions.DEFAULT_SEACH_DOMAINS,
 "addressResolver." + tag + ".servers",
 "addressResolver.servers"));
 addressResolverOptions
-
.setOptResourceEnabled(getBooleanProperty(AddressResolverOptions.DEFAULT_OPT_RESOURCE_ENABLED,
+.setOptResourceEnabled(getBooleanProperty(configSource,
+AddressResolverOptions.DEFAULT_OPT_RESOURCE_ENABLED,
 "addressResolver." + tag + ".optResourceEnabled",
 "addressResolver.optResourceEnabled"));
 addressResolverOptions
-
.setCacheMinTimeToLive(getIntProperty(AddressResolverOptions.DEFAULT_CACHE_MIN_TIME_TO_LIVE,
+.setCacheMinTimeToLive(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_CACHE_MIN_TIME_TO_LIVE,
 "addressResolver." + tag + ".cacheMinTimeToLive",
 "addressResolver.cacheMinTimeToLive"));
 addressResolverOptions
-
.setCacheMaxTimeToLive(getIntProperty(AddressResolverOptions.DEFAULT_CACHE_MAX_TIME_TO_LIVE,
+.setCacheMaxTimeToLive(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_CACHE_MAX_TIME_TO_LIVE,
 "addressResolver." + tag + ".cacheMaxTimeToLive",
 "addressResolver.cacheMaxTimeToLive"));
 addressResolverOptions
-
.setCacheNegativeTimeToLive(getIntProperty(AddressResolverOptions.DEFAULT_CACHE_NEGATIVE_TIME_TO_LIVE,
+.setCacheNegativeTimeToLive(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_CACHE_NEGATIVE_TIME_TO_LIVE,
 "addressResolver." + tag + ".cacheNegativeTimeToLive",
 "addressResolver.cacheNegativeTimeToLive"));
 addressResolverOptions
-
.setQueryTimeout(getIntProperty(AddressResolverOptions.DEFAULT_QUERY_TIMEOUT,
+.setQueryTimeout(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_QUERY_TIMEOUT,
 "addressResolver." + tag + ".queryTimeout",
 "addressResolver.queryTimeout"));
 addressResolverOptions
-
.setMaxQueries(getIntProperty(AddressResolverOptions.DEFAULT_MAX_QUERIES,
+.setMaxQueries(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_MAX_QUERIES,
 "addressResolver." + tag + ".maxQueries",
 "addressResolver.maxQueries"));
 addressResolverOptions
-.setRdFlag(getBooleanProperty(AddressResolverOptions.DEFAULT_RD_FLAG,
+.setRdFlag(getBooleanProperty(configSource,
+AddressResolverOptions.DEFAULT_RD_FLAG,
 "addressResolver." + tag + ".rdFlag",
 "addressResolver.rdFlag"));
 addressResolverOptions
-
.setSearchDomains(getStringListProperty(AddressResolverOptions.DEFAULT_SEACH_DOMAINS,
+.setSearchDomains(getStringListProperty(configSource,
+AddressResolverOptions.DEFAULT_SEACH_DOMAINS,
 "addressResolver." + tag + ".searchDomains",
 "addressResolver.searchDomains"));
 addressResolverOptions
-
.setNdots(getIntProperty(AddressResolverOptions.DEFAULT_CACHE_MIN_TIME_TO_LIVE,
+.setNdots(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_CACHE_MIN_TIME_TO_LIVE,
 "addressResolver." + tag + ".ndots",
 "addressResolver.ndots"));
 addressResolverOptions
-
.setRotateServers(getBooleanProperty(AddressResolverOptions.DEFAULT_ROTATE_SERVERS,
+.setRotateServers(getBooleanProperty(configSource,
+AddressResolverOptions.DEFAULT_ROTATE_SERVERS,
 "addressResolver."

[jira] [Commented] (SCB-315) As a SDK user, i want to custom netty dns resovl properties so that the ServiceComb has to add config support

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351222#comment-16351222
 ] 

ASF GitHub Bot commented on SCB-315:


wujimin commented on a change in pull request #546: SCB-315 Config Center 
module can't get config by DynamicPropertyFacto…
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/546#discussion_r165803367
 
 

 ##
 File path: 
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/AddressResolverConfig.java
 ##
 @@ -32,96 +34,113 @@
* @return AddressResolverOptions
*/
   public static AddressResolverOptions getAddressResover(String tag) {
+return getAddressResover(tag, null);
+  }
+
+  /**
+   * get the target endpoints with custom address resolve config
+   * @param tag config tag, such as sc.consumer or cc.consumer
+   * @param configSource get config from special config source
+   * @return AddressResolverOptions
+   */
+  public static AddressResolverOptions getAddressResover(String tag, 
Configuration configSource) {
 AddressResolverOptions addressResolverOptions = new 
AddressResolverOptions();
 addressResolverOptions
-
.setServers(getStringListProperty(AddressResolverOptions.DEFAULT_SEACH_DOMAINS,
+.setServers(getStringListProperty(configSource,
+AddressResolverOptions.DEFAULT_SEACH_DOMAINS,
 "addressResolver." + tag + ".servers",
 "addressResolver.servers"));
 addressResolverOptions
-
.setOptResourceEnabled(getBooleanProperty(AddressResolverOptions.DEFAULT_OPT_RESOURCE_ENABLED,
+.setOptResourceEnabled(getBooleanProperty(configSource,
+AddressResolverOptions.DEFAULT_OPT_RESOURCE_ENABLED,
 "addressResolver." + tag + ".optResourceEnabled",
 "addressResolver.optResourceEnabled"));
 addressResolverOptions
-
.setCacheMinTimeToLive(getIntProperty(AddressResolverOptions.DEFAULT_CACHE_MIN_TIME_TO_LIVE,
+.setCacheMinTimeToLive(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_CACHE_MIN_TIME_TO_LIVE,
 "addressResolver." + tag + ".cacheMinTimeToLive",
 "addressResolver.cacheMinTimeToLive"));
 addressResolverOptions
-
.setCacheMaxTimeToLive(getIntProperty(AddressResolverOptions.DEFAULT_CACHE_MAX_TIME_TO_LIVE,
+.setCacheMaxTimeToLive(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_CACHE_MAX_TIME_TO_LIVE,
 "addressResolver." + tag + ".cacheMaxTimeToLive",
 "addressResolver.cacheMaxTimeToLive"));
 addressResolverOptions
-
.setCacheNegativeTimeToLive(getIntProperty(AddressResolverOptions.DEFAULT_CACHE_NEGATIVE_TIME_TO_LIVE,
+.setCacheNegativeTimeToLive(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_CACHE_NEGATIVE_TIME_TO_LIVE,
 "addressResolver." + tag + ".cacheNegativeTimeToLive",
 "addressResolver.cacheNegativeTimeToLive"));
 addressResolverOptions
-
.setQueryTimeout(getIntProperty(AddressResolverOptions.DEFAULT_QUERY_TIMEOUT,
+.setQueryTimeout(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_QUERY_TIMEOUT,
 "addressResolver." + tag + ".queryTimeout",
 "addressResolver.queryTimeout"));
 addressResolverOptions
-
.setMaxQueries(getIntProperty(AddressResolverOptions.DEFAULT_MAX_QUERIES,
+.setMaxQueries(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_MAX_QUERIES,
 "addressResolver." + tag + ".maxQueries",
 "addressResolver.maxQueries"));
 addressResolverOptions
-.setRdFlag(getBooleanProperty(AddressResolverOptions.DEFAULT_RD_FLAG,
+.setRdFlag(getBooleanProperty(configSource,
+AddressResolverOptions.DEFAULT_RD_FLAG,
 "addressResolver." + tag + ".rdFlag",
 "addressResolver.rdFlag"));
 addressResolverOptions
-
.setSearchDomains(getStringListProperty(AddressResolverOptions.DEFAULT_SEACH_DOMAINS,
+.setSearchDomains(getStringListProperty(configSource,
+AddressResolverOptions.DEFAULT_SEACH_DOMAINS,
 "addressResolver." + tag + ".searchDomains",
 "addressResolver.searchDomains"));
 addressResolverOptions
-
.setNdots(getIntProperty(AddressResolverOptions.DEFAULT_CACHE_MIN_TIME_TO_LIVE,
+.setNdots(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_CACHE_MIN_TIME_TO_LIVE,
 "addressResolver." + tag + ".ndots",
 "addressResolver.ndots"));
 addressResolverOptions
-
.setRotateServers(getBooleanProperty(AddressResolverOptions.DEFAULT_ROTATE_SERVERS,
+.setRotateServers(getBooleanProperty(configSource,
+AddressResolverOptions.DEFAULT_ROTATE_SERVERS,
 "addressResolver."

[jira] [Commented] (SCB-326) Feature adjustment for 1.0.0-m1 publish,replace EventBus with EventManager

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351195#comment-16351195
 ] 

ASF GitHub Bot commented on SCB-326:


coveralls commented on issue #548: [SCB-326] Remove custom EventBus an replace 
with Already Exists EventManager
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/548#issuecomment-362765697
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15354857/badge)](https://coveralls.io/builds/15354857)
   
   Coverage decreased (-0.04%) to 87.28% when pulling 
**498ec860a6c806ff75d84d72866306bfc4d80d4b on zhengyangyong:SCB-326** into 
**769dc9dd52f3c003f763ddaacd5d601a37ed273e on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Feature adjustment for 1.0.0-m1 publish,replace EventBus with EventManager
> --
>
> Key: SCB-326
> URL: https://issues.apache.org/jira/browse/SCB-326
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> Remove custom EventBus because old EventManager with google EventBus is good 
> enough



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-320) Feature adjustment for 1.0.0-m1 publish,temporary disable custom metrics

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351185#comment-16351185
 ] 

ASF GitHub Bot commented on SCB-320:


coveralls commented on issue #547: [SCB-320] remove custom metrics service
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/547#issuecomment-362763016
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15354758/badge)](https://coveralls.io/builds/15354758)
   
   Coverage decreased (-0.07%) to 87.243% when pulling 
**ea1fa89b502e6571657323d2cba3850feb3a03cd on zhengyangyong:SCB-320-1** into 
**769dc9dd52f3c003f763ddaacd5d601a37ed273e on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Feature adjustment for 1.0.0-m1 publish,temporary disable custom metrics
> 
>
> Key: SCB-320
> URL: https://issues.apache.org/jira/browse/SCB-320
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> Because support of custom metrics not so prefect temporary disable it
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-315) As a SDK user, i want to custom netty dns resovl properties so that the ServiceComb has to add config support

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351183#comment-16351183
 ] 

ASF GitHub Bot commented on SCB-315:


jeho0815 commented on a change in pull request #546: SCB-315 Config Center 
module can't get config by DynamicPropertyFacto…
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/546#discussion_r165799469
 
 

 ##
 File path: 
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/AddressResolverConfig.java
 ##
 @@ -32,58 +33,89 @@
* @return AddressResolverOptions
*/
   public static AddressResolverOptions getAddressResover(String tag) {
+return getAddressResover(tag, null);
+  }
+
+  /**
+   * get the target endpoints with custom address resolve config
+   * @param tag config tag, such as sc.consumer or cc.consumer
+   * @param configSource get config from special config source
+   * @return AddressResolverOptions
+   */
+  public static AddressResolverOptions getAddressResover(String tag, 
ConcurrentCompositeConfiguration configSource) {
 AddressResolverOptions addressResolverOptions = new 
AddressResolverOptions();
 addressResolverOptions
-
.setServers(getStringListProperty(AddressResolverOptions.DEFAULT_SEACH_DOMAINS,
+.setServers(getStringListProperty(configSource,
+AddressResolverOptions.DEFAULT_SEACH_DOMAINS,
 "addressResolver." + tag + ".servers",
 "addressResolver.servers"));
 addressResolverOptions
-
.setOptResourceEnabled(getBooleanProperty(AddressResolverOptions.DEFAULT_OPT_RESOURCE_ENABLED,
+.setOptResourceEnabled(getBooleanProperty(configSource,
+AddressResolverOptions.DEFAULT_OPT_RESOURCE_ENABLED,
 "addressResolver." + tag + ".optResourceEnabled",
 "addressResolver.optResourceEnabled"));
 addressResolverOptions
-
.setCacheMinTimeToLive(getIntProperty(AddressResolverOptions.DEFAULT_CACHE_MIN_TIME_TO_LIVE,
+.setCacheMinTimeToLive(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_CACHE_MIN_TIME_TO_LIVE,
 "addressResolver." + tag + ".cacheMinTimeToLive",
 "addressResolver.cacheMinTimeToLive"));
 addressResolverOptions
-
.setCacheMaxTimeToLive(getIntProperty(AddressResolverOptions.DEFAULT_CACHE_MAX_TIME_TO_LIVE,
+.setCacheMaxTimeToLive(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_CACHE_MAX_TIME_TO_LIVE,
 "addressResolver." + tag + ".cacheMaxTimeToLive",
 "addressResolver.cacheMaxTimeToLive"));
 addressResolverOptions
-
.setCacheNegativeTimeToLive(getIntProperty(AddressResolverOptions.DEFAULT_CACHE_NEGATIVE_TIME_TO_LIVE,
+.setCacheNegativeTimeToLive(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_CACHE_NEGATIVE_TIME_TO_LIVE,
 "addressResolver." + tag + ".cacheNegativeTimeToLive",
 "addressResolver.cacheNegativeTimeToLive"));
 addressResolverOptions
-
.setQueryTimeout(getIntProperty(AddressResolverOptions.DEFAULT_QUERY_TIMEOUT,
+.setQueryTimeout(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_QUERY_TIMEOUT,
 "addressResolver." + tag + ".queryTimeout",
 "addressResolver.queryTimeout"));
 addressResolverOptions
-
.setMaxQueries(getIntProperty(AddressResolverOptions.DEFAULT_MAX_QUERIES,
+.setMaxQueries(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_MAX_QUERIES,
 "addressResolver." + tag + ".maxQueries",
 "addressResolver.maxQueries"));
 addressResolverOptions
-.setRdFlag(getBooleanProperty(AddressResolverOptions.DEFAULT_RD_FLAG,
+.setRdFlag(getBooleanProperty(configSource,
+AddressResolverOptions.DEFAULT_RD_FLAG,
 "addressResolver." + tag + ".rdFlag",
 "addressResolver.rdFlag"));
 addressResolverOptions
-
.setSearchDomains(getStringListProperty(AddressResolverOptions.DEFAULT_SEACH_DOMAINS,
+.setSearchDomains(getStringListProperty(configSource,
+AddressResolverOptions.DEFAULT_SEACH_DOMAINS,
 "addressResolver." + tag + ".searchDomains",
 "addressResolver.searchDomains"));
 addressResolverOptions
-
.setNdots(getIntProperty(AddressResolverOptions.DEFAULT_CACHE_MIN_TIME_TO_LIVE,
+.setNdots(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_CACHE_MIN_TIME_TO_LIVE,
 "addressResolver." + tag + ".ndots",
 "addressResolver.ndots"));
 addressResolverOptions
-
.setRotateServers(getBooleanProperty(AddressResolverOptions.DEFAULT_ROTATE_SERVERS,
+.setRotateServers(getBooleanProperty(configSource,
+AddressResolverOptions.DEFAULT_ROTATE_SERVERS,

[jira] [Commented] (SCB-315) As a SDK user, i want to custom netty dns resovl properties so that the ServiceComb has to add config support

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351180#comment-16351180
 ] 

ASF GitHub Bot commented on SCB-315:


wujimin commented on a change in pull request #546: SCB-315 Config Center 
module can't get config by DynamicPropertyFacto…
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/546#discussion_r165799372
 
 

 ##
 File path: 
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/AddressResolverConfig.java
 ##
 @@ -32,58 +33,89 @@
* @return AddressResolverOptions
*/
   public static AddressResolverOptions getAddressResover(String tag) {
+return getAddressResover(tag, null);
+  }
+
+  /**
+   * get the target endpoints with custom address resolve config
+   * @param tag config tag, such as sc.consumer or cc.consumer
+   * @param configSource get config from special config source
+   * @return AddressResolverOptions
+   */
+  public static AddressResolverOptions getAddressResover(String tag, 
ConcurrentCompositeConfiguration configSource) {
 AddressResolverOptions addressResolverOptions = new 
AddressResolverOptions();
 addressResolverOptions
-
.setServers(getStringListProperty(AddressResolverOptions.DEFAULT_SEACH_DOMAINS,
+.setServers(getStringListProperty(configSource,
+AddressResolverOptions.DEFAULT_SEACH_DOMAINS,
 "addressResolver." + tag + ".servers",
 "addressResolver.servers"));
 addressResolverOptions
-
.setOptResourceEnabled(getBooleanProperty(AddressResolverOptions.DEFAULT_OPT_RESOURCE_ENABLED,
+.setOptResourceEnabled(getBooleanProperty(configSource,
+AddressResolverOptions.DEFAULT_OPT_RESOURCE_ENABLED,
 "addressResolver." + tag + ".optResourceEnabled",
 "addressResolver.optResourceEnabled"));
 addressResolverOptions
-
.setCacheMinTimeToLive(getIntProperty(AddressResolverOptions.DEFAULT_CACHE_MIN_TIME_TO_LIVE,
+.setCacheMinTimeToLive(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_CACHE_MIN_TIME_TO_LIVE,
 "addressResolver." + tag + ".cacheMinTimeToLive",
 "addressResolver.cacheMinTimeToLive"));
 addressResolverOptions
-
.setCacheMaxTimeToLive(getIntProperty(AddressResolverOptions.DEFAULT_CACHE_MAX_TIME_TO_LIVE,
+.setCacheMaxTimeToLive(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_CACHE_MAX_TIME_TO_LIVE,
 "addressResolver." + tag + ".cacheMaxTimeToLive",
 "addressResolver.cacheMaxTimeToLive"));
 addressResolverOptions
-
.setCacheNegativeTimeToLive(getIntProperty(AddressResolverOptions.DEFAULT_CACHE_NEGATIVE_TIME_TO_LIVE,
+.setCacheNegativeTimeToLive(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_CACHE_NEGATIVE_TIME_TO_LIVE,
 "addressResolver." + tag + ".cacheNegativeTimeToLive",
 "addressResolver.cacheNegativeTimeToLive"));
 addressResolverOptions
-
.setQueryTimeout(getIntProperty(AddressResolverOptions.DEFAULT_QUERY_TIMEOUT,
+.setQueryTimeout(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_QUERY_TIMEOUT,
 "addressResolver." + tag + ".queryTimeout",
 "addressResolver.queryTimeout"));
 addressResolverOptions
-
.setMaxQueries(getIntProperty(AddressResolverOptions.DEFAULT_MAX_QUERIES,
+.setMaxQueries(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_MAX_QUERIES,
 "addressResolver." + tag + ".maxQueries",
 "addressResolver.maxQueries"));
 addressResolverOptions
-.setRdFlag(getBooleanProperty(AddressResolverOptions.DEFAULT_RD_FLAG,
+.setRdFlag(getBooleanProperty(configSource,
+AddressResolverOptions.DEFAULT_RD_FLAG,
 "addressResolver." + tag + ".rdFlag",
 "addressResolver.rdFlag"));
 addressResolverOptions
-
.setSearchDomains(getStringListProperty(AddressResolverOptions.DEFAULT_SEACH_DOMAINS,
+.setSearchDomains(getStringListProperty(configSource,
+AddressResolverOptions.DEFAULT_SEACH_DOMAINS,
 "addressResolver." + tag + ".searchDomains",
 "addressResolver.searchDomains"));
 addressResolverOptions
-
.setNdots(getIntProperty(AddressResolverOptions.DEFAULT_CACHE_MIN_TIME_TO_LIVE,
+.setNdots(getIntProperty(configSource,
+AddressResolverOptions.DEFAULT_CACHE_MIN_TIME_TO_LIVE,
 "addressResolver." + tag + ".ndots",
 "addressResolver.ndots"));
 addressResolverOptions
-
.setRotateServers(getBooleanProperty(AddressResolverOptions.DEFAULT_ROTATE_SERVERS,
+.setRotateServers(getBooleanProperty(configSource,
+AddressResolverOptions.DEFAULT_ROTATE_SERVERS,

[jira] [Commented] (SCB-326) Feature adjustment for 1.0.0-m1 publish,replace EventBus with EventManager

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351173#comment-16351173
 ] 

ASF GitHub Bot commented on SCB-326:


zhengyangyong opened a new pull request #548: [SCB-326] Remove custom EventBus 
an replace with Already Exists EventManager
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/548
 
 
   …google EventBus because it is good enough
   
   Signed-off-by: zhengyangyong 
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   Remove custom EventBus an replace with old EventManager with google EventBus 
because it is good enough


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Feature adjustment for 1.0.0-m1 publish,replace EventBus with EventManager
> --
>
> Key: SCB-326
> URL: https://issues.apache.org/jira/browse/SCB-326
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> Remove custom EventBus because old EventManager with google EventBus is good 
> enough



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-320) Feature adjustment for 1.0.0-m1 publish,temporary disable custom metrics

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351156#comment-16351156
 ] 

ASF GitHub Bot commented on SCB-320:


zhengyangyong opened a new pull request #547: [SCB-320] remove custom metrics 
service
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/547
 
 
   …ism later
   
   Signed-off-by: zhengyangyong 
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   remove custom metrics service and we will provider new mechanism later 
(1.0.0-m2)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Feature adjustment for 1.0.0-m1 publish,temporary disable custom metrics
> 
>
> Key: SCB-320
> URL: https://issues.apache.org/jira/browse/SCB-320
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> Because support of custom metrics not so prefect temporary disable it
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SCB-192) document for async/reactive

2018-02-02 Thread wujimin (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SCB-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

wujimin resolved SCB-192.
-
Resolution: Done

> document for async/reactive
> ---
>
> Key: SCB-192
> URL: https://issues.apache.org/jira/browse/SCB-192
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SCB-307) avoid to create unnecessary vertx context during send http response.

2018-02-02 Thread wujimin (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SCB-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

wujimin resolved SCB-307.
-
Resolution: Done

> avoid to create unnecessary vertx context during send http response.
> 
>
> Key: SCB-307
> URL: https://issues.apache.org/jira/browse/SCB-307
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SCB-310) provide vertx eventLoopContext created count

2018-02-02 Thread wujimin (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SCB-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

wujimin resolved SCB-310.
-
Resolution: Done

> provide vertx eventLoopContext created count
> 
>
> Key: SCB-310
> URL: https://issues.apache.org/jira/browse/SCB-310
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> if created too many eventLoopContext, then must be some mistake.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SCB-327) Feature adjustment for 1.0.0-m1 publish,Update default Publish

2018-02-02 Thread yangyongzheng (JIRA) 
yangyongzheng created SCB-327:
-

 Summary: Feature adjustment for 1.0.0-m1 publish,Update default 
Publish
 Key: SCB-327
 URL: https://issues.apache.org/jira/browse/SCB-327
 Project: Apache ServiceComb
  Issue Type: Sub-task
  Components: Java-Chassis
Affects Versions: java-chassis-1.0.0-m1
Reporter: yangyongzheng
Assignee: yangyongzheng
 Fix For: java-chassis-1.0.0-m1


Change data publish from RegistryMetric model to map



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SCB-326) Feature adjustment for 1.0.0-m1 publish,replace EventBus with EventManager

2018-02-02 Thread yangyongzheng (JIRA) 
yangyongzheng created SCB-326:
-

 Summary: Feature adjustment for 1.0.0-m1 publish,replace EventBus 
with EventManager
 Key: SCB-326
 URL: https://issues.apache.org/jira/browse/SCB-326
 Project: Apache ServiceComb
  Issue Type: Sub-task
  Components: Java-Chassis
Affects Versions: java-chassis-1.0.0-m1
Reporter: yangyongzheng
Assignee: yangyongzheng
 Fix For: java-chassis-1.0.0-m1


Remove custom EventBus because old EventManager with google EventBus is good 
enough



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-320) Feature adjustment for 1.0.0-m1 publish,temporary disable custom metrics

2018-02-02 Thread yangyongzheng (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SCB-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

yangyongzheng updated SCB-320:
--
Component/s: Java-Chassis

> Feature adjustment for 1.0.0-m1 publish,temporary disable custom metrics
> 
>
> Key: SCB-320
> URL: https://issues.apache.org/jira/browse/SCB-320
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> Because support of custom metrics not so prefect temporary disable it
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SCB-147) Delete 0.5.0 metrics in foundation-metrics

2018-02-02 Thread yangyongzheng (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SCB-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

yangyongzheng resolved SCB-147.
---
Resolution: Fixed

> Delete 0.5.0 metrics in foundation-metrics
> --
>
> Key: SCB-147
> URL: https://issues.apache.org/jira/browse/SCB-147
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
> Attachments: 20180127-113436(eSpace).png
>
>
> New Metrics applied in 1.0.0-m1 ,so 1.0.0-m2 old version of metrics can be 
> removed



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-317) Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350679#comment-16350679
 ] 

ASF GitHub Bot commented on SCB-317:


coveralls commented on issue #273: SCB-317 Update the cors license
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/273#issuecomment-362648705
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15348223/badge)](https://coveralls.io/builds/15348223)
   
   Coverage increased (+0.05%) to 73.937% when pulling 
**23088057543be6a758c1ecf19539398c96847111 on asifdxtreme:cors** into 
**e9a498a5475549fe8a2b4c60d4e005b1bf0c3b00 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Prepare the release for Service-Center-1.0.0-m1
> ---
>
> Key: SCB-317
> URL: https://issues.apache.org/jira/browse/SCB-317
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: Service-Center
>Affects Versions: service-center-1.0.0-m1
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-317) Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350689#comment-16350689
 ] 

ASF GitHub Bot commented on SCB-317:


codecov-io commented on issue #273: SCB-317 Update the cors license
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/273#issuecomment-362648774
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/273?src=pr=h1)
 Report
   > Merging 
[#273](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/273?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/e9a498a5475549fe8a2b4c60d4e005b1bf0c3b00?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/273/graphs/tree.svg?height=150=650=GAaF7zrg8R=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/273?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master #273   +/-   ##
   ===
 Coverage   70.33%   70.33%   
   ===
 Files  17   17   
 Lines3418 3418   
   ===
 Hits 2404 2404   
 Misses846  846   
 Partials  168  168
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/273?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/273?src=pr=footer).
 Last update 
[e9a498a...2308805](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/273?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Prepare the release for Service-Center-1.0.0-m1
> ---
>
> Key: SCB-317
> URL: https://issues.apache.org/jira/browse/SCB-317
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: Service-Center
>Affects Versions: service-center-1.0.0-m1
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-317) Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350663#comment-16350663
 ] 

ASF GitHub Bot commented on SCB-317:


asifdxtreme opened a new pull request #273: SCB-317 Update the cors license
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/273
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
- [x] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Prepare the release for Service-Center-1.0.0-m1
> ---
>
> Key: SCB-317
> URL: https://issues.apache.org/jira/browse/SCB-317
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: Service-Center
>Affects Versions: service-center-1.0.0-m1
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-317) Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350660#comment-16350660
 ] 

ASF GitHub Bot commented on SCB-317:


coveralls commented on issue #272: SCB-317 Use CDN Servers to resolve front-end 
dependencies
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/272#issuecomment-362645195
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15347993/badge)](https://coveralls.io/builds/15347993)
   
   Coverage increased (+0.1%) to 73.998% when pulling 
**d4b2cff3587f34c5e24d4c2953eee33588e3282c on asifdxtreme:master** into 
**e9a498a5475549fe8a2b4c60d4e005b1bf0c3b00 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Prepare the release for Service-Center-1.0.0-m1
> ---
>
> Key: SCB-317
> URL: https://issues.apache.org/jira/browse/SCB-317
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: Service-Center
>Affects Versions: service-center-1.0.0-m1
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-317) Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350651#comment-16350651
 ] 

ASF GitHub Bot commented on SCB-317:


asifdxtreme opened a new pull request #272: SCB-317 Use CDN Servers to resolve 
front-end dependencies
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/272
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
- [x] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Prepare the release for Service-Center-1.0.0-m1
> ---
>
> Key: SCB-317
> URL: https://issues.apache.org/jira/browse/SCB-317
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: Service-Center
>Affects Versions: service-center-1.0.0-m1
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-239) [pack] omega recovery

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350478#comment-16350478
 ] 

ASF GitHub Bot commented on SCB-239:


seanyinx commented on a change in pull request #122: SCB-239 omega stateless
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/122#discussion_r165661954
 
 

 ##
 File path: 
alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/TxConsistentService.java
 ##
 @@ -40,11 +51,33 @@ public boolean handle(TxEvent event) {
   return false;
 }
 
+if (isEventWithTimeout(event)) {
+  saveTxTimeout(event);
+}
+
 eventRepository.save(event);
 
+if (Arrays.asList(TxEndedEvent.name(), SagaEndedEvent.name(), 
TxAbortedEvent.name()).contains(event.type())) {
+  CompletableFuture.runAsync(() -> 
timeoutRepository.markTxTimeoutAsDone(event.globalTxId(), event.localTxId()));
 
 Review comment:
   this makes alpha stateful, which we try to avoid


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [pack] omega recovery
> -
>
> Key: SCB-239
> URL: https://issues.apache.org/jira/browse/SCB-239
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Saga
>Affects Versions: saga-0.1.0
>Reporter: Eric Lee
>Assignee: Eric Lee
>Priority: Major
> Fix For: saga-0.1.0
>
>
> as a user, I want to have the pending data stored persistently and be able to 
> resume the execution of these data if omega fails.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-239) [pack] omega recovery

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350481#comment-16350481
 ] 

ASF GitHub Bot commented on SCB-239:


seanyinx commented on a change in pull request #122: SCB-239 omega stateless
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/122#discussion_r165667413
 
 

 ##
 File path: 
alpha/alpha-core/src/test/java/org/apache/servicecomb/saga/alpha/core/TxConsistentServiceTest.java
 ##
 @@ -70,6 +78,29 @@ public void deleteDuplicateEvents(String type) {
 }
   };
 
+  private final Deque timeouts = new ConcurrentLinkedDeque<>();
+  private final TxTimeoutRepository timeoutRepository = new 
TxTimeoutRepository() {
+@Override
+public void save(TxTimeout timeout) {
+  timeouts.add(timeout);
+}
+
+@Override
+public void markTxTimeoutAsDone(String globalTxId, String localTxId) {
+  for (TxTimeout timeout : timeouts) {
+if (timeout.globalTxId().equals(globalTxId) && 
timeout.localTxId().equals(localTxId)) {
+  timeout.setStatus(DONE.name());
+  break;
+}
+  }
+}
+
+@Override
+public List findFirstTimeoutTxToAbort() {
+  return null;
 
 Review comment:
   empty list instead of null


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [pack] omega recovery
> -
>
> Key: SCB-239
> URL: https://issues.apache.org/jira/browse/SCB-239
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Saga
>Affects Versions: saga-0.1.0
>Reporter: Eric Lee
>Assignee: Eric Lee
>Priority: Major
> Fix For: saga-0.1.0
>
>
> as a user, I want to have the pending data stored persistently and be able to 
> resume the execution of these data if omega fails.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-239) [pack] omega recovery

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350476#comment-16350476
 ] 

ASF GitHub Bot commented on SCB-239:


seanyinx commented on a change in pull request #122: SCB-239 omega stateless
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/122#discussion_r165664602
 
 

 ##
 File path: 
alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/TxEvent.java
 ##
 @@ -40,6 +42,12 @@
   private String compensationMethod;
   private byte[] payloads;
 
+  @Version
+  private long version;
+
+  @Transient
+  private int timeout;
 
 Review comment:
   why not save timeout?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [pack] omega recovery
> -
>
> Key: SCB-239
> URL: https://issues.apache.org/jira/browse/SCB-239
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Saga
>Affects Versions: saga-0.1.0
>Reporter: Eric Lee
>Assignee: Eric Lee
>Priority: Major
> Fix For: saga-0.1.0
>
>
> as a user, I want to have the pending data stored persistently and be able to 
> resume the execution of these data if omega fails.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-317) Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350436#comment-16350436
 ] 

ASF GitHub Bot commented on SCB-317:


little-cui opened a new pull request #271:  SCB-317 Prepare the release for 
Service-Center-1.0.0-m1
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/271
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Prepare the release for Service-Center-1.0.0-m1
> ---
>
> Key: SCB-317
> URL: https://issues.apache.org/jira/browse/SCB-317
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: Service-Center
>Affects Versions: service-center-1.0.0-m1
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-317) Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350336#comment-16350336
 ] 

ASF GitHub Bot commented on SCB-317:


codecov-io commented on issue #270: SCB-317 Prepare the release for 
Service-Center-1.0.0-m1 
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/270#issuecomment-362588647
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/270?src=pr=h1)
 Report
   > Merging 
[#270](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/270?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/1d56c950820ceae9863df9993415dd378265d1a5?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/270/graphs/tree.svg?width=650=GAaF7zrg8R=150=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/270?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master #270   +/-   ##
   ===
 Coverage   70.36%   70.36%   
   ===
 Files  17   17   
 Lines3418 3418   
   ===
 Hits 2405 2405   
 Misses846  846   
 Partials  167  167
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/270?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/270/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==)
 | `76.82% <0%> (-0.43%)` | :arrow_down: |
   | 
[server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/270/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv)
 | `76.02% <0%> (+0.58%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/270?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/270?src=pr=footer).
 Last update 
[1d56c95...e9a9b98](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/270?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Prepare the release for Service-Center-1.0.0-m1
> ---
>
> Key: SCB-317
> URL: https://issues.apache.org/jira/browse/SCB-317
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: Service-Center
>Affects Versions: service-center-1.0.0-m1
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-317) Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350345#comment-16350345
 ] 

ASF GitHub Bot commented on SCB-317:


codecov-io commented on issue #270: SCB-317 Prepare the release for 
Service-Center-1.0.0-m1 
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/270#issuecomment-362588647
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/270?src=pr=h1)
 Report
   > Merging 
[#270](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/270?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/1d56c950820ceae9863df9993415dd378265d1a5?src=pr=desc)
 will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/270/graphs/tree.svg?height=150=GAaF7zrg8R=650=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/270?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #270  +/-   ##
   ==
   + Coverage   70.36%   70.39%   +0.02% 
   ==
 Files  17   17  
 Lines3418 3418  
   ==
   + Hits 2405 2406   +1 
 Misses846  846  
   + Partials  167  166   -1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/270?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/270/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==)
 | `76.82% <0%> (-0.43%)` | :arrow_down: |
   | 
[server/service/util/dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/270/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv)
 | `57.74% <0%> (+0.16%)` | :arrow_up: |
   | 
[server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/270/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv)
 | `76.02% <0%> (+0.58%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/270?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/270?src=pr=footer).
 Last update 
[1d56c95...e9a9b98](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/270?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Prepare the release for Service-Center-1.0.0-m1
> ---
>
> Key: SCB-317
> URL: https://issues.apache.org/jira/browse/SCB-317
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: Service-Center
>Affects Versions: service-center-1.0.0-m1
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-317) Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350176#comment-16350176
 ] 

ASF GitHub Bot commented on SCB-317:


codecov-io commented on issue #269: SCB-317 Prepare the release for 
Service-Center-1.0.0-m1
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/269#issuecomment-362558630
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/269?src=pr=h1)
 Report
   > Merging 
[#269](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/269?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/d6b0b3ac55ae0ad3cd35525c7cf6a42ff9ad54ad?src=pr=desc)
 will **increase** coverage by `0.16%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/269/graphs/tree.svg?height=150=650=GAaF7zrg8R=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/269?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #269  +/-   ##
   ==
   + Coverage   70.17%   70.33%   +0.16% 
   ==
 Files  17   17  
 Lines3470 3418  -52 
   ==
   - Hits 2435 2404  -31 
   + Misses864  846  -18 
   + Partials  171  168   -3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/269?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/microservices.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/269/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlcy5nbw==)
 | `74.45% <ø> (+0.39%)` | :arrow_up: |
   | 
[server/service/util/dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/269/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv)
 | `57.58% <ø> (+0.41%)` | :arrow_up: |
   | 
[server/service/util/microservice\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/269/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9taWNyb3NlcnZpY2VfdXRpbC5nbw==)
 | `74.84% <0%> (-1.73%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/269?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/269?src=pr=footer).
 Last update 
[d6b0b3a...e34c978](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/269?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Prepare the release for Service-Center-1.0.0-m1
> ---
>
> Key: SCB-317
> URL: https://issues.apache.org/jira/browse/SCB-317
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: Service-Center
>Affects Versions: service-center-1.0.0-m1
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-317) Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350177#comment-16350177
 ] 

ASF GitHub Bot commented on SCB-317:


coveralls commented on issue #269: SCB-317 Prepare the release for 
Service-Center-1.0.0-m1
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/269#issuecomment-362558642
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15342582/badge)](https://coveralls.io/builds/15342582)
   
   Coverage increased (+0.2%) to 73.895% when pulling 
**e34c978bf5fc57fcfc4ebd840fe050ecf7e52c13 on little-cui:master** into 
**d6b0b3ac55ae0ad3cd35525c7cf6a42ff9ad54ad on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Prepare the release for Service-Center-1.0.0-m1
> ---
>
> Key: SCB-317
> URL: https://issues.apache.org/jira/browse/SCB-317
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: Service-Center
>Affects Versions: service-center-1.0.0-m1
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-315) As a SDK user, i want to custom netty dns resovl properties so that the ServiceComb has to add config support

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350130#comment-16350130
 ] 

ASF GitHub Bot commented on SCB-315:


jeho0815 opened a new pull request #546: SCB-315 Config Center module can't get 
config by DynamicPropertyFacto…
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/546
 
 
   …ry.getInstance().getStringProperty, so has to use 
ConcurrentCompositeConfiguration
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> As a SDK user, i want to custom netty dns resovl properties so that the 
> ServiceComb has to add config support
> -
>
> Key: SCB-315
> URL: https://issues.apache.org/jira/browse/SCB-315
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: jeho0815
>Assignee: jeho0815
>Priority: Major
>
> Default DNS resovl use the machine config, but sometimes the application want 
> to set by themselves to adapt to diffrent local or cloud enviroments



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-320) Feature adjustment for 1.0.0-m1 publish,temporary disable custom metrics

2018-02-02 Thread yangyongzheng (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SCB-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

yangyongzheng updated SCB-320:
--
Description: 
Because support of custom metrics not so prefect temporary disable it

 

  was:
1.Because support of custom metrics not so prefect temporary disable it；

2.change data publish from RegistryMetric model to map

3.Remove custom EventBus because old EventManager with google EventBus is good 
enough


> Feature adjustment for 1.0.0-m1 publish,temporary disable custom metrics
> 
>
> Key: SCB-320
> URL: https://issues.apache.org/jira/browse/SCB-320
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> Because support of custom metrics not so prefect temporary disable it
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-260) Prepare LICENSE/NOTICE files for releasing

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350030#comment-16350030
 ] 

ASF GitHub Bot commented on SCB-260:


WillemJiang closed pull request #545: [SCB-260] Clarify original copyright of 
some files
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/545
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/NOTICE b/NOTICE
index 1fce66db5..a31e77a1b 100644
--- a/NOTICE
+++ b/NOTICE
@@ -71,3 +71,54 @@ The following components are provided under the  BSD  
(http://asm.objectweb.org/
 
 ASM Core (http://asm.objectweb.org/asm/) org.ow2.asm:asm:jar:5.0.4
 
+
+For 
foundations/foundation-vertx/src/main/java/io/vertx/ext/web/impl/MimeTypesUtils.java
+(Forked from 
https://github.com/vert-x3/vertx-web/blob/927ed057ddc028eb09a168db621de3d72fd85ed4/vertx-web/src/main/java/io/vertx/ext/web/impl/Utils.java)
+
+Copyright 2014 Red Hat, Inc.
+
+ All rights reserved. This program and the accompanying materials
+ are made available under the terms of the Eclipse Public License v1.0
+ and Apache License v2.0 which accompanies this distribution.
+
+ The Eclipse Public License is available at
+ http://www.eclipse.org/legal/epl-v10.html
+
+ The Apache License v2.0 is available at
+ http://www.opensource.org/licenses/apache2.0.php
+
+ You may elect to redistribute this code under either of these licenses.
+
+
+For 
swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/extend/property/AbstractBaseIntegerProperty.java
+(Forked from 
https://github.com/swagger-api/swagger-core/blob/master/modules/swagger-models/src/main/java/io/swagger/models/properties/IntegerProperty.java)
+
+Copyright 2016 SmartBear Software
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at 
[apache.org/licenses/LICENSE-2.0](http://www.apache.org/licenses/LICENSE-2.0)
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+
+
+For 
transports/transport-rest/transport-rest-vertx/src/main/java/org/apache/servicecomb/transport/rest/vertx/RestBodyHandler.java
+(Froked from 
https://github.com/vert-x3/vertx-web/blob/master/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/BodyHandlerImpl.java)
+
+Copyright 2014 Red Hat, Inc.
+
+ All rights reserved. This program and the accompanying materials
+ are made available under the terms of the Eclipse Public License v1.0
+ and Apache License v2.0 which accompanies this distribution.
+
+ The Eclipse Public License is available at
+ http://www.eclipse.org/legal/epl-v10.html
+
+ The Apache License v2.0 is available at
+ http://www.opensource.org/licenses/apache2.0.php
+
+ You may elect to redistribute this code under either of these licenses.
diff --git 
a/foundations/foundation-vertx/src/main/java/io/vertx/ext/web/impl/MimeTypesUtils.java
 
b/foundations/foundation-vertx/src/main/java/io/vertx/ext/web/impl/MimeTypesUtils.java
index cb74fb1d6..c184726a9 100644
--- 
a/foundations/foundation-vertx/src/main/java/io/vertx/ext/web/impl/MimeTypesUtils.java
+++ 
b/foundations/foundation-vertx/src/main/java/io/vertx/ext/web/impl/MimeTypesUtils.java
@@ -1,18 +1,23 @@
 /*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
+ * Copyright 2014 Red Hat, Inc.
  *
- * http://www.apache.org/licenses/LICENSE-2.0
+ *  All rights reserved. This program and the accompanying materials
+ *  are made available under the terms of the Eclipse Public License v1.0
+ *  and Apache License v2.0 which accompanies this distribution.
  *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions

[jira] [Commented] (SCB-320) Feature adjustment for 1.0.0-m1 publish

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350026#comment-16350026
 ] 

ASF GitHub Bot commented on SCB-320:


zhengyangyong commented on issue #540: [SCB-320] Feature adjustment for 
1.0.0-m1 publish
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/540#issuecomment-362530385
 
 
   This PR will split to three smaller PR


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Feature adjustment for 1.0.0-m1 publish
> ---
>
> Key: SCB-320
> URL: https://issues.apache.org/jira/browse/SCB-320
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> 1.Because support of custom metrics not so prefect temporary disable it；
> 2.change data publish from RegistryMetric model to map
> 3.Remove custom EventBus because old EventManager with google EventBus is 
> good enough



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-321) Support report trace data

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349973#comment-16349973
 ] 

ASF GitHub Bot commented on SCB-321:


codecov-io commented on issue #267:  SCB-321 Support report trace data
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/267#issuecomment-362265029
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267?src=pr=h1)
 Report
   > Merging 
[#267](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/089e77467d5206ce423d065baf757aa92a371468?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267/graphs/tree.svg?height=150=650=GAaF7zrg8R=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master#267   +/-   ##
   ==
 Coverage70.2%   70.2%   
   ==
 Files  17  17   
 Lines34703470   
   ==
 Hits 24362436   
 Misses864 864   
 Partials  170 170
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==)
 | `76.82% <0%> (-0.43%)` | :arrow_down: |
   | 
[server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv)
 | `71.28% <0%> (+0.16%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267?src=pr=footer).
 Last update 
[089e774...c482bdf](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support report trace data
> -
>
> Key: SCB-321
> URL: https://issues.apache.org/jira/browse/SCB-321
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-321) Support report trace data

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349972#comment-16349972
 ] 

ASF GitHub Bot commented on SCB-321:


coveralls commented on issue #267:  SCB-321 Support report trace data
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/267#issuecomment-362264980
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15340664/badge)](https://coveralls.io/builds/15340664)
   
   Coverage increased (+0.05%) to 73.881% when pulling 
**c482bdf4a9baa7d11f726e78f69b8d0bea39a227 on little-cui:SCB-321** into 
**089e77467d5206ce423d065baf757aa92a371468 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support report trace data
> -
>
> Key: SCB-321
> URL: https://issues.apache.org/jira/browse/SCB-321
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-321) Support report trace data

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349964#comment-16349964
 ] 

ASF GitHub Bot commented on SCB-321:


coveralls commented on issue #267:  SCB-321 Support report trace data
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/267#issuecomment-362264980
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15340621/badge)](https://coveralls.io/builds/15340621)
   
   Coverage increased (+0.05%) to 73.881% when pulling 
**c482bdf4a9baa7d11f726e78f69b8d0bea39a227 on little-cui:SCB-321** into 
**089e77467d5206ce423d065baf757aa92a371468 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support report trace data
> -
>
> Key: SCB-321
> URL: https://issues.apache.org/jira/browse/SCB-321
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-321) Support report trace data

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349965#comment-16349965
 ] 

ASF GitHub Bot commented on SCB-321:


codecov-io commented on issue #267:  SCB-321 Support report trace data
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/267#issuecomment-362265029
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267?src=pr=h1)
 Report
   > Merging 
[#267](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/089e77467d5206ce423d065baf757aa92a371468?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267/graphs/tree.svg?width=650=pr=150=GAaF7zrg8R)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master#267   +/-   ##
   ==
 Coverage70.2%   70.2%   
   ==
 Files  17  17   
 Lines34703470   
   ==
 Hits 24362436   
 Misses864 864   
 Partials  170 170
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==)
 | `76.82% <0%> (-0.43%)` | :arrow_down: |
   | 
[server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv)
 | `76.02% <0%> (+0.58%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267?src=pr=footer).
 Last update 
[089e774...c482bdf](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support report trace data
> -
>
> Key: SCB-321
> URL: https://issues.apache.org/jira/browse/SCB-321
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-321) Support report trace data

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349936#comment-16349936
 ] 

ASF GitHub Bot commented on SCB-321:


codecov-io commented on issue #267:  SCB-321 Support report trace data
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/267#issuecomment-362265029
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267?src=pr=h1)
 Report
   > Merging 
[#267](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/089e77467d5206ce423d065baf757aa92a371468?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267/graphs/tree.svg?width=650=150=pr=GAaF7zrg8R)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master#267   +/-   ##
   ==
 Coverage70.2%   70.2%   
   ==
 Files  17  17   
 Lines34703470   
   ==
 Hits 24362436   
 Misses864 864   
 Partials  170 170
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267?src=pr=footer).
 Last update 
[089e774...30943a5](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/267?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support report trace data
> -
>
> Key: SCB-321
> URL: https://issues.apache.org/jira/browse/SCB-321
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-321) Support report trace data

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349938#comment-16349938
 ] 

ASF GitHub Bot commented on SCB-321:


coveralls commented on issue #267:  SCB-321 Support report trace data
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/267#issuecomment-362264980
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15340437/badge)](https://coveralls.io/builds/15340437)
   
   Coverage remained the same at 73.832% when pulling 
**30943a5a7aef6bd43cc8e375b2a907b03b5db3da on little-cui:SCB-321** into 
**089e77467d5206ce423d065baf757aa92a371468 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support report trace data
> -
>
> Key: SCB-321
> URL: https://issues.apache.org/jira/browse/SCB-321
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (SCB-177) Support traceId in accesslog

2018-02-02 Thread YaoHaishi (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SCB-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

YaoHaishi closed SCB-177.
-

> Support traceId in accesslog
> 
>
> Key: SCB-177
> URL: https://issues.apache.org/jira/browse/SCB-177
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: YaoHaishi
>Assignee: YaoHaishi
>Priority: Minor
>
> Let access log can print traceId



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-219) Let JsonUtils ignore unknown properties

2018-02-02 Thread YaoHaishi (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349930#comment-16349930
 ] 

YaoHaishi commented on SCB-219:
---

This issue has been fixed in [https://issues.apache.org/jira/browse/SCB-251]

> Let JsonUtils ignore unknown properties
> ---
>
> Key: SCB-219
> URL: https://issues.apache.org/jira/browse/SCB-219
> Project: Apache ServiceComb
>  Issue Type: Improvement
>Reporter: YaoHaishi
>Assignee: YaoHaishi
>Priority: Major
>
> At present, JsonUtils throws exception while deserializing json string that 
> contains unknown properties. This may cause problems when we want to achieve 
> legacy version compatibility.
> Maybe we should make JsonUtils ignore unknown properties. I find that there 
> is such configuration, but it's commented(line 42 - line 46 in 
> JsonUtils.java).
> Should we enable it?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (SCB-219) Let JsonUtils ignore unknown properties

2018-02-02 Thread YaoHaishi (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SCB-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

YaoHaishi closed SCB-219.
-
Resolution: Duplicate

> Let JsonUtils ignore unknown properties
> ---
>
> Key: SCB-219
> URL: https://issues.apache.org/jira/browse/SCB-219
> Project: Apache ServiceComb
>  Issue Type: Improvement
>Reporter: YaoHaishi
>Assignee: YaoHaishi
>Priority: Major
>
> At present, JsonUtils throws exception while deserializing json string that 
> contains unknown properties. This may cause problems when we want to achieve 
> legacy version compatibility.
> Maybe we should make JsonUtils ignore unknown properties. I find that there 
> is such configuration, but it's commented(line 42 - line 46 in 
> JsonUtils.java).
> Should we enable it?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)