[jira] [Commented] (SCB-514) update pom and code, so that we can treat warnings as errors
[
https://issues.apache.org/jira/browse/SCB-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451688#comment-16451688
]
ASF GitHub Bot commented on SCB-514:
coveralls commented on issue #675: [SCB-514] Warning as error
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/675#issuecomment-384168811
[](https://coveralls.io/builds/16684256)
Coverage increased (+0.002%) to 87.378% when pulling
**71994507542b86927fe6d6ab33bdf1e0e2c910c1 on wujimin:warning-as-error** into
**43cec8919f32de8311019639bc517fada8c7c704 on apache:master**.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> update pom and code, so that we can treat warnings as errors
>
>
> Key: SCB-514
> URL: https://issues.apache.org/jira/browse/SCB-514
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> supress warning tips:
> 1.update maven-compiler-plugin in java-chassis-dependencies/pom.xml:
> {code:java}
>
> ..
>
>
>
>
> {code}
> 2.deprecated class must not in import scope, if must use this class, use
> qulified name in code, DO NOT import it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-470) Provide Maven Archetype of business-service-spring-boot-starter
[ https://issues.apache.org/jira/browse/SCB-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451651#comment-16451651 ] ASF GitHub Bot commented on SCB-470: coveralls commented on issue #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#issuecomment-380649944 [](https://coveralls.io/builds/16683672) Coverage remained the same at 87.376% when pulling **957b53866fadfc78338114cd720a4c48c6f90172 on zhengyangyong:SCB-470** into **43cec8919f32de8311019639bc517fada8c7c704 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Provide Maven Archetype of business-service-spring-boot-starter > --- > > Key: SCB-470 > URL: https://issues.apache.org/jira/browse/SCB-470 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Affects Versions: java-chassis-1.0.0-m2 >Reporter: yangyongzheng >Assignee: yangyongzheng >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > This Archetype for create a common microservice using > spring-boot-starter-provider. > It's contains : > 1.All necessary dependencies in pom. > 2.An HelloEndpoint provider using springmvc mode. > 3.Default microservice.yaml. > 4.Provider bean xml Included spring component-scan. > 5.An HelloConsumer using springmvc mode. > 6.Readme file teach user what can be done further. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-470) Provide Maven Archetype of business-service-spring-boot-starter
[ https://issues.apache.org/jira/browse/SCB-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451596#comment-16451596 ] ASF GitHub Bot commented on SCB-470: coveralls commented on issue #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#issuecomment-380649944 [](https://coveralls.io/builds/16683458) Coverage decreased (-0.1%) to 87.376% when pulling **df8118bf39197d39ce07503ca1a7ace0cc75f12a on zhengyangyong:SCB-470** into **6f66e2622b0c056d26682672b881c15920f06fba on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Provide Maven Archetype of business-service-spring-boot-starter > --- > > Key: SCB-470 > URL: https://issues.apache.org/jira/browse/SCB-470 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Affects Versions: java-chassis-1.0.0-m2 >Reporter: yangyongzheng >Assignee: yangyongzheng >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > This Archetype for create a common microservice using > spring-boot-starter-provider. > It's contains : > 1.All necessary dependencies in pom. > 2.An HelloEndpoint provider using springmvc mode. > 3.Default microservice.yaml. > 4.Provider bean xml Included spring component-scan. > 5.An HelloConsumer using springmvc mode. > 6.Readme file teach user what can be done further. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-470) Provide Maven Archetype of business-service-spring-boot-starter
[ https://issues.apache.org/jira/browse/SCB-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451556#comment-16451556 ] ASF GitHub Bot commented on SCB-470: zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r183934772 ## File path: archetypes/business-service-spring-boot-starter/README.md ## @@ -0,0 +1,36 @@ +## Welcome to use ServiceComb Java Chassis +This project(module) is generate by *org.apache.servicecomb.archetypes:business-service-spring-boot-starter-archetype*, it use **spring-boot-starter-provider** to develop service endpoint. + +### More works can be done further: +1. Modify "HelloEndpoint", add your business service logic, or create some new endpoints to provide your services. More details can be found : http://servicecomb.incubator.apache.org/users/use-servicecomb-in-spring-boot/ Review comment: Fixed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Provide Maven Archetype of business-service-spring-boot-starter > --- > > Key: SCB-470 > URL: https://issues.apache.org/jira/browse/SCB-470 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Affects Versions: java-chassis-1.0.0-m2 >Reporter: yangyongzheng >Assignee: yangyongzheng >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > This Archetype for create a common microservice using > spring-boot-starter-provider. > It's contains : > 1.All necessary dependencies in pom. > 2.An HelloEndpoint provider using springmvc mode. > 3.Default microservice.yaml. > 4.Provider bean xml Included spring component-scan. > 5.An HelloConsumer using springmvc mode. > 6.Readme file teach user what can be done further. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-470) Provide Maven Archetype of business-service-spring-boot-starter
[ https://issues.apache.org/jira/browse/SCB-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451551#comment-16451551 ] ASF GitHub Bot commented on SCB-470: zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r183934108 ## File path: archetypes/business-service-spring-boot-starter/README.md ## @@ -0,0 +1,36 @@ +## Welcome to use ServiceComb Java Chassis +This project(module) is generate by *org.apache.servicecomb.archetypes:business-service-spring-boot-starter-archetype*, it use **spring-boot-starter-provider** to develop service endpoint. + +### More works can be done further: +1. Modify "HelloEndpoint", add your business service logic, or create some new endpoints to provide your services. More details can be found : http://servicecomb.incubator.apache.org/users/use-servicecomb-in-spring-boot/ Review comment: 链接写错了。。。http://servicecomb.incubator.apache.org/users/develop-with-spring-boot-starter/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Provide Maven Archetype of business-service-spring-boot-starter > --- > > Key: SCB-470 > URL: https://issues.apache.org/jira/browse/SCB-470 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Affects Versions: java-chassis-1.0.0-m2 >Reporter: yangyongzheng >Assignee: yangyongzheng >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > This Archetype for create a common microservice using > spring-boot-starter-provider. > It's contains : > 1.All necessary dependencies in pom. > 2.An HelloEndpoint provider using springmvc mode. > 3.Default microservice.yaml. > 4.Provider bean xml Included spring component-scan. > 5.An HelloConsumer using springmvc mode. > 6.Readme file teach user what can be done further. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-470) Provide Maven Archetype of business-service-spring-boot-starter
[ https://issues.apache.org/jira/browse/SCB-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451550#comment-16451550 ] ASF GitHub Bot commented on SCB-470: zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r183933958 ## File path: archetypes/business-service-spring-boot-starter/README.md ## @@ -0,0 +1,36 @@ +## Welcome to use ServiceComb Java Chassis +This project(module) is generate by *org.apache.servicecomb.archetypes:business-service-spring-boot-starter-archetype*, it use **spring-boot-starter-provider** to develop service endpoint. + +### More works can be done further: +1. Modify "HelloEndpoint", add your business service logic, or create some new endpoints to provide your services. More details can be found : http://servicecomb.incubator.apache.org/users/use-servicecomb-in-spring-boot/ Review comment: sorry ,I will check web site later This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Provide Maven Archetype of business-service-spring-boot-starter > --- > > Key: SCB-470 > URL: https://issues.apache.org/jira/browse/SCB-470 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Affects Versions: java-chassis-1.0.0-m2 >Reporter: yangyongzheng >Assignee: yangyongzheng >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > This Archetype for create a common microservice using > spring-boot-starter-provider. > It's contains : > 1.All necessary dependencies in pom. > 2.An HelloEndpoint provider using springmvc mode. > 3.Default microservice.yaml. > 4.Provider bean xml Included spring component-scan. > 5.An HelloConsumer using springmvc mode. > 6.Readme file teach user what can be done further. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-470) Provide Maven Archetype of business-service-spring-boot-starter
[ https://issues.apache.org/jira/browse/SCB-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451509#comment-16451509 ] ASF GitHub Bot commented on SCB-470: liubao68 commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r183926357 ## File path: archetypes/business-service-spring-boot-starter/README.md ## @@ -0,0 +1,36 @@ +## Welcome to use ServiceComb Java Chassis +This project(module) is generate by *org.apache.servicecomb.archetypes:business-service-spring-boot-starter-archetype*, it use **spring-boot-starter-provider** to develop service endpoint. + +### More works can be done further: +1. Modify "HelloEndpoint", add your business service logic, or create some new endpoints to provide your services. More details can be found : http://servicecomb.incubator.apache.org/users/use-servicecomb-in-spring-boot/ Review comment: Can not access : http://servicecomb.incubator.apache.org/users/use-servicecomb-in-spring-boot/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Provide Maven Archetype of business-service-spring-boot-starter > --- > > Key: SCB-470 > URL: https://issues.apache.org/jira/browse/SCB-470 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Affects Versions: java-chassis-1.0.0-m2 >Reporter: yangyongzheng >Assignee: yangyongzheng >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > This Archetype for create a common microservice using > spring-boot-starter-provider. > It's contains : > 1.All necessary dependencies in pom. > 2.An HelloEndpoint provider using springmvc mode. > 3.Default microservice.yaml. > 4.Provider bean xml Included spring component-scan. > 5.An HelloConsumer using springmvc mode. > 6.Readme file teach user what can be done further. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SCB-514) update pom and code, so that we can treat warnings as errors
[
https://issues.apache.org/jira/browse/SCB-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
wujimin reassigned SCB-514:
---
Assignee: wujimin
> update pom and code, so that we can treat warnings as errors
>
>
> Key: SCB-514
> URL: https://issues.apache.org/jira/browse/SCB-514
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> supress warning tips:
> 1.update maven-compiler-plugin in java-chassis-dependencies/pom.xml:
> {code:java}
>
> ..
>
>
>
>
> {code}
> 2.deprecated class must not in import scope, if must use this class, use
> qulified name in code, DO NOT import it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SCB-501) document for download
[ https://issues.apache.org/jira/browse/SCB-501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujimin resolved SCB-501. - Resolution: Done > document for download > - > > Key: SCB-501 > URL: https://issues.apache.org/jira/browse/SCB-501 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-501) document for download
[ https://issues.apache.org/jira/browse/SCB-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451454#comment-16451454 ] wujimin commented on SCB-501: - https://java.huaweicse.com/general-development/file-download.html > document for download > - > > Key: SCB-501 > URL: https://issues.apache.org/jira/browse/SCB-501 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-224) [pack] retry sub-transaction on failure
[ https://issues.apache.org/jira/browse/SCB-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449470#comment-16449470 ] ASF GitHub Bot commented on SCB-224: coveralls commented on issue #138: SCB-224 retry sub-transaction on failure URL: https://github.com/apache/incubator-servicecomb-saga/pull/138#issuecomment-368816986 [](https://coveralls.io/builds/16665603) Coverage increased (+0.3%) to 95.361% when pulling **436296b07b1bcf92aab65cd65e358feade8d77d4 on eric-lee-ltk:SCB-224** into **aff2719e0322c452dc52c0e90f9150ac0fb123e6 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [pack] retry sub-transaction on failure > --- > > Key: SCB-224 > URL: https://issues.apache.org/jira/browse/SCB-224 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Saga >Reporter: Yin Xiang >Assignee: Eric Lee >Priority: Major > Fix For: saga-0.2.0 > > > as a user, i want to retry transaction in my service, so that it can always > be done eventually. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-504) Upgrade to Spring boot 1.5.12.RELEASE
[ https://issues.apache.org/jira/browse/SCB-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449454#comment-16449454 ] ASF GitHub Bot commented on SCB-504: coveralls commented on issue #673: [SCB-504] upgrade spring boot version to 1.5.8.RELEASE and spring version to 4.3.12.RELEASE URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/673#issuecomment-383531568 [](https://coveralls.io/builds/16665239) Coverage decreased (-0.01%) to 87.365% when pulling **07b4584dbc614a45c2c9b0efdcc78ddfc468b65b on zhengyangyong:SCB-504** into **43cec8919f32de8311019639bc517fada8c7c704 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade to Spring boot 1.5.12.RELEASE > - > > Key: SCB-504 > URL: https://issues.apache.org/jira/browse/SCB-504 > Project: Apache ServiceComb > Issue Type: Wish > Components: Java-Chassis >Affects Versions: java-chassis-1.0.0-m2 >Reporter: yangyongzheng >Assignee: yangyongzheng >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > https://github.com/apache/incubator-servicecomb-java-chassis/issues/654 > we may test upgrade to 1.5.12.RELEASE -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-508) Cache does not match the etcd store
[
https://issues.apache.org/jira/browse/SCB-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449447#comment-16449447
]
ASF GitHub Bot commented on SCB-508:
little-cui closed pull request #332: SCB-508 Cache does not match the etcd store
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/332
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/integration/health-metrics-grafana.json
b/integration/health-metrics-grafana.json
index aff03ab7..55e5c695 100644
--- a/integration/health-metrics-grafana.json
+++ b/integration/health-metrics-grafana.json
@@ -1,18 +1,3 @@
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements. See the NOTICE file distributed with
-# this work for additional information regarding copyright ownership.
-# The ASF licenses this file to You under the Apache License, Version 2.0
-# (the "License"); you may not use this file except in compliance with
-# the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
{
"annotations": {
"list": [
@@ -31,7 +16,7 @@
"gnetId": null,
"graphTooltip": 0,
"hideControls": false,
- "id": 5,
+ "id": 6,
"links": [
{
"icon": "external link",
@@ -57,9 +42,9 @@
"height": "",
"id": 1,
"legend": {
-"alignAsTable": false,
+"alignAsTable": true,
"avg": true,
-"current": false,
+"current": true,
"max": false,
"min": false,
"show": true,
@@ -448,7 +433,7 @@
"repeatIteration": null,
"repeatRowId": null,
"showTitle": false,
- "title": "Dashboard Row",
+ "title": "service metrics",
"titleSize": "h6"
},
{
@@ -571,7 +556,7 @@
"legend": {
"alignAsTable": true,
"avg": true,
-"current": false,
+"current": true,
"max": true,
"min": true,
"show": true,
@@ -649,7 +634,7 @@
"legend": {
"alignAsTable": true,
"avg": true,
-"current": false,
+"current": true,
"max": true,
"min": true,
"show": true,
@@ -909,7 +894,7 @@
"dashes": false,
"datasource": null,
"fill": 1,
- "id": 7,
+ "id": 14,
"legend": {
"alignAsTable": true,
"avg": true,
@@ -977,6 +962,92 @@
"show": true
}
]
+},
+{
+ "aliasColors": {},
+ "bars": false,
+ "dashLength": 10,
+ "dashes": false,
+ "datasource": null,
+ "fill": 1,
+ "id": 7,
+ "legend": {
+"alignAsTable": true,
+"avg": false,
+"current": true,
+"max": true,
+"min": false,
+"rightSide": true,
+"show": true,
+"sort": "current",
+"sortDesc": true,
+"total": false,
+"values": true
+ },
+ "lines": true,
+ "linewidth": 1,
+ "links": [],
+ "nullPointMode": "null",
+ "percentage": false,
+ "pointradius": 5,
+ "points": false,
+ "renderer": "flot",
+ "seriesOverrides": [],
+ "spaceLength": 10,
+ "span": 12,
+ "stack": false,
+ "steppedLine": false,
+ "targets": [
+{
+ "expr": "service_center_local_cache_size_bytes",
+ "format": "time_series",
+ "intervalFactor": 2,
+ "legendFormat": "{{resource}}.{{type}}",
+ "refId": "A"
+},
+{
+ "expr": "sum(service_center_local_cache_size_bytes)",
+ "format": "time_series",
+ "intervalFactor": 2,
+ "legendFormat": "ALL",
+ "refId": "B"
+}
+ ],
+ "thresholds": [],
+ "timeFrom": null,
+ "timeShift": null,
+ "title": "Cache",
+ "tooltip": {
+"shared": true,
+"sort": 0,
+"value_type": "individual"
+ },
+ "type": "graph",
+
[jira] [Commented] (SCB-508) Cache does not match the etcd store
[ https://issues.apache.org/jira/browse/SCB-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449443#comment-16449443 ] ASF GitHub Bot commented on SCB-508: coveralls commented on issue #332: SCB-508 Cache does not match the etcd store URL: https://github.com/apache/incubator-servicecomb-service-center/pull/332#issuecomment-383774261 [](https://coveralls.io/builds/16664964) Coverage increased (+0.007%) to 72.937% when pulling **fae3ae3841b02828c38185d813782f09d783bfeb on little-cui:master** into **bdbdfebc6e0754bf1dda8f77498d768feb947da1 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cache does not match the etcd store > --- > > Key: SCB-508 > URL: https://issues.apache.org/jira/browse/SCB-508 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.0.0-m2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-508) Cache does not match the etcd store
[ https://issues.apache.org/jira/browse/SCB-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449444#comment-16449444 ] ASF GitHub Bot commented on SCB-508: codecov-io commented on issue #332: SCB-508 Cache does not match the etcd store URL: https://github.com/apache/incubator-servicecomb-service-center/pull/332#issuecomment-383774260 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/332?src=pr=h1) Report > Merging [#332](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/332?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/bdbdfebc6e0754bf1dda8f77498d768feb947da1?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/332?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #332 +/- ## === Coverage 69.45% 69.45% === Files 17 17 Lines3438 3438 === Hits 2388 2388 Misses884 884 Partials 166 166 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/332?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/332?src=pr=footer). Last update [bdbdfeb...fae3ae3](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/332?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cache does not match the etcd store > --- > > Key: SCB-508 > URL: https://issues.apache.org/jira/browse/SCB-508 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.0.0-m2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-504) Upgrade to Spring boot 1.5.12.RELEASE
[ https://issues.apache.org/jira/browse/SCB-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449410#comment-16449410 ] ASF GitHub Bot commented on SCB-504: zhengyangyong commented on issue #673: [SCB-504] upgrade spring boot version to 1.5.8.RELEASE and spring version to 4.3.12.RELEASE URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/673#issuecomment-383824902 @liubao68 Yes ,but the behavior of RestTemplate had changed so may make some trouble when user upgrade to 1.0.0-m2 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade to Spring boot 1.5.12.RELEASE > - > > Key: SCB-504 > URL: https://issues.apache.org/jira/browse/SCB-504 > Project: Apache ServiceComb > Issue Type: Wish > Components: Java-Chassis >Affects Versions: java-chassis-1.0.0-m2 >Reporter: yangyongzheng >Assignee: yangyongzheng >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > https://github.com/apache/incubator-servicecomb-java-chassis/issues/654 > we may test upgrade to 1.5.12.RELEASE -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-506) 服务治理相关的需要事件上报
[
https://issues.apache.org/jira/browse/SCB-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449402#comment-16449402
]
ASF GitHub Bot commented on SCB-506:
liubao68 commented on a change in pull request #666: [SCB-506]服务治理相关的需要事件上报
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/666#discussion_r183620187
##
File path:
handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperHandler.java
##
@@ -72,8 +76,14 @@ public BizkeeperHandler(String groupname) {
@Override
public void handle(Invocation invocation, AsyncResponse asyncResp) {
HystrixObservable command =
delegate.createBizkeeperCommand(invocation);
-
Observable observable = command.toObservable();
+HystrixCircuitBreaker circuitBreaker =
+
HystrixCircuitBreaker.Factory.getInstance(CommandKey.toHystrixCommandKey(groupname,
invocation));
+if (circuitBreaker != null && circuitBreaker.isOpen()) {
+ EventManager.post(new CircutBreakerEvent(invocation, this.groupname,
Type.OPEN));
+}else {
+ EventManager.post(new CircutBreakerEvent(invocation, this.groupname,
Type.CLOSE));
Review comment:
We need only send event when last time is OPEN and turn to be CLOSED. Can't
send for each invocation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> 服务治理相关的需要事件上报
> -
>
> Key: SCB-506
> URL: https://issues.apache.org/jira/browse/SCB-506
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: xuyiyun
>Assignee: xuyiyun
>Priority: Major
>
> 如果发生服务降级 实例隔离 熔断等操作，业务监控系统需要能获取到对应的通知，方便集成
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-506) 服务治理相关的需要事件上报
[
https://issues.apache.org/jira/browse/SCB-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449390#comment-16449390
]
ASF GitHub Bot commented on SCB-506:
liubao68 commented on a change in pull request #666: [SCB-506]服务治理相关的需要事件上报
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/666#discussion_r183619179
##
File path:
foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/event/AlarmEvent.java
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.foundation.common.event;
+
+import java.util.HashMap;
+
+public class AlarmEvent {
+
+ Type type;
+
+ private int id;
+
+ private HashMap msg;
+
+ public AlarmEvent(Type type, int id) {
+this.type = type;
+this.id = id;
+ }
+
+ public Type getType() {
+return this.type;
+ }
+
+ public int getId() {
+return id;
+ }
+
+ public HashMap getMsg() {
+return msg;
+ }
+
+ public void setMsg(HashMap msg2) {
+this.msg = msg2;
+ }
+
+ public enum Type {
+OPEN,
+CLOSE,
+SUCCED,
Review comment:
Use SUCCEDED or SUCCESSFUL. When should we use OPEN vs SUCCED?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> 服务治理相关的需要事件上报
> -
>
> Key: SCB-506
> URL: https://issues.apache.org/jira/browse/SCB-506
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: xuyiyun
>Assignee: xuyiyun
>Priority: Major
>
> 如果发生服务降级 实例隔离 熔断等操作，业务监控系统需要能获取到对应的通知，方便集成
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-506) 服务治理相关的需要事件上报
[ https://issues.apache.org/jira/browse/SCB-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449384#comment-16449384 ] ASF GitHub Bot commented on SCB-506: liubao68 commented on issue #666: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/666#issuecomment-383820433 You have make some related merge. Please fix it or submit a new one. You can refer http://servicecomb.incubator.apache.org/developers/submit-codes/ to create new PR's. And you can directly commit to your new branch for comments fix to your PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > 服务治理相关的需要事件上报 > - > > Key: SCB-506 > URL: https://issues.apache.org/jira/browse/SCB-506 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: xuyiyun >Assignee: xuyiyun >Priority: Major > > 如果发生服务降级 实例隔离 熔断等操作，业务监控系统需要能获取到对应的通知，方便集成 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-506) 服务治理相关的需要事件上报
[ https://issues.apache.org/jira/browse/SCB-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449381#comment-16449381 ] ASF GitHub Bot commented on SCB-506: coveralls commented on issue #666: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/666#issuecomment-383819845 [](https://coveralls.io/builds/16664255) Coverage increased (+0.02%) to 87.395% when pulling **9c358ad8a20778d0beb3775dd78869b519af4102 on xuyiyun0929:alarm** into **43cec8919f32de8311019639bc517fada8c7c704 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > 服务治理相关的需要事件上报 > - > > Key: SCB-506 > URL: https://issues.apache.org/jira/browse/SCB-506 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: xuyiyun >Assignee: xuyiyun >Priority: Major > > 如果发生服务降级 实例隔离 熔断等操作，业务监控系统需要能获取到对应的通知，方便集成 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-504) Upgrade to Spring boot 1.5.12.RELEASE
[ https://issues.apache.org/jira/browse/SCB-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449365#comment-16449365 ] ASF GitHub Bot commented on SCB-504: liubao68 commented on issue #673: [SCB-504] upgrade spring boot version to 1.5.8.RELEASE and spring version to 4.3.12.RELEASE URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/673#issuecomment-383817205 I think we'd better upgrade to 1.5.12.RELEASE & 4.3.16.RELEASE as some security fixes have been done. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade to Spring boot 1.5.12.RELEASE > - > > Key: SCB-504 > URL: https://issues.apache.org/jira/browse/SCB-504 > Project: Apache ServiceComb > Issue Type: Wish > Components: Java-Chassis >Affects Versions: java-chassis-1.0.0-m2 >Reporter: yangyongzheng >Assignee: yangyongzheng >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > https://github.com/apache/incubator-servicecomb-java-chassis/issues/654 > we may test upgrade to 1.5.12.RELEASE -- This message was sent by Atlassian JIRA (v7.6.3#76005)
