[jira] [Commented] (SCB-771) Update LICENSE/NOTICE for Service-Center 1.0.0 release
[ https://issues.apache.org/jira/browse/SCB-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553762#comment-16553762 ] ASF GitHub Bot commented on SCB-771: coveralls commented on issue #398: [SCB-771] Add missing dependencies in LICENSE URL: https://github.com/apache/incubator-servicecomb-service-center/pull/398#issuecomment-407270777 [](https://coveralls.io/builds/18128979) Coverage increased (+0.08%) to 74.514% when pulling **788c69afdb647c2ebaf022c5c29dc07a13b61c4a on yangbor:master** into **aa34cb9d7525a2743b521a8bfe436d0bb4688b12 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update LICENSE/NOTICE for Service-Center 1.0.0 release > -- > > Key: SCB-771 > URL: https://issues.apache.org/jira/browse/SCB-771 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Affects Versions: service-center-1.0.0 >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Major > Fix For: service-center-1.0.0 > > > Add missing dependencies in LICENSE for binary release. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-771) Update LICENSE/NOTICE for Service-Center 1.0.0 release
[ https://issues.apache.org/jira/browse/SCB-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553761#comment-16553761 ] ASF GitHub Bot commented on SCB-771: codecov-io commented on issue #398: [SCB-771] Add missing dependencies in LICENSE URL: https://github.com/apache/incubator-servicecomb-service-center/pull/398#issuecomment-407270750 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/398?src=pr=h1) Report > Merging [#398](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/398?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/aa34cb9d7525a2743b521a8bfe436d0bb4688b12?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/398?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #398 +/- ## === Coverage 71.69% 71.69% === Files 39 39 Lines4130 4130 === Hits 2961 2961 Misses 1002 1002 Partials 167 167 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/398?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/398?src=pr=footer). Last update [aa34cb9...788c69a](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/398?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update LICENSE/NOTICE for Service-Center 1.0.0 release > -- > > Key: SCB-771 > URL: https://issues.apache.org/jira/browse/SCB-771 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Affects Versions: service-center-1.0.0 >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Major > Fix For: service-center-1.0.0 > > > Add missing dependencies in LICENSE for binary release. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-772) Java Chassis::Handlers::Loadbalance test failed
yangyongzheng created SCB-772: - Summary: Java Chassis::Handlers::Loadbalance test failed Key: SCB-772 URL: https://issues.apache.org/jira/browse/SCB-772 Project: Apache ServiceComb Issue Type: Bug Components: Java-Chassis Affects Versions: java-chassis-1.0.0-m2 Environment: JDK : java version "1.8.0_171" Java(TM) SE Runtime Environment (build 1.8.0_171-b11) Java HotSpot(TM) 64-Bit Server VM (build 25.171-b11, mixed mode) OS : Linux version 4.4.0-104-generic (buildd@lgw01-amd64-022) (gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.5) ) #127-Ubuntu SMP Mon Dec 11 12:16:42 UTC 2017 Reporter: yangyongzheng Fix For: java-chassis-1.0.0 Java Chassis::Handlers::Loadbalance test failed: 2018-07-24 09:45:08,429 [main ] ERROR ExceptionUtils - Exception: org.apache.servicecomb.core.exception.CseException; No available address found. microserviceName=ms, version=null, discoveryGroupName=null ServiceDefinitionException Code:servicecomb.lb.no.available.address, Message:No available address found. microserviceName=ms, version=null, discoveryGroupName=null at org.apache.servicecomb.core.exception.ExceptionUtils.createCseException(ExceptionUtils.java:57) at org.apache.servicecomb.core.exception.ExceptionUtils.lbAddressNotFound(ExceptionUtils.java:88) at org.apache.servicecomb.loadbalance.LoadbalanceHandler.send(LoadbalanceHandler.java:135) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at mockit.internal.util.MethodReflection.invoke(MethodReflection.java:120) at mockit.internal.util.MethodReflection.invoke(MethodReflection.java:185) at mockit.Deencapsulation.invoke(Deencapsulation.java:210) at org.apache.servicecomb.loadbalance.TestLoadbalanceHandler.send_noEndPoint(TestLoadbalanceHandler.java:195) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at mockit.integration.junit4.internal.JUnit4TestRunnerDecorator.executeTestMethod(JUnit4TestRunnerDecorator.java:162) at mockit.integration.junit4.internal.JUnit4TestRunnerDecorator.invokeExplosively(JUnit4TestRunnerDecorator.java:71) at mockit.integration.junit4.internal.MockFrameworkMethod.invokeExplosively(MockFrameworkMethod.java:37) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:239) at org.junit.rules.RunRules.evaluate(RunRules.java:20) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:367) at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:274) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:290) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:242) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121) 2018-07-24 09:45:08,493 [main ] INFO DiscoveryTree - DiscoveryFilter org.apache.servicecomb.loadbalance.filter.ServerDiscoveryFilter, enabled true. 2018-07-24 09:45:08,542 [main ]
[jira] [Commented] (SCB-771) Update LICENSE/NOTICE for Service-Center 1.0.0 release
[ https://issues.apache.org/jira/browse/SCB-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553752#comment-16553752 ] ASF GitHub Bot commented on SCB-771: yangbor opened a new pull request #398: [SCB-771] Add missing dependencies in LICENSE URL: https://github.com/apache/incubator-servicecomb-service-center/pull/398 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update LICENSE/NOTICE for Service-Center 1.0.0 release > -- > > Key: SCB-771 > URL: https://issues.apache.org/jira/browse/SCB-771 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Affects Versions: service-center-1.0.0 >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Major > Fix For: service-center-1.0.0 > > > Add missing dependencies in LICENSE for binary release. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-771) Update LICENSE/NOTICE for Service-Center 1.0.0 release
Yang Bo created SCB-771: --- Summary: Update LICENSE/NOTICE for Service-Center 1.0.0 release Key: SCB-771 URL: https://issues.apache.org/jira/browse/SCB-771 Project: Apache ServiceComb Issue Type: Improvement Components: Service-Center Affects Versions: service-center-1.0.0 Reporter: Yang Bo Assignee: Yang Bo Fix For: service-center-1.0.0 Add missing dependencies in LICENSE for binary release. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-687) highway server not accept too many connection
[ https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553715#comment-16553715 ] ASF GitHub Bot commented on SCB-687: zhengyangyong commented on a change in pull request #824: [SCB-687] add highway server connection protection URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/824#discussion_r204609279 ## File path: integration-tests/spring-pojo-connection-limit-test/src/test/resources/microservice.yaml ## @@ -0,0 +1,29 @@ +## --- +## Licensed to the Apache Software Foundation (ASF) under one or more +## contributor license agreements. See the NOTICE file distributed with +## this work for additional information regarding copyright ownership. +## The ASF licenses this file to You under the Apache License, Version 2.0 +## (the "License"); you may not use this file except in compliance with +## the License. You may obtain a copy of the License at +## +## http://www.apache.org/licenses/LICENSE-2.0 +## +## Unless required by applicable law or agreed to in writing, software +## distributed under the License is distributed on an "AS IS" BASIS, +## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +## See the License for the specific language governing permissions and +## limitations under the License. +## --- + +APPLICATION_ID: pojotest-it +service_description: + name: pojo + version: 0.0.4 +servicecomb: + service: +registry: + address: http://127.0.0.1:30100 + highway: +address: 0.0.0.0:7070 +server: + connection-limit: 0 Review comment: Done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > highway server not accept too many connection > - > > Key: SCB-687 > URL: https://issues.apache.org/jira/browse/SCB-687 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: yangyongzheng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-735) Add admin dump api
[ https://issues.apache.org/jira/browse/SCB-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553647#comment-16553647 ] ASF GitHub Bot commented on SCB-735: coveralls edited a comment on issue #396: SCB-735 Add admin dump api URL: https://github.com/apache/incubator-servicecomb-service-center/pull/396#issuecomment-406771280 [](https://coveralls.io/builds/18127937) Coverage increased (+1.6%) to 76.049% when pulling **7242ebf83e096b1cbb5cb65dbbefe9397e33e73e on little-cui:admin** into **aa34cb9d7525a2743b521a8bfe436d0bb4688b12 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add admin dump api > -- > > Key: SCB-735 > URL: https://issues.apache.org/jira/browse/SCB-735 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-735) Add admin dump api
[ https://issues.apache.org/jira/browse/SCB-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553645#comment-16553645 ] ASF GitHub Bot commented on SCB-735: codecov-io edited a comment on issue #396: SCB-735 Add admin dump api URL: https://github.com/apache/incubator-servicecomb-service-center/pull/396#issuecomment-406771272 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr=h1) Report > Merging [#396](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/aa34cb9d7525a2743b521a8bfe436d0bb4688b12?src=pr=desc) will **increase** coverage by `1.1%`. > The diff coverage is `77.25%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr=tree) ```diff @@ Coverage Diff@@ ## master#396 +/- ## + Coverage 71.69% 72.8% +1.1% Files 39 118 +79 Lines41309743 +5613 + Hits 29617093 +4132 - Misses 10022174 +1172 - Partials 167 476+309 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr=tree) | Coverage Δ | | |---|---|---| | [pkg/chain/invocation.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr=tree#diff-cGtnL2NoYWluL2ludm9jYXRpb24uZ28=) | `89.47% <ø> (ø)` | | | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `73.07% <ø> (ø)` | | | [pkg/task/executor.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr=tree#diff-cGtnL3Rhc2svZXhlY3V0b3IuZ28=) | `76% <ø> (ø)` | | | [server/service/notification/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2NvbW1vbi5nbw==) | `100% <ø> (ø)` | :arrow_up: | | [server/core/backend/extend.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9leHRlbmQuZ28=) | `75% <ø> (ø)` | | | [server/error/error.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr=tree#diff-c2VydmVyL2Vycm9yL2Vycm9yLmdv) | `100% <ø> (ø)` | | | [server/govern/controller\_v4.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9jb250cm9sbGVyX3Y0Lmdv) | `73.49% <ø> (ø)` | | | [pkg/validate/url.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr=tree#diff-cGtnL3ZhbGlkYXRlL3VybC5nbw==) | `0% <0%> (ø)` | | | [server/core/backend/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9jb21tb24uZ28=) | `75% <0%> (ø)` | | | [pkg/task/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr=tree#diff-cGtnL3Rhc2svc2VydmljZS5nbw==) | `40% <0%> (ø)` | | | ... and [127 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr=footer). Last update [aa34cb9...7242ebf](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add admin dump api > -- > > Key: SCB-735 > URL: https://issues.apache.org/jira/browse/SCB-735 > Project: Apache ServiceComb > Issue Type: New Feature > Components:
[jira] [Resolved] (SCB-761) Prepare 1.0.0 Release for SC
[ https://issues.apache.org/jira/browse/SCB-761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Asif Siddiqui resolved SCB-761. Resolution: Fixed > Prepare 1.0.0 Release for SC > > > Key: SCB-761 > URL: https://issues.apache.org/jira/browse/SCB-761 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-767) When using Response to return multi-code message, handlers / filters given ClassCaseException
[ https://issues.apache.org/jira/browse/SCB-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552819#comment-16552819 ] ASF GitHub Bot commented on SCB-767: coveralls edited a comment on issue #827: [SCB-767]When using Response to return multi-code message, handlers /filters given ClassCaseException URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/827#issuecomment-406578556 [](https://coveralls.io/builds/18115081) Coverage decreased (-0.3%) to 86.668% when pulling **a2722a7d74c1fc91c3922fe0c4d7c49cb7788b82 on liubao68:response-fail** into **a1d0804132cc949061440d7de6fd971a1cfeb246 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > When using Response to return multi-code message, handlers / filters given > ClassCaseException > - > > Key: SCB-767 > URL: https://issues.apache.org/jira/browse/SCB-767 > Project: Apache ServiceComb > Issue Type: Bug >Reporter: liubao >Assignee: liubao >Priority: Major > > Error code 400， 500 etc. takes as error. But the object result is not > throwable. So got class cast exception. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-735) Add admin dump api
[ https://issues.apache.org/jira/browse/SCB-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552816#comment-16552816 ] ASF GitHub Bot commented on SCB-735: codecov-io edited a comment on issue #396: SCB-735 Add admin dump api URL: https://github.com/apache/incubator-servicecomb-service-center/pull/396#issuecomment-406771272 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr=h1) Report > Merging [#396](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/aa34cb9d7525a2743b521a8bfe436d0bb4688b12?src=pr=desc) will **increase** coverage by `1.1%`. > The diff coverage is `77.02%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr=tree) ```diff @@ Coverage Diff@@ ## master#396 +/- ## + Coverage 71.69% 72.8% +1.1% Files 39 118 +79 Lines41309743 +5613 + Hits 29617093 +4132 - Misses 10022174 +1172 - Partials 167 476+309 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr=tree) | Coverage Δ | | |---|---|---| | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `74.03% <ø> (ø)` | | | [server/core/backend/extend.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9leHRlbmQuZ28=) | `75% <ø> (ø)` | | | [pkg/chain/invocation.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr=tree#diff-cGtnL2NoYWluL2ludm9jYXRpb24uZ28=) | `89.47% <ø> (ø)` | | | [pkg/task/executor.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr=tree#diff-cGtnL3Rhc2svZXhlY3V0b3IuZ28=) | `76% <ø> (ø)` | | | [server/error/error.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr=tree#diff-c2VydmVyL2Vycm9yL2Vycm9yLmdv) | `100% <ø> (ø)` | | | [server/service/notification/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2NvbW1vbi5nbw==) | `100% <ø> (ø)` | :arrow_up: | | [server/govern/controller\_v4.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9jb250cm9sbGVyX3Y0Lmdv) | `73.49% <ø> (ø)` | | | [pkg/validate/url.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr=tree#diff-cGtnL3ZhbGlkYXRlL3VybC5nbw==) | `0% <0%> (ø)` | | | [server/core/backend/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9jb21tb24uZ28=) | `75% <0%> (ø)` | | | [pkg/task/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr=tree#diff-cGtnL3Rhc2svc2VydmljZS5nbw==) | `40% <0%> (ø)` | | | ... and [127 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr=footer). Last update [aa34cb9...9c673ac](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/396?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add admin dump api > -- > > Key: SCB-735 > URL: https://issues.apache.org/jira/browse/SCB-735 > Project: Apache ServiceComb > Issue Type: New Feature > Components:
[jira] [Commented] (SCB-735) Add admin dump api
[ https://issues.apache.org/jira/browse/SCB-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552815#comment-16552815 ] ASF GitHub Bot commented on SCB-735: coveralls edited a comment on issue #396: SCB-735 Add admin dump api URL: https://github.com/apache/incubator-servicecomb-service-center/pull/396#issuecomment-406771280 [](https://coveralls.io/builds/18115063) Coverage increased (+1.6%) to 76.063% when pulling **9c673ac19c3007bb6839379c60e7dbaa161166b1 on little-cui:admin** into **aa34cb9d7525a2743b521a8bfe436d0bb4688b12 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add admin dump api > -- > > Key: SCB-735 > URL: https://issues.apache.org/jira/browse/SCB-735 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-767) When using Response to return multi-code message, handlers / filters given ClassCaseException
[ https://issues.apache.org/jira/browse/SCB-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552773#comment-16552773 ] ASF GitHub Bot commented on SCB-767: liubao68 commented on issue #827: [SCB-767]When using Response to return multi-code message, handlers /filters given ClassCaseException URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/827#issuecomment-407044680 After modification to service implementation, this scenario is not a bug. But user may have the same problem when they use it this way, just commit the test codes as an example. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > When using Response to return multi-code message, handlers / filters given > ClassCaseException > - > > Key: SCB-767 > URL: https://issues.apache.org/jira/browse/SCB-767 > Project: Apache ServiceComb > Issue Type: Bug >Reporter: liubao >Assignee: liubao >Priority: Major > > Error code 400， 500 etc. takes as error. But the object result is not > throwable. So got class cast exception. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-736) generate default value to swagger for primitive type, even there is no defaultValue annotation
[
https://issues.apache.org/jira/browse/SCB-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552634#comment-16552634
]
Mahesh Raju Somalaraju commented on SCB-736:
This issue is in progress
> generate default value to swagger for primitive type, even there is no
> defaultValue annotation
> --
>
> Key: SCB-736
> URL: https://issues.apache.org/jira/browse/SCB-736
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: Mahesh Raju Somalaraju
>Priority: Major
>
> {code:java}
> @GetMapping(path = "test")
> public String test(int i, boolean b) {
> return "" + i + b;
> }
> {code}
> request without any query parameter should be ok
> must include all primitive types.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (SCB-736) generate default value to swagger for primitive type, even there is no defaultValue annotation
[
https://issues.apache.org/jira/browse/SCB-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahesh Raju Somalaraju reassigned SCB-736:
--
Assignee: Mahesh Raju Somalaraju (was: sukesh)
> generate default value to swagger for primitive type, even there is no
> defaultValue annotation
> --
>
> Key: SCB-736
> URL: https://issues.apache.org/jira/browse/SCB-736
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: Mahesh Raju Somalaraju
>Priority: Major
>
> {code:java}
> @GetMapping(path = "test")
> public String test(int i, boolean b) {
> return "" + i + b;
> }
> {code}
> request without any query parameter should be ok
> must include all primitive types.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-769) When delay fault injection is enabled, the business thread will be blocked
[
https://issues.apache.org/jira/browse/SCB-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552563#comment-16552563
]
ASF GitHub Bot commented on SCB-769:
yhs0092 opened a new pull request #833: [SCB-769] Fix delay fault injection
blocking thread
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/833
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually
before you start working on it). Trivial changes like typos do not require a
JIRA issue. Your pull request should address just this issue, without pulling
in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[SCB-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA
issue.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
See details in [SCB-769](https://issues.apache.org/jira/browse/SCB-769)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> When delay fault injection is enabled, the business thread will be blocked
> ---
>
> Key: SCB-769
> URL: https://issues.apache.org/jira/browse/SCB-769
> Project: Apache ServiceComb
> Issue Type: Bug
>Reporter: YaoHaishi
>Assignee: YaoHaishi
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
> When delay fault injection is enabled, the not delayed invocation will make
> business thread blocked in synchronized mode, or network thread blocked in
> reactive mode.
> The cause is that if the invocation should not be delayed, the process logic
> in DelayFault exits without calling asynResponse.success("success");
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-709) Implement JAX-RS body parameter required feature
[ https://issues.apache.org/jira/browse/SCB-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552510#comment-16552510 ] Mahesh Raju Somalaraju commented on SCB-709: 1. Implement JAX-RS body parameter required feature >> Regarding this implentation, Jaxrs not support for body as optional. "body parameter required false" option is not there. Closing this Jira as point 1 and point 2 has nothing to do it. > Implement JAX-RS body parameter required feature > > > Key: SCB-709 > URL: https://issues.apache.org/jira/browse/SCB-709 > Project: Apache ServiceComb > Issue Type: New Feature >Reporter: liubao >Assignee: Mahesh Raju Somalaraju >Priority: Major > > SCB-701 remaining problems: > 1. Implement JAX-RS body parameter required feature > 2. SCB-701 has changes, consumer code can send null or an object to provider, > null encode as empty body I think is better. And for provider, is required = > true, either null or emty body will throw exception is better, but now from > consumer code, we can not send null. and with postman, send null will not > throw exception when required = true > 3. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
