[jira] [Commented] (SCB-950) [SCB-950] modify consumer producer metrics and add edge metrics
[ https://issues.apache.org/jira/browse/SCB-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642752#comment-16642752 ] ASF GitHub Bot commented on SCB-950: coveralls edited a comment on issue #944: [SCB-950] modify consumer producer metrics and add edge metrics URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/944#issuecomment-427647235 [](https://coveralls.io/builds/19417071) Coverage decreased (-0.1%) to 86.08% when pulling **17e729ad3962a7dfe06dcb32954fd5e65945b10b on heyile:metrics_apm** into **6aadae0de82b3b3940f0c163b815d6675aedc2bc on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [SCB-950] modify consumer producer metrics and add edge metrics > > > Key: SCB-950 > URL: https://issues.apache.org/jira/browse/SCB-950 > Project: Apache ServiceComb > Issue Type: Improvement >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > the info in the old metics is not enough. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-950) [SCB-950] modify consumer producer metrics and add edge metrics
[ https://issues.apache.org/jira/browse/SCB-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642748#comment-16642748 ] ASF GitHub Bot commented on SCB-950: coveralls edited a comment on issue #944: [SCB-950] modify consumer producer metrics and add edge metrics URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/944#issuecomment-427647235 [](https://coveralls.io/builds/19417054) Coverage decreased (-0.1%) to 86.084% when pulling **17e729ad3962a7dfe06dcb32954fd5e65945b10b on heyile:metrics_apm** into **6aadae0de82b3b3940f0c163b815d6675aedc2bc on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [SCB-950] modify consumer producer metrics and add edge metrics > > > Key: SCB-950 > URL: https://issues.apache.org/jira/browse/SCB-950 > Project: Apache ServiceComb > Issue Type: Improvement >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > the info in the old metics is not enough. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-951) Wrong help information in scctl
[
https://issues.apache.org/jira/browse/SCB-951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642658#comment-16642658
]
ASF GitHub Bot commented on SCB-951:
little-cui closed pull request #454: SCB-951 Wrong help information in scctl
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/454
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/scctl/pkg/plugin/README.md b/scctl/pkg/plugin/README.md
index 979cdeaa..39096e86 100644
--- a/scctl/pkg/plugin/README.md
+++ b/scctl/pkg/plugin/README.md
@@ -20,9 +20,9 @@ Get the microservices list from ServiceCenter. `service`
command can be instead
Options
-- `domain`(d) domain name, return `default` domain microservices list by
default.
-- `output`(o) support mode `wide`, return the complete microservices
information(e.g., framework, endpoints).
-- `all-domains` return all domains microservices information.
+- `domain`(d) print the information under the specified domain in service
center, print under the `default` domain by default.
+- `output`(o) support mode `wide`, output the complete microservices
information(e.g., framework, endpoints).
+- `all-domains` print the information under all domains in service center.
Examples
diff --git a/scctl/pkg/plugin/get/cmd.go b/scctl/pkg/plugin/get/cmd.go
index 05fa3ad7..ba86983c 100644
--- a/scctl/pkg/plugin/get/cmd.go
+++ b/scctl/pkg/plugin/get/cmd.go
@@ -37,9 +37,9 @@ func NewGetCommand(parent *cobra.Command) *cobra.Command {
Short: "Output the resources information of service center",
}
parent.AddCommand(cmd)
- cmd.PersistentFlags().StringVarP(, "domain", "d", "default",
"the info of the service center")
- cmd.PersistentFlags().StringVarP(, "output", "o", "", "print the
info of the service center")
- cmd.PersistentFlags().BoolVar(, "all-domains", false, "print
the info of the service center")
+ cmd.PersistentFlags().StringVarP(, "domain", "d", "default",
"print the information under the specified domain in service center")
+ cmd.PersistentFlags().StringVarP(, "output", "o", "", "output
the complete microservice information(e.g., framework, endpoints)")
+ cmd.PersistentFlags().BoolVar(, "all-domains", false, "print
the information under all domains in service center")
return cmd
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Wrong help information in scctl
> ---
>
> Key: SCB-951
> URL: https://issues.apache.org/jira/browse/SCB-951
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Minor
> Fix For: service-center-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-737) avoid null point exception
[
https://issues.apache.org/jira/browse/SCB-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641851#comment-16641851
]
ASF GitHub Bot commented on SCB-737:
wujimin commented on a change in pull request #936: [SCB-737]Avoid null point
exception
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/936#discussion_r223366629
##
File path:
providers/provider-pojo/src/main/java/org/apache/servicecomb/provider/pojo/schema/PojoProducers.java
##
@@ -63,6 +63,9 @@ protected void processProvider(String beanName, Object bean)
{
// aop后，新的实例的父类可能是原class，也可能只是个proxy，父类不是原class
// 所以，需要先取出原class，再取标注
Class beanCls = BeanUtils.getImplClassFromBean(bean);
+if(beanCls == null) {
Review comment:
if got null, maybe will cause to lost schema definition
so need to print a warn log at least.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> avoid null point exception
> --
>
> Key: SCB-737
> URL: https://issues.apache.org/jira/browse/SCB-737
> Project: Apache ServiceComb
> Issue Type: Task
>Reporter: laijianbin
>Assignee: laijianbin
>Priority: Major
>
> 2018-07-11
> 03:27:52,651Z(28241):ERROR{}[main]org.springframework.boot.SpringApplication.reportFailure(SpringApplication.java:771)-->Application
> startup failed
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name 'batchConfig': Unsatisfied dependency expressed
> through field 'jobBuilderFactory'; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'jobBuilders' defined in class path resource
> [org/springframework/batch/core/configuration/annotation/SimpleBatchConfiguration.class]:
> Bean instantiation via factory method failed; nested exception is
> org.springframework.beans.BeanInstantiationException: Failed to instantiate
> [org.springframework.batch.core.configuration.annotation.JobBuilderFactory]:
> Factory method 'jobBuilders' threw exception; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'jobRepository' defined in class path resource
> [org/springframework/batch/core/configuration/annotation/SimpleBatchConfiguration.class]:
> Initialization of bean failed; nested exception is
> java.lang.NullPointerException
>
> RELEASE]
> at
> org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:230)
> ~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
> at
> org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:302)
> ~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
> at
> org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:202)
> ~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
> at
> org.springframework.beans.factory.config.DependencyDescriptor.resolveCandidate(DependencyDescriptor.java:207)
> ~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
> at
> org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:1136)
> ~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
> at
> org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:1064)
> ~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
> at
> org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:585)
> ~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
> ... 19 more
> Caused by: java.lang.NullPointerException
> at
> org.apache.servicecomb.provider.rest.common.RestProducers.processProvider(RestProducers.java:52)
> ~[provider-rest-common-1.0.0.B003.6.jar:1.0.0.B003.6]
> at
> org.apache.servicecomb.provider.rest.common.RestProducers.postProcessAfterInitialization(RestProducers.java:43)
> ~[provider-rest-common-1.0.0.B003.6.jar:1.0.0.B003.6]
> at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyBeanPostProcessorsAfterInitialization(AbstractAutowireCapableBeanFactory.java:423)
> ~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
> at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1594)
> ~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
>
[jira] [Commented] (SCB-950) [SCB-950] modify consumer producer metrics and add edge metrics
[ https://issues.apache.org/jira/browse/SCB-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641538#comment-16641538 ] ASF GitHub Bot commented on SCB-950: coveralls edited a comment on issue #944: [SCB-950] modify consumer producer metrics and add edge metrics URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/944#issuecomment-427647235 [](https://coveralls.io/builds/19399479) Coverage decreased (-0.1%) to 86.088% when pulling **512636f6e926218c0540d1b43746e17194aeb5da on heyile:metrics_apm** into **6aadae0de82b3b3940f0c163b815d6675aedc2bc on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [SCB-950] modify consumer producer metrics and add edge metrics > > > Key: SCB-950 > URL: https://issues.apache.org/jira/browse/SCB-950 > Project: Apache ServiceComb > Issue Type: Improvement >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > the info in the old metics is not enough. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-951) Wrong help information in scctl
[ https://issues.apache.org/jira/browse/SCB-951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641514#comment-16641514 ] ASF GitHub Bot commented on SCB-951: codecov-io commented on issue #454: SCB-951 Wrong help information in scctl URL: https://github.com/apache/incubator-servicecomb-service-center/pull/454#issuecomment-427756909 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/454?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@4e2344f`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/454?src=pr=tree) ```diff @@Coverage Diff@@ ## master #454 +/- ## = Coverage ? 60.17% = Files ? 156 Lines ?13404 Branches ?0 = Hits ? 8066 Misses? 4759 Partials ? 579 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/454?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/454?src=pr=footer). Last update [4e2344f...c2711d7](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/454?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Wrong help information in scctl > --- > > Key: SCB-951 > URL: https://issues.apache.org/jira/browse/SCB-951 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Minor > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-951) Wrong help information in scctl
[ https://issues.apache.org/jira/browse/SCB-951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] little-cui resolved SCB-951. Resolution: Fixed > Wrong help information in scctl > --- > > Key: SCB-951 > URL: https://issues.apache.org/jira/browse/SCB-951 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Minor > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-951) Wrong help information in scctl
[ https://issues.apache.org/jira/browse/SCB-951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641492#comment-16641492 ] ASF GitHub Bot commented on SCB-951: little-cui opened a new pull request #454: SCB-951 Wrong help information in scctl URL: https://github.com/apache/incubator-servicecomb-service-center/pull/454 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Wrong help information in scctl > --- > > Key: SCB-951 > URL: https://issues.apache.org/jira/browse/SCB-951 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Minor > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-951) Wrong help information in scctl
little-cui created SCB-951: -- Summary: Wrong help information in scctl Key: SCB-951 URL: https://issues.apache.org/jira/browse/SCB-951 Project: Apache ServiceComb Issue Type: Bug Components: Service-Center Reporter: little-cui Assignee: little-cui Fix For: service-center-1.1.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-737) avoid null point exception
[
https://issues.apache.org/jira/browse/SCB-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641388#comment-16641388
]
ASF GitHub Bot commented on SCB-737:
laijianbin commented on a change in pull request #936: [SCB-737]Avoid null
point exception
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/936#discussion_r223254374
##
File path:
providers/provider-pojo/src/main/java/org/apache/servicecomb/provider/pojo/schema/PojoProducers.java
##
@@ -63,6 +63,9 @@ protected void processProvider(String beanName, Object bean)
{
// aop后，新的实例的父类可能是原class，也可能只是个proxy，父类不是原class
// 所以，需要先取出原class，再取标注
Class beanCls = BeanUtils.getImplClassFromBean(bean);
+if(beanCls == null) {
Review comment:
org.springframework.aop.TargetClassAware.getTargetClass(),this method return
the target Class, or null if not known. more detail, reference
https://issues.apache.org/jira/browse/SCB-737?filter=-1
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> avoid null point exception
> --
>
> Key: SCB-737
> URL: https://issues.apache.org/jira/browse/SCB-737
> Project: Apache ServiceComb
> Issue Type: Task
>Reporter: laijianbin
>Assignee: laijianbin
>Priority: Major
>
> 2018-07-11
> 03:27:52,651Z(28241):ERROR{}[main]org.springframework.boot.SpringApplication.reportFailure(SpringApplication.java:771)-->Application
> startup failed
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name 'batchConfig': Unsatisfied dependency expressed
> through field 'jobBuilderFactory'; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'jobBuilders' defined in class path resource
> [org/springframework/batch/core/configuration/annotation/SimpleBatchConfiguration.class]:
> Bean instantiation via factory method failed; nested exception is
> org.springframework.beans.BeanInstantiationException: Failed to instantiate
> [org.springframework.batch.core.configuration.annotation.JobBuilderFactory]:
> Factory method 'jobBuilders' threw exception; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'jobRepository' defined in class path resource
> [org/springframework/batch/core/configuration/annotation/SimpleBatchConfiguration.class]:
> Initialization of bean failed; nested exception is
> java.lang.NullPointerException
>
> RELEASE]
> at
> org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:230)
> ~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
> at
> org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:302)
> ~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
> at
> org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:202)
> ~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
> at
> org.springframework.beans.factory.config.DependencyDescriptor.resolveCandidate(DependencyDescriptor.java:207)
> ~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
> at
> org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:1136)
> ~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
> at
> org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:1064)
> ~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
> at
> org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:585)
> ~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
> ... 19 more
> Caused by: java.lang.NullPointerException
> at
> org.apache.servicecomb.provider.rest.common.RestProducers.processProvider(RestProducers.java:52)
> ~[provider-rest-common-1.0.0.B003.6.jar:1.0.0.B003.6]
> at
> org.apache.servicecomb.provider.rest.common.RestProducers.postProcessAfterInitialization(RestProducers.java:43)
> ~[provider-rest-common-1.0.0.B003.6.jar:1.0.0.B003.6]
> at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyBeanPostProcessorsAfterInitialization(AbstractAutowireCapableBeanFactory.java:423)
> ~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
> at
>
