[jira] [Commented] (SCB-1025) Add microservice properties tab on service detail page
[ https://issues.apache.org/jira/browse/SCB-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687578#comment-16687578 ] ASF GitHub Bot commented on SCB-1025: - little-cui commented on issue #490: SCB-1025 Add Properties View in Service Info Page URL: https://github.com/apache/servicecomb-service-center/pull/490#issuecomment-438941225 how about change the tab name to 'Raw' and show the full microservice body This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add microservice properties tab on service detail page > -- > > Key: SCB-1025 > URL: https://issues.apache.org/jira/browse/SCB-1025 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1025) Add microservice properties tab on service detail page
[ https://issues.apache.org/jira/browse/SCB-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687570#comment-16687570 ] ASF GitHub Bot commented on SCB-1025: - codecov-io commented on issue #490: SCB-1025 Add Properties View in Service Info Page URL: https://github.com/apache/servicecomb-service-center/pull/490#issuecomment-438939440 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/490?src=pr=h1) Report > Merging [#490](https://codecov.io/gh/apache/servicecomb-service-center/pull/490?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/a4b1a5660689b5dab3c0ec387bd848c981860470?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/490?src=pr=tree) ```diff @@Coverage Diff @@ ## master #490 +/- ## == - Coverage 59.73% 59.72% -0.02% == Files 165 165 Lines 1379613796 == - Hits 8241 8239 -2 Misses 4973 4973 - Partials 582 584 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/490?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/plugin/pkg/registry/etcd/tracing.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/490/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC90cmFjaW5nLmdv) | `72.72% <0%> (-9.1%)` | :arrow_down: | | [pkg/util/tree.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/490/diff?src=pr=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `81.25% <0%> (-3.13%)` | :arrow_down: | | [server/service/tag.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/490/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `67.4% <0%> (-0.56%)` | :arrow_down: | | [server/govern/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/490/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `72.6% <0%> (-0.34%)` | :arrow_down: | | [server/broker/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/490/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `57.78% <0%> (-0.16%)` | :arrow_down: | | [server/plugin/pkg/registry/etcd/etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/490/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9ldGNkLmdv) | `86.36% <0%> (+0.18%)` | :arrow_up: | | [server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/490/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.47% <0%> (+0.26%)` | :arrow_up: | | [server/service/util/tag\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/490/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==) | `65.38% <0%> (+3.84%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/490?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/490?src=pr=footer). Last update [a4b1a56...5d822d0](https://codecov.io/gh/apache/servicecomb-service-center/pull/490?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add microservice properties tab on service detail page > -- > > Key: SCB-1025 > URL: https://issues.apache.org/jira/browse/SCB-1025 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1025) Add microservice properties tab on service detail page
[ https://issues.apache.org/jira/browse/SCB-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687571#comment-16687571 ] ASF GitHub Bot commented on SCB-1025: - coveralls commented on issue #490: SCB-1025 Add Properties View in Service Info Page URL: https://github.com/apache/servicecomb-service-center/pull/490#issuecomment-438939516 [](https://coveralls.io/builds/20116840) Coverage increased (+0.04%) to 62.181% when pulling **5d822d09d5adfd2ae6a3b48ce6fb0956490a33a7 on asifdxtreme:master** into **a4b1a5660689b5dab3c0ec387bd848c981860470 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add microservice properties tab on service detail page > -- > > Key: SCB-1025 > URL: https://issues.apache.org/jira/browse/SCB-1025 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1025) Add microservice properties tab on service detail page
[ https://issues.apache.org/jira/browse/SCB-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687551#comment-16687551 ] ASF GitHub Bot commented on SCB-1025: - asifdxtreme opened a new pull request #490: SCB-1025 Add Properties View in Service Info Page URL: https://github.com/apache/servicecomb-service-center/pull/490 Preview :  No Properties View :  https://github.com/apache/servicecomb-service-center/issues/489 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add microservice properties tab on service detail page > -- > > Key: SCB-1025 > URL: https://issues.apache.org/jira/browse/SCB-1025 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-806) Polish alpha-server logger
[ https://issues.apache.org/jira/browse/SCB-806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-806: - Fix Version/s: saga-0.2.1 > Polish alpha-server logger > --- > > Key: SCB-806 > URL: https://issues.apache.org/jira/browse/SCB-806 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Jeremy Xu >Assignee: Jeremy Xu >Priority: Minor > Fix For: saga-0.3.0, saga-0.2.1 > > > There are some log output setting is not right in Alpha-server, such as the > JPA related log is still sent to stand output. > alpha-server虽有log4j2.xml，但日志输出并没有按此配置文件输出，另外jpa相关的日志还是直接打到标准输出的。 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (SCB-805) If the node time of alpha and omega are not same, the transaction could be aborted
[
https://issues.apache.org/jira/browse/SCB-805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Willem Jiang reopened SCB-805:
--
Assignee: Willem Jiang (was: Jeremy Xu)
> If the node time of alpha and omega are not same, the transaction could be
> aborted
> --
>
> Key: SCB-805
> URL: https://issues.apache.org/jira/browse/SCB-805
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
>Affects Versions: saga-0.2.0
>Reporter: Jeremy Xu
>Assignee: Willem Jiang
>Priority: Minor
> Fix For: saga-0.3.0, saga-0.2.1
>
>
> If the node time of alpha and omega are not same, the transaction could be
> aborted.
> As the alpha just create the TxEvent which is based on the omega's message
> timestamp, it could trigger the EventScanner timeout check to abort the
> transaction. We should use the Alpha timestamp to create the date.
> RT,
> 当alpha与omega所在节点的时间不同步时，分布式事务会被异常aborted。检查代码发现alpha侧创建TxEvent时用到了omega侧传过来的时间戳。
> {code:java}
> @Override
> public void onTxEvent(GrpcTxEvent message, StreamObserver
> responseObserver) {
> boolean ok = txConsistentService.handle(new TxEvent(
> message.getServiceName(),
> message.getInstanceId(),
> new Date(message.getTimestamp()), // 这里用到了omega侧传过来的时间戳
> message.getGlobalTxId(),
> message.getLocalTxId(),
> message.getParentTxId().isEmpty() ? null : message.getParentTxId(),
> message.getType(),
> message.getCompensationMethod(),
> message.getTimeout(),
> message.getRetryMethod(),
> message.getRetries(),
> message.getPayloads().toByteArray()
> ));{code}
>
> 这里感觉可以直接用收到TxEvent的时间，即*new Date()*即可。
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Reopened] (SCB-821) Add missing dependencyManagement for omega-transport-feign
[ https://issues.apache.org/jira/browse/SCB-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang reopened SCB-821: -- Assignee: Willem Jiang (was: Yang Bo) > Add missing dependencyManagement for omega-transport-feign > -- > > Key: SCB-821 > URL: https://issues.apache.org/jira/browse/SCB-821 > Project: Apache ServiceComb > Issue Type: Bug > Components: Saga >Affects Versions: saga-0.3.0 >Reporter: Yang Bo >Assignee: Willem Jiang >Priority: Major > Fix For: saga-0.3.0 > > > Project failed to build with -Prelease due to missing version information of > omega-transport-feign. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (SCB-831) Saga UT failed at LoadBalancedClusterMessageSenderTest on Windows environment
[
https://issues.apache.org/jira/browse/SCB-831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Willem Jiang reopened SCB-831:
--
Assignee: Willem Jiang (was: yangyongzheng)
> Saga UT failed at LoadBalancedClusterMessageSenderTest on Windows environment
> -
>
> Key: SCB-831
> URL: https://issues.apache.org/jira/browse/SCB-831
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Saga
>Affects Versions: saga-0.2.0
> Environment: Windows 7 or Windows Server 2008 R2
>Reporter: yangyongzheng
>Assignee: Willem Jiang
>Priority: Major
> Fix For: saga-0.3.0
>
>
> UT will failed at :
> LoadBalancedClusterMessageSenderTest.stopSendingWhenClusterIsDown
> It seems this assert
> await().atMost(2, SECONDS).until(new Callable() {
> @Override
> public Boolean call() throws Exception {
> return connected.get(8080).size() == 2 || connected.get(8090).size()
> == 2;
> }
> });
> The connected size will only be 1 not 2
> I had found out that GrpcCompensateStreamObserver don't trigger onError when
> simulate connection closed in this case so LoadBalancedClusterMessageSender
> can't take PushBackReconnectRunnable from pendingTasks in order to reconnect
> server, then the connected count will be only 1, then test case failed
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Reopened] (SCB-785) Cannot get the GlobalTxId and LocalTxId in the compensation method
[
https://issues.apache.org/jira/browse/SCB-785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Willem Jiang reopened SCB-785:
--
Assignee: Willem Jiang (was: Jeremy Xu)
> Cannot get the GlobalTxId and LocalTxId in the compensation method
> --
>
> Key: SCB-785
> URL: https://issues.apache.org/jira/browse/SCB-785
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
>Affects Versions: saga-0.2.0
>Reporter: Jeremy Xu
>Assignee: Willem Jiang
>Priority: Minor
> Fix For: saga-0.3.0, saga-0.2.1
>
>
> 补偿方法里无法获取分布式事务的全局事务ID及本地事务ID
> 因为在子事务业务处理方法中会将一部分中间数据存入外部缓存中，对应的补偿方法将可以通过这些中间数据进行合理的补偿操作，当时存入中间数据时会附带上globalTxId,
> localTxId，后面将根据这个查找到之前存入的中间数据。但发现在业务方法中可以获取分布式事务的全局事务ID及本地事务ID，但对应的补偿方法里却不行。
> Customer may want to access the globalTxId and LocalTxId in application to
> store these information into DB for the recovery.
> 示例代码如下：
>
> {code:java}
> @Autowired
> OmegaContext omegaContext;
> @Compensable(timeout=5, compensationMethod="cancel")
> public boolean transferOut(String from, int amount) {
> // 这里可以获得
> System.out.println(omegaContext.globalTxId());
> System.out.println(omegaContext.localTxId());
> repo.reduceBalanceByUsername(from, amount);
> }
> public boolean cancel(String from, int amount) {
> // 这里不可以获得
> System.out.println(omegaContext.globalTxId());
> System.out.println(omegaContext.localTxId());
> repo.addBalanceByUsername(from, amount);
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SCB-785) Cannot get the GlobalTxId and LocalTxId in the compensation method
[
https://issues.apache.org/jira/browse/SCB-785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Willem Jiang updated SCB-785:
-
Fix Version/s: saga-0.2.1
> Cannot get the GlobalTxId and LocalTxId in the compensation method
> --
>
> Key: SCB-785
> URL: https://issues.apache.org/jira/browse/SCB-785
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
>Affects Versions: saga-0.2.0
>Reporter: Jeremy Xu
>Assignee: Jeremy Xu
>Priority: Minor
> Fix For: saga-0.3.0, saga-0.2.1
>
>
> 补偿方法里无法获取分布式事务的全局事务ID及本地事务ID
> 因为在子事务业务处理方法中会将一部分中间数据存入外部缓存中，对应的补偿方法将可以通过这些中间数据进行合理的补偿操作，当时存入中间数据时会附带上globalTxId,
> localTxId，后面将根据这个查找到之前存入的中间数据。但发现在业务方法中可以获取分布式事务的全局事务ID及本地事务ID，但对应的补偿方法里却不行。
> Customer may want to access the globalTxId and LocalTxId in application to
> store these information into DB for the recovery.
> 示例代码如下：
>
> {code:java}
> @Autowired
> OmegaContext omegaContext;
> @Compensable(timeout=5, compensationMethod="cancel")
> public boolean transferOut(String from, int amount) {
> // 这里可以获得
> System.out.println(omegaContext.globalTxId());
> System.out.println(omegaContext.localTxId());
> repo.reduceBalanceByUsername(from, amount);
> }
> public boolean cancel(String from, int amount) {
> // 这里不可以获得
> System.out.println(omegaContext.globalTxId());
> System.out.println(omegaContext.localTxId());
> repo.addBalanceByUsername(from, amount);
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SCB-805) If the node time of alpha and omega are not same, the transaction could be aborted
[
https://issues.apache.org/jira/browse/SCB-805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Willem Jiang updated SCB-805:
-
Fix Version/s: saga-0.2.1
> If the node time of alpha and omega are not same, the transaction could be
> aborted
> --
>
> Key: SCB-805
> URL: https://issues.apache.org/jira/browse/SCB-805
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
>Affects Versions: saga-0.2.0
>Reporter: Jeremy Xu
>Assignee: Jeremy Xu
>Priority: Minor
> Fix For: saga-0.3.0, saga-0.2.1
>
>
> If the node time of alpha and omega are not same, the transaction could be
> aborted.
> As the alpha just create the TxEvent which is based on the omega's message
> timestamp, it could trigger the EventScanner timeout check to abort the
> transaction. We should use the Alpha timestamp to create the date.
> RT,
> 当alpha与omega所在节点的时间不同步时，分布式事务会被异常aborted。检查代码发现alpha侧创建TxEvent时用到了omega侧传过来的时间戳。
> {code:java}
> @Override
> public void onTxEvent(GrpcTxEvent message, StreamObserver
> responseObserver) {
> boolean ok = txConsistentService.handle(new TxEvent(
> message.getServiceName(),
> message.getInstanceId(),
> new Date(message.getTimestamp()), // 这里用到了omega侧传过来的时间戳
> message.getGlobalTxId(),
> message.getLocalTxId(),
> message.getParentTxId().isEmpty() ? null : message.getParentTxId(),
> message.getType(),
> message.getCompensationMethod(),
> message.getTimeout(),
> message.getRetryMethod(),
> message.getRetries(),
> message.getPayloads().toByteArray()
> ));{code}
>
> 这里感觉可以直接用收到TxEvent的时间，即*new Date()*即可。
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Reopened] (SCB-806) Polish alpha-server logger
[ https://issues.apache.org/jira/browse/SCB-806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang reopened SCB-806: -- Assignee: Willem Jiang (was: Jeremy Xu) > Polish alpha-server logger > --- > > Key: SCB-806 > URL: https://issues.apache.org/jira/browse/SCB-806 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Jeremy Xu >Assignee: Willem Jiang >Priority: Minor > Fix For: saga-0.3.0, saga-0.2.1 > > > There are some log output setting is not right in Alpha-server, such as the > JPA related log is still sent to stand output. > alpha-server虽有log4j2.xml，但日志输出并没有按此配置文件输出，另外jpa相关的日志还是直接打到标准输出的。 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-784) SagaStart annotated method should abort the saga transaction once the exception is thrown
[
https://issues.apache.org/jira/browse/SCB-784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Willem Jiang updated SCB-784:
-
Fix Version/s: saga-0.2.1
> SagaStart annotated method should abort the saga transaction once the
> exception is thrown
> -
>
> Key: SCB-784
> URL: https://issues.apache.org/jira/browse/SCB-784
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Saga
>Reporter: Willem Jiang
>Assignee: Willem Jiang
>Priority: Major
> Fix For: saga-0.3.0, saga-0.2.1
>
>
> The below transaction should be aborted, now the Omega should send the abort
> message back to the alpha.
> {code}
> @SagaStart
> service() {
> transaction1;
> exception;
> transaction2;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SCB-741) Caused by: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long for column 'payloads' at row 1
[
https://issues.apache.org/jira/browse/SCB-741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Willem Jiang updated SCB-741:
-
Fix Version/s: saga-0.2.1
> Caused by: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long
> for column 'payloads' at row 1
>
>
> Key: SCB-741
> URL: https://issues.apache.org/jira/browse/SCB-741
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Saga
> Environment: Mac,Intellij Idea
>Reporter: justdebugit
>Assignee: Gao Xin
>Priority: Major
> Fix For: saga-0.3.0, saga-0.2.1
>
>
> I encounter an Exception at Alpha Server
> {code:java}
> Caused by: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long
> for column 'payloads' at row 1
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3974)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3912)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2530)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2683)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2486)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at
> com.mysql.jdbc.PreparedStatement.executeInternal(PreparedStatement.java:1858)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at
> com.mysql.jdbc.PreparedStatement.executeUpdateInternal(PreparedStatement.java:2079)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at
> com.mysql.jdbc.PreparedStatement.executeUpdateInternal(PreparedStatement.java:2013)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at
> com.mysql.jdbc.PreparedStatement.executeLargeUpdate(PreparedStatement.java:5104)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at
> com.mysql.jdbc.PreparedStatement.executeUpdate(PreparedStatement.java:1998)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at sun.reflect.GeneratedMethodAccessor68.invoke(Unknown Source) ~[na:na]
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> ~[na:1.8.0_102]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_102]
> at
> org.apache.tomcat.jdbc.pool.StatementFacade$StatementProxy.invoke(StatementFacade.java:114)
> ~[tomcat-jdbc-8.5.31.jar:na]
> at com.sun.proxy.$Proxy106.executeUpdate(Unknown Source) ~[na:na]
> at
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeDirectNoSelect(DatabaseAccessor.java:895)
> ~[org.eclipse.persistence.core-2.7.1.jar:na]
> ... 60 common frames omitted
> {code}
> I find it's because payload bytes is more than 10240
> {code:java}
> public class TxAbortedEvent extends TxEvent {
> public TxAbortedEvent(String globalTxId, String localTxId, String
> parentTxId, String compensationMethod, Throwable throwable) {
> super(EventType.TxAbortedEvent, globalTxId, localTxId, parentTxId,
> compensationMethod, 0, "", 0,
> stackTrace(throwable));
> }
> private static String stackTrace(Throwable e) {
> StringWriter writer = new StringWriter();
> e.printStackTrace(new PrintWriter(writer));
> return writer.toString();
> }
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Reopened] (SCB-741) Caused by: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long for column 'payloads' at row 1
[
https://issues.apache.org/jira/browse/SCB-741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Willem Jiang reopened SCB-741:
--
Assignee: Willem Jiang (was: Gao Xin)
> Caused by: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long
> for column 'payloads' at row 1
>
>
> Key: SCB-741
> URL: https://issues.apache.org/jira/browse/SCB-741
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Saga
> Environment: Mac,Intellij Idea
>Reporter: justdebugit
>Assignee: Willem Jiang
>Priority: Major
> Fix For: saga-0.3.0, saga-0.2.1
>
>
> I encounter an Exception at Alpha Server
> {code:java}
> Caused by: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long
> for column 'payloads' at row 1
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3974)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3912)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2530)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2683)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2486)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at
> com.mysql.jdbc.PreparedStatement.executeInternal(PreparedStatement.java:1858)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at
> com.mysql.jdbc.PreparedStatement.executeUpdateInternal(PreparedStatement.java:2079)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at
> com.mysql.jdbc.PreparedStatement.executeUpdateInternal(PreparedStatement.java:2013)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at
> com.mysql.jdbc.PreparedStatement.executeLargeUpdate(PreparedStatement.java:5104)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at
> com.mysql.jdbc.PreparedStatement.executeUpdate(PreparedStatement.java:1998)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at sun.reflect.GeneratedMethodAccessor68.invoke(Unknown Source) ~[na:na]
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> ~[na:1.8.0_102]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_102]
> at
> org.apache.tomcat.jdbc.pool.StatementFacade$StatementProxy.invoke(StatementFacade.java:114)
> ~[tomcat-jdbc-8.5.31.jar:na]
> at com.sun.proxy.$Proxy106.executeUpdate(Unknown Source) ~[na:na]
> at
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeDirectNoSelect(DatabaseAccessor.java:895)
> ~[org.eclipse.persistence.core-2.7.1.jar:na]
> ... 60 common frames omitted
> {code}
> I find it's because payload bytes is more than 10240
> {code:java}
> public class TxAbortedEvent extends TxEvent {
> public TxAbortedEvent(String globalTxId, String localTxId, String
> parentTxId, String compensationMethod, Throwable throwable) {
> super(EventType.TxAbortedEvent, globalTxId, localTxId, parentTxId,
> compensationMethod, 0, "", 0,
> stackTrace(throwable));
> }
> private static String stackTrace(Throwable e) {
> StringWriter writer = new StringWriter();
> e.printStackTrace(new PrintWriter(writer));
> return writer.toString();
> }
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Reopened] (SCB-784) SagaStart annotated method should abort the saga transaction once the exception is thrown
[
https://issues.apache.org/jira/browse/SCB-784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Willem Jiang reopened SCB-784:
--
> SagaStart annotated method should abort the saga transaction once the
> exception is thrown
> -
>
> Key: SCB-784
> URL: https://issues.apache.org/jira/browse/SCB-784
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Saga
>Reporter: Willem Jiang
>Assignee: Willem Jiang
>Priority: Major
> Fix For: saga-0.3.0, saga-0.2.1
>
>
> The below transaction should be aborted, now the Omega should send the abort
> message back to the alpha.
> {code}
> @SagaStart
> service() {
> transaction1;
> exception;
> transaction2;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-731) Add the omega-transport-feign into distribution kit
[ https://issues.apache.org/jira/browse/SCB-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687543#comment-16687543 ] Willem Jiang commented on SCB-731: -- It's same with the SCB-732. > Add the omega-transport-feign into distribution kit > --- > > Key: SCB-731 > URL: https://issues.apache.org/jira/browse/SCB-731 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Saga >Reporter: Willem Jiang >Priority: Major > Fix For: saga-0.3.0 > > > We need to update the saga-distribution pom.xml file. > > https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/pom.xml > > We need add the third party dependency of > io.github.openfeign:feign-core:jar:9.5.1 into the release license file as > well. > > https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/src/release/LICENSE -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-731) Add the omega-transport-feign into distribution kit
[ https://issues.apache.org/jira/browse/SCB-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang resolved SCB-731. -- Resolution: Duplicate > Add the omega-transport-feign into distribution kit > --- > > Key: SCB-731 > URL: https://issues.apache.org/jira/browse/SCB-731 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Saga >Reporter: Willem Jiang >Priority: Major > Fix For: saga-0.3.0 > > > We need to update the saga-distribution pom.xml file. > > https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/pom.xml > > We need add the third party dependency of > io.github.openfeign:feign-core:jar:9.5.1 into the release license file as > well. > > https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/src/release/LICENSE -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-732) Add the omega-transport-feign into distribution kit
[ https://issues.apache.org/jira/browse/SCB-732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-732: - Fix Version/s: saga-0.2.1 > Add the omega-transport-feign into distribution kit > --- > > Key: SCB-732 > URL: https://issues.apache.org/jira/browse/SCB-732 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Saga >Reporter: Willem Jiang >Assignee: Yang Bo >Priority: Major > Fix For: saga-0.3.0, saga-0.2.1 > > > We need to update the saga-distribution pom.xml file. > > https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/pom.xml > > We need add the third party dependency of > io.github.openfeign:feign-core:jar:9.5.1 into the release license file as > well. > > https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/src/release/LICENSE -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (SCB-731) Add the omega-transport-feign into distribution kit
[ https://issues.apache.org/jira/browse/SCB-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang reopened SCB-731: -- > Add the omega-transport-feign into distribution kit > --- > > Key: SCB-731 > URL: https://issues.apache.org/jira/browse/SCB-731 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Saga >Reporter: Willem Jiang >Priority: Major > Fix For: saga-0.3.0 > > > We need to update the saga-distribution pom.xml file. > > https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/pom.xml > > We need add the third party dependency of > io.github.openfeign:feign-core:jar:9.5.1 into the release license file as > well. > > https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/src/release/LICENSE -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-1026) Saga compensation should support to define the retry times
Willem Jiang created SCB-1026: - Summary: Saga compensation should support to define the retry times Key: SCB-1026 URL: https://issues.apache.org/jira/browse/SCB-1026 Project: Apache ServiceComb Issue Type: Task Components: Saga Reporter: Willem Jiang We should let use chose the retry times of Saga compensation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-1019) consumer support application/xml MIME type
[ https://issues.apache.org/jira/browse/SCB-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-1019: -- Summary: consumer support application/xml MIME type (was: (https://issues.apache.org/jira/browse/SCB) > consumer support application/xml MIME type > -- > > Key: SCB-1019 > URL: https://issues.apache.org/jira/browse/SCB-1019 > Project: Apache ServiceComb > Issue Type: Task >Reporter: laijianbin >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-1025) Add microservice properties tab on service detail page
Mohammad Asif Siddiqui created SCB-1025: --- Summary: Add microservice properties tab on service detail page Key: SCB-1025 URL: https://issues.apache.org/jira/browse/SCB-1025 Project: Apache ServiceComb Issue Type: Improvement Components: Service-Center Reporter: Mohammad Asif Siddiqui Assignee: Mohammad Asif Siddiqui -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[
https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686646#comment-16686646
]
ASF GitHub Bot commented on SCB-993:
little-cui closed pull request #487: SCB-993 Fixed the error of microservice
registration in multi-dc
URL: https://github.com/apache/servicecomb-service-center/pull/487
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/server/admin/admin_suite_test.go b/server/admin/admin_suite_test.go
index 8053859a..9c11b874 100644
--- a/server/admin/admin_suite_test.go
+++ b/server/admin/admin_suite_test.go
@@ -20,6 +20,7 @@ import _
"github.com/apache/servicecomb-service-center/server/init"
import _ "github.com/apache/servicecomb-service-center/server/bootstrap"
import (
"github.com/apache/servicecomb-service-center/pkg/util"
+ serviceUtil
"github.com/apache/servicecomb-service-center/server/service/util"
"github.com/astaxie/beego"
. "github.com/onsi/ginkgo"
"github.com/onsi/ginkgo/reporters"
@@ -45,5 +46,5 @@ var _ = BeforeSuite(func() {
func getContext() context.Context {
return util.SetContext(
util.SetDomainProject(context.Background(), "default",
"default"),
- "noCache", "1")
+ serviceUtil.CTX_NOCACHE, "1")
}
diff --git a/server/core/microservice.go b/server/core/microservice.go
index 25765a1a..9331e2c1 100644
--- a/server/core/microservice.go
+++ b/server/core/microservice.go
@@ -45,7 +45,8 @@ const (
REGISTRY_DEFAULT_LEASE_RENEWALINTERVAL int32 = 30
REGISTRY_DEFAULT_LEASE_RETRYTIMES int32 = 3
- IS_SC_SELF = "sc_self"
+ CTX_SC_SELF = "_sc_self"
+ CTX_SC_REGISTRY = "_registryOnly"
)
func init() {
@@ -85,9 +86,10 @@ func prepareSelfRegistration() {
}
func AddDefaultContextValue(ctx context.Context) context.Context {
- return util.SetContext(
- util.SetDomainProject(ctx, REGISTRY_DOMAIN, REGISTRY_PROJECT),
- IS_SC_SELF, true)
+ return util.SetContext(util.SetContext(util.SetDomainProject(ctx,
+ REGISTRY_DOMAIN, REGISTRY_PROJECT),
+ CTX_SC_SELF, true),
+ CTX_SC_REGISTRY, "1")
}
func IsDefaultDomainProject(domainProject string) bool {
@@ -116,7 +118,7 @@ func IsShared(key *pb.MicroServiceKey) bool {
}
func IsSCInstance(ctx context.Context) bool {
- b, _ := ctx.Value(IS_SC_SELF).(bool)
+ b, _ := ctx.Value(CTX_SC_SELF).(bool)
return b
}
diff --git a/server/govern/govern_suite_test.go
b/server/govern/govern_suite_test.go
index 2b20ef0d..0954f22f 100644
--- a/server/govern/govern_suite_test.go
+++ b/server/govern/govern_suite_test.go
@@ -25,6 +25,7 @@ import (
pb "github.com/apache/servicecomb-service-center/server/core/proto"
"github.com/apache/servicecomb-service-center/server/govern"
"github.com/apache/servicecomb-service-center/server/service"
+ serviceUtil
"github.com/apache/servicecomb-service-center/server/service/util"
"github.com/astaxie/beego"
. "github.com/onsi/ginkgo"
"github.com/onsi/ginkgo/reporters"
@@ -54,5 +55,5 @@ var _ = BeforeSuite(func() {
func getContext() context.Context {
return util.SetContext(
util.SetDomainProject(context.Background(), "default",
"default"),
- "noCache", "1")
+ serviceUtil.CTX_NOCACHE, "1")
}
diff --git a/server/handler/cache/cache.go b/server/handler/cache/cache.go
index 7bda9d4f..4bb6fd5d 100644
--- a/server/handler/cache/cache.go
+++ b/server/handler/cache/cache.go
@@ -32,6 +32,10 @@ func (l *CacheResponse) Handle(i *chain.Invocation) {
r := i.Context().Value(rest.CTX_REQUEST).(*http.Request)
query := r.URL.Query()
+ if r.Method != http.MethodGet {
+ i.WithContext(serviceUtil.CTX_REGISTRYONLY, "1")
+ }
+
noCache := query.Get(serviceUtil.CTX_NOCACHE) == "1"
if noCache {
i.WithContext(serviceUtil.CTX_NOCACHE, "1")
diff --git a/server/plugin/pkg/discovery/aggregate/adaptor.go
b/server/plugin/pkg/discovery/aggregate/adaptor.go
index 6efb2c5c..e56e7c38 100644
--- a/server/plugin/pkg/discovery/aggregate/adaptor.go
+++ b/server/plugin/pkg/discovery/aggregate/adaptor.go
@@ -26,6 +26,7 @@ import (
// Aggregator is a discovery service adaptor implement of one registry cluster
type Aggregator struct {
discovery.Indexer
+ Type discovery.Type
Adaptors []discovery.Adaptor
}
@@ -81,21 +82,16 @@ func getLogConflictFunc(t discovery.Type) func(origin,
conflict *discovery.KeyVa
}
func NewAggregator(t discovery.Type, cfg *discovery.Config) *Aggregator {
[jira] [Commented] (SCB-995) Implement Saga Console API's in Alpha Server
[ https://issues.apache.org/jira/browse/SCB-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686471#comment-16686471 ] ASF GitHub Bot commented on SCB-995: coveralls commented on issue #336: SCB-995 Add Unit Test for Alpha Console API's URL: https://github.com/apache/servicecomb-saga/pull/336#issuecomment-438653098 [](https://coveralls.io/builds/20097868) Coverage increased (+2.2%) to 92.007% when pulling **15038a88cdb1ad955b7c50f87089227fc708a570 on asifdxtreme:master** into **10cdd07742497d349c087c8f641e466455b137bb on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Implement Saga Console API's in Alpha Server > > > Key: SCB-995 > URL: https://issues.apache.org/jira/browse/SCB-995 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Saga >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > > Implement new Saga Console API's as per this document > https://cwiki.apache.org/confluence/display/SERVICECOMB/Saga+Management+Console+API%27s -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-995) Implement Saga Console API's in Alpha Server
[ https://issues.apache.org/jira/browse/SCB-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686435#comment-16686435 ] ASF GitHub Bot commented on SCB-995: asifdxtreme opened a new pull request #336: SCB-995 Add Unit Test for Alpha Console API's URL: https://github.com/apache/servicecomb-saga/pull/336 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Implement Saga Console API's in Alpha Server > > > Key: SCB-995 > URL: https://issues.apache.org/jira/browse/SCB-995 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Saga >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > > Implement new Saga Console API's as per this document > https://cwiki.apache.org/confluence/display/SERVICECOMB/Saga+Management+Console+API%27s -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686254#comment-16686254 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #487: SCB-993 Fixed the error of microservice registration in multi-dc URL: https://github.com/apache/servicecomb-service-center/pull/487#issuecomment-438181672 [](https://coveralls.io/builds/20095238) Coverage decreased (-0.7%) to 62.127% when pulling **7bf51f96f28e4f2e5f8eba61faf942423149cea5 on little-cui:master** into **09040b90d0dc3c87f976caec1e0b6d2c5b1d86db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686250#comment-16686250 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #487: SCB-993 Fixed the error of microservice registration in multi-dc URL: https://github.com/apache/servicecomb-service-center/pull/487#issuecomment-438181426 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/487?src=pr=h1) Report > Merging [#487](https://codecov.io/gh/apache/servicecomb-service-center/pull/487?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/09040b90d0dc3c87f976caec1e0b6d2c5b1d86db?src=pr=desc) will **decrease** coverage by `0.64%`. > The diff coverage is `25%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/487?src=pr=tree) ```diff @@Coverage Diff @@ ## master #487 +/- ## == - Coverage 60.32% 59.68% -0.65% == Files 159 165 +6 Lines 1353413796 +262 == + Hits 8165 8234 +69 - Misses 4787 4980 +193 Partials 582 582 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/487?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC91dGlsLmdv) | `80% <0%> (-20%)` | :arrow_down: | | [...er/plugin/pkg/discovery/servicecenter/aggregate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWdncmVnYXRlLmdv) | `14.28% <0%> (ø)` | | | [...rver/plugin/pkg/discovery/servicecenter/indexer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvaW5kZXhlci5nbw==) | `35% <100%> (ø)` | | | [server/core/microservice.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvbWljcm9zZXJ2aWNlLmdv) | `70.27% <20%> (-0.97%)` | :arrow_down: | | [server/service/notification/listwatcher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2xpc3R3YXRjaGVyLmdv) | `69.01% <0%> (-9.86%)` | :arrow_down: | | [server/plugin/pkg/discovery/servicecenter/repo.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvcmVwby5nbw==) | `33.33% <0%> (ø)` | | | [...erver/plugin/pkg/discovery/servicecenter/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvY2FjaGVyLmdv) | `33.33% <0%> (ø)` | | | [...rver/plugin/pkg/discovery/servicecenter/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWRhcHRvci5nbw==) | `0% <0%> (ø)` | | | [...erver/plugin/pkg/discovery/servicecenter/common.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvY29tbW9uLmdv) | `100% <0%> (ø)` | | | ... and [5 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/487?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/487?src=pr=footer). Last update [09040b9...7bf51f9](https://codecov.io/gh/apache/servicecomb-service-center/pull/487?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL:
[jira] [Resolved] (SCB-1015) Support the forth microservice version number registration
[ https://issues.apache.org/jira/browse/SCB-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] little-cui resolved SCB-1015. - Resolution: Fixed > Support the forth microservice version number registration > -- > > Key: SCB-1015 > URL: https://issues.apache.org/jira/browse/SCB-1015 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-1024) map interface to some java class
何一乐 created SCB-1024: Summary: map interface to some java class Key: SCB-1024 URL: https://issues.apache.org/jira/browse/SCB-1024 Project: Apache ServiceComb Issue Type: Improvement Components: Java-Chassis Reporter: 何一乐 1.org.apache.servicecomb.swagger.extend.ModelResolverlverExt中增加一个map保存interface与实现类之间的映射关系：Map 2.提供手段，让开发人员注册映射关系 3.在两个resolve调用之前，将interface换成实现类:type = = typeMaps.getOrDefault(ult(type, type); ); org.apache.servicecomb.swagger.extend.ModelResolverlverExt#resolve ve org.apache.servicecomb.swagger.extend.ModelResolverlverExt#resolveProperty 目标是自动将operation输入/输出相关的接口自动转换为实现类 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
