[jira] [Commented] (SCB-233) Don't deploy if building with the PR
[ https://issues.apache.org/jira/browse/SCB-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325979#comment-16325979 ] ASF GitHub Bot commented on SCB-233: zhfeng commented on a change in pull request #119: SCB-233 update to deploy only with non PR building URL: https://github.com/apache/incubator-servicecomb-saga/pull/119#discussion_r161449469 ## File path: .travis.yml ## @@ -27,7 +27,7 @@ script: - mvn clean install -Pjacoco -Pdocker coveralls:report - mvn clean verify -f saga-demo -Pdemo -Pdocker -Ddocker.useColor=false -Ddocker.showLogs after_success: -- mvn deploy -DskipTests --settings .travis.settings.xml +- if [ "$TRAVIS_PULL_REQUEST" = "false" ]; then mvn deploy -DskipTests --settings .travis.settings.xml; fi Review comment: see http://docs.travis-ci.com/user/ci-environment/ TRAVIS_BRANCH * for push builds, or builds not triggered by a pull request, this is the name of the branch. * for builds triggered by a pull request this is the name of the branch targeted by the pull request. * for builds triggered by a tag, this is the same as the name of the tag (TRAVIS_TAG). So it looks like in many case of the pull request, the branch target is "master". This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Don't deploy if building with the PR > > > Key: SCB-233 > URL: https://issues.apache.org/jira/browse/SCB-233 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Zheng Feng >Assignee: Zheng Feng >Priority: Major > Fix For: saga-0.3.0 > > > currently the travis CI runs the deploy command when building with the PR. we > should improve this step. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-233) Don't deploy if building with the PR
[ https://issues.apache.org/jira/browse/SCB-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325916#comment-16325916 ] ASF GitHub Bot commented on SCB-233: seanyinx commented on a change in pull request #119: SCB-233 update to deploy only with non PR building URL: https://github.com/apache/incubator-servicecomb-saga/pull/119#discussion_r161437204 ## File path: .travis.yml ## @@ -27,7 +27,7 @@ script: - mvn clean install -Pjacoco -Pdocker coveralls:report - mvn clean verify -f saga-demo -Pdemo -Pdocker -Ddocker.useColor=false -Ddocker.showLogs after_success: -- mvn deploy -DskipTests --settings .travis.settings.xml +- if [ "$TRAVIS_PULL_REQUEST" = "false" ]; then mvn deploy -DskipTests --settings .travis.settings.xml; fi Review comment: how about checking if branch is master instead? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Don't deploy if building with the PR > > > Key: SCB-233 > URL: https://issues.apache.org/jira/browse/SCB-233 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Zheng Feng >Assignee: Zheng Feng >Priority: Major > Fix For: saga-0.3.0 > > > currently the travis CI runs the deploy command when building with the PR. we > should improve this step. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-233) Don't deploy if building with the PR
[ https://issues.apache.org/jira/browse/SCB-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325693#comment-16325693 ] ASF GitHub Bot commented on SCB-233: coveralls commented on issue #119: SCB-233 update to deploy only with non PR building URL: https://github.com/apache/incubator-servicecomb-saga/pull/119#issuecomment-357527692 [](https://coveralls.io/builds/15044344) Coverage decreased (-0.4%) to 94.781% when pulling **525fab5f30e2c548b91b969775e9b16f9cb0e448 on zhfeng:SCB-233** into **5b2b59ac479758bd8386cc0e2c78f664e18563b6 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Don't deploy if building with the PR > > > Key: SCB-233 > URL: https://issues.apache.org/jira/browse/SCB-233 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Zheng Feng >Assignee: Zheng Feng > Fix For: saga-0.3.0 > > > currently the travis CI runs the deploy command when building with the PR. we > should improve this step. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SCB-233) Don't deploy if building with the PR
[ https://issues.apache.org/jira/browse/SCB-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325679#comment-16325679 ] ASF GitHub Bot commented on SCB-233: coveralls commented on issue #119: SCB-233 update to deploy only with non PR building URL: https://github.com/apache/incubator-servicecomb-saga/pull/119#issuecomment-357526128 [](https://coveralls.io/builds/15044224) Coverage remained the same at 95.229% when pulling **2f3f883ae42a07b74ac7ea076fbef190e6912d35 on zhfeng:SCB-233** into **5b2b59ac479758bd8386cc0e2c78f664e18563b6 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Don't deploy if building with the PR > > > Key: SCB-233 > URL: https://issues.apache.org/jira/browse/SCB-233 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Zheng Feng >Assignee: Zheng Feng > Fix For: saga-0.3.0 > > > currently the travis CI runs the deploy command when building with the PR. we > should improve this step. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SCB-233) Don't deploy if building with the PR
[ https://issues.apache.org/jira/browse/SCB-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325670#comment-16325670 ] ASF GitHub Bot commented on SCB-233: coveralls commented on issue #119: SCB-233 update to deploy only with non PR building URL: https://github.com/apache/incubator-servicecomb-saga/pull/119#issuecomment-357524824 [](https://coveralls.io/builds/15044089) Coverage remained the same at 95.229% when pulling **7934ad710f1a8a658aa5c4b60d4147d4d6c99c2a on zhfeng:SCB-233** into **5b2b59ac479758bd8386cc0e2c78f664e18563b6 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Don't deploy if building with the PR > > > Key: SCB-233 > URL: https://issues.apache.org/jira/browse/SCB-233 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Zheng Feng >Assignee: Zheng Feng > Fix For: saga-0.3.0 > > > currently the travis CI runs the deploy command when building with the PR. we > should improve this step. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SCB-233) Don't deploy if building with the PR
[ https://issues.apache.org/jira/browse/SCB-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325663#comment-16325663 ] ASF GitHub Bot commented on SCB-233: zhfeng opened a new pull request #119: SCB-233 update to deploy only with non PR building URL: https://github.com/apache/incubator-servicecomb-saga/pull/119 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Don't deploy if building with the PR > > > Key: SCB-233 > URL: https://issues.apache.org/jira/browse/SCB-233 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Zheng Feng >Assignee: Zheng Feng > Fix For: saga-0.3.0 > > > currently the travis CI runs the deploy command when building with the PR. we > should improve this step. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
