stillalex commented on PR #1856:
URL: https://github.com/apache/solr/pull/1856#issuecomment-1689255120
@dsmiley pushed some changes. this is a proposal, feel free to change it
back if you don't find it useful.
I am still considering a test for auto-generating a client trace for
internal
sayandigital commented on PR #1449:
URL: https://github.com/apache/solr/pull/1449#issuecomment-1689254035
Thanks @gerlowskija to help take this to completion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
pjmcarthur opened a new pull request, #1862:
URL: https://github.com/apache/solr/pull/1862
https://issues.apache.org/jira/browse/SOLR-16946
# Description
When a Cluster Singleton plugin config is updated via the /cluster/plugin
API, the `ClusterSingletons.modified` method calls
tpunder commented on PR #1861:
URL: https://github.com/apache/solr/pull/1861#issuecomment-1689073445
I've now included docs for the Reference Guide as part of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
tpunder commented on code in PR #1861:
URL: https://github.com/apache/solr/pull/1861#discussion_r1302281953
##
solr/core/src/java/org/apache/solr/core/QuerySenderListener.java:
##
@@ -44,65 +53,131 @@ public QuerySenderListener(SolrCore core) {
@Override
public void newS
tpunder commented on code in PR #1861:
URL: https://github.com/apache/solr/pull/1861#discussion_r1302272877
##
solr/core/src/java/org/apache/solr/core/QuerySenderListener.java:
##
@@ -44,65 +53,131 @@ public QuerySenderListener(SolrCore core) {
@Override
public void newS
Paul McArthur created SOLR-16946:
Summary: Cluster Singleton stop method sometimes not called on
Overseer close
Key: SOLR-16946
URL: https://issues.apache.org/jira/browse/SOLR-16946
Project: Solr
janhoy commented on code in PR #1861:
URL: https://github.com/apache/solr/pull/1861#discussion_r1302244189
##
solr/core/src/java/org/apache/solr/core/QuerySenderListener.java:
##
@@ -44,65 +53,131 @@ public QuerySenderListener(SolrCore core) {
@Override
public void newSe
tpunder opened a new pull request, #1861:
URL: https://github.com/apache/solr/pull/1861
https://issues.apache.org/jira/browse/SOLR-16945
# Description
This adds opt-in multi-threaded warming support to CaffeineCache and
QuerySenderListener.
# Solution
The implemen
[
https://issues.apache.org/jira/browse/SOLR-16265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757682#comment-17757682
]
ASF subversion and git services commented on SOLR-16265:
Commit 5
janhoy commented on code in PR #1851:
URL: https://github.com/apache/solr/pull/1851#discussion_r1302216094
##
solr/core/src/resources/security.json:
##
@@ -0,0 +1,74 @@
+{
+ "authentication": {
+"blockUnknown": false,
+"class": "solr.BasicAuthPlugin",
Review Comment:
[
https://issues.apache.org/jira/browse/SOLR-16265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757680#comment-17757680
]
ASF subversion and git services commented on SOLR-16265:
Commit c
HoustonPutman merged PR #1860:
URL: https://github.com/apache/solr/pull/1860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apa
janhoy commented on code in PR #1851:
URL: https://github.com/apache/solr/pull/1851#discussion_r1302206658
##
solr/core/src/java/org/apache/solr/cli/AuthTool.java:
##
@@ -347,37 +352,21 @@ private int handleBasicAuth(CommandLine cli) throws
Exception {
boolean blockU
stillalex commented on PR #1860:
URL: https://github.com/apache/solr/pull/1860#issuecomment-1688933123
good catch @HoustonPutman!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
Tim Underwood created SOLR-16945:
Summary: Add multi-threaded warming support to CaffeineCache and
QuerySenderListener
Key: SOLR-16945
URL: https://issues.apache.org/jira/browse/SOLR-16945
Project: So
HoustonPutman opened a new pull request, #1860:
URL: https://github.com/apache/solr/pull/1860
https://issues.apache.org/jira/browse/SOLR-16265
Fixing error seen below when passing a bad url to the client.
> ERROR: Cannot invoke
"org.eclipse.jetty.client.api.Request.abort(java.l
stillalex commented on PR #1119:
URL: https://github.com/apache/solr/pull/1119#issuecomment-1688919453
@gerlowskija updated the PR, please take a look and let me know what you
think. the test will fail on purpose to show that the correct class was called,
but because it's a static util meth
stillalex commented on code in PR #1119:
URL: https://github.com/apache/solr/pull/1119#discussion_r1302183689
##
solr/core/src/test/org/apache/solr/handler/replication/BackupAPITest.java:
##
@@ -0,0 +1,102 @@
+package org.apache.solr.handler.replication;
+
+import static org.apa
stillalex commented on code in PR #1119:
URL: https://github.com/apache/solr/pull/1119#discussion_r1302180114
##
solr/core/src/java/org/apache/solr/handler/replication/BackupAPI.java:
##
@@ -0,0 +1,100 @@
+package org.apache.solr.handler.replication;
+
+import static org.apache.
stillalex commented on code in PR #1119:
URL: https://github.com/apache/solr/pull/1119#discussion_r1302179642
##
solr/core/src/java/org/apache/solr/handler/replication/BackupAPI.java:
##
@@ -0,0 +1,100 @@
+package org.apache.solr.handler.replication;
+
+import static org.apache.
stillalex commented on code in PR #1119:
URL: https://github.com/apache/solr/pull/1119#discussion_r1302178487
##
solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java:
##
@@ -452,6 +454,11 @@ void call() throws Exception {
}
}
+ @Override
Review Comm
stillalex commented on code in PR #1119:
URL: https://github.com/apache/solr/pull/1119#discussion_r1302178487
##
solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java:
##
@@ -452,6 +454,11 @@ void call() throws Exception {
}
}
+ @Override
Review Comm
stillalex commented on code in PR #1119:
URL: https://github.com/apache/solr/pull/1119#discussion_r1302177490
##
solr/core/src/java/org/apache/solr/handler/replication/BackupAPI.java:
##
@@ -0,0 +1,100 @@
+package org.apache.solr.handler.replication;
+
+import static org.apache.
stillalex commented on code in PR #1119:
URL: https://github.com/apache/solr/pull/1119#discussion_r1302173918
##
solr/core/src/java/org/apache/solr/handler/replication/BackupAPI.java:
##
@@ -0,0 +1,100 @@
+package org.apache.solr.handler.replication;
Review Comment:
header a
HoustonPutman commented on issue #599:
URL: https://github.com/apache/solr-operator/issues/599#issuecomment-1688869332
The first one is
[SOLR-16934](https://issues.apache.org/jira/browse/SOLR-16934)
The second one is an issue with how the Solr Operator calls the Solr API.
Basically w
[
https://issues.apache.org/jira/browse/SOLR-16934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman resolved SOLR-16934.
---
Fix Version/s: 9.4
Assignee: Houston Putman
Resolution: Fixed
> Solr does not
[
https://issues.apache.org/jira/browse/SOLR-16934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757654#comment-17757654
]
ASF subversion and git services commented on SOLR-16934:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-16934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757649#comment-17757649
]
ASF subversion and git services commented on SOLR-16934:
Commit 6
HoustonPutman merged PR #1857:
URL: https://github.com/apache/solr/pull/1857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apa
[
https://issues.apache.org/jira/browse/SOLR-16938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757643#comment-17757643
]
David Smiley commented on SOLR-16938:
-
bq. Are you on board with supporting both? I.e
epugh commented on code in PR #1851:
URL: https://github.com/apache/solr/pull/1851#discussion_r1302123124
##
solr/core/src/resources/security.json:
##
@@ -0,0 +1,74 @@
+{
+ "authentication": {
+"blockUnknown": false,
+"class": "solr.BasicAuthPlugin",
Review Comment:
epugh commented on code in PR #1851:
URL: https://github.com/apache/solr/pull/1851#discussion_r1302120050
##
solr/core/src/java/org/apache/solr/cli/AuthTool.java:
##
@@ -347,37 +352,21 @@ private int handleBasicAuth(CommandLine cli) throws
Exception {
boolean blockUn
gerlowskija merged PR #1790:
URL: https://github.com/apache/solr/pull/1790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
janhoy commented on code in PR #1851:
URL: https://github.com/apache/solr/pull/1851#discussion_r1302085868
##
solr/core/src/resources/security.json:
##
@@ -0,0 +1,74 @@
+{
+ "authentication": {
+"blockUnknown": false,
+"class": "solr.BasicAuthPlugin",
Review Comment:
renatoh commented on PR #1834:
URL: https://github.com/apache/solr/pull/1834#issuecomment-1688753168
I am a bit confused, so why would we need an assert at a place where it is
impossible for the Socket to be null?
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/SOLR-16944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-16944.
Fix Version/s: 9.4
Resolution: Fixed
> /api/node/health should be governed by "health" permi
[
https://issues.apache.org/jira/browse/SOLR-16944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757625#comment-17757625
]
ASF subversion and git services commented on SOLR-16944:
Commit b
epugh commented on PR #1834:
URL: https://github.com/apache/solr/pull/1834#issuecomment-1688716006
Actually, I went ahead and fixed the precommit... going to run the tests
and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/SOLR-15960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757608#comment-17757608
]
Jan Høydahl commented on SOLR-15960:
I did a similar stunt in otel plugin, a method {
epugh commented on PR #1834:
URL: https://github.com/apache/solr/pull/1834#issuecomment-1688684161
@renatoh can you check the precommit failure? It's a weird one where we
can't do waht the warning tells us to do Please ping me if I don't get
this merged after you get precommit fixed
epugh commented on PR #1851:
URL: https://github.com/apache/solr/pull/1851#issuecomment-1688682748
Now I am getting excited about this PR ;-). Better Auth defaults and Better
Ref Guide ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
epugh commented on PR #1851:
URL: https://github.com/apache/solr/pull/1851#issuecomment-1688681991
Thanks @HoustonPutman !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
HoustonPutman commented on PR #1851:
URL: https://github.com/apache/solr/pull/1851#issuecomment-1688681227
> Do we have other examples of linking to Github in teh ref guide? I could
definitly link to just the main branch of it.
We should link to the correct branch. If the capability i
[
https://issues.apache.org/jira/browse/SOLR-16944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757598#comment-17757598
]
ASF subversion and git services commented on SOLR-16944:
Commit 5
janhoy merged PR #1858:
URL: https://github.com/apache/solr/pull/1858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh commented on PR #1851:
URL: https://github.com/apache/solr/pull/1851#issuecomment-1688674757
Do we have other examples of linking to Github in teh ref guide? I could
definitly link to just the main branch of it.
And yeah, generally I find Crave hates me after a couple of com
[
https://issues.apache.org/jira/browse/SOLR-15940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757596#comment-17757596
]
Eric Pugh commented on SOLR-15940:
--
So, the bats test that I added WAS passing on main..
janhoy commented on PR #1851:
URL: https://github.com/apache/solr/pull/1851#issuecomment-1688670787
Re. syncing - could we link to the file on github instead of displaying it
verbatim in ref-guide?
This is a tiny step towards secure-by-default, making it easy to get a
production grad
HoustonPutman commented on code in PR #1857:
URL: https://github.com/apache/solr/pull/1857#discussion_r1301999444
##
solr/server/etc/security.policy:
##
@@ -191,6 +191,12 @@ grant {
permission java.io.FilePermission "${solr.jetty.truststore}",
"read,write,delete,readlink";
janhoy commented on PR #1812:
URL: https://github.com/apache/solr/pull/1812#issuecomment-1688656636
Better first upgrade errorprone-rules in
https://github.com/apache/solr/pull/1701 and then circle back to this as a pure
caffeine upgrade.
--
This is an automated message from the Apache G
risdenk commented on code in PR #1857:
URL: https://github.com/apache/solr/pull/1857#discussion_r1301997757
##
solr/server/etc/security.policy:
##
@@ -191,6 +191,12 @@ grant {
permission java.io.FilePermission "${solr.jetty.truststore}",
"read,write,delete,readlink";
perm
epugh commented on PR #1851:
URL: https://github.com/apache/solr/pull/1851#issuecomment-1688656348
also, I think if we want to have really strong security, I think at that
point, we are sort of suggesting that it happens at start up...(Someday I
hope to follow the Rails pattern of havin
epugh commented on PR #1851:
URL: https://github.com/apache/solr/pull/1851#issuecomment-1688654436
My assumption is that "search" and "index" belong primarily to machines, i.e
your ETL pipeline and your search API, so wouldn't use the admin UI anyway
And might even have passwords defin
gerlowskija commented on code in PR #1859:
URL: https://github.com/apache/solr/pull/1859#discussion_r1301983681
##
solr/api/src/java/org/apache/solr/client/api/model/Constants.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
gerlowskija commented on code in PR #1859:
URL: https://github.com/apache/solr/pull/1859#discussion_r1301983681
##
solr/api/src/java/org/apache/solr/client/api/model/Constants.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
[
https://issues.apache.org/jira/browse/SOLR-15960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757588#comment-17757588
]
Eric Pugh commented on SOLR-15960:
--
A potential approach...
> Unified use of system pro
gerlowskija opened a new pull request, #1859:
URL: https://github.com/apache/solr/pull/1859
https://issues.apache.org/jira/browse/SOLR-16825
# Description
SOLR-16825 added a new gradle module, 'api', which holds v2 API definitions
as interfaces. This allows us to generate an O
[
https://issues.apache.org/jira/browse/SOLR-16762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757585#comment-17757585
]
Eric Pugh commented on SOLR-16762:
--
This was fixed by SOLR-15152.
> Clarify when we are
[
https://issues.apache.org/jira/browse/SOLR-16762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-16762.
--
Resolution: Duplicate
This was fixed during the previous work on the bin/solr export tooling.
> Cla
[
https://issues.apache.org/jira/browse/SOLR-16911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-16911.
--
Fix Version/s: main (10.0)
Resolution: Fixed
> Strip out configurable hostContext
>
[
https://issues.apache.org/jira/browse/SOLR-16938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757577#comment-17757577
]
Jan Høydahl commented on SOLR-16938:
Guess I'm inspired by the elegant standardized c
sandbergja commented on PR #1827:
URL: https://github.com/apache/solr/pull/1827#issuecomment-1688574672
Thanks for all your help, @dsmiley ! The test is so much more readable now!
Should be ready for your re-review.
--
This is an automated message from the Apache Git Service.
To respond
janhoy commented on PR #1851:
URL: https://github.com/apache/solr/pull/1851#issuecomment-1688564766
I compiled my suggested changes as a PR to your branch:
https://github.com/epugh/solr/pull/5 with these changes:
* Renames role `user` as `search`
* Adds role `index` which can do `/
[
https://issues.apache.org/jira/browse/SOLR-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757562#comment-17757562
]
ASF subversion and git services commented on SOLR-16929:
Commit f
[
https://issues.apache.org/jira/browse/SOLR-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu resolved SOLR-16929.
-
Fix Version/s: 9.4
Resolution: Fixed
> SolrStream propagates undecoded error message
> ---
janhoy opened a new pull request, #1858:
URL: https://github.com/apache/solr/pull/1858
https://issues.apache.org/jira/browse/SOLR-16944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
stillalex merged PR #1852:
URL: https://github.com/apache/solr/pull/1852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
[
https://issues.apache.org/jira/browse/SOLR-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757558#comment-17757558
]
ASF subversion and git services commented on SOLR-16929:
Commit c
Jan Høydahl created SOLR-16944:
--
Summary: /api/node/health should be governed by "health" permission
Key: SOLR-16944
URL: https://issues.apache.org/jira/browse/SOLR-16944
Project: Solr
Issue Typ
HoustonPutman commented on issue #579:
URL: https://github.com/apache/solr-operator/issues/579#issuecomment-1688527179
Not sure what you mean by "this feature", but if you mean the locked cluster
operations, its a feature of the solr operator and has been merged in for the
next release (v0.
HoustonPutman opened a new pull request, #1857:
URL: https://github.com/apache/solr/pull/1857
https://issues.apache.org/jira/browse/SOLR-16934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/SOLR-16940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman resolved SOLR-16940.
---
Fix Version/s: 9.4
Assignee: Houston Putman
Resolution: Fixed
> Allow users t
[
https://issues.apache.org/jira/browse/SOLR-16940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757544#comment-17757544
]
ASF subversion and git services commented on SOLR-16940:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-16941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman resolved SOLR-16941.
---
Fix Version/s: 9.4
Assignee: Houston Putman
Resolution: Fixed
> Improve Solr
laminelam commented on code in PR #1791:
URL: https://github.com/apache/solr/pull/1791#discussion_r1298538572
##
solr/webapp/web/js/angular/services.js:
##
@@ -286,8 +286,74 @@ solrAdminServices.factory('System',
})
}])
.factory('AuthenticationService',
-['base64'
[
https://issues.apache.org/jira/browse/SOLR-16941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757530#comment-17757530
]
ASF subversion and git services commented on SOLR-16941:
Commit 1
[
https://issues.apache.org/jira/browse/SOLR-16938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757504#comment-17757504
]
David Smiley commented on SOLR-16938:
-
I'm not arguing against env vars, just against
dsmiley commented on PR #1856:
URL: https://github.com/apache/solr/pull/1856#issuecomment-1688298154
> would the existing tests cover the basics
Yeah I think we don't need 100% coverage in this tests of all Solr's code
paths. Really, just some basic scenarios is fine -- query, indexing,
epugh commented on PR #1851:
URL: https://github.com/apache/solr/pull/1851#issuecomment-1688243680
@janhoy could I talk you into pushing up a commit to the security.json that
implements that changes you mentioned? For all that I try to work on security
stuff, I don't actually grok it too
janhoy merged PR #1820:
URL: https://github.com/apache/solr/pull/1820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
janhoy commented on PR #1792:
URL: https://github.com/apache/solr/pull/1792#issuecomment-1688216572
> BTW, I have added a WARN message.
Thanks, the validation and warn log looks good 👍
Will do a final review when refguide docs are in. Also remember CHANGES.txt.
--
This is an
janhoy commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1301667152
##
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTIssuerConfig.java:
##
@@ -64,12 +72,18 @@ public class JWTIssuerConfig {
private WellKnownDiscoveryConf
janhoy commented on code in PR #1791:
URL: https://github.com/apache/solr/pull/1791#discussion_r1301664112
##
solr/webapp/web/js/angular/services.js:
##
@@ -286,8 +286,74 @@ solrAdminServices.factory('System',
})
}])
.factory('AuthenticationService',
-['base64', f
janhoy commented on code in PR #1791:
URL: https://github.com/apache/solr/pull/1791#discussion_r1301661134
##
solr/webapp/web/js/angular/controllers/login.js:
##
@@ -60,92 +60,169 @@ solrAdminApp.controller('LoginController',
var hp = AuthenticationService.decodeHas
janhoy commented on PR #1791:
URL: https://github.com/apache/solr/pull/1791#issuecomment-1688203926
I tested in a real KeyCloak idp environment today, with my [custom
image](https://hub.docker.com/layers/cominvent/solr/10-codeflow-csp2/images/sha256-a85f101563a03b8dc43e648d800615909570cbaa5c
stillalex commented on PR #1856:
URL: https://github.com/apache/solr/pull/1856#issuecomment-1688125194
> TODO the client side span but the test integration from my fork is a PITA
to integrate into changes to TestDistributedTracing
would the existing tests cover the basics? for more ex
stillalex commented on PR #1856:
URL: https://github.com/apache/solr/pull/1856#issuecomment-1688109194
@dsmiley do you want to include the apache httpclient update in this PR?
I would prefer merging efforts rather than diverging into a bunch of
different tickets
https://github.com/apach
stillalex commented on code in PR #1854:
URL: https://github.com/apache/solr/pull/1854#discussion_r1301578462
##
solr/core/src/java/org/apache/solr/util/stats/InstrumentedHttpRequestExecutor.java:
##
@@ -147,6 +152,13 @@ public HttpResponse execute(HttpRequest request,
HttpClie
stillalex commented on PR #1854:
URL: https://github.com/apache/solr/pull/1854#issuecomment-1688098261
@dsmiley I wanted to make sure this review is headed in the right direction.
I feel we got sidetracked with a number of thing unrelated to this proposal for
trace id generation, but rather
stillalex commented on code in PR #1854:
URL: https://github.com/apache/solr/pull/1854#discussion_r1301571072
##
solr/core/src/test/org/apache/solr/util/tracing/TestSimplePropagatorDistributedTracing.java:
##
@@ -114,6 +115,26 @@ public void test() throws IOException, SolrServer
stillalex commented on code in PR #1854:
URL: https://github.com/apache/solr/pull/1854#discussion_r1301569725
##
solr/core/src/java/org/apache/solr/util/stats/InstrumentedHttpRequestExecutor.java:
##
@@ -147,6 +152,13 @@ public HttpResponse execute(HttpRequest request,
HttpClie
stillalex commented on code in PR #1856:
URL: https://github.com/apache/solr/pull/1856#discussion_r1301564710
##
solr/core/src/java/org/apache/solr/util/stats/InstrumentedHttpListenerFactory.java:
##
@@ -86,19 +89,36 @@ private static String methodNameString(Request request) {
janhoy commented on PR #1851:
URL: https://github.com/apache/solr/pull/1851#issuecomment-1688040495
Also, there should be some agreement between security-dashboard screen in
Admin UI and this default security.json. I.e. if you bootstrap a cluster with
this default, it should not trigger any
janhoy commented on code in PR #1851:
URL: https://github.com/apache/solr/pull/1851#discussion_r1301509653
##
solr/core/src/resources/security.json:
##
@@ -0,0 +1,74 @@
+{
+ "authentication": {
+"blockUnknown": true,
+"class": "solr.BasicAuthPlugin",
+"credentials":
janhoy commented on code in PR #1851:
URL: https://github.com/apache/solr/pull/1851#discussion_r1301509653
##
solr/core/src/resources/security.json:
##
@@ -0,0 +1,74 @@
+{
+ "authentication": {
+"blockUnknown": true,
+"class": "solr.BasicAuthPlugin",
+"credentials":
[
https://issues.apache.org/jira/browse/SOLR-16829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757377#comment-17757377
]
Eric Pugh commented on SOLR-16829:
--
At this point, we have now also ported over version
[
https://issues.apache.org/jira/browse/SOLR-16870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-16870.
--
Fix Version/s: main (10.0)
Resolution: Fixed
Not quite sure why this didn't go to branch_9x, may
[
https://issues.apache.org/jira/browse/SOLR-16920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-16920.
--
Fix Version/s: main (10.0)
9.4
Resolution: Fixed
> Add Full Lifecycle Bats te
janhoy commented on issue #331:
URL: https://github.com/apache/solr-operator/issues/331#issuecomment-1687775215
The short answer is No, see
https://solr.apache.org/guide/solr/latest/deployment-guide/jwt-authentication-plugin.html#using-clients-with-jwt-auth.
Please ask further questions i
1 - 100 of 104 matches
Mail list logo
