Phoenix_Daddy created SPARK-23349:
-------------------------------------

             Summary: Duplicate and redundant type determination for 
ShuffleManager Object
                 Key: SPARK-23349
                 URL: https://issues.apache.org/jira/browse/SPARK-23349
             Project: Spark
          Issue Type: Improvement
          Components: Shuffle, SQL
    Affects Versions: 2.2.1
            Reporter: Phoenix_Daddy
             Fix For: 2.2.1


org.apache.spark.sql.execution.exchange.ShuffleExchange

In the "needtocopyobjectsbeforguffle()" function,there is a nested "if or else" 
branch .
The <sortBasedShufffleOn> condition in the first layer "if" has the same value 
as the <bypassIsSupported> condition in the second layer "if", that is, 
<bypassIsSupported> must be true when <sortBasedShufffleOn> is true.
In addition, the <byPassMergeThreshold> condition will be used in the second 
layer "if" and should not be calculated until needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to