[
https://issues.apache.org/jira/browse/SPARK-12311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055073#comment-15055073
]
Sean Owen edited comment on SPARK-12311 at 12/14/15 1:45 PM:
-------------------------------------------------------------
LGTM, feel free to make a pull request.
EDIT: I knew I was missing something. Josh is right that there's a mixin trait
that should fix this. Are you sure it's actually not working?
was (Author: srowen):
LGTM, feel free to make a pull request.
> [CORE] Restore previous value of "os.arch" property in test suites after
> forcing to set specific value to "os.arch" property
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: SPARK-12311
> URL: https://issues.apache.org/jira/browse/SPARK-12311
> Project: Spark
> Issue Type: Bug
> Components: Spark Core
> Affects Versions: 1.5.2
> Reporter: Kazuaki Ishizaki
> Priority: Minor
>
> Although current BlockManagerSuite.scala and SizeEstimatorSuite.scala set the
> specific value (e.g. "amd64") into system property "os.arch", they do not
> restore the original value of "os.arch" after these test suites. This may
> lead to failures in a test case that depends on architecture on other
> platform rather than amd64.
> They should save the original value of "os.arch" and restore this at the end
> of these test suites.
>
> https://github.com/apache/spark/blob/master/core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala
> https://github.com/apache/spark/blob/master/core/src/test/scala/org/apache/spark/util/SizeEstimatorSuite.scala
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
