[jira] [Commented] (SPARK-18088) ChiSqSelector FPR PR cleanups

2016-10-26 Thread Apache Spark (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609149#comment-15609149 ] Apache Spark commented on SPARK-18088: -- User 'jkbradley' has created a pull request

[jira] [Commented] (SPARK-18088) ChiSqSelector FPR PR cleanups

2016-10-26 Thread Joseph K. Bradley (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609143#comment-15609143 ] Joseph K. Bradley commented on SPARK-18088: --- But I'm happy to discuss more & mo

[jira] [Commented] (SPARK-18088) ChiSqSelector FPR PR cleanups

2016-10-26 Thread Joseph K. Bradley (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609141#comment-15609141 ] Joseph K. Bradley commented on SPARK-18088: --- I'd actually propose: * Rename kbe

[jira] [Commented] (SPARK-18088) ChiSqSelector FPR PR cleanups

2016-10-26 Thread Yanbo Liang (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15608643#comment-15608643 ] Yanbo Liang commented on SPARK-18088: - +1 [~peng.m...@intel.com] I vote to change par

[jira] [Commented] (SPARK-18088) ChiSqSelector FPR PR cleanups

2016-10-26 Thread Peng Meng (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15608322#comment-15608322 ] Peng Meng commented on SPARK-18088: --- I am neutral for changing the selectorType "KBest"

[jira] [Commented] (SPARK-18088) ChiSqSelector FPR PR cleanups

2016-10-25 Thread Joseph K. Bradley (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15606146#comment-15606146 ] Joseph K. Bradley commented on SPARK-18088: --- How do you feel about renaming the

[jira] [Commented] (SPARK-18088) ChiSqSelector FPR PR cleanups

2016-10-25 Thread Joseph K. Bradley (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15606142#comment-15606142 ] Joseph K. Bradley commented on SPARK-18088: --- Ahh, you're right, sorry, I see th

[jira] [Commented] (SPARK-18088) ChiSqSelector FPR PR cleanups

2016-10-25 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605239#comment-15605239 ] Sean Owen commented on SPARK-18088: --- [~josephkb] could we pause and discuss this? I'm n

[jira] [Commented] (SPARK-18088) ChiSqSelector FPR PR cleanups

2016-10-25 Thread Peng Meng (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605231#comment-15605231 ] Peng Meng commented on SPARK-18088: --- In the previous implementation, testing against o

[jira] [Commented] (SPARK-18088) ChiSqSelector FPR PR cleanups

2016-10-25 Thread Peng Meng (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605211#comment-15605211 ] Peng Meng commented on SPARK-18088: --- Hi [~josephkb] , I am not quite understand "Testin

[jira] [Commented] (SPARK-18088) ChiSqSelector FPR PR cleanups

2016-10-24 Thread Joseph K. Bradley (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-18088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15604317#comment-15604317 ] Joseph K. Bradley commented on SPARK-18088: --- Calling this a bug since FPR is no