[jira] [Commented] (SPARK-19899) FPGrowth input column naming

2017-03-16 Thread Maciej Szymkiewicz (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-19899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928827#comment-15928827 ] Maciej Szymkiewicz commented on SPARK-19899: [~mlnick] For some reason SparkQA recognized the

[jira] [Commented] (SPARK-19899) FPGrowth input column naming

2017-03-16 Thread Nick Pentreath (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-19899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928193#comment-15928193 ] Nick Pentreath commented on SPARK-19899: +1 on {{itemsCol}} - feel free to send a PR :) >

[jira] [Commented] (SPARK-19899) FPGrowth input column naming

2017-03-14 Thread Felix Cheung (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-19899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924677#comment-15924677 ] Felix Cheung commented on SPARK-19899: -- +1 on "itemsCol" looks like it is defaulting to "items" for

[jira] [Commented] (SPARK-19899) FPGrowth input column naming

2017-03-14 Thread Maciej Szymkiewicz (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-19899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924435#comment-15924435 ] Maciej Szymkiewicz commented on SPARK-19899: "itemsCol" sounds good. What should we use as a

[jira] [Commented] (SPARK-19899) FPGrowth input column naming

2017-03-14 Thread Joseph K. Bradley (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-19899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924362#comment-15924362 ] Joseph K. Bradley commented on SPARK-19899: --- Thanks for bringing this up. I'm pretty convinced

[jira] [Commented] (SPARK-19899) FPGrowth input column naming

2017-03-10 Thread Maciej Szymkiewicz (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-19899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905834#comment-15905834 ] Maciej Szymkiewicz commented on SPARK-19899: Thanks [~yuhaoyan]. > FPGrowth input column

[jira] [Commented] (SPARK-19899) FPGrowth input column naming

2017-03-10 Thread yuhao yang (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-19899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905492#comment-15905492 ] yuhao yang commented on SPARK-19899: also cc [~podongfeng] since I recalled he mentioned to use

[jira] [Commented] (SPARK-19899) FPGrowth input column naming

2017-03-10 Thread yuhao yang (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-19899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905484#comment-15905484 ] yuhao yang commented on SPARK-19899: Thanks for the reply. We can wait for some time to see if people

[jira] [Commented] (SPARK-19899) FPGrowth input column naming

2017-03-10 Thread Maciej Szymkiewicz (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-19899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905480#comment-15905480 ] Maciej Szymkiewicz commented on SPARK-19899: This is just an idea, but I would start with: -

[jira] [Commented] (SPARK-19899) FPGrowth input column naming

2017-03-10 Thread yuhao yang (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-19899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905451#comment-15905451 ] yuhao yang commented on SPARK-19899: {quote} if we mix-in HasFeaturesCol the featuresCol should be

[jira] [Commented] (SPARK-19899) FPGrowth input column naming

2017-03-10 Thread Maciej Szymkiewicz (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-19899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905405#comment-15905405 ] Maciej Szymkiewicz commented on SPARK-19899: In my opinion a trait for each input category

[jira] [Commented] (SPARK-19899) FPGrowth input column naming

2017-03-10 Thread yuhao yang (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-19899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905367#comment-15905367 ] yuhao yang commented on SPARK-19899: Thanks for the suggestion. I'm neutral on this. Not sure if we

[jira] [Commented] (SPARK-19899) FPGrowth input column naming

2017-03-10 Thread Maciej Szymkiewicz (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-19899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904999#comment-15904999 ] Maciej Szymkiewicz commented on SPARK-19899: CC [~felixcheung], [~josephkb], [~mlnick],