[jira] [Commented] (SPARK-23711) Add fallback to interpreted execution logic

2018-08-20 Thread Apache Spark (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-23711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586090#comment-16586090 ] Apache Spark commented on SPARK-23711: -- User 'maropu' has created a pull request for this issue:

[jira] [Commented] (SPARK-23711) Add fallback to interpreted execution logic

2018-04-19 Thread Apache Spark (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-23711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444099#comment-16444099 ] Apache Spark commented on SPARK-23711: -- User 'viirya' has created a pull request for this issue:

[jira] [Commented] (SPARK-23711) Add fallback to interpreted execution logic

2018-04-19 Thread Liang-Chi Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-23711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443959#comment-16443959 ] Liang-Chi Hsieh commented on SPARK-23711: - Ok. > Add fallback to interpreted execution logic >

[jira] [Commented] (SPARK-23711) Add fallback to interpreted execution logic

2018-04-19 Thread Herman van Hovell (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-23711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443934#comment-16443934 ] Herman van Hovell commented on SPARK-23711: --- Can you make a small PR initially so we can

[jira] [Commented] (SPARK-23711) Add fallback to interpreted execution logic

2018-04-19 Thread Liang-Chi Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-23711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443924#comment-16443924 ] Liang-Chi Hsieh commented on SPARK-23711: - Yeah, I agree that is a good rule. I will prepare a PR

[jira] [Commented] (SPARK-23711) Add fallback to interpreted execution logic

2018-04-19 Thread Herman van Hovell (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-23711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443882#comment-16443882 ] Herman van Hovell commented on SPARK-23711: --- ObjectHashAggregateExec uses code generations for

[jira] [Commented] (SPARK-23711) Add fallback to interpreted execution logic

2018-04-19 Thread Liang-Chi Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-23711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443879#comment-16443879 ] Liang-Chi Hsieh commented on SPARK-23711: - object hash aggregate? If you mean

[jira] [Commented] (SPARK-23711) Add fallback to interpreted execution logic

2018-04-19 Thread Herman van Hovell (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-23711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443866#comment-16443866 ] Herman van Hovell commented on SPARK-23711: --- There a lot of places where we do not fallback to

[jira] [Commented] (SPARK-23711) Add fallback to interpreted execution logic

2018-04-18 Thread Takeshi Yamamuro (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-23711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443588#comment-16443588 ] Takeshi Yamamuro commented on SPARK-23711: -- +1, I also think so. > Add fallback to interpreted

[jira] [Commented] (SPARK-23711) Add fallback to interpreted execution logic

2018-04-18 Thread Liang-Chi Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-23711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443573#comment-16443573 ] Liang-Chi Hsieh commented on SPARK-23711: - About this, I suppose that in