[ 
https://issues.apache.org/jira/browse/SPARK-38175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494372#comment-17494372
 ] 

Apache Spark commented on SPARK-38175:
--------------------------------------

User 'LuciferYang' has created a pull request for this issue:
https://github.com/apache/spark/pull/35567

> Clean up unused parameters in private methods signature
> -------------------------------------------------------
>
>                 Key: SPARK-38175
>                 URL: https://issues.apache.org/jira/browse/SPARK-38175
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 3.3.0
>            Reporter: Yang Jie
>            Assignee: Yang Jie
>            Priority: Minor
>             Fix For: 3.3.0
>
>
> The private method `castDecimalToIntegralTypeCode` in Cast.scala as follows:
>  
> {code:java}
> private[this] def castDecimalToIntegralTypeCode(
>       ctx: CodegenContext,
>       integralType: String,
>       catalogType: String): CastFunction = {
>     if (ansiEnabled) {
>       (c, evPrim, evNull) => code"$evPrim = 
> $c.roundTo${integralType.capitalize}();"
>     } else {
>       (c, evPrim, evNull) => code"$evPrim = 
> $c.to${integralType.capitalize}();"
>     }
>   } {code}
> `ctx` and `catalogType` are useless
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to