[ https://issues.apache.org/jira/browse/SPARK-29237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dongjoon Hyun resolved SPARK-29237. ----------------------------------- Fix Version/s: 3.0.0 Assignee: Maxim Gekk Resolution: Fixed This is resolved via https://github.com/apache/spark/pull/25924 > Use _FUNC_ in expression examples > --------------------------------- > > Key: SPARK-29237 > URL: https://issues.apache.org/jira/browse/SPARK-29237 > Project: Spark > Issue Type: Improvement > Components: SQL > Affects Versions: 3.0.0 > Reporter: Maxim Gekk > Assignee: Maxim Gekk > Priority: Minor > Fix For: 3.0.0 > > > Some examples for expressions use function names directly instead of _FUNC_: > {code} > $ find . -name "*.scala" -print0|xargs -0 grep -n -i '> SELECT'|grep -v _FUNC_ > ./sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala:453: > > SELECT MOD(2, 1.8); > ./sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala:113: > > SELECT CASE WHEN 1 > 0 THEN 1 WHEN 2 > 0 THEN 2.0 ELSE 1.2 END; > ./sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala:115: > > SELECT CASE WHEN 1 < 0 THEN 1 WHEN 2 > 0 THEN 2.0 ELSE 1.2 END; > ./sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala:117: > > SELECT CASE WHEN 1 < 0 THEN 1 WHEN 2 < 0 THEN 2.0 END; > ./sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala:1100: > > SELECT from_utc_timestamp('2016-08-31', 'Asia/Seoul'); > ./sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:1126: > > SELECT POSITION('bar' IN 'foobarbar'); > ./sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:1735: > > SELECT CHAR_LENGTH('Spark SQL '); > ./sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:1737: > > SELECT CHARACTER_LENGTH('Spark SQL '); > ... > {code} > Need to replace the function names by _FUNC_ to avoid errors in examples in > the future. Name binding must be done only in one place FunctionRegistry -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org