[ 
https://issues.apache.org/jira/browse/SPARK-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Or updated SPARK-1615:
-----------------------------

    Description: 
Much of SparkListenerSuite relies on LiveListenerBus's waitUntilEmpty() method. 
As the name suggests, this waits until the event queue is empty. However, the 
following race condition could happen:

(1) We dequeue the event
(2) The queue is empty, we return true
(3) The test asserts something assuming that all listeners have finished 
executing (and fails)
(4) The listeners receive the event

This has been a possible race condition for a long time, but for some reason 
we've never run into it.

  was:
Much of SparkListenerSuite relies on LiveListenerBus's waitUntilEmpty() method. 
As the name suggests, this waits until the event queue is empty. However, the 
following race condition could happen:

(1) We dequeue the event
(2) The queue is empty, we return true
(3) The test asserts something assuming that all listeners have finished 
executing
(4) The listeners receive the event

This has been a possible race condition for a long time, but for some reason 
we've never run into it.


> Very subtle race condition in SparkListenerSuite
> ------------------------------------------------
>
>                 Key: SPARK-1615
>                 URL: https://issues.apache.org/jira/browse/SPARK-1615
>             Project: Spark
>          Issue Type: Bug
>          Components: Spark Core
>    Affects Versions: 0.9.1
>            Reporter: Andrew Or
>            Assignee: Andrew Or
>            Priority: Minor
>             Fix For: 1.0.0
>
>
> Much of SparkListenerSuite relies on LiveListenerBus's waitUntilEmpty() 
> method. As the name suggests, this waits until the event queue is empty. 
> However, the following race condition could happen:
> (1) We dequeue the event
> (2) The queue is empty, we return true
> (3) The test asserts something assuming that all listeners have finished 
> executing (and fails)
> (4) The listeners receive the event
> This has been a possible race condition for a long time, but for some reason 
> we've never run into it.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to