[ 
https://issues.apache.org/jira/browse/SPARK-29807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yuanjian Li updated SPARK-29807:
--------------------------------
    Description: 
The relation between "spark.sql.ansi.enabled" and "spark.sql.dialect" is 
confusing, since the "PostgreSQL" dialect should contain the features of 
"spark.sql.ansi.enabled".

To make things clearer, we can rename the "spark.sql.ansi.enabled" to 
"spark.sql.dialect.spark.ansi.enabled", thus the option 
"spark.sql.dialect.spark.ansi.enabled" is only for Spark dialect.

For the casting and arithmetic operations, runtime exceptions should be thrown 
if "spark.sql.dialect" is "spark" and "spark.sql.dialect.spark.ansi.enabled" is 
true or "spark.sql.dialect" is PostgresSQL.

  was:
The relation between "spark.sql.ansi.enabled" and "spark.sql.dialect" is 
confusing, since the "PostgreSQL" dialect should contain the features of 
"spark.sql.ansi.enabled".
To make things clearer, we can rename the "spark.sql.ansi.enabled" to 
"spark.sql.dialect.spark.ansi.enabled", thus the option 
"spark.sql.dialect.spark.ansi.enabled" is only for Spark dialect.
For the casting and arithmetic operations, runtime exceptions should be thrown 
if 
"spark.sql.dialect" is "spark" and "spark.sql.dialect.spark.ansi.enabled" is 
true
or "spark.sql.dialect" is PostgresSQL.


> Rename "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled"
> -------------------------------------------------------------------------
>
>                 Key: SPARK-29807
>                 URL: https://issues.apache.org/jira/browse/SPARK-29807
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 3.0.0
>            Reporter: Yuanjian Li
>            Priority: Major
>
> The relation between "spark.sql.ansi.enabled" and "spark.sql.dialect" is 
> confusing, since the "PostgreSQL" dialect should contain the features of 
> "spark.sql.ansi.enabled".
> To make things clearer, we can rename the "spark.sql.ansi.enabled" to 
> "spark.sql.dialect.spark.ansi.enabled", thus the option 
> "spark.sql.dialect.spark.ansi.enabled" is only for Spark dialect.
> For the casting and arithmetic operations, runtime exceptions should be 
> thrown if "spark.sql.dialect" is "spark" and 
> "spark.sql.dialect.spark.ansi.enabled" is true or "spark.sql.dialect" is 
> PostgresSQL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to