[ 
https://issues.apache.org/jira/browse/SPARK-41830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sandeep Singh updated SPARK-41830:
----------------------------------
    Description: 
{code:java}
File 
"/Users/s.singh/personal/spark-oss/python/pyspark/sql/connect/dataframe.py", 
line 401, in pyspark.sql.connect.dataframe.DataFrame.sample
Failed example:
    df.sample(0.5, 3).count()
Exception raised:
    Traceback (most recent call last):
      File 
"/usr/local/Cellar/python@3.10/3.10.8/Frameworks/Python.framework/Versions/3.10/lib/python3.10/doctest.py",
 line 1350, in __run
        exec(compile(example.source, filename, "single",
      File "<doctest pyspark.sql.connect.dataframe.DataFrame.sample[1]>", line 
1, in <module>
        df.sample(0.5, 3).count()
    TypeError: DataFrame.sample() takes 2 positional arguments but 3 were given
**********************************************************************
File 
"/Users/s.singh/personal/spark-oss/python/pyspark/sql/connect/dataframe.py", 
line 411, in pyspark.sql.connect.dataframe.DataFrame.sample
Failed example:
    df.sample(False, fraction=1.0).count()
Exception raised:
    Traceback (most recent call last):
      File 
"/usr/local/Cellar/python@3.10/3.10.8/Frameworks/Python.framework/Versions/3.10/lib/python3.10/doctest.py",
 line 1350, in __run
        exec(compile(example.source, filename, "single",
      File "<doctest pyspark.sql.connect.dataframe.DataFrame.sample[6]>", line 
1, in <module>
        df.sample(False, fraction=1.0).count()
    TypeError: DataFrame.sample() got multiple values for argument 
'fraction'{code}

  was:
{code:java}
File 
"/Users/s.singh/personal/spark-oss/python/pyspark/sql/connect/dataframe.py", 
line 422, in pyspark.sql.connect.dataframe.DataFrame.sort
Failed example:
    df.orderBy(["age", "name"], ascending=[False, False]).show()
Exception raised:
    Traceback (most recent call last):
      File 
"/usr/local/Cellar/python@3.10/3.10.8/Frameworks/Python.framework/Versions/3.10/lib/python3.10/doctest.py",
 line 1350, in __run
        exec(compile(example.source, filename, "single",
      File "<doctest pyspark.sql.connect.dataframe.DataFrame.sort[8]>", line 1, 
in <module>
        df.orderBy(["age", "name"], ascending=[False, False]).show()
    TypeError: DataFrame.sort() got an unexpected keyword argument 'ascending'
**********************************************************************
File 
"/Users/s.singh/personal/spark-oss/python/pyspark/sql/connect/dataframe.py", 
line 379, in pyspark.sql.connect.dataframe.DataFrame.sortWithinPartitions
Failed example:
    df.sortWithinPartitions("age", ascending=False)
Exception raised:
    Traceback (most recent call last):
      File 
"/usr/local/Cellar/python@3.10/3.10.8/Frameworks/Python.framework/Versions/3.10/lib/python3.10/doctest.py",
 line 1350, in __run
        exec(compile(example.source, filename, "single",
      File "<doctest 
pyspark.sql.connect.dataframe.DataFrame.sortWithinPartitions[1]>", line 1, in 
<module>
        df.sortWithinPartitions("age", ascending=False)
    TypeError: DataFrame.sortWithinPartitions() got an unexpected keyword 
argument 'ascending'{code}


> Fix DataFrame.sample parameters
> -------------------------------
>
>                 Key: SPARK-41830
>                 URL: https://issues.apache.org/jira/browse/SPARK-41830
>             Project: Spark
>          Issue Type: Sub-task
>          Components: Connect
>    Affects Versions: 3.4.0
>            Reporter: Sandeep Singh
>            Priority: Major
>
> {code:java}
> File 
> "/Users/s.singh/personal/spark-oss/python/pyspark/sql/connect/dataframe.py", 
> line 401, in pyspark.sql.connect.dataframe.DataFrame.sample
> Failed example:
>     df.sample(0.5, 3).count()
> Exception raised:
>     Traceback (most recent call last):
>       File 
> "/usr/local/Cellar/python@3.10/3.10.8/Frameworks/Python.framework/Versions/3.10/lib/python3.10/doctest.py",
>  line 1350, in __run
>         exec(compile(example.source, filename, "single",
>       File "<doctest pyspark.sql.connect.dataframe.DataFrame.sample[1]>", 
> line 1, in <module>
>         df.sample(0.5, 3).count()
>     TypeError: DataFrame.sample() takes 2 positional arguments but 3 were 
> given
> **********************************************************************
> File 
> "/Users/s.singh/personal/spark-oss/python/pyspark/sql/connect/dataframe.py", 
> line 411, in pyspark.sql.connect.dataframe.DataFrame.sample
> Failed example:
>     df.sample(False, fraction=1.0).count()
> Exception raised:
>     Traceback (most recent call last):
>       File 
> "/usr/local/Cellar/python@3.10/3.10.8/Frameworks/Python.framework/Versions/3.10/lib/python3.10/doctest.py",
>  line 1350, in __run
>         exec(compile(example.source, filename, "single",
>       File "<doctest pyspark.sql.connect.dataframe.DataFrame.sample[6]>", 
> line 1, in <module>
>         df.sample(False, fraction=1.0).count()
>     TypeError: DataFrame.sample() got multiple values for argument 
> 'fraction'{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to