[
https://issues.apache.org/jira/browse/SPARK-21631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117780#comment-16117780
]
Liang-Chi Hsieh commented on SPARK-21631:
-
[~ibingoogle] I saw you did {{export
[
https://issues.apache.org/jira/browse/SPARK-21631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115448#comment-16115448
]
Sean Wong commented on SPARK-21631:
---
So, how to set NOLINT_ON_COMPILE? in which file? Thanks.
>
[
https://issues.apache.org/jira/browse/SPARK-21631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115186#comment-16115186
]
Liang-Chi Hsieh commented on SPARK-21631:
-
I've tried. {{NOLINT_ON_COMPILE=1 build/sbt "testOnly
[
https://issues.apache.org/jira/browse/SPARK-21631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114895#comment-16114895
]
Sean Wong commented on SPARK-21631:
---
Set a system environment variable NOLINT_ON_COMPILE is
[
https://issues.apache.org/jira/browse/SPARK-21631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114893#comment-16114893
]
Sean Wong commented on SPARK-21631:
---
I used to modify the source code like "import..." in Spark 1.6.1
[
https://issues.apache.org/jira/browse/SPARK-21631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114693#comment-16114693
]
Sean Wong commented on SPARK-21631:
---
I added NOLINT_ON_COMPILE in ~/.bashrc:
export
[
https://issues.apache.org/jira/browse/SPARK-21631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114532#comment-16114532
]
Liang-Chi Hsieh commented on SPARK-21631:
-
I've not tried. But from the building code, seems you
[
https://issues.apache.org/jira/browse/SPARK-21631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114525#comment-16114525
]
Sean Owen commented on SPARK-21631:
---
I don't know that the Maven build itself run scala style checks,
[
https://issues.apache.org/jira/browse/SPARK-21631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114518#comment-16114518
]
Sean Wong commented on SPARK-21631:
---
You are right. It is a style thing. Because I added the import at
[
https://issues.apache.org/jira/browse/SPARK-21631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114082#comment-16114082
]
Sean Owen commented on SPARK-21631:
---
Oh I see it is a style thing. OK, well, it's probably because the
[
https://issues.apache.org/jira/browse/SPARK-21631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114044#comment-16114044
]
Liang-Chi Hsieh commented on SPARK-21631:
-
I can make the same error by violating scala style
[
https://issues.apache.org/jira/browse/SPARK-21631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113992#comment-16113992
]
Sean Wong commented on SPARK-21631:
---
not compliant with Spark code style? But building with maven is ok
[
https://issues.apache.org/jira/browse/SPARK-21631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113775#comment-16113775
]
Liang-Chi Hsieh commented on SPARK-21631:
-
Looks like just it is not compliant with Spark code
13 matches
Mail list logo