[jira] [Assigned] (SPARK-24329) Remove comments filtering before parsing of CSV files
[ https://issues.apache.org/jira/browse/SPARK-24329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hyukjin Kwon reassigned SPARK-24329: Assignee: Maxim Gekk > Remove comments filtering before parsing of CSV files > - > > Key: SPARK-24329 > URL: https://issues.apache.org/jira/browse/SPARK-24329 > Project: Spark > Issue Type: Improvement > Components: SQL >Affects Versions: 2.3.0 >Reporter: Maxim Gekk >Assignee: Maxim Gekk >Priority: Minor > Fix For: 2.4.0 > > > Comments and whitespace filtering has been performed by uniVocity parser > already according to parser settings: > https://github.com/apache/spark/blob/branch-2.3/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala#L178-L180 > It is not necessary to do the same before parsing. Need to inspect all places > where the filterCommentAndEmpty method is called, and remove the former one > if it duplicates filtering of uniVocity parser. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Assigned] (SPARK-24329) Remove comments filtering before parsing of CSV files
[ https://issues.apache.org/jira/browse/SPARK-24329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apache Spark reassigned SPARK-24329: Assignee: (was: Apache Spark) > Remove comments filtering before parsing of CSV files > - > > Key: SPARK-24329 > URL: https://issues.apache.org/jira/browse/SPARK-24329 > Project: Spark > Issue Type: Improvement > Components: SQL >Affects Versions: 2.3.0 >Reporter: Maxim Gekk >Priority: Minor > > Comments and whitespace filtering has been performed by uniVocity parser > already according to parser settings: > https://github.com/apache/spark/blob/branch-2.3/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala#L178-L180 > It is not necessary to do the same before parsing. Need to inspect all places > where the filterCommentAndEmpty method is called, and remove the former one > if it duplicates filtering of uniVocity parser. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Assigned] (SPARK-24329) Remove comments filtering before parsing of CSV files
[ https://issues.apache.org/jira/browse/SPARK-24329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apache Spark reassigned SPARK-24329: Assignee: Apache Spark > Remove comments filtering before parsing of CSV files > - > > Key: SPARK-24329 > URL: https://issues.apache.org/jira/browse/SPARK-24329 > Project: Spark > Issue Type: Improvement > Components: SQL >Affects Versions: 2.3.0 >Reporter: Maxim Gekk >Assignee: Apache Spark >Priority: Minor > > Comments and whitespace filtering has been performed by uniVocity parser > already according to parser settings: > https://github.com/apache/spark/blob/branch-2.3/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala#L178-L180 > It is not necessary to do the same before parsing. Need to inspect all places > where the filterCommentAndEmpty method is called, and remove the former one > if it duplicates filtering of uniVocity parser. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
