[jira] [Commented] (SPARK-22443) AggregatedDialect doesn't override quoteIdentifier and other methods in JdbcDialects

2017-11-05 Thread Xiao Li (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-22443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239418#comment-16239418 ] Xiao Li commented on SPARK-22443: - It sounds your custom dialect is a good solution for your scenario.

[jira] [Commented] (SPARK-22443) AggregatedDialect doesn't override quoteIdentifier and other methods in JdbcDialects

2017-11-04 Thread Hongbo (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-22443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239312#comment-16239312 ] Hongbo commented on SPARK-22443: In our case, we want to map MySQL YEAR to ShortType instead of DateType.

[jira] [Commented] (SPARK-22443) AggregatedDialect doesn't override quoteIdentifier and other methods in JdbcDialects

2017-11-04 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-22443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239133#comment-16239133 ] Sean Owen commented on SPARK-22443: --- The semantics here are already odd. The methods might return

[jira] [Commented] (SPARK-22443) AggregatedDialect doesn't override quoteIdentifier and other methods in JdbcDialects

2017-11-04 Thread Hongbo (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-22443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239097#comment-16239097 ] Hongbo commented on SPARK-22443: [~srowen] Thanks for the quick response! I think returning the first

[jira] [Commented] (SPARK-22443) AggregatedDialect doesn't override quoteIdentifier and other methods in JdbcDialects

2017-11-04 Thread Apache Spark (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-22443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238858#comment-16238858 ] Apache Spark commented on SPARK-22443: -- User 'huaxingao' has created a pull request for this issue:

[jira] [Commented] (SPARK-22443) AggregatedDialect doesn't override quoteIdentifier and other methods in JdbcDialects

2017-11-03 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/SPARK-22443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238482#comment-16238482 ] Sean Owen commented on SPARK-22443: --- Good catch. I suppose that this and getTableExistsQuery and