[ https://issues.apache.org/jira/browse/SPARK-23609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387470#comment-16387470 ]
Apache Spark commented on SPARK-23609: -------------------------------------- User 'heary-cao' has created a pull request for this issue: https://github.com/apache/spark/pull/20747 > Test code does not conform to the test title > -------------------------------------------- > > Key: SPARK-23609 > URL: https://issues.apache.org/jira/browse/SPARK-23609 > Project: Spark > Issue Type: Improvement > Components: SQL, Tests > Affects Versions: 2.4.0 > Reporter: caoxuewen > Priority: Minor > > Currently, In testing EnsureRequirements's test cases to eliminate > ShuffleExchange, The test code is not in conformity with the purpose of the > test.These test cases are as follows: > 1、test("EnsureRequirements eliminates Exchange if child has same > partitioning") > The checking condition is that there is no ShuffleExchange in the physical > plan. = = 2 It's not accurate here. > 2、test("EnsureRequirements does not eliminate Exchange with different > partitioning") > The purpose of the test is to not eliminate ShuffleExchange, but its test > code is the same as test("EnsureRequirements eliminates Exchange if child has > same partitioning") -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org