[jira] [Commented] (SPARK-26126) Should put scala-library deps into root pom instead of spark-tags module
[
https://issues.apache.org/jira/browse/SPARK-26126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733848#comment-16733848
]
Hyukjin Kwon commented on SPARK-26126:
--
There are sometimes some reasons and it needs a lot of efforts to check the
history of, in particular, old codes. For instance, some modules could no need
for {{spark-tags}} intentionally, and use module specific annotation.
If you can track the history, check why it was added there, and are able to
elaborate why changing is correct, please go ahead for a PR. Don't forget to
double check SBT build as well.
Otherwise, let's just leave this resolved.
> Should put scala-library deps into root pom instead of spark-tags module
>
>
> Key: SPARK-26126
> URL: https://issues.apache.org/jira/browse/SPARK-26126
> Project: Spark
> Issue Type: Bug
> Components: Spark Core
>Affects Versions: 2.1.0, 2.3.0, 2.4.0
>Reporter: liupengcheng
>Priority: Minor
>
> When I do some backport in our custom spark, I notice some strange code from
> spark-tags module:
> {code:java}
>
>
> org.scala-lang
> scala-library
> ${scala.version}
>
>
> {code}
> As i known, should spark-tags only contains some annotation related classes
> or deps?
> should we put the scala-library deps to root pom?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-26126) Should put scala-library deps into root pom instead of spark-tags module
[
https://issues.apache.org/jira/browse/SPARK-26126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733836#comment-16733836
]
liupengcheng commented on SPARK-26126:
--
[~hyukjin.kwon] Yes, there is no actual problem happening, but put the
dependency of scala-library into spark-tags module is confusing.
If you agree that we shall put it into root pom for better understanding, I can
put a PR for this issue.
> Should put scala-library deps into root pom instead of spark-tags module
>
>
> Key: SPARK-26126
> URL: https://issues.apache.org/jira/browse/SPARK-26126
> Project: Spark
> Issue Type: Bug
> Components: Spark Core
>Affects Versions: 2.1.0, 2.3.0, 2.4.0
>Reporter: liupengcheng
>Priority: Minor
>
> When I do some backport in our custom spark, I notice some strange code from
> spark-tags module:
> {code:java}
>
>
> org.scala-lang
> scala-library
> ${scala.version}
>
>
> {code}
> As i known, should spark-tags only contains some annotation related classes
> or deps?
> should we put the scala-library deps to root pom?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-26126) Should put scala-library deps into root pom instead of spark-tags module
[
https://issues.apache.org/jira/browse/SPARK-26126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733796#comment-16733796
]
Hyukjin Kwon commented on SPARK-26126:
--
If there's no actual problem hapenning, I would leave this resolved.
> Should put scala-library deps into root pom instead of spark-tags module
>
>
> Key: SPARK-26126
> URL: https://issues.apache.org/jira/browse/SPARK-26126
> Project: Spark
> Issue Type: Bug
> Components: Spark Core
>Affects Versions: 2.1.0, 2.3.0, 2.4.0
>Reporter: liupengcheng
>Priority: Minor
>
> When I do some backport in our custom spark, I notice some strange code from
> spark-tags module:
> {code:java}
>
>
> org.scala-lang
> scala-library
> ${scala.version}
>
>
> {code}
> As i known, should spark-tags only contains some annotation related classes
> or deps?
> should we put the scala-library deps to root pom?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-26126) Should put scala-library deps into root pom instead of spark-tags module
[
https://issues.apache.org/jira/browse/SPARK-26126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733795#comment-16733795
]
Hyukjin Kwon commented on SPARK-26126:
--
It matters since JIRA's supposed to file an issue. Questions should go to
mailing list.
What problem does it cause?
> Should put scala-library deps into root pom instead of spark-tags module
>
>
> Key: SPARK-26126
> URL: https://issues.apache.org/jira/browse/SPARK-26126
> Project: Spark
> Issue Type: Bug
> Components: Spark Core
>Affects Versions: 2.1.0, 2.3.0, 2.4.0
>Reporter: liupengcheng
>Priority: Minor
>
> When I do some backport in our custom spark, I notice some strange code from
> spark-tags module:
> {code:java}
>
>
> org.scala-lang
> scala-library
> ${scala.version}
>
>
> {code}
> As i known, should spark-tags only contains some annotation related classes
> or deps?
> should we put the scala-library deps to root pom?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-26126) Should put scala-library deps into root pom instead of spark-tags module
[
https://issues.apache.org/jira/browse/SPARK-26126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733738#comment-16733738
]
liupengcheng commented on SPARK-26126:
--
[~hyukjin.kwon] it's an issue, it's really doesn't matter, but it's just
confusing.
> Should put scala-library deps into root pom instead of spark-tags module
>
>
> Key: SPARK-26126
> URL: https://issues.apache.org/jira/browse/SPARK-26126
> Project: Spark
> Issue Type: Bug
> Components: Spark Core
>Affects Versions: 2.1.0, 2.3.0, 2.4.0
>Reporter: liupengcheng
>Priority: Minor
>
> When I do some backport in our custom spark, I notice some strange code from
> spark-tags module:
> {code:java}
>
>
> org.scala-lang
> scala-library
> ${scala.version}
>
>
> {code}
> As i known, should spark-tags only contains some annotation related classes
> or deps?
> should we put the scala-library deps to root pom?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-26126) Should put scala-library deps into root pom instead of spark-tags module
[
https://issues.apache.org/jira/browse/SPARK-26126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694333#comment-16694333
]
Hyukjin Kwon commented on SPARK-26126:
--
Hi [~liupengcheng], is it a question or an issue?
> Should put scala-library deps into root pom instead of spark-tags module
>
>
> Key: SPARK-26126
> URL: https://issues.apache.org/jira/browse/SPARK-26126
> Project: Spark
> Issue Type: Bug
> Components: Spark Core
>Affects Versions: 2.1.0, 2.3.0, 2.4.0
>Reporter: liupengcheng
>Priority: Minor
>
> When I do some backport in our custom spark, I notice some strange code from
> spark-tags module:
> {code:java}
>
>
> org.scala-lang
> scala-library
> ${scala.version}
>
>
> {code}
> As i known, should spark-tags only contains some annotation related classes
> or deps?
> should we put the scala-library deps to root pom?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
