[ 
https://issues.apache.org/jira/browse/STORM-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ethan Li updated STORM-3734:
----------------------------
    Description: 
The IntegerValidator allows the non-integer object, like Double(1.0).
https://github.com/apache/storm/blob/7bef73a6faa14558ef254efe74cbe4bfef81c2e2/storm-client/src/jvm/org/apache/storm/validation/ConfigValidation.java#L404-L415

It can be reproduced by 

{code:java}
        IntegerValidator validator = new IntegerValidator();
        validator.validateInteger("test", 1.0);
{code}

More details at https://github.com/apache/storm/pull/3365#issuecomment-754775896


  was:
The IntegerValidator allows the non-integer object, like Double(1.0).
https://github.com/apache/storm/blob/7bef73a6faa14558ef254efe74cbe4bfef81c2e2/storm-client/src/jvm/org/apache/storm/validation/ConfigValidation.java#L404-L415

It can be reproduced by 

{code:java}
        IntegerValidator validator = new IntegerValidator();
        validator.validateInteger("test", 1.0);
{code}



> IntegerValidator doesn't force the object type to be Integer
> ------------------------------------------------------------
>
>                 Key: STORM-3734
>                 URL: https://issues.apache.org/jira/browse/STORM-3734
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Ethan Li
>            Priority: Major
>
> The IntegerValidator allows the non-integer object, like Double(1.0).
> https://github.com/apache/storm/blob/7bef73a6faa14558ef254efe74cbe4bfef81c2e2/storm-client/src/jvm/org/apache/storm/validation/ConfigValidation.java#L404-L415
> It can be reproduced by 
> {code:java}
>         IntegerValidator validator = new IntegerValidator();
>         validator.validateInteger("test", 1.0);
> {code}
> More details at 
> https://github.com/apache/storm/pull/3365#issuecomment-754775896



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to