[
https://issues.apache.org/jira/browse/STORM-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jungtaek Lim resolved STORM-3143.
---------------------------------
Resolution: Fixed
Thanks [~zhengdai], I merged into master.
> Unnecessary inclusion of empty match result in Json
> ---------------------------------------------------
>
> Key: STORM-3143
> URL: https://issues.apache.org/jira/browse/STORM-3143
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-webapp
> Affects Versions: 2.0.0
> Reporter: Zhengdai Hu
> Assignee: Zhengdai Hu
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.0.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> `FindNMatches()` didn't correctly filter out empty match result in
> `substringSearch()` and hence send back an empty map to user. I don't know if
> this the desired behavior but a fix to current behavior will make metrics for
> logviewer easier to implement.
> An example of current behavior:
> {code:json}
> {
> "fileOffset": 1,
> "searchString": "sdf",
> "matches": [
> {
> "searchString": "sdf",
> "fileName": "word-count-1-1530815972/6701/worker.log",
> "matches": [],
> "port": "6701",
> "isDaemon": "no",
> "startByteOffset": 0
> }
> ]
> }
> {code}
> Desired behavior:
> {code:json}
> {
> "fileOffset": 1,
> "searchString": "sdf",
> "matches": []
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
