[GitHub] [struts] sonarcloud[bot] commented on pull request #651: [WW-5277] Upgrades Freemarker to version 2.3.32

2023-01-15 Thread GitBox
sonarcloud[bot] commented on PR #651: URL: https://github.com/apache/struts/pull/651#issuecomment-1383569987 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts-site] asf-ci commented on pull request #182: Cleans up information about how to use CSP related interceptors

2023-01-10 Thread GitBox
asf-ci commented on PR #182: URL: https://github.com/apache/struts-site/pull/182#issuecomment-1378341325 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [struts] sonarcloud[bot] commented on pull request #650: [WW-5273] Supports file upload using Servlet API 3.1

2022-12-30 Thread GitBox
sonarcloud[bot] commented on PR #650: URL: https://github.com/apache/struts/pull/650#issuecomment-1367965271 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #650: [WW-5273] Supports file upload using Servlet API 3.1

2022-12-30 Thread GitBox
sonarcloud[bot] commented on PR #650: URL: https://github.com/apache/struts/pull/650#issuecomment-1367819739 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #649: [WW-5272] Extends to support java.sql.Time

2022-12-29 Thread GitBox
sonarcloud[bot] commented on PR #649: URL: https://github.com/apache/struts/pull/649#issuecomment-1367202782 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #650: [WW-5273] Supports file upload using Servlet API 3.1

2022-12-29 Thread GitBox
sonarcloud[bot] commented on PR #650: URL: https://github.com/apache/struts/pull/650#issuecomment-1367202233 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] github-code-scanning[bot] commented on a diff in pull request #650: [WW-5273] Supports file upload using Servlet API 3.1

2022-12-29 Thread GitBox
github-code-scanning[bot] commented on code in PR #650: URL: https://github.com/apache/struts/pull/650#discussion_r1058848403 ## core/src/main/java/org/apache/struts2/dispatcher/multipart/ServletMultiPartRequest.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software

[GitHub] [struts] sonarcloud[bot] commented on pull request #650: [WW-5273] Supports file upload using Servlet API 3.1

2022-12-29 Thread GitBox
sonarcloud[bot] commented on PR #650: URL: https://github.com/apache/struts/pull/650#issuecomment-1367194607 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #649: [WW-5272] Extends to support java.sql.Time

2022-12-28 Thread GitBox
sonarcloud[bot] commented on PR #649: URL: https://github.com/apache/struts/pull/649#issuecomment-1366497044 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] kusalk commented on pull request #648: WW-5270 Fix forwarding from Struts excluded URL

2022-12-20 Thread GitBox
kusalk commented on PR #648: URL: https://github.com/apache/struts/pull/648#issuecomment-1359204527 My initial ThreadLocal based approach to reworking the request cleanup process was not functioning as intended. I've reverted to tracking filter recursion as a request attribute but have stil

[GitHub] [struts] sonarcloud[bot] commented on pull request #647: [WW-5269] Upgrades Jackson to version 2.14.1

2022-12-18 Thread GitBox
sonarcloud[bot] commented on PR #647: URL: https://github.com/apache/struts/pull/647#issuecomment-1356726231 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] lukaszlenart commented on pull request #645: WW-5265 Allow removal of a single/specific container provider

2022-12-13 Thread GitBox
lukaszlenart commented on PR #645: URL: https://github.com/apache/struts/pull/645#issuecomment-1350445965 LGTM 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [struts] dependabot[bot] commented on pull request #644: Bump spring-web from 5.3.23 to 6.0.0

2022-12-12 Thread GitBox
dependabot[bot] commented on PR #644: URL: https://github.com/apache/struts/pull/644#issuecomment-1347882394 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

[GitHub] [struts] lukaszlenart commented on pull request #645: WW-5265 Allow removal of a single/specific container provider

2022-12-12 Thread GitBox
lukaszlenart commented on PR #645: URL: https://github.com/apache/struts/pull/645#issuecomment-1347845099 @kusalk could you rebase this PR over the `master` branch? I found one issue that prevents running Sonar scan, sorry for that :( Depends on #646 -- This is an automated message f

[GitHub] [struts] sonarcloud[bot] commented on pull request #646: [WW-5264] Removes XSLTResult from struts-default.xml as it was moved in to plugin

2022-12-12 Thread GitBox
sonarcloud[bot] commented on PR #646: URL: https://github.com/apache/struts/pull/646#issuecomment-1347823908 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #643: Applies permission to GH workflows

2022-12-09 Thread GitBox
sonarcloud[bot] commented on PR #643: URL: https://github.com/apache/struts/pull/643#issuecomment-1344073235 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #641: [WW-5264] Moves XSLT result into a dedicated plugin

2022-12-09 Thread GitBox
sonarcloud[bot] commented on PR #641: URL: https://github.com/apache/struts/pull/641#issuecomment-1344023054 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #641: [WW-5264] Moves XSLT result into a dedicated plugin

2022-12-09 Thread GitBox
sonarcloud[bot] commented on PR #641: URL: https://github.com/apache/struts/pull/641#issuecomment-1344004493 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] lukaszlenart commented on pull request #642: WW-5199 Allow forwarding from/to actions

2022-12-09 Thread GitBox
lukaszlenart commented on PR #642: URL: https://github.com/apache/struts/pull/642#issuecomment-1343982607 Thanks a lot! I had no idea that the fix would so easy :) LGTM 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [struts] sonarcloud[bot] commented on pull request #641: [WW-5264] Moves XSLT result into a dedicated plugin

2022-12-04 Thread GitBox
sonarcloud[bot] commented on PR #641: URL: https://github.com/apache/struts/pull/641#issuecomment-1336473888 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #641: [WW-5264] Moves XSLT result into a dedicated plugin

2022-12-04 Thread GitBox
sonarcloud[bot] commented on PR #641: URL: https://github.com/apache/struts/pull/641#issuecomment-1336393522 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #640: [WW-5262] Extracts excluded classes and beans into dedicated XML config files

2022-12-04 Thread GitBox
sonarcloud[bot] commented on PR #640: URL: https://github.com/apache/struts/pull/640#issuecomment-1336371187 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] TheFergus commented on pull request #430: WW-5084: Add Content Security Policy support to Struts

2022-12-01 Thread GitBox
TheFergus commented on PR #430: URL: https://github.com/apache/struts/pull/430#issuecomment-1333470726 @lukaszlenart Hi, for , if the src of the tags needs variables, what should I do? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [struts] sonarcloud[bot] commented on pull request #640: [WW-5262] Extracts excluded classes and beans into dedicated XML config files

2022-11-30 Thread GitBox
sonarcloud[bot] commented on PR #640: URL: https://github.com/apache/struts/pull/640#issuecomment-1333285941 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #639: [WW-5263] Uses proper names for CSP, COOP and COEP interceptors

2022-11-30 Thread GitBox
sonarcloud[bot] commented on PR #639: URL: https://github.com/apache/struts/pull/639#issuecomment-1333273808 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts-site] asf-ci commented on pull request #178: Adds missing info about CPS interceptor

2022-11-28 Thread GitBox
asf-ci commented on PR #178: URL: https://github.com/apache/struts-site/pull/178#issuecomment-1329223942 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [struts-site] asf-ci commented on pull request #178: Adds missing info about CPS interceptor

2022-11-28 Thread GitBox
asf-ci commented on PR #178: URL: https://github.com/apache/struts-site/pull/178#issuecomment-1329213248 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [struts] sonarcloud[bot] commented on pull request #638: Defines to autolink PRs to issues in ASF JIRA

2022-11-28 Thread GitBox
sonarcloud[bot] commented on PR #638: URL: https://github.com/apache/struts/pull/638#issuecomment-1328885923 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts-site] asf-ci commented on pull request #177: Adds an announcement about Struts 6.1.1

2022-11-27 Thread GitBox
asf-ci commented on PR #177: URL: https://github.com/apache/struts-site/pull/177#issuecomment-1328616339 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [struts-site] asf-ci commented on pull request #177: Adds an announcement about Struts 6.1.1

2022-11-27 Thread GitBox
asf-ci commented on PR #177: URL: https://github.com/apache/struts-site/pull/177#issuecomment-1328611347 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [struts] sonarcloud[bot] commented on pull request #637: Updates OWASP suppressions as some reports are false positive

2022-11-27 Thread GitBox
sonarcloud[bot] commented on PR #637: URL: https://github.com/apache/struts/pull/637#issuecomment-1328191269 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #635: [WW-4173] Introduces a dedicated interface to allow conditionally disabling a given interceptor

2022-11-11 Thread GitBox
sonarcloud[bot] commented on PR #635: URL: https://github.com/apache/struts/pull/635#issuecomment-1311789541 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #635: [WW-4173] Introduces a dedicated interface to allow conditionally disabling a given interceptor

2022-11-11 Thread GitBox
sonarcloud[bot] commented on PR #635: URL: https://github.com/apache/struts/pull/635#issuecomment-1311407935 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #636: [WW-5260] Introduces a constant to set submitUnchecked attribute of checkbox tag globally

2022-11-11 Thread GitBox
sonarcloud[bot] commented on PR #636: URL: https://github.com/apache/struts/pull/636#issuecomment-1311394775 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #635: [WW-4173] Introduces a dedicated interface to allow conditionally disabling a given interceptor

2022-11-11 Thread GitBox
sonarcloud[bot] commented on PR #635: URL: https://github.com/apache/struts/pull/635#issuecomment-1311388368 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #636: [WW-5260] Introduces a constant to set submitUnchecked attribute of checkbox tag globally

2022-11-11 Thread GitBox
sonarcloud[bot] commented on PR #636: URL: https://github.com/apache/struts/pull/636#issuecomment-1311383764 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #635: [WW-4173] Introduces a dedicated interface to allow conditionally disabling a given interceptor

2022-11-09 Thread GitBox
sonarcloud[bot] commented on PR #635: URL: https://github.com/apache/struts/pull/635#issuecomment-1308956384 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #635: [WW-4173] Introduces a dedicated interface to allow conditionally disabling a given interceptor

2022-11-09 Thread GitBox
sonarcloud[bot] commented on PR #635: URL: https://github.com/apache/struts/pull/635#issuecomment-1308937364 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #634: [WW-5259] Extracts UrlHelper#parseQueryString into a dedicated bean

2022-11-07 Thread GitBox
sonarcloud[bot] commented on PR #634: URL: https://github.com/apache/struts/pull/634#issuecomment-1305463156 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #634: [WW-5259] Extracts UrlHelper#parseQueryString into a dedicated bean

2022-11-06 Thread GitBox
sonarcloud[bot] commented on PR #634: URL: https://github.com/apache/struts/pull/634#issuecomment-1304860888 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #634: [WW-5259] Extracts UrlHelper#parseQueryString into a dedicated bean

2022-11-06 Thread GitBox
sonarcloud[bot] commented on PR #634: URL: https://github.com/apache/struts/pull/634#issuecomment-1304857474 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #632: [WW-5257] Cleans up template

2022-11-06 Thread GitBox
sonarcloud[bot] commented on PR #632: URL: https://github.com/apache/struts/pull/632#issuecomment-1304835401 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #633: [WW-5258] Upgrades Struts Annotations to version 1.0.8

2022-11-05 Thread GitBox
sonarcloud[bot] commented on PR #633: URL: https://github.com/apache/struts/pull/633#issuecomment-1304594016 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts-site] asf-ci commented on pull request #176: [WW-5254] Adds description about the Async plugin

2022-11-05 Thread GitBox
asf-ci commented on PR #176: URL: https://github.com/apache/struts-site/pull/176#issuecomment-1304587265 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [struts-site] asf-ci commented on pull request #176: [WW-5254] Adds description about the Async plugin

2022-11-05 Thread GitBox
asf-ci commented on PR #176: URL: https://github.com/apache/struts-site/pull/176#issuecomment-1304584791 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [struts-site] asf-ci commented on pull request #176: [WW-5254] Adds description about the Async plugin

2022-11-05 Thread GitBox
asf-ci commented on PR #176: URL: https://github.com/apache/struts-site/pull/176#issuecomment-1304583086 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [struts] sonarcloud[bot] commented on pull request #632: [WW-5257] Cleans up template

2022-11-05 Thread GitBox
sonarcloud[bot] commented on PR #632: URL: https://github.com/apache/struts/pull/632#issuecomment-1304441338 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #631: [WW-5240] Uses doubleOn* attributes in the template

2022-11-05 Thread GitBox
sonarcloud[bot] commented on PR #631: URL: https://github.com/apache/struts/pull/631#issuecomment-1304433864 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #630: [WW-4514] Fixes building query string with empty parameters

2022-11-04 Thread GitBox
sonarcloud[bot] commented on PR #630: URL: https://github.com/apache/struts/pull/630#issuecomment-1303106330 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #630: [WW-4514] Fixes building query string with empty parameters

2022-11-04 Thread GitBox
sonarcloud[bot] commented on PR #630: URL: https://github.com/apache/struts/pull/630#issuecomment-1303097915 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #630: [WW-4514] Fixes building query string with empty parameters

2022-11-04 Thread GitBox
sonarcloud[bot] commented on PR #630: URL: https://github.com/apache/struts/pull/630#issuecomment-1303089753 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] github-code-scanning[bot] commented on a diff in pull request #630: [WW-4514] Fixes building query string with empty parameters

2022-11-04 Thread GitBox
github-code-scanning[bot] commented on code in PR #630: URL: https://github.com/apache/struts/pull/630#discussion_r1013716930 ## core/src/main/java/org/apache/struts2/url/StrutsParametersStringBuilder.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [struts] sonarcloud[bot] commented on pull request #629: [WW-5255] Fixes and and uses them across tags

2022-11-02 Thread GitBox
sonarcloud[bot] commented on PR #629: URL: https://github.com/apache/struts/pull/629#issuecomment-1300139200 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #629: [WW-5255] Fixes and and uses them across tags

2022-11-02 Thread GitBox
sonarcloud[bot] commented on PR #629: URL: https://github.com/apache/struts/pull/629#issuecomment-1299923697 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #629: [WW-5255] Fixes and and uses them across tags

2022-11-02 Thread GitBox
sonarcloud[bot] commented on PR #629: URL: https://github.com/apache/struts/pull/629#issuecomment-1299713390 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #628: [WW-5252] Disables parsing external entities

2022-10-30 Thread GitBox
sonarcloud[bot] commented on PR #628: URL: https://github.com/apache/struts/pull/628#issuecomment-1296230813 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #628: [WW-5252] Disables parsing external entities

2022-10-27 Thread GitBox
sonarcloud[bot] commented on PR #628: URL: https://github.com/apache/struts/pull/628#issuecomment-1293401882 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #627: [WW-4440] Adds basic README.md to all submodules

2022-10-27 Thread GitBox
sonarcloud[bot] commented on PR #627: URL: https://github.com/apache/struts/pull/627#issuecomment-1293356676 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #626: [WW-4692] Extracts Url encoder/decoder into dedicated interfaces/classes

2022-10-26 Thread GitBox
sonarcloud[bot] commented on PR #626: URL: https://github.com/apache/struts/pull/626#issuecomment-1291926261 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #626: [WW-4692] Extracts Url encoder/decoder into dedicated interfaces/classes

2022-10-26 Thread GitBox
sonarcloud[bot] commented on PR #626: URL: https://github.com/apache/struts/pull/626#issuecomment-1291783110 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #626: [WW-4692] Extracts Url encoder/decoder into dedicated interfaces/classes

2022-10-26 Thread GitBox
sonarcloud[bot] commented on PR #626: URL: https://github.com/apache/struts/pull/626#issuecomment-1291759538 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #626: [WW-4692] Extracts Url encoder/decoder into dedicated interfaces/classes

2022-10-26 Thread GitBox
sonarcloud[bot] commented on PR #626: URL: https://github.com/apache/struts/pull/626#issuecomment-1291714077 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #626: [WW-4692] Extracts Url encoder/decoder into dedicated interfaces/classes

2022-10-25 Thread GitBox
sonarcloud[bot] commented on PR #626: URL: https://github.com/apache/struts/pull/626#issuecomment-1290653060 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #625: [WW-4173] Adds support to disable processing a given interceptor

2022-10-23 Thread GitBox
sonarcloud[bot] commented on PR #625: URL: https://github.com/apache/struts/pull/625#issuecomment-1288489186 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #625: [WW-4173] Adds support to disable processing a given interceptor

2022-10-21 Thread GitBox
sonarcloud[bot] commented on PR #625: URL: https://github.com/apache/struts/pull/625#issuecomment-1287350762 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #624: [WW-5137] Removes deprecated class attribute

2022-10-21 Thread GitBox
sonarcloud[bot] commented on PR #624: URL: https://github.com/apache/struts/pull/624#issuecomment-1286845441 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #623: [WW-3725] Removes unused template

2022-10-21 Thread GitBox
sonarcloud[bot] commented on PR #623: URL: https://github.com/apache/struts/pull/623#issuecomment-1286725426 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #622: [WW-5133] Drops labelposition attribute

2022-10-21 Thread GitBox
sonarcloud[bot] commented on PR #622: URL: https://github.com/apache/struts/pull/622#issuecomment-1286669661 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #621: [WW-3737] Allows to define a custom separator used to split patterns

2022-10-19 Thread GitBox
sonarcloud[bot] commented on PR #621: URL: https://github.com/apache/struts/pull/621#issuecomment-1283906441 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #620: [WW-3529] Fixes using RegEx related characters in named pattern

2022-10-19 Thread GitBox
sonarcloud[bot] commented on PR #620: URL: https://github.com/apache/struts/pull/620#issuecomment-1283783418 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #619: [WW-5230] Upgrades OGNL to version 3.3.4

2022-10-19 Thread GitBox
sonarcloud[bot] commented on PR #619: URL: https://github.com/apache/struts/pull/619#issuecomment-1283726980 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #608: [WW-5233] Include Apache Tiles code base in the Tiles plugin

2022-10-19 Thread GitBox
sonarcloud[bot] commented on PR #608: URL: https://github.com/apache/struts/pull/608#issuecomment-1283541842 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] dependabot[bot] commented on pull request #617: Bump jackson-databind from 2.13.2.1 to 2.13.4.1

2022-10-19 Thread GitBox
dependabot[bot] commented on PR #617: URL: https://github.com/apache/struts/pull/617#issuecomment-1283534514 Looks like com.fasterxml.jackson.core:jackson-databind is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [struts] sonarcloud[bot] commented on pull request #608: [WW-5233] Include Apache Tiles code base in the Tiles plugin

2022-10-19 Thread GitBox
sonarcloud[bot] commented on PR #608: URL: https://github.com/apache/struts/pull/608#issuecomment-1283527535 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #618: [WW-5245] Upgrades Jackson Databind to version 2.13.4.2

2022-10-18 Thread GitBox
sonarcloud[bot] commented on PR #618: URL: https://github.com/apache/struts/pull/618#issuecomment-1283523374 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #615: [WW-2815] Refactors XStreamHandler to allow to provide a custom configuration

2022-10-17 Thread GitBox
sonarcloud[bot] commented on PR #615: URL: https://github.com/apache/struts/pull/615#issuecomment-1280528962 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #615: [WW-2815] Refactors XStreamHandler to allow to provide a custom configuration

2022-10-17 Thread GitBox
sonarcloud[bot] commented on PR #615: URL: https://github.com/apache/struts/pull/615#issuecomment-1280471265 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #615: [WW-2815] Refactors XStreamHandler to allow to provide a custom configuration

2022-10-17 Thread GitBox
sonarcloud[bot] commented on PR #615: URL: https://github.com/apache/struts/pull/615#issuecomment-1280447391 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #615: [WW-2815] Refactors XStreamHandler to allow to provide a custom configuration

2022-10-17 Thread GitBox
sonarcloud[bot] commented on PR #615: URL: https://github.com/apache/struts/pull/615#issuecomment-1280381006 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #614: [WW-5244] Upgrades commons-text to version 1.10.0

2022-10-16 Thread GitBox
sonarcloud[bot] commented on PR #614: URL: https://github.com/apache/struts/pull/614#issuecomment-1279907503 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] burtonrhodes commented on pull request #611: [WW-5241] Fixes issue with includeParams=all when using exec & wait

2022-10-14 Thread GitBox
burtonrhodes commented on PR #611: URL: https://github.com/apache/struts/pull/611#issuecomment-1278898933 This fix is working nicely on my end. Many thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [struts] sonarcloud[bot] commented on pull request #613: [WW-5242] Marks struts.mapper.action.prefix.crossNamespaces as deprecated

2022-10-14 Thread GitBox
sonarcloud[bot] commented on PR #613: URL: https://github.com/apache/struts/pull/613#issuecomment-1278852054 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #608: [WW-5233] Include Apache Tiles code base in the Tiles plugin

2022-10-14 Thread GitBox
sonarcloud[bot] commented on PR #608: URL: https://github.com/apache/struts/pull/608#issuecomment-1278836593 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #611: [WW-5241] Fixes issue with includeParams=all when using exec & wait

2022-10-14 Thread GitBox
sonarcloud[bot] commented on PR #611: URL: https://github.com/apache/struts/pull/611#issuecomment-1278831083 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #611: [WW-5241] Fixes issue with includeParams=all when using exec & wait

2022-10-14 Thread GitBox
sonarcloud[bot] commented on PR #611: URL: https://github.com/apache/struts/pull/611#issuecomment-1278797631 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #611: [WW-5241] Fixes issue with includeParams=all when using exec & wait

2022-10-14 Thread GitBox
sonarcloud[bot] commented on PR #611: URL: https://github.com/apache/struts/pull/611#issuecomment-1278752178 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] lukaszlenart commented on pull request #611: [WW-5241] Fixes issue with includeParams=all when using exec & wait

2022-10-14 Thread GitBox
lukaszlenart commented on PR #611: URL: https://github.com/apache/struts/pull/611#issuecomment-1278745968 @burtonrhodes fixed, the bug was in `DefaultActionMapper` which ignored DMI flag and was appending `!method` every time. -- This is an automated message from the Apache Git Service. T

[GitHub] [struts] sonarcloud[bot] commented on pull request #611: [WW-5241] Fixes issue with includeParams=all when using exec & wait

2022-10-13 Thread GitBox
sonarcloud[bot] commented on PR #611: URL: https://github.com/apache/struts/pull/611#issuecomment-1277645267 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] burtonrhodes commented on pull request #571: [WW-5190] Fixes StackOverflowException when dispatching request

2022-10-13 Thread GitBox
burtonrhodes commented on PR #571: URL: https://github.com/apache/struts/pull/571#issuecomment-1277509217 Done! [https://issues.apache.org/jira/browse/WW-5241](https://issues.apache.org/jira/browse/WW-5241) -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [struts] lukaszlenart commented on pull request #571: [WW-5190] Fixes StackOverflowException when dispatching request

2022-10-13 Thread GitBox
lukaszlenart commented on PR #571: URL: https://github.com/apache/struts/pull/571#issuecomment-1277454643 Ok, so please register a new JIRA ticket and we can start working on solution after figuring out what's wrong. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [struts] burtonrhodes commented on pull request #571: [WW-5190] Fixes StackOverflowException when dispatching request

2022-10-13 Thread GitBox
burtonrhodes commented on PR #571: URL: https://github.com/apache/struts/pull/571#issuecomment-1277451158 I don't use DMI, but have no specific setting in my struts.xml file regarding it. However, given your suggestion, I specifically disabled DMI to see if that would help - but the result

[GitHub] [struts] lukaszlenart commented on pull request #571: [WW-5190] Fixes StackOverflowException when dispatching request

2022-10-12 Thread GitBox
lukaszlenart commented on PR #571: URL: https://github.com/apache/struts/pull/571#issuecomment-1277092879 @burtonrhodes do you use DMI? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [struts] burtonrhodes commented on pull request #571: [WW-5190] Fixes StackOverflowException when dispatching request

2022-10-10 Thread GitBox
burtonrhodes commented on PR #571: URL: https://github.com/apache/struts/pull/571#issuecomment-1273516984 This change is breaking my ExecuteAndWait implementations using the [recommended refresh implementation](https://struts.apache.org/core-developers/execute-and-wait-interceptor). The re

[GitHub] [struts] sonarcloud[bot] commented on pull request #608: [WW-5233] Include Apache Tiles code base in the Tiles plugin

2022-10-07 Thread GitBox
sonarcloud[bot] commented on PR #608: URL: https://github.com/apache/struts/pull/608#issuecomment-1271387876 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] gregh3269 commented on pull request #610: Add missing classes and tld definition.

2022-10-07 Thread GitBox
gregh3269 commented on PR #610: URL: https://github.com/apache/struts/pull/610#issuecomment-1271346962 Coveralls thingy GetAsStringTag from: private GetAsStringModel model = new GetAsStringModel()); to: private GetAsStringModel model = new GetAsStringModel(new DefaultAttributeRe

[GitHub] [struts] coveralls commented on pull request #610: Add missing classes and tld definition.

2022-10-07 Thread GitBox
coveralls commented on PR #610: URL: https://github.com/apache/struts/pull/610#issuecomment-1271335631 [![Coverage Status](https://coveralls.io/builds/53088484/badge)](https://coveralls.io/builds/53088484) Coverage decreased (-0.3%) to 51.819% when pulling **b3f1c1e6d267e4110176f

[GitHub] [struts] sonarcloud[bot] commented on pull request #608: [WW-5233] Include Apache Tiles code base in the Tiles plugin

2022-10-05 Thread GitBox
sonarcloud[bot] commented on PR #608: URL: https://github.com/apache/struts/pull/608#issuecomment-1265147087 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #608: [WW-5233] Include Apache Tiles code base in the Tiles plugin

2022-10-05 Thread GitBox
sonarcloud[bot] commented on PR #608: URL: https://github.com/apache/struts/pull/608#issuecomment-1265021808 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #608: [WW-5233] Include Apache Tiles code base in the Tiles plugin

2022-10-05 Thread GitBox
sonarcloud[bot] commented on PR #608: URL: https://github.com/apache/struts/pull/608#issuecomment-1264983730 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #608: [WW-5233] Include Apache Tiles code base in the Tiles plugin

2022-10-05 Thread GitBox
sonarcloud[bot] commented on PR #608: URL: https://github.com/apache/struts/pull/608#issuecomment-1264686370 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

  1   2   3   4   5   6   7   8   9   10   >