[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194185#comment-16194185 ] ASF GitHub Bot commented on WW-4849: lukaszlenart closed pull request #165: WW-4849 Restore ObjectFactory

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-10-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194186#comment-16194186 ] ASF subversion and git services commented on WW-4849: - Commit

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194183#comment-16194183 ] ASF GitHub Bot commented on WW-4849: lukaszlenart closed pull request #168: WW-4849: Initializable

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182056#comment-16182056 ] ASF GitHub Bot commented on WW-4849: gstein closed pull request #168: WW-4849: Initializable interface

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182057#comment-16182057 ] ASF GitHub Bot commented on WW-4849: lukaszlenart opened a new pull request #168: WW-4849: Initializable

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-26 Thread Lukasz Lenart (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180351#comment-16180351 ] Lukasz Lenart commented on WW-4849: --- PR is here https://github.com/apache/struts/pull/168 (after migrating

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-26 Thread Lukasz Lenart (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180324#comment-16180324 ] Lukasz Lenart commented on WW-4849: --- I have a solution, let me prepare a PR > ObjectFactory constructor

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-22 Thread surahma (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176334#comment-16176334 ] surahma commented on WW-4849: - [~lukaszlenart] yes thats right i am using it > ObjectFactory constructor

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-22 Thread Lukasz Lenart (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176317#comment-16176317 ] Lukasz Lenart commented on WW-4849: --- Thanks, you are using this plugin

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-22 Thread surahma (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176265#comment-16176265 ] surahma commented on WW-4849: - [~lukaszlenart] i think , when i am use struts 2.5.10.1 the issue is not problem

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-22 Thread Lukasz Lenart (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176256#comment-16176256 ] Lukasz Lenart commented on WW-4849: --- [~jaya123] not yet, can you post more details? > ObjectFactory

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-22 Thread surahma (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176253#comment-16176253 ] surahma commented on WW-4849: - are the problem solved? cause i am same problem when upgrade to struts 2.5.13

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-21 Thread Lukasz Lenart (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174364#comment-16174364 ] Lukasz Lenart commented on WW-4849: --- I think I have figured out a possible solution without breaking things

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-13 Thread Lukasz Lenart (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164223#comment-16164223 ] Lukasz Lenart commented on WW-4849: --- To be honest I'm not fully convinced that the current solution with

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-11 Thread Mitth'raw'nuruodo (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162196#comment-16162196 ] Mitth'raw'nuruodo commented on WW-4849: --- Can I just clarify the answer to my question above? Subclasses

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-11 Thread Lukasz Lenart (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161883#comment-16161883 ] Lukasz Lenart commented on WW-4849: --- [~thrawnca] I would ask you to join the discussion here [1] (or I can

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-10 Thread Lukasz Lenart (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160675#comment-16160675 ] Lukasz Lenart commented on WW-4849: --- Struts does not follow the semantic versioning, just because of using

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-10 Thread Mitth'raw'nuruodo (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160514#comment-16160514 ] Mitth'raw'nuruodo commented on WW-4849: --- OK, if this change was really necessary, then: - it should

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-08 Thread Aleksandr Mashchenko (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159009#comment-16159009 ] Aleksandr Mashchenko commented on WW-4849: -- _ Any other custom object factories will still be

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-08 Thread Lukasz Lenart (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158269#comment-16158269 ] Lukasz Lenart commented on WW-4849: --- The main problem here is with our (Struts) DI mechanism which in fact

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-07 Thread Mitth'raw'nuruodo (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157803#comment-16157803 ] Mitth'raw'nuruodo commented on WW-4849: --- "The note about default constructor in this document is very

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-07 Thread Aleksandr Mashchenko (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157721#comment-16157721 ] Aleksandr Mashchenko commented on WW-4849: -- The note about default constructor in this document is

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-06 Thread Mitth'raw'nuruodo (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156121#comment-16156121 ] Mitth'raw'nuruodo commented on WW-4849: --- [~aleksandr-m] I'm not sure how much of your previous comment

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-06 Thread Aleksandr Mashchenko (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155643#comment-16155643 ] Aleksandr Mashchenko commented on WW-4849: -- _to ensure that a container can only be injected once_

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-06 Thread Lukasz Lenart (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154882#comment-16154882 ] Lukasz Lenart commented on WW-4849: --- Sorry, I meant to fix the vulnerability reported in S2-052 you do not

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-06 Thread Mitth'raw'nuruodo (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154858#comment-16154858 ] Mitth'raw'nuruodo commented on WW-4849: --- Sorry, I don't think I understand your reply properly. "just

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-05 Thread Lukasz Lenart (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154843#comment-16154843 ] Lukasz Lenart commented on WW-4849: --- You can always just drop in the plugin itself, you do not need to

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154713#comment-16154713 ] ASF GitHub Bot commented on WW-4849: GitHub user ThrawnCA opened a pull request:

[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions

2017-09-05 Thread Mitth'raw'nuruodo (JIRA)
[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154701#comment-16154701 ] Mitth'raw'nuruodo commented on WW-4849: --- It should be feasible to restore the no-argument constructor