Re: [PR] WW-5350 Refactor SecurityMemberAccess [struts]

2023-11-12 Thread via GitHub
sonarcloud[bot] commented on PR #780: URL: https://github.com/apache/struts/pull/780#issuecomment-1807061451 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

Re: [PR] WW-5350 Refactor SecurityMemberAccess [struts]

2023-11-12 Thread via GitHub
kusalk commented on PR #780: URL: https://github.com/apache/struts/pull/780#issuecomment-1807061357 @lukaszlenart I'm going to make it extensible as part of WW-5343 so that applications can add even stronger checks if they so desire - so will leave it not `final` -- This is an automated

Re: [PR] WW-5350 Refactor SecurityMemberAccess [struts]

2023-11-05 Thread via GitHub
sonarcloud[bot] commented on PR #780: URL: https://github.com/apache/struts/pull/780#issuecomment-1793706015 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

Re: [PR] WW-5350 Refactor SecurityMemberAccess [struts]

2023-11-05 Thread via GitHub
sonarcloud[bot] commented on PR #780: URL: https://github.com/apache/struts/pull/780#issuecomment-1793701515 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

Re: [PR] WW-5350 Refactor SecurityMemberAccess [struts]

2023-11-05 Thread via GitHub
sonarcloud[bot] commented on PR #780: URL: https://github.com/apache/struts/pull/780#issuecomment-1793698505 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

Re: [PR] WW-5350 Refactor SecurityMemberAccess [struts]

2023-11-05 Thread via GitHub
kusalk commented on code in PR #780: URL: https://github.com/apache/struts/pull/780#discussion_r1382547971 ## core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java: ## @@ -104,126 +105,168 @@ public void restore(Map context, Object target, Member member,

Re: [PR] WW-5350 Refactor SecurityMemberAccess [struts]

2023-11-05 Thread via GitHub
kusalk commented on code in PR #780: URL: https://github.com/apache/struts/pull/780#discussion_r1382538846 ## core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java: ## @@ -104,126 +105,164 @@ public void restore(Map context, Object target, Member member,

Re: [PR] WW-5350 Refactor SecurityMemberAccess [struts]

2023-11-05 Thread via GitHub
kusalk commented on code in PR #780: URL: https://github.com/apache/struts/pull/780#discussion_r1382540169 ## core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java: ## @@ -104,126 +105,164 @@ public void restore(Map context, Object target, Member member,

Re: [PR] WW-5350 Refactor SecurityMemberAccess [struts]

2023-11-05 Thread via GitHub
kusalk commented on code in PR #780: URL: https://github.com/apache/struts/pull/780#discussion_r1382538745 ## core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java: ## @@ -104,126 +105,164 @@ public void restore(Map context, Object target, Member member,

Re: [PR] WW-5350 Refactor SecurityMemberAccess [struts]

2023-11-05 Thread via GitHub
sonarcloud[bot] commented on PR #780: URL: https://github.com/apache/struts/pull/780#issuecomment-1793685163 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate