Re: [PR] Adds script to track visitors with Matomo [struts-site]

2023-10-15 Thread via GitHub
asf-ci commented on PR #208: URL: https://github.com/apache/struts-site/pull/208#issuecomment-1763343034 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
sonarcloud[bot] commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1763378573 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885211&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885211 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

Re: [PR] Fix conflicting dependencies [struts]

2023-10-15 Thread via GitHub
sonarcloud[bot] commented on PR #767: URL: https://github.com/apache/struts/pull/767#issuecomment-1763379679 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
sonarcloud[bot] commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1763380211 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885212&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885212 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
sonarcloud[bot] commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1763383378 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885213&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885213 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
sonarcloud[bot] commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1763387927 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885215&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885215 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
sonarcloud[bot] commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1763389644 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885216&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885216 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
sonarcloud[bot] commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1763389989 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885217&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885217 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
kusalk commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1763391582 I found that previously, `struts.ognl.expressionCacheLRUMode=true` was not reliable due to setter injection not guaranteeing the order of operations. I've thus refactored the code to use cons

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885218&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885218 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
kusalk commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1359879865 ## core/src/main/resources/org/apache/struts2/default.properties: ## @@ -243,25 +243,25 @@ struts.ognl.enableExpressionCache=true ### For expressionCacheLRUMode true, the

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885219&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885219 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
kusalk commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1359880540 ## core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java: ## @@ -125,6 +127,24 @@ */ public class DefaultConfiguration implements Configuratio

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885220&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885220 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
kusalk commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1359880961 ## core/src/main/java/com/opensymphony/xwork2/ognl/DefaultOgnlCacheFactory.java: ## @@ -15,52 +15,86 @@ */ package com.opensymphony.xwork2.ognl; -import java.util.conc

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885221&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885221 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
kusalk commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1359881125 ## core/src/main/java/com/opensymphony/xwork2/ognl/OgnlLRUCache.java: ## @@ -81,7 +81,9 @@ public int getEvictionLimit() { @Override public void setEvictionLimi

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885222&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885222 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
sonarcloud[bot] commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1763394968 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885223&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885223 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
kusalk commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1359880540 ## core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java: ## @@ -125,6 +127,24 @@ */ public class DefaultConfiguration implements Configuratio

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885224&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885224 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
kusalk commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1359882251 ## core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java: ## @@ -143,12 +143,18 @@ protected void setEnableExpressionCache(String cache) { enableExpression

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885225&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885225 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
kusalk commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1359882251 ## core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java: ## @@ -143,12 +143,18 @@ protected void setEnableExpressionCache(String cache) { enableExpression

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
sonarcloud[bot] commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1763396297 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885226&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885226 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885228&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885228 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
kusalk commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1359882251 ## core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java: ## @@ -143,12 +143,18 @@ protected void setEnableExpressionCache(String cache) { enableExpression

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885229&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885229 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
kusalk commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1763400837 I've taken care to maintain full API compatibility given that these classes are extension points and thus public API -- This is an automated message from the Apache Git Service. To respond

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885231&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885231 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
ben-manes commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1359917451 ## core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java: ## @@ -143,12 +143,18 @@ protected void setEnableExpressionCache(String cache) { enableExpress

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885237&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885237 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
ben-manes commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1359917925 ## core/src/main/java/com/opensymphony/xwork2/ognl/OgnlCaffeineCache.java: ## @@ -0,0 +1,82 @@ +/* + * Copyright 2022 Apache Software Foundation. + * + * Licensed under

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885238&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885238 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

Re: [PR] List of companies providing commercial support [struts-site]

2023-10-15 Thread via GitHub
asf-ci commented on PR #207: URL: https://github.com/apache/struts-site/pull/207#issuecomment-1763455998 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
ben-manes commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1359917987 ## core/src/main/java/com/opensymphony/xwork2/ognl/OgnlCaffeineCache.java: ## @@ -0,0 +1,82 @@ +/* + * Copyright 2022 Apache Software Foundation. + * + * Licensed under

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885239&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885239 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

Re: [PR] Bump org.springframework:spring-web from 5.3.23 to 6.0.12 [struts-examples]

2023-10-15 Thread via GitHub
dependabot[bot] commented on PR #263: URL: https://github.com/apache/struts-examples/pull/263#issuecomment-1763577310 Superseded by #272. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
kusalk commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1359882251 ## core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java: ## @@ -143,12 +143,18 @@ protected void setEnableExpressionCache(String cache) { enableExpression

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885246&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885246 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
kusalk commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1763618099 Thanks @ben-manes, amended! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885247&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885247 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
sonarcloud[bot] commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1763620736 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[jira] [Work logged] (WW-5355) Use LRU cache by default

2023-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885248&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885248 ] ASF GitHub Bot logged work on WW-5355: -- Author: ASF GitHub Bot

Re: [PR] Bump spring.platformVersion from 5.3.27 to 6.0.13 [struts]

2023-10-15 Thread via GitHub
dependabot[bot] commented on PR #769: URL: https://github.com/apache/struts/pull/769#issuecomment-1763710914 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by ad