[jira] [Commented] (WW-4892) Use Jackson handler to handle JSON by default
[ https://issues.apache.org/jira/browse/WW-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689108#comment-16689108 ] Lukasz Lenart commented on WW-4892: --- Hm maybe you are right, json-lib is outdated for very long now, dropping support for it is a way better. > Use Jackson handler to handle JSON by default > - > > Key: WW-4892 > URL: https://issues.apache.org/jira/browse/WW-4892 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - REST >Affects Versions: 2.5.14 >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Major > Fix For: 2.5.14.1 > > > Existing JsonLibHandler is using outdated json-lib which wasn't updated for > years, switching to Jackson (which is already available in to the plugin) is > the best option. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (WW-4979) Update multiple Struts 2.6.x libraries to more recent versions
[ https://issues.apache.org/jira/browse/WW-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688922#comment-16688922 ] Lukasz Lenart edited comment on WW-4979 at 11/16/18 7:10 AM: - Hello Apache Struts Team. With respect to WW-4981 Java 11 support, there might be some consideration for a future Struts 2.6.x moving to Felix 6.0.1 (or later). Felix 6.0.1 implements OSGi R7 and its changelog indicates support for Java 9 (no mention of Java 10/11, though). A jump from 4.x to 6.x is more likely to require changes to the Struts 2 OSGi plugin though. > Update multiple Struts 2.6.x libraries to more recent versions > -- > > Key: WW-4979 > URL: https://issues.apache.org/jira/browse/WW-4979 > Project: Struts 2 > Issue Type: Dependency > Components: Build Management, Other >Affects Versions: 2.6 > Environment: All. >Reporter: James Chaplin >Priority: Minor > Labels: build, pull-request-available > Fix For: 2.6 > > > Hello Apache Struts Team. > This Jira issue is intended to request/track introduction of newer (believed > to be compatible) library versions for the unreleased Struts 2.6.x line. > This can be achieved by modifications to one or more pom.xml build files for > the project. > Since multiple library version upgrades are being attempted at the same time > there is some risk, but the build regression does complete without failure. > The number of library upgrades could be reduced (broken into smaller sets and > slowly introduced) if necessary. End users would also have the option of > manually back-leveling specific jars. > Please find below a list of library version updates that appear to be > compatible with the current versions in the 2.6.x build line. > - > Update Struts 2.6 build with some newer (compatible) library versions. > Change the main pom.xml library versions for the following: > - spring.platformVersion 4.3.13.RELEASE -> 4.3.20.RELEASE > - oval 1.31 -> 1.90 (Note: required unit test fix for > OValValidationInterceptorTest.java AND code fix for > OvalValidationInterceptor.java. Oval 1.70 was the most recent that could be > used without a fix to OvalValidationInterceptor.) > - jackson 2.9.6 -> 2.9.7 > - fluido-skin.version 1.6 -> 1.7 > - slf4j (slf4j-api, slf4j-simple) 1.7.12 -> 1.7.25 > - xstream 1.4.10 -> 1.4.11.1 > - jetty 6.1.9 -> 6.1.26 (last in 6.1.x line) > - xerces 2.10.0 - > 2.12.0 > - org.owasp 3.1.1 -> 3.3.4 > - versions-maven-plugin 2.5 -> 2.7 > - doxia-core 1.7 -> 1.8 > - doxia-module-markdown 1.3 -> 1.7 > - org.apache.felix.main 4.0.3 -> 4.6.1 (Note: most recent 4.x) > - easymock 3.4 -> 3.5.1 > - javax.el 3.0 -> 3.0.1-b10 > - jasper 6.0.18 -> 6.0.53 (Note: most recent 6.0.x) > - juli 6.0.18 -> 6.0.53 (Note: most recent 6.0.x) > - commons-logging 1.1.3 -> 1.2 > - commons-collections4 4.1 -> 4.2 > - commons-io 2.5 -> 2.6 > - commons-lang3 3.6 -> 3.8.1 > - commons-text 1.2 -> 1.3 (Note: most recent compatible with Java 7) > - commons-validator 1.5.1 -> 1.6 > - mockito 1.9.5 -> 1.10.19 (Note: most recent 1.x) > - cdi-api 1.0-SP1 -> 1.0-SP4 (Note: most recent 1.0.x) > - weld-core 1.0.1-Final -> 1.0.1-SP4 (Note: most recent 1.0.x) > - cglib 2.2 -> 2.2.2 (Note: most recent 2.2.x, as 2.2.3's > status is uncertain) > Note: cglib-nodep version appears to be determined by the jmock-cglib > requirement for JMock 1.2.0. Leaving the cglib-nodep version is probably > safest for now. However for 2.6.x the cglib dependency can probably go to > 2.2.2 for the build. There might be consideration for the cglib 3.x series, > but that might impact other components. > - > There is an open PR #265 which demonstrates the build/regression completes > using the above version changes. The main Showcase application (not the REST > one) appears to work interactively as well, but there are no demonstrator > applications for the Plugins. > Please note: The struts2-rest-showcase application does not work > (initialization fails due to: > com.opensymphony.xwork2.config.ConfigurationException: Unable to find > interceptor class referenced by ref-name profiling). The init failed before > the library version changes, so it doesn't appear to be related. > Please review the above and see if some or all of the library updates appear > appropriate for the 2.6.x build line. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (WW-4978) Update multiple Struts 2.5.x libraries to more recent versions
[ https://issues.apache.org/jira/browse/WW-4978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688905#comment-16688905 ] Lukasz Lenart edited comment on WW-4978 at 11/16/18 7:10 AM: - Important Note For WW-4978: --- - According to the Felix changelog, Felix 4.6.1 implements OSGi R6. - According to the Felix changelog, Felix 4.0.3 implements OSGi R4.3. Some conflicting internet sources made it unclear which OSGi levels the various 4.x series implement, but the changelog should be authoritative. Although various documentation seem to indicate bundles designed for OSGi 4.x should run under a newer (such as R6) framework, some also indicate that such bundles may experience slightly different behaviour (depending on how the bundle was designed). Anyone using the Struts 2 OSGi Plugin should be aware of the version change for the Felix framework jar in Struts 2.5.19+. If Struts 2 OSGi Plugin issues are encountered, reverting to Felix 4.0.3 (org.apache.felix.main-4.0.3.jar and org.apache.felix.framework-4.0.3.jar) may help resolve any issues. Someone with expertise in OSGi and the Struts 2 OSGi plugin may have a more pertinent comment to provide. > Update multiple Struts 2.5.x libraries to more recent versions > -- > > Key: WW-4978 > URL: https://issues.apache.org/jira/browse/WW-4978 > Project: Struts 2 > Issue Type: Dependency > Components: Build Management, Other >Affects Versions: 2.5.18 > Environment: All. >Reporter: James Chaplin >Priority: Minor > Labels: build, pull-request-available > Fix For: 2.5.19 > > > Hello Apache Struts Team. > This Jira issue is intended to request/track introduction of newer (believed > to be compatible) library versions for the Struts 2.5.x line. This can be > achieved by modifications to one or more pom.xml build files for the project. > Since multiple library version upgrades are being attempted at the same time > there is some risk, but the build regression does complete without failure. > The number of library upgrades could be reduced (broken into smaller sets and > slowly introduced) if necessary. End users would also have the option of > manually back-leveling specific jars. > Please find below a list of library version updates that appear to be > compatible with the current versions in the 2.5.x build line. > - > Update Struts 2.5.19 build with some newer (compatible) library versions. > Change the main pom.xml library versions for the following: > - spring.platformVersion 4.3.13.RELEASE -> 4.3.20.RELEASE > - ognl 3.1.15 -> 3.1.18 (Note: newest version that passes unit tests) > - oval 1.31 -> 1.90 (Note: requires unit test fix for > OValValidationInterceptorTest.java) > - tiles 3.0.7 -> 3.0.8 > - tiles-request 1.0.6 -> 1.0.7 > - log4j 2.10.0 -> 2.11.1 > - jackson 2.9.5 -> 2.9.7 > - fluido-skin.version 1.6 -> 1.7 > - slf4j 1.7.12 -> 1.7.25 > - xtream 1.4.10 -> 1.4.11.1 > - jetty 6.1.9 -> 6.1.26 (last in 6.1.x line) > - xerces 2.10.0 - > 2.12.0 > - org.owasp 3.1.1 -> 3.3.4 > - versions-maven-plugin 2.5 -> 2.7 > - doxia-core 1.7 -> 1.8 > - doxia-markdown 1.3 -> 1.7 > - freemarker 2.3.26-incubating -> 2.3.28 > - org.apache.felix.main 4.0.3 -> 4.6.1 (Note: most recent 4.x) > - easymock 3.4 -> 3.5.1 > - javax.el 3.0 -> 3.0.1-b10 > - jasper 6.0.18 -> 6.0.53 (Note: most recent 6.0.x) > - juli 6.0.18 -> 6.0.53 (Note: most recent 6.0.x) > - commons-logging 1.1.3 -> 1.2 > - commons-collections4 4.1 -> 4.2 > - commons-io 2.5 -> 2.6 > - commons-lang 3.6 -> 3.8.1 > - commons-beanutils 1.9.2 -> 1.9.3 > - commons-validator 1.5.1 -> 1.6 > - mockito 1.9.5 -> 1.10.19 (Note: most recent 1.x) > - cdi-api 1.0-SP1 -> 1.0-SP4 (Note: most recent 1.0.x) > - weld-core 1.0.1-Final -> 1.0.1-SP4 (Note: most recent 1.0.x) > Note: cglib-nodep version appears to be determined by the jmock-cglib > requirement for JMock 1.2.0. Seems safer to leave cglib/cglib-nodep alone > for 2.5.x series builds. > - > There is an open PR #264 which demonstrates the build/regression completes > using the above version changes. The Showcase applications appear to work > interactively as well, but there are no demonstrator applications for the > Plugins. > Please review the above and see if some or all of the library updates appear > appropriate for the 2.5.x build line. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (WW-4979) Update multiple Struts 2.6.x libraries to more recent versions
[ https://issues.apache.org/jira/browse/WW-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688909#comment-16688909 ] Lukasz Lenart edited comment on WW-4979 at 11/16/18 7:10 AM: - Important Note For WW-4979: --- - According to the Felix changelog, Felix 4.6.1 implements OSGi R6. - According to the Felix changelog, Felix 4.0.3 implements OSGi R4.3. Some conflicting internet sources made it unclear which OSGi levels the various 4.x series implement, but the changelog should be authoritative. Although various documentation seem to indicate bundles designed for OSGi 4.x should run under a newer (such as R6) framework, some also indicate that such bundles may experience slightly different behaviour (depending on how the bundle was designed). Anyone using the Struts 2 OSGi Plugin should be aware of the version change for the Felix framework jar in Struts 2.6 (compared to older 2.5.x or 2.3.x series). If Struts 2 OSGi Plugin issues are encountered, reverting to Felix 4.0.3 (org.apache.felix.main-4.0.3.jar and org.apache.felix.framework-4.0.3.jar) may help resolve any issues. Someone with expertise in OSGi and the Struts 2 OSGi plugin may have a more pertinent comment to provide. > Update multiple Struts 2.6.x libraries to more recent versions > -- > > Key: WW-4979 > URL: https://issues.apache.org/jira/browse/WW-4979 > Project: Struts 2 > Issue Type: Dependency > Components: Build Management, Other >Affects Versions: 2.6 > Environment: All. >Reporter: James Chaplin >Priority: Minor > Labels: build, pull-request-available > Fix For: 2.6 > > > Hello Apache Struts Team. > This Jira issue is intended to request/track introduction of newer (believed > to be compatible) library versions for the unreleased Struts 2.6.x line. > This can be achieved by modifications to one or more pom.xml build files for > the project. > Since multiple library version upgrades are being attempted at the same time > there is some risk, but the build regression does complete without failure. > The number of library upgrades could be reduced (broken into smaller sets and > slowly introduced) if necessary. End users would also have the option of > manually back-leveling specific jars. > Please find below a list of library version updates that appear to be > compatible with the current versions in the 2.6.x build line. > - > Update Struts 2.6 build with some newer (compatible) library versions. > Change the main pom.xml library versions for the following: > - spring.platformVersion 4.3.13.RELEASE -> 4.3.20.RELEASE > - oval 1.31 -> 1.90 (Note: required unit test fix for > OValValidationInterceptorTest.java AND code fix for > OvalValidationInterceptor.java. Oval 1.70 was the most recent that could be > used without a fix to OvalValidationInterceptor.) > - jackson 2.9.6 -> 2.9.7 > - fluido-skin.version 1.6 -> 1.7 > - slf4j (slf4j-api, slf4j-simple) 1.7.12 -> 1.7.25 > - xstream 1.4.10 -> 1.4.11.1 > - jetty 6.1.9 -> 6.1.26 (last in 6.1.x line) > - xerces 2.10.0 - > 2.12.0 > - org.owasp 3.1.1 -> 3.3.4 > - versions-maven-plugin 2.5 -> 2.7 > - doxia-core 1.7 -> 1.8 > - doxia-module-markdown 1.3 -> 1.7 > - org.apache.felix.main 4.0.3 -> 4.6.1 (Note: most recent 4.x) > - easymock 3.4 -> 3.5.1 > - javax.el 3.0 -> 3.0.1-b10 > - jasper 6.0.18 -> 6.0.53 (Note: most recent 6.0.x) > - juli 6.0.18 -> 6.0.53 (Note: most recent 6.0.x) > - commons-logging 1.1.3 -> 1.2 > - commons-collections4 4.1 -> 4.2 > - commons-io 2.5 -> 2.6 > - commons-lang3 3.6 -> 3.8.1 > - commons-text 1.2 -> 1.3 (Note: most recent compatible with Java 7) > - commons-validator 1.5.1 -> 1.6 > - mockito 1.9.5 -> 1.10.19 (Note: most recent 1.x) > - cdi-api 1.0-SP1 -> 1.0-SP4 (Note: most recent 1.0.x) > - weld-core 1.0.1-Final -> 1.0.1-SP4 (Note: most recent 1.0.x) > - cglib 2.2 -> 2.2.2 (Note: most recent 2.2.x, as 2.2.3's > status is uncertain) > Note: cglib-nodep version appears to be determined by the jmock-cglib > requirement for JMock 1.2.0. Leaving the cglib-nodep version is probably > safest for now. However for 2.6.x the cglib dependency can probably go to > 2.2.2 for the build. There might be consideration for the cglib 3.x series, > but that might impact other components. > - > There is an open PR #265 which demonstrates the build/regression completes > using the above version changes. The main Showcase application (not the REST > one) appears to work interactively as well, but there are no demonstrator > applications for the Plugins. > Please note: The struts2-rest-showcase application does not work > (initialization fails due to: >
[jira] [Commented] (WW-4981) Add support for Java 11
[
https://issues.apache.org/jira/browse/WW-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689102#comment-16689102
]
Lukasz Lenart commented on WW-4981:
---
I'm getting some NPE in {{ClassPathFinder}} :\
> Add support for Java 11
> ---
>
> Key: WW-4981
> URL: https://issues.apache.org/jira/browse/WW-4981
> Project: Struts 2
> Issue Type: Task
> Components: Build Management
> Environment: {{oraclejdk11, }}{{openjdk11,
> [https://adoptopenjdk.net|https://adoptopenjdk.net/]}}
>Reporter: Sebastian Peters
>Priority: Critical
> Fix For: 2.6
>
>
> Java 11 is the new LTS release and Java 9 and 10 are already EOL.
> see [https://www.oracle.com/technetwork/java/javase/eol-135779.html]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4981) Add support for Java 11
[
https://issues.apache.org/jira/browse/WW-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688679#comment-16688679
]
Sebastian Peters commented on WW-4981:
--
Me too. ;)
I use the following command for isolated testing based on adoptopenjdk:
{{docker run -it --rm \}}
{{ --name struts-openjdk11 \}}
{{ --env USER=maven \}}
{{ -v "$PWD":/root \}}
{{ -v "$HOME"/.m2:/root/.m2 \}}
{{ -w /root \}}
{{ adoptopenjdk/maven-openjdk11:latest \}}
{{ mvn clean package}}
> Add support for Java 11
> ---
>
> Key: WW-4981
> URL: https://issues.apache.org/jira/browse/WW-4981
> Project: Struts 2
> Issue Type: Task
> Components: Build Management
> Environment: {{oraclejdk11, }}{{openjdk11,
> [https://adoptopenjdk.net|https://adoptopenjdk.net/]}}
>Reporter: Sebastian Peters
>Priority: Critical
> Fix For: 2.6
>
>
> Java 11 is the new LTS release and Java 9 and 10 are already EOL.
> see [https://www.oracle.com/technetwork/java/javase/eol-135779.html]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (WW-4981) Add support for Java 11
[
https://issues.apache.org/jira/browse/WW-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688679#comment-16688679
]
Sebastian Peters edited comment on WW-4981 at 11/15/18 9:33 PM:
Me too. ;)
I use the following command for isolated testing based on adoptopenjdk:
{{docker run -it --rm --name struts-openjdk11 --env USER=maven -v "$PWD":/root
-v "$HOME"/.m2:/root/.m2 -w /root adoptopenjdk/maven-openjdk11:latest mvn clean
package}}
was (Author: sepe81):
Me too. ;)
I use the following command for isolated testing based on adoptopenjdk:
{{docker run -it --rm \}}
{{ --name struts-openjdk11 \}}
{{ --env USER=maven \}}
{{ -v "$PWD":/root \}}
{{ -v "$HOME"/.m2:/root/.m2 \}}
{{ -w /root \}}
{{ adoptopenjdk/maven-openjdk11:latest \}}
{{ mvn clean package}}
> Add support for Java 11
> ---
>
> Key: WW-4981
> URL: https://issues.apache.org/jira/browse/WW-4981
> Project: Struts 2
> Issue Type: Task
> Components: Build Management
> Environment: {{oraclejdk11, }}{{openjdk11,
> [https://adoptopenjdk.net|https://adoptopenjdk.net/]}}
>Reporter: Sebastian Peters
>Priority: Critical
> Fix For: 2.6
>
>
> Java 11 is the new LTS release and Java 9 and 10 are already EOL.
> see [https://www.oracle.com/technetwork/java/javase/eol-135779.html]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4981) Add support for Java 11
[
https://issues.apache.org/jira/browse/WW-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688594#comment-16688594
]
Lukasz Lenart commented on WW-4981:
---
Already started working on this :)
> Add support for Java 11
> ---
>
> Key: WW-4981
> URL: https://issues.apache.org/jira/browse/WW-4981
> Project: Struts 2
> Issue Type: Task
> Components: Build Management
> Environment: {{oraclejdk11, }}{{openjdk11,
> [https://adoptopenjdk.net|https://adoptopenjdk.net/]}}
>Reporter: Sebastian Peters
>Priority: Critical
> Fix For: 2.6
>
>
> Java 11 is the new LTS release and Java 9 and 10 are already EOL.
> see [https://www.oracle.com/technetwork/java/javase/eol-135779.html]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4981) Add support for Java 11
[
https://issues.apache.org/jira/browse/WW-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688518#comment-16688518
]
Sebastian Peters commented on WW-4981:
--
We should try to update to maven-surefire-plugin to 2.22.1 b/c
https://issues.apache.org/jira/browse/SUREFIRE-1562 adds Java 11 support for
maven testing.
> Add support for Java 11
> ---
>
> Key: WW-4981
> URL: https://issues.apache.org/jira/browse/WW-4981
> Project: Struts 2
> Issue Type: Task
> Components: Build Management
> Environment: {{oraclejdk11, }}{{openjdk11,
> [https://adoptopenjdk.net|https://adoptopenjdk.net/]}}
>Reporter: Sebastian Peters
>Priority: Critical
> Fix For: 2.6
>
>
> Java 11 is the new LTS release and Java 9 and 10 are already EOL.
> see [https://www.oracle.com/technetwork/java/javase/eol-135779.html]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4845) run, test, and validate Struts2 with Java9
[ https://issues.apache.org/jira/browse/WW-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688529#comment-16688529 ] Sebastian Peters commented on WW-4845: -- I created WW-4981 for Java 11 support. > run, test, and validate Struts2 with Java9 > -- > > Key: WW-4845 > URL: https://issues.apache.org/jira/browse/WW-4845 > Project: Struts 2 > Issue Type: Task > Components: Core >Affects Versions: 2.5.13 >Reporter: adam brin >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.6 > > > it looks like Java9 will be released in September. While it may not be > possible to be compliant on day 1, it would be nice to have a formal release > that's certified with Java 9. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (WW-4981) Add support for Java 11
[
https://issues.apache.org/jira/browse/WW-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688518#comment-16688518
]
Sebastian Peters edited comment on WW-4981 at 11/15/18 7:04 PM:
We should try to update the maven-surefire-plugin to 2.22.1 b/c
https://issues.apache.org/jira/browse/SUREFIRE-1562 adds Java 11 support for
maven testing.
was (Author: sepe81):
We should try to update to maven-surefire-plugin to 2.22.1 b/c
https://issues.apache.org/jira/browse/SUREFIRE-1562 adds Java 11 support for
maven testing.
> Add support for Java 11
> ---
>
> Key: WW-4981
> URL: https://issues.apache.org/jira/browse/WW-4981
> Project: Struts 2
> Issue Type: Task
> Components: Build Management
> Environment: {{oraclejdk11, }}{{openjdk11,
> [https://adoptopenjdk.net|https://adoptopenjdk.net/]}}
>Reporter: Sebastian Peters
>Priority: Critical
> Fix For: 2.6
>
>
> Java 11 is the new LTS release and Java 9 and 10 are already EOL.
> see [https://www.oracle.com/technetwork/java/javase/eol-135779.html]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (WW-4981) Add support for Java 11
[
https://issues.apache.org/jira/browse/WW-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebastian Peters updated WW-4981:
-
Environment: {{oraclejdk11, }}{{openjdk11,
[https://adoptopenjdk.net|https://adoptopenjdk.net/]}} (was: {{oraclejdk11,
}}{{openjdk11, https://adoptopenjdk.net/}}{{}})
> Add support for Java 11
> ---
>
> Key: WW-4981
> URL: https://issues.apache.org/jira/browse/WW-4981
> Project: Struts 2
> Issue Type: Task
> Components: Build Management
> Environment: {{oraclejdk11, }}{{openjdk11,
> [https://adoptopenjdk.net|https://adoptopenjdk.net/]}}
>Reporter: Sebastian Peters
>Priority: Critical
> Fix For: 2.6
>
>
> Java 11 is the new LTS release and Java 9 and 10 are already EOL.
> see [https://www.oracle.com/technetwork/java/javase/eol-135779.html]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (WW-4981) Add support for Java 11
Sebastian Peters created WW-4981:
Summary: Add support for Java 11
Key: WW-4981
URL: https://issues.apache.org/jira/browse/WW-4981
Project: Struts 2
Issue Type: Task
Components: Build Management
Environment: {{oraclejdk11, }}{{openjdk11,
https://adoptopenjdk.net/}}{{}}
Reporter: Sebastian Peters
Fix For: 2.6
Java 11 is the new LTS release and Java 9 and 10 are already EOL.
see [https://www.oracle.com/technetwork/java/javase/eol-135779.html]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4892) Use Jackson handler to handle JSON by default
[ https://issues.apache.org/jira/browse/WW-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688315#comment-16688315 ] Sebastian Peters commented on WW-4892: -- [~lukaszlenart] It is already marked as deprecated since version 2.5.14.1 (this change/commit here) but without further comments. Isn't the new minor version 2.6 a good version for cleanup or should we wait till major version 3.0? > Use Jackson handler to handle JSON by default > - > > Key: WW-4892 > URL: https://issues.apache.org/jira/browse/WW-4892 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - REST >Affects Versions: 2.5.14 >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Major > Fix For: 2.5.14.1 > > > Existing JsonLibHandler is using outdated json-lib which wasn't updated for > years, switching to Jackson (which is already available in to the plugin) is > the best option. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (WW-4845) run, test, and validate Struts2 with Java9
[ https://issues.apache.org/jira/browse/WW-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-4845: -- Summary: run, test, and validate Struts2 with Java9 (was: run, test, and validate Struts2 with Java9 and Java11) > run, test, and validate Struts2 with Java9 > -- > > Key: WW-4845 > URL: https://issues.apache.org/jira/browse/WW-4845 > Project: Struts 2 > Issue Type: Task > Components: Core >Affects Versions: 2.5.13 >Reporter: adam brin >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.6 > > > it looks like Java9 will be released in September. While it may not be > possible to be compliant on day 1, it would be nice to have a formal release > that's certified with Java 9. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4845) run, test, and validate Struts2 with Java9
[ https://issues.apache.org/jira/browse/WW-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688238#comment-16688238 ] Lukasz Lenart commented on WW-4845: --- I have removed -Java11- as there is still a problem with surefire plugin under JDK11, it works under JDK9 > run, test, and validate Struts2 with Java9 > -- > > Key: WW-4845 > URL: https://issues.apache.org/jira/browse/WW-4845 > Project: Struts 2 > Issue Type: Task > Components: Core >Affects Versions: 2.5.13 >Reporter: adam brin >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.6 > > > it looks like Java9 will be released in September. While it may not be > possible to be compliant on day 1, it would be nice to have a formal release > that's certified with Java 9. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4930) SMI cannot be diasabled for action-packages found via the convention-plugin
[
https://issues.apache.org/jira/browse/WW-4930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688221#comment-16688221
]
Hudson commented on WW-4930:
SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #205 (See
[https://builds.apache.org/job/Struts-master-JDK7/205/])
WW-4930 Add constant to enable smi inheritance between parent package
(p.heidelbach: rev 38b96b11fe043a6892108b28d0758a9f0d4533e8)
* (edit)
plugins/convention/src/main/java/org/apache/struts2/convention/ConventionConstants.java
* (edit)
plugins/convention/src/test/java/org/apache/struts2/convention/PackageBasedActionConfigBuilderTest.java
* (edit) plugins/convention/src/main/resources/struts-plugin.xml
* (edit)
plugins/convention/src/main/java/org/apache/struts2/convention/PackageBasedActionConfigBuilder.java
* (edit)
plugins/convention/src/main/java/org/apache/struts2/convention/config/entities/ConventionConstantConfig.java
WW-4930 Add test run with enabled SMI inheritance (p.heidelbach: rev
8b4755dc4964226762398567e4c6aa6fda9a072f)
* (edit)
plugins/convention/src/test/java/org/apache/struts2/convention/PackageBasedActionConfigBuilderTest.java
> SMI cannot be diasabled for action-packages found via the convention-plugin
> ---
>
> Key: WW-4930
> URL: https://issues.apache.org/jira/browse/WW-4930
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Convention
>Affects Versions: 2.5.16
> Environment: Windows 10
> Java 1.8
>Reporter: Philipp Heidelbach
>Priority: Major
> Fix For: 2.6
>
>
> I'm trying to update Struts 2.3.34 to 2.5.16 and disabling SMI doesn't seem
> to work.
> I debuged XmlConfigurationProvider but in the packageConfig of our package
> (named default see below) SMI is correctly set to false. Debugging
> PackageBaseActionConfigBuilder shows that our default-package is used as
> parent package and in the parentPkg SMI is set to false. The pkgConfig
> however is alwasy null (line: 1043) and so a new package config is created in
> which SMI is set to true.
> Thus for all these actions methods i get the error that these methods aren't
> allowed.
> If I use @AllowedMethod-annotations it works fine.
> Below the beginning of our struts.xml
> {code:xml}
>
> "-//Apache Software Foundation//DTD Struts Configuration 2.5//EN"
> "http://struts.apache.org/dtds/struts-2.5.dtd;>
>
>
> value="jar,zip,vfsfile,vfszip" />
> value=".*/newd[-.\w]*\.jar(!/)?" />
> value="org.apache.struts.*,org.apache.struts2.*,org.springframework.web.struts.*,org.springframework.web.struts2.*,org.hibernate.*"
> />
>
> value="applicationResources" />
>
>
>
>
>
>
>
>
> strict-method-invocation="false">
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4930) SMI cannot be diasabled for action-packages found via the convention-plugin
[
https://issues.apache.org/jira/browse/WW-4930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688227#comment-16688227
]
Lukasz Lenart commented on WW-4930:
---
[~Heidelbach] it was a pleasure :)
> SMI cannot be diasabled for action-packages found via the convention-plugin
> ---
>
> Key: WW-4930
> URL: https://issues.apache.org/jira/browse/WW-4930
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Convention
>Affects Versions: 2.5.16
> Environment: Windows 10
> Java 1.8
>Reporter: Philipp Heidelbach
>Priority: Major
> Fix For: 2.6
>
>
> I'm trying to update Struts 2.3.34 to 2.5.16 and disabling SMI doesn't seem
> to work.
> I debuged XmlConfigurationProvider but in the packageConfig of our package
> (named default see below) SMI is correctly set to false. Debugging
> PackageBaseActionConfigBuilder shows that our default-package is used as
> parent package and in the parentPkg SMI is set to false. The pkgConfig
> however is alwasy null (line: 1043) and so a new package config is created in
> which SMI is set to true.
> Thus for all these actions methods i get the error that these methods aren't
> allowed.
> If I use @AllowedMethod-annotations it works fine.
> Below the beginning of our struts.xml
> {code:xml}
>
> "-//Apache Software Foundation//DTD Struts Configuration 2.5//EN"
> "http://struts.apache.org/dtds/struts-2.5.dtd;>
>
>
> value="jar,zip,vfsfile,vfszip" />
> value=".*/newd[-.\w]*\.jar(!/)?" />
> value="org.apache.struts.*,org.apache.struts2.*,org.springframework.web.struts.*,org.springframework.web.struts2.*,org.hibernate.*"
> />
>
> value="applicationResources" />
>
>
>
>
>
>
>
>
> strict-method-invocation="false">
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4930) SMI cannot be diasabled for action-packages found via the convention-plugin
[
https://issues.apache.org/jira/browse/WW-4930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688220#comment-16688220
]
Philipp Heidelbach commented on WW-4930:
Thanks for your help.
> SMI cannot be diasabled for action-packages found via the convention-plugin
> ---
>
> Key: WW-4930
> URL: https://issues.apache.org/jira/browse/WW-4930
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Convention
>Affects Versions: 2.5.16
> Environment: Windows 10
> Java 1.8
>Reporter: Philipp Heidelbach
>Priority: Major
> Fix For: 2.6
>
>
> I'm trying to update Struts 2.3.34 to 2.5.16 and disabling SMI doesn't seem
> to work.
> I debuged XmlConfigurationProvider but in the packageConfig of our package
> (named default see below) SMI is correctly set to false. Debugging
> PackageBaseActionConfigBuilder shows that our default-package is used as
> parent package and in the parentPkg SMI is set to false. The pkgConfig
> however is alwasy null (line: 1043) and so a new package config is created in
> which SMI is set to true.
> Thus for all these actions methods i get the error that these methods aren't
> allowed.
> If I use @AllowedMethod-annotations it works fine.
> Below the beginning of our struts.xml
> {code:xml}
>
> "-//Apache Software Foundation//DTD Struts Configuration 2.5//EN"
> "http://struts.apache.org/dtds/struts-2.5.dtd;>
>
>
> value="jar,zip,vfsfile,vfszip" />
> value=".*/newd[-.\w]*\.jar(!/)?" />
> value="org.apache.struts.*,org.apache.struts2.*,org.springframework.web.struts.*,org.springframework.web.struts2.*,org.hibernate.*"
> />
>
> value="applicationResources" />
>
>
>
>
>
>
>
>
> strict-method-invocation="false">
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4930) SMI cannot be diasabled for action-packages found via the convention-plugin
[
https://issues.apache.org/jira/browse/WW-4930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688192#comment-16688192
]
ASF subversion and git services commented on WW-4930:
-
Commit 8b4755dc4964226762398567e4c6aa6fda9a072f in struts's branch
refs/heads/master from [~Heidelbach]
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=8b4755d ]
WW-4930 Add test run with enabled SMI inheritance
> SMI cannot be diasabled for action-packages found via the convention-plugin
> ---
>
> Key: WW-4930
> URL: https://issues.apache.org/jira/browse/WW-4930
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Convention
>Affects Versions: 2.5.16
> Environment: Windows 10
> Java 1.8
>Reporter: Philipp Heidelbach
>Priority: Major
> Fix For: 2.6
>
>
> I'm trying to update Struts 2.3.34 to 2.5.16 and disabling SMI doesn't seem
> to work.
> I debuged XmlConfigurationProvider but in the packageConfig of our package
> (named default see below) SMI is correctly set to false. Debugging
> PackageBaseActionConfigBuilder shows that our default-package is used as
> parent package and in the parentPkg SMI is set to false. The pkgConfig
> however is alwasy null (line: 1043) and so a new package config is created in
> which SMI is set to true.
> Thus for all these actions methods i get the error that these methods aren't
> allowed.
> If I use @AllowedMethod-annotations it works fine.
> Below the beginning of our struts.xml
> {code:xml}
>
> "-//Apache Software Foundation//DTD Struts Configuration 2.5//EN"
> "http://struts.apache.org/dtds/struts-2.5.dtd;>
>
>
> value="jar,zip,vfsfile,vfszip" />
> value=".*/newd[-.\w]*\.jar(!/)?" />
> value="org.apache.struts.*,org.apache.struts2.*,org.springframework.web.struts.*,org.springframework.web.struts2.*,org.hibernate.*"
> />
>
> value="applicationResources" />
>
>
>
>
>
>
>
>
> strict-method-invocation="false">
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (WW-4866) ASM 5.2 and Java 9 leads to IllegalArgumentException
[
https://issues.apache.org/jira/browse/WW-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart resolved WW-4866.
---
Resolution: Fixed
Resolved by upgrading to ASM 7.0 WW-4976
> ASM 5.2 and Java 9 leads to IllegalArgumentException
>
>
> Key: WW-4866
> URL: https://issues.apache.org/jira/browse/WW-4866
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Convention
>Affects Versions: 2.5.13
> Environment: Java 9
>Reporter: Michael Hintenaus
>Assignee: Lukasz Lenart
>Priority: Critical
> Fix For: 2.6
>
>
> With ASM 5.2 and Java 9 I will get the following Stacktrace:
> {noformat}
> java.lang.IllegalArgumentException
> at org.objectweb.asm.ClassReader.(Unknown Source)
> at org.objectweb.asm.ClassReader.(Unknown Source)
> at org.objectweb.asm.ClassReader.(Unknown Source)
> at
> org.apache.struts2.convention.DefaultClassFinder.readClassDef(DefaultClassFinder.java:461)
> at
> org.apache.struts2.convention.DefaultClassFinder.access$200(DefaultClassFinder.java:52)
> at
> org.apache.struts2.convention.DefaultClassFinder$InfoBuildingVisitor.extractSuperInterfaces(DefaultClassFinder.java:514)
> at
> org.apache.struts2.convention.DefaultClassFinder$InfoBuildingVisitor.visit(DefaultClassFinder.java:501)
> at org.objectweb.asm.ClassReader.accept(Unknown Source)
> at org.objectweb.asm.ClassReader.accept(Unknown Source)
> at
> org.apache.struts2.convention.DefaultClassFinder.readClassDef(DefaultClassFinder.java:462)
> at
> org.apache.struts2.convention.DefaultClassFinder.(DefaultClassFinder.java:93)
> at
> org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildClassFinder(PackageBasedActionConfigBuilder.java:395)
> at
> org.apache.struts2.convention.PackageBasedActionConfigBuilder.findActions(PackageBasedActionConfigBuilder.java:377)
> at
> org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildActionConfigs(PackageBasedActionConfigBuilder.java:333)
> at
> org.apache.struts2.convention.ClasspathPackageProvider.loadPackages(ClasspathPackageProvider.java:52)
> at
> com.opensymphony.xwork2.config.impl.DefaultConfiguration.reloadContainer(DefaultConfiguration.java:198)
> at
> com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(ConfigurationManager.java:63)
> at
> org.apache.struts2.dispatcher.Dispatcher.getContainer(Dispatcher.java:960)
> at
> org.apache.struts2.dispatcher.Dispatcher.init_PreloadConfiguration(Dispatcher.java:466)
> at org.apache.struts2.dispatcher.Dispatcher.init(Dispatcher.java:499)
> at
> org.apache.struts2.util.StrutsTestCaseHelper.initDispatcher(StrutsTestCaseHelper.java:47)
> at
> org.apache.struts2.StrutsJUnit4TestCase.initDispatcher(StrutsJUnit4TestCase.java:247)
> at
> org.apache.struts2.StrutsJUnit4TestCase.setUp(StrutsJUnit4TestCase.java:236)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (WW-4845) run, test, and validate Struts2 with Java9 and Java11
[ https://issues.apache.org/jira/browse/WW-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart resolved WW-4845. --- Resolution: Fixed PR got merged, hurraaa!!! > run, test, and validate Struts2 with Java9 and Java11 > - > > Key: WW-4845 > URL: https://issues.apache.org/jira/browse/WW-4845 > Project: Struts 2 > Issue Type: Task > Components: Core >Affects Versions: 2.5.13 >Reporter: adam brin >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.6 > > > it looks like Java9 will be released in September. While it may not be > possible to be compliant on day 1, it would be nice to have a formal release > that's certified with Java 9. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4845) run, test, and validate Struts2 with Java9
[ https://issues.apache.org/jira/browse/WW-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688202#comment-16688202 ] ASF subversion and git services commented on WW-4845: - Commit 16d6d21078eab6c59ada923c261ca911871b4ada in struts's branch refs/heads/master from [~yasser.zamani] [ https://gitbox.apache.org/repos/asf?p=struts.git;h=16d6d21 ] workaround coveralls fail on java 9 See also WW-4845 > run, test, and validate Struts2 with Java9 > -- > > Key: WW-4845 > URL: https://issues.apache.org/jira/browse/WW-4845 > Project: Struts 2 > Issue Type: Task > Components: Core >Affects Versions: 2.5.13 >Reporter: adam brin >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.6 > > > it looks like Java9 will be released in September. While it may not be > possible to be compliant on day 1, it would be nice to have a formal release > that's certified with Java 9. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (WW-4845) run, test, and validate Struts2 with Java9 and Java11
[ https://issues.apache.org/jira/browse/WW-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-4845: -- Summary: run, test, and validate Struts2 with Java9 and Java11 (was: run, test, and validate Struts2 with Java9) > run, test, and validate Struts2 with Java9 and Java11 > - > > Key: WW-4845 > URL: https://issues.apache.org/jira/browse/WW-4845 > Project: Struts 2 > Issue Type: Task > Components: Core >Affects Versions: 2.5.13 >Reporter: adam brin >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.6 > > > it looks like Java9 will be released in September. While it may not be > possible to be compliant on day 1, it would be nice to have a formal release > that's certified with Java 9. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4845) run, test, and validate Struts2 with Java9
[ https://issues.apache.org/jira/browse/WW-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688206#comment-16688206 ] ASF subversion and git services commented on WW-4845: - Commit 56d86a485b35f1d38ad5938d3cacb41b04933962 in struts's branch refs/heads/master from [~lukaszlenart] [ https://gitbox.apache.org/repos/asf?p=struts.git;h=56d86a4 ] Merge pull request #262 from yasserzamani/WW-4845 WW-4845 pass all current tests with java 9 > run, test, and validate Struts2 with Java9 > -- > > Key: WW-4845 > URL: https://issues.apache.org/jira/browse/WW-4845 > Project: Struts 2 > Issue Type: Task > Components: Core >Affects Versions: 2.5.13 >Reporter: adam brin >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.6 > > > it looks like Java9 will be released in September. While it may not be > possible to be compliant on day 1, it would be nice to have a formal release > that's certified with Java 9. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4845) run, test, and validate Struts2 with Java9
[ https://issues.apache.org/jira/browse/WW-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688207#comment-16688207 ] ASF subversion and git services commented on WW-4845: - Commit 56d86a485b35f1d38ad5938d3cacb41b04933962 in struts's branch refs/heads/master from [~lukaszlenart] [ https://gitbox.apache.org/repos/asf?p=struts.git;h=56d86a4 ] Merge pull request #262 from yasserzamani/WW-4845 WW-4845 pass all current tests with java 9 > run, test, and validate Struts2 with Java9 > -- > > Key: WW-4845 > URL: https://issues.apache.org/jira/browse/WW-4845 > Project: Struts 2 > Issue Type: Task > Components: Core >Affects Versions: 2.5.13 >Reporter: adam brin >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.6 > > > it looks like Java9 will be released in September. While it may not be > possible to be compliant on day 1, it would be nice to have a formal release > that's certified with Java 9. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4845) run, test, and validate Struts2 with Java9
[ https://issues.apache.org/jira/browse/WW-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688205#comment-16688205 ] ASF subversion and git services commented on WW-4845: - Commit 02abab365a402cf0d4f58d6b373c86f5bd59f1eb in struts's branch refs/heads/master from [~yasser.zamani] [ https://gitbox.apache.org/repos/asf?p=struts.git;h=02abab3 ] satisfy coveralls via testing with a not URLClassLoader See also WW-4845 > run, test, and validate Struts2 with Java9 > -- > > Key: WW-4845 > URL: https://issues.apache.org/jira/browse/WW-4845 > Project: Struts 2 > Issue Type: Task > Components: Core >Affects Versions: 2.5.13 >Reporter: adam brin >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.6 > > > it looks like Java9 will be released in September. While it may not be > possible to be compliant on day 1, it would be nice to have a formal release > that's certified with Java 9. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4845) run, test, and validate Struts2 with Java9
[ https://issues.apache.org/jira/browse/WW-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688200#comment-16688200 ] ASF subversion and git services commented on WW-4845: - Commit a5d888a3731e154c848afc6784d5da366a49eaa9 in struts's branch refs/heads/master from [~yasser.zamani] [ https://gitbox.apache.org/repos/asf?p=struts.git;h=a5d888a ] pass all current tests with java 9 See also WW-4845 > run, test, and validate Struts2 with Java9 > -- > > Key: WW-4845 > URL: https://issues.apache.org/jira/browse/WW-4845 > Project: Struts 2 > Issue Type: Task > Components: Core >Affects Versions: 2.5.13 >Reporter: adam brin >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.6 > > > it looks like Java9 will be released in September. While it may not be > possible to be compliant on day 1, it would be nice to have a formal release > that's certified with Java 9. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4845) run, test, and validate Struts2 with Java9
[ https://issues.apache.org/jira/browse/WW-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688204#comment-16688204 ] ASF subversion and git services commented on WW-4845: - Commit 7763156f4ea99d6a82cc0705a4beb1d19d1fc8ac in struts's branch refs/heads/master from [~yasser.zamani] [ https://gitbox.apache.org/repos/asf?p=struts.git;h=7763156 ] Merge branch 'master' of https://github.com/apache/struts into WW-4845 > run, test, and validate Struts2 with Java9 > -- > > Key: WW-4845 > URL: https://issues.apache.org/jira/browse/WW-4845 > Project: Struts 2 > Issue Type: Task > Components: Core >Affects Versions: 2.5.13 >Reporter: adam brin >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.6 > > > it looks like Java9 will be released in September. While it may not be > possible to be compliant on day 1, it would be nice to have a formal release > that's certified with Java 9. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4845) run, test, and validate Struts2 with Java9
[ https://issues.apache.org/jira/browse/WW-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688201#comment-16688201 ] ASF subversion and git services commented on WW-4845: - Commit e0c1edee5bd01787da9a619576e429a670c4c33a in struts's branch refs/heads/master from [~yasser.zamani] [ https://gitbox.apache.org/repos/asf?p=struts.git;h=e0c1ede ] Merge branch 'master' of https://github.com/apache/struts into WW-4845 > run, test, and validate Struts2 with Java9 > -- > > Key: WW-4845 > URL: https://issues.apache.org/jira/browse/WW-4845 > Project: Struts 2 > Issue Type: Task > Components: Core >Affects Versions: 2.5.13 >Reporter: adam brin >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.6 > > > it looks like Java9 will be released in September. While it may not be > possible to be compliant on day 1, it would be nice to have a formal release > that's certified with Java 9. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4845) run, test, and validate Struts2 with Java9
[ https://issues.apache.org/jira/browse/WW-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688203#comment-16688203 ] ASF subversion and git services commented on WW-4845: - Commit f8e19872c351d17b44af03a3d499aefc070524ac in struts's branch refs/heads/master from [~yasser.zamani] [ https://gitbox.apache.org/repos/asf?p=struts.git;h=f8e1987 ] skip coveralls on java 9 org.codehaus.mojo:cobertura-maven-plugin:2.7 doesn't work with java 9 See also WW-4845 > run, test, and validate Struts2 with Java9 > -- > > Key: WW-4845 > URL: https://issues.apache.org/jira/browse/WW-4845 > Project: Struts 2 > Issue Type: Task > Components: Core >Affects Versions: 2.5.13 >Reporter: adam brin >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.6 > > > it looks like Java9 will be released in September. While it may not be > possible to be compliant on day 1, it would be nice to have a formal release > that's certified with Java 9. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4845) run, test, and validate Struts2 with Java9
[
https://issues.apache.org/jira/browse/WW-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688199#comment-16688199
]
ASF GitHub Bot commented on WW-4845:
lukaszlenart closed pull request #262: WW-4845 pass all current tests with java
9
URL: https://github.com/apache/struts/pull/262
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index 14daf858e..8d985742d 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -4,6 +4,7 @@ sudo: false
jdk:
- openjdk7
- oraclejdk8
+ - oraclejdk9
install: true
script: mvn test -DskipAssembly
diff --git
a/core/src/main/java/com/opensymphony/xwork2/util/ClassPathFinder.java
b/core/src/main/java/com/opensymphony/xwork2/util/ClassPathFinder.java
index 518814939..5838abdef 100644
--- a/core/src/main/java/com/opensymphony/xwork2/util/ClassPathFinder.java
+++ b/core/src/main/java/com/opensymphony/xwork2/util/ClassPathFinder.java
@@ -27,6 +27,7 @@
import java.net.URISyntaxException;
import java.net.URL;
import java.net.URLClassLoader;
+import java.util.Collections;
import java.util.HashMap;
import java.util.Vector;
import java.util.zip.ZipEntry;
@@ -77,11 +78,7 @@ public void setPattern(String pattern) {
*/
public Vector findMatches() {
Vector matches = new Vector<>();
- URLClassLoader cl = getURLClassLoader();
- if (cl == null ) {
- throw new XWorkException("unable to attain an
URLClassLoader") ;
- }
- URL[] parentUrls = cl.getURLs();
+ URL[] parentUrls = getClassLoaderURLs();
compiledPattern = patternMatcher.compilePattern(pattern);
for (URL url : parentUrls) {
if (!"file".equals(url.getProtocol())) {
@@ -173,20 +170,24 @@ public void setPatternMatcher(PatternMatcher
patternMatcher) {
this.patternMatcher = patternMatcher;
}
- private URLClassLoader getURLClassLoader() {
- URLClassLoader ucl = null;
+ private URL[] getClassLoaderURLs() {
+ URL[] urls;
ClassLoader loader =
Thread.currentThread().getContextClassLoader();
-
- if(! (loader instanceof URLClassLoader)) {
+
+ if (!(loader instanceof URLClassLoader)) {
loader = ClassPathFinder.class.getClassLoader();
- if (loader instanceof URLClassLoader) {
- ucl = (URLClassLoader) loader ;
- }
}
- else {
- ucl = (URLClassLoader) loader;
+
+ if (loader instanceof URLClassLoader) {
+ urls = ((URLClassLoader) loader).getURLs();
+ } else {//jdk9 or later
+ try {
+ urls =
Collections.list(loader.getResources("")).toArray(new URL[0]);
+ } catch (IOException e) {
+ throw new XWorkException("unable to get
ClassLoader URLs", e);
+ }
}
-
- return ucl ;
+
+ return urls;
}
}
diff --git a/core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java
b/core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java
index bca4f136d..2541ad5a1 100644
--- a/core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java
+++ b/core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java
@@ -27,6 +27,7 @@
import com.opensymphony.xwork2.util.*;
import com.opensymphony.xwork2.util.reflection.ReflectionContextState;
import ognl.*;
+import org.apache.struts2.TestUtils;
import java.lang.reflect.Method;
import java.util.*;
@@ -374,8 +375,18 @@ public void testSetPropertiesDate() {
assertEquals(cal.getTime(), foo.getBirthday());
//UK style test
-props.put("event", "18/10/2006 14:23:45");
-props.put("meeting", "09/09/2006 14:30");
+if (TestUtils.isJdk9OrLater()) {
+/* In JDK 9 and later, the default locale data uses data derived
from the
+Unicode Consortium's Common Locale Data Repository (CLDR). The
short date-time format is ‹{1}, {0}› in the
+CLDR locale, as opposed to {1} {0} in the JRE locale data.
+Please refer :
http://www.oracle.com/technetwork/java/javase/9-relnote-issues-3704069.html#JDK-8008577
*/
+props.put("event", "18/10/2006, 14:23:45");
+props.put("meeting", "09/09/2006, 14:30");
+}
+else {
+props.put("event", "18/10/2006 14:23:45");
[jira] [Resolved] (WW-4930) SMI cannot be diasabled for action-packages found via the convention-plugin
[
https://issues.apache.org/jira/browse/WW-4930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart resolved WW-4930.
---
Resolution: Fixed
PR got merged, thank you :)
> SMI cannot be diasabled for action-packages found via the convention-plugin
> ---
>
> Key: WW-4930
> URL: https://issues.apache.org/jira/browse/WW-4930
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Convention
>Affects Versions: 2.5.16
> Environment: Windows 10
> Java 1.8
>Reporter: Philipp Heidelbach
>Priority: Major
> Fix For: 2.6
>
>
> I'm trying to update Struts 2.3.34 to 2.5.16 and disabling SMI doesn't seem
> to work.
> I debuged XmlConfigurationProvider but in the packageConfig of our package
> (named default see below) SMI is correctly set to false. Debugging
> PackageBaseActionConfigBuilder shows that our default-package is used as
> parent package and in the parentPkg SMI is set to false. The pkgConfig
> however is alwasy null (line: 1043) and so a new package config is created in
> which SMI is set to true.
> Thus for all these actions methods i get the error that these methods aren't
> allowed.
> If I use @AllowedMethod-annotations it works fine.
> Below the beginning of our struts.xml
> {code:xml}
>
> "-//Apache Software Foundation//DTD Struts Configuration 2.5//EN"
> "http://struts.apache.org/dtds/struts-2.5.dtd;>
>
>
> value="jar,zip,vfsfile,vfszip" />
> value=".*/newd[-.\w]*\.jar(!/)?" />
> value="org.apache.struts.*,org.apache.struts2.*,org.springframework.web.struts.*,org.springframework.web.struts2.*,org.hibernate.*"
> />
>
> value="applicationResources" />
>
>
>
>
>
>
>
>
> strict-method-invocation="false">
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4930) SMI cannot be diasabled for action-packages found via the convention-plugin
[
https://issues.apache.org/jira/browse/WW-4930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688193#comment-16688193
]
ASF subversion and git services commented on WW-4930:
-
Commit 772f8999b7a0993cb936534d4e16a06c4a446309 in struts's branch
refs/heads/master from [~lukaszlenart]
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=772f899 ]
Merge pull request #267 from
pHeidelbach/WW-4930-smi-cannot-be-disabled-for-action-packges-found-via-convention-plugin
WW-4930 Add constant to enable smi inheritance
> SMI cannot be diasabled for action-packages found via the convention-plugin
> ---
>
> Key: WW-4930
> URL: https://issues.apache.org/jira/browse/WW-4930
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Convention
>Affects Versions: 2.5.16
> Environment: Windows 10
> Java 1.8
>Reporter: Philipp Heidelbach
>Priority: Major
> Fix For: 2.6
>
>
> I'm trying to update Struts 2.3.34 to 2.5.16 and disabling SMI doesn't seem
> to work.
> I debuged XmlConfigurationProvider but in the packageConfig of our package
> (named default see below) SMI is correctly set to false. Debugging
> PackageBaseActionConfigBuilder shows that our default-package is used as
> parent package and in the parentPkg SMI is set to false. The pkgConfig
> however is alwasy null (line: 1043) and so a new package config is created in
> which SMI is set to true.
> Thus for all these actions methods i get the error that these methods aren't
> allowed.
> If I use @AllowedMethod-annotations it works fine.
> Below the beginning of our struts.xml
> {code:xml}
>
> "-//Apache Software Foundation//DTD Struts Configuration 2.5//EN"
> "http://struts.apache.org/dtds/struts-2.5.dtd;>
>
>
> value="jar,zip,vfsfile,vfszip" />
> value=".*/newd[-.\w]*\.jar(!/)?" />
> value="org.apache.struts.*,org.apache.struts2.*,org.springframework.web.struts.*,org.springframework.web.struts2.*,org.hibernate.*"
> />
>
> value="applicationResources" />
>
>
>
>
>
>
>
>
> strict-method-invocation="false">
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4930) SMI cannot be diasabled for action-packages found via the convention-plugin
[
https://issues.apache.org/jira/browse/WW-4930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688194#comment-16688194
]
ASF subversion and git services commented on WW-4930:
-
Commit 772f8999b7a0993cb936534d4e16a06c4a446309 in struts's branch
refs/heads/master from [~lukaszlenart]
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=772f899 ]
Merge pull request #267 from
pHeidelbach/WW-4930-smi-cannot-be-disabled-for-action-packges-found-via-convention-plugin
WW-4930 Add constant to enable smi inheritance
> SMI cannot be diasabled for action-packages found via the convention-plugin
> ---
>
> Key: WW-4930
> URL: https://issues.apache.org/jira/browse/WW-4930
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Convention
>Affects Versions: 2.5.16
> Environment: Windows 10
> Java 1.8
>Reporter: Philipp Heidelbach
>Priority: Major
> Fix For: 2.6
>
>
> I'm trying to update Struts 2.3.34 to 2.5.16 and disabling SMI doesn't seem
> to work.
> I debuged XmlConfigurationProvider but in the packageConfig of our package
> (named default see below) SMI is correctly set to false. Debugging
> PackageBaseActionConfigBuilder shows that our default-package is used as
> parent package and in the parentPkg SMI is set to false. The pkgConfig
> however is alwasy null (line: 1043) and so a new package config is created in
> which SMI is set to true.
> Thus for all these actions methods i get the error that these methods aren't
> allowed.
> If I use @AllowedMethod-annotations it works fine.
> Below the beginning of our struts.xml
> {code:xml}
>
> "-//Apache Software Foundation//DTD Struts Configuration 2.5//EN"
> "http://struts.apache.org/dtds/struts-2.5.dtd;>
>
>
> value="jar,zip,vfsfile,vfszip" />
> value=".*/newd[-.\w]*\.jar(!/)?" />
> value="org.apache.struts.*,org.apache.struts2.*,org.springframework.web.struts.*,org.springframework.web.struts2.*,org.hibernate.*"
> />
>
> value="applicationResources" />
>
>
>
>
>
>
>
>
> strict-method-invocation="false">
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4930) SMI cannot be diasabled for action-packages found via the convention-plugin
[
https://issues.apache.org/jira/browse/WW-4930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688191#comment-16688191
]
ASF subversion and git services commented on WW-4930:
-
Commit 38b96b11fe043a6892108b28d0758a9f0d4533e8 in struts's branch
refs/heads/master from [~Heidelbach]
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=38b96b1 ]
WW-4930 Add constant to enable smi inheritance between parent package configs
and its children
> SMI cannot be diasabled for action-packages found via the convention-plugin
> ---
>
> Key: WW-4930
> URL: https://issues.apache.org/jira/browse/WW-4930
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Convention
>Affects Versions: 2.5.16
> Environment: Windows 10
> Java 1.8
>Reporter: Philipp Heidelbach
>Priority: Major
> Fix For: 2.6
>
>
> I'm trying to update Struts 2.3.34 to 2.5.16 and disabling SMI doesn't seem
> to work.
> I debuged XmlConfigurationProvider but in the packageConfig of our package
> (named default see below) SMI is correctly set to false. Debugging
> PackageBaseActionConfigBuilder shows that our default-package is used as
> parent package and in the parentPkg SMI is set to false. The pkgConfig
> however is alwasy null (line: 1043) and so a new package config is created in
> which SMI is set to true.
> Thus for all these actions methods i get the error that these methods aren't
> allowed.
> If I use @AllowedMethod-annotations it works fine.
> Below the beginning of our struts.xml
> {code:xml}
>
> "-//Apache Software Foundation//DTD Struts Configuration 2.5//EN"
> "http://struts.apache.org/dtds/struts-2.5.dtd;>
>
>
> value="jar,zip,vfsfile,vfszip" />
> value=".*/newd[-.\w]*\.jar(!/)?" />
> value="org.apache.struts.*,org.apache.struts2.*,org.springframework.web.struts.*,org.springframework.web.struts2.*,org.hibernate.*"
> />
>
> value="applicationResources" />
>
>
>
>
>
>
>
>
> strict-method-invocation="false">
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4930) SMI cannot be diasabled for action-packages found via the convention-plugin
[
https://issues.apache.org/jira/browse/WW-4930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688190#comment-16688190
]
ASF GitHub Bot commented on WW-4930:
lukaszlenart closed pull request #267: WW-4930 Add constant to enable smi
inheritance
URL: https://github.com/apache/struts/pull/267
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/plugins/convention/src/main/java/org/apache/struts2/convention/ConventionConstants.java
b/plugins/convention/src/main/java/org/apache/struts2/convention/ConventionConstants.java
index 46ec9d46c..d63c3c275 100644
---
a/plugins/convention/src/main/java/org/apache/struts2/convention/ConventionConstants.java
+++
b/plugins/convention/src/main/java/org/apache/struts2/convention/ConventionConstants.java
@@ -49,4 +49,6 @@
public static final String CONVENTION_ACTION_MAP_ALL_MATCHES =
"struts.convention.action.mapAllMatches";
public static final String CONVENTION_ACTION_EAGER_LOADING =
"struts.convention.action.eagerLoading";
public static final String CONVENTION_RESULT_FLAT_LAYOUT =
"struts.convention.result.flatLayout";
+/** Enables the inheritance of the SMI value from a parent package config
to its children */
+public static final String CONVENTION_ENABLE_SMI_INHERITANCE =
"struts.convention.enable.smi.inheritance";
}
diff --git
a/plugins/convention/src/main/java/org/apache/struts2/convention/PackageBasedActionConfigBuilder.java
b/plugins/convention/src/main/java/org/apache/struts2/convention/PackageBasedActionConfigBuilder.java
index bc586d4ac..764e72945 100644
---
a/plugins/convention/src/main/java/org/apache/struts2/convention/PackageBasedActionConfigBuilder.java
+++
b/plugins/convention/src/main/java/org/apache/struts2/convention/PackageBasedActionConfigBuilder.java
@@ -84,6 +84,7 @@
private boolean alwaysMapExecute;
private boolean excludeParentClassLoader;
private boolean slashesInActionNames;
+private boolean enableSmiInheritance;
private static final String DEFAULT_METHOD = "execute";
private boolean eagerLoading = false;
@@ -102,12 +103,14 @@
* action for indexes. If this is set to
true, index actions are not created because
* the unknown handler will redirect from
/foo to /foo/. The only action that is created
* is to the empty action in the namespace
(e.g. the namespace /foo and the action "").
+ * @param enableSmiInheritance A boolean parameter which determines if a
newly created package config inherits the SMI value of its parent package config
* @param defaultParentPackage The default parent package for all the
configuration.
*/
@Inject
public PackageBasedActionConfigBuilder(Configuration configuration,
Container container, ObjectFactory objectFactory,
@Inject(ConventionConstants.CONVENTION_REDIRECT_TO_SLASH) String
redirectToSlash,
-
@Inject(ConventionConstants.CONVENTION_DEFAULT_PARENT_PACKAGE) String
defaultParentPackage) {
+
@Inject(ConventionConstants.CONVENTION_DEFAULT_PARENT_PACKAGE) String
defaultParentPackage,
+
@Inject(ConventionConstants.CONVENTION_ENABLE_SMI_INHERITANCE) String
enableSmiInheritance) {
// Validate that the parameters are okay
this.configuration = configuration;
@@ -116,6 +119,7 @@ public PackageBasedActionConfigBuilder(Configuration
configuration, Container co
this.interceptorMapBuilder =
container.getInstance(InterceptorMapBuilder.class,
container.getInstance(String.class,
ConventionConstants.CONVENTION_INTERCEPTOR_MAP_BUILDER));
this.objectFactory = objectFactory;
this.redirectToSlash = Boolean.parseBoolean(redirectToSlash);
+this.enableSmiInheritance = Boolean.parseBoolean(enableSmiInheritance);
if (LOG.isTraceEnabled()) {
LOG.trace("Setting action default parent package to [{}]",
defaultParentPackage);
@@ -1042,6 +1046,9 @@ protected void createActionConfig(PackageConfig.Builder
pkgCfg, Class actionC
PackageConfig.Builder pkgConfig = packageConfigs.get(name);
if (pkgConfig == null) {
pkgConfig = new
PackageConfig.Builder(name).namespace(actionNamespace).addParent(parentPkg);
+if (enableSmiInheritance) {
+
pkgConfig.strictMethodInvocation(parentPkg.isStrictMethodInvocation());
+}
packageConfigs.put(name, pkgConfig);
//check for @DefaultInterceptorRef in the
