yasserzamani commented on pull request #470:
URL: https://github.com/apache/struts/pull/470#issuecomment-769862709
LGTM thanks! :+1:
This is an automated message from the Apache Git Service.
To respond to the message, please
coveralls commented on pull request #471:
URL: https://github.com/apache/struts/pull/471#issuecomment-774337349
[](https://coveralls.io/builds/36914438)
Coverage increased (+0.8%) to 50.677% when pulling
**6b0369013f3
JCgH4164838Gh792C124B5 commented on a change in pull request #442:
URL: https://github.com/apache/struts/pull/442#discussion_r571489536
##
File path: core/src/main/java/org/apache/struts2/views/TagAttribute.java
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Founda
lukaszlenart commented on pull request #471:
URL: https://github.com/apache/struts/pull/471#issuecomment-774688467
Good catch! Would you mind creating a JIRA ticket and referencing it here?
https://issues.apache.org/jira/projects/WW/
-
Marcono1234 commented on pull request #471:
URL: https://github.com/apache/struts/pull/471#issuecomment-774719253
https://issues.apache.org/jira/browse/WW-5116
This is an automated message from the Apache Git Service.
To resp
coveralls edited a comment on pull request #471:
URL: https://github.com/apache/struts/pull/471#issuecomment-774337349
[](https://coveralls.io/builds/36929864)
Coverage remained the same at 49.898% when pulling
**53c0
lukaszlenart commented on pull request #471:
URL: https://github.com/apache/struts/pull/471#issuecomment-774903630
Thanks a lot! LGTM 👍
This is an automated message from the Apache Git Service.
To respond to the message, ple
lukaszlenart commented on pull request #471:
URL: https://github.com/apache/struts/pull/471#issuecomment-774903874
@Marcono1234 do you want to cherry-pick this change into 2.5.x?
This is an automated message from the Apache G
Marcono1234 commented on pull request #471:
URL: https://github.com/apache/struts/pull/471#issuecomment-775259330
Created #472 for it, I hope it is fine like this.
This is an automated message from the Apache Git Service.
To
coveralls commented on pull request #472:
URL: https://github.com/apache/struts/pull/472#issuecomment-775283973
[](https://coveralls.io/builds/36954348)
Coverage remained the same at 47.305% when pulling
**cb5e55b06c4
lukaszlenart commented on pull request #472:
URL: https://github.com/apache/struts/pull/472#issuecomment-775373241
Nice, thanks a lot! LGTM 👍
This is an automated message from the Apache Git Service.
To respond to the messag
coveralls commented on pull request #474:
URL: https://github.com/apache/struts/pull/474#issuecomment-784196812
[](https://coveralls.io/builds/37370896)
Coverage increased (+0.0009%) to 49.898% when pulling
**92afe8b8
lukaszlenart commented on pull request #474:
URL: https://github.com/apache/struts/pull/474#issuecomment-784951793
You must also modify
[`template/simple/textarea.ftl`](https://github.com/apache/struts/blob/master/core/src/main/resources/template/simple/textarea.ftl#L21-L47),
add something
lukaszlenart commented on pull request #474:
URL: https://github.com/apache/struts/pull/474#issuecomment-784952140
Also would you mind adding `minlength`?
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea#attributes
--
kerttup commented on pull request #474:
URL: https://github.com/apache/struts/pull/474#issuecomment-786594208
Modified textarea.ftl and added also minlength attribute.
This is an automated message from the Apache Git Service.
coveralls edited a comment on pull request #474:
URL: https://github.com/apache/struts/pull/474#issuecomment-784196812
[](https://coveralls.io/builds/37478080)
Coverage increased (+0.002%) to 49.899% when pulling
**25
lukaszlenart commented on pull request #474:
URL: https://github.com/apache/struts/pull/474#issuecomment-787413059
@kerttup do you plan port these changes into 2.5.x branch?
This is an automated message from the Apache Git Se
coveralls commented on pull request #475:
URL: https://github.com/apache/struts/pull/475#issuecomment-791972851
[](https://coveralls.io/builds/37708166)
Coverage increased (+0.005%) to 47.31% when pulling
**4afa345c65
yasserzamani commented on a change in pull request #475:
URL: https://github.com/apache/struts/pull/475#discussion_r593729482
##
File path: core/src/test/java/org/apache/struts2/views/jsp/ui/HiddenTest.java
##
@@ -62,6 +62,23 @@ public void testDisabled() throws Exception {
kerttup commented on pull request #474:
URL: https://github.com/apache/struts/pull/474#issuecomment-798849349
Hi @lukaszlenart, what do you mean with plan port? This was my first pull
request so I am new to this and dont know the practices yet.
lukaszlenart commented on pull request #474:
URL: https://github.com/apache/struts/pull/474#issuecomment-798873619
We are currently developing two versions of Struts
- `master` branch represents incoming [Struts
2.6](https://issues.apache.org/jira/projects/WW/versions/12340222)
- `str
kerttup commented on pull request #474:
URL: https://github.com/apache/struts/pull/474#issuecomment-798887582
Thanks for the clarification. I think this can wait until the next version.
This is an automated message from the A
lukaszlenart commented on pull request #476:
URL: https://github.com/apache/struts/pull/476#issuecomment-799335078
Is it related to https://issues.apache.org/jira/browse/WW-5119 ?
This is an automated message from the Apache
davoustp commented on pull request #476:
URL: https://github.com/apache/struts/pull/476#issuecomment-799337438
> Is it related to https://issues.apache.org/jira/browse/WW-5119 ?
Yes, indeed this is the same issue. I did not find it prior to your comment,
sorry for the duplicate. :-(
davoustp commented on pull request #476:
URL: https://github.com/apache/struts/pull/476#issuecomment-799338596
BTW, I also provided a separated pull request #477 (backport for Struts
2.5.x) using JDK 1.7.
This is an automate
coveralls commented on pull request #476:
URL: https://github.com/apache/struts/pull/476#issuecomment-799341393
[](https://coveralls.io/builds/37934367)
Coverage remained the same at 49.899% when pulling
**83c2354bb3b
coveralls commented on pull request #477:
URL: https://github.com/apache/struts/pull/477#issuecomment-799346239
[](https://coveralls.io/builds/37934586)
Coverage remained the same at 47.305% when pulling
**69669d6cf76
lukaszlenart commented on pull request #476:
URL: https://github.com/apache/struts/pull/476#issuecomment-799439352
@davoustp did you create additional ticket in JIRA? Or
[WW-5119](https://issues.apache.org/jira/browse/WW-5119) is enough?
---
coveralls edited a comment on pull request #476:
URL: https://github.com/apache/struts/pull/476#issuecomment-799341393
[](https://coveralls.io/builds/37939155)
Coverage remained the same at 49.899% when pulling
**83c2
coveralls edited a comment on pull request #477:
URL: https://github.com/apache/struts/pull/477#issuecomment-799346239
[](https://coveralls.io/builds/37940077)
Coverage remained the same at 47.305% when pulling
**6966
davoustp commented on pull request #476:
URL: https://github.com/apache/struts/pull/476#issuecomment-800166219
> @davoustp did you create additional ticket in JIRA? Or
[WW-5119](https://issues.apache.org/jira/browse/WW-5119) is enough?
I did not create any JIRA issue, I believe
[WW-
JCgH4164838Gh792C124B5 commented on a change in pull request #477:
URL: https://github.com/apache/struts/pull/477#discussion_r598130091
##
File path:
core/src/main/java/com/opensymphony/xwork2/util/AbstractLocalizedTextProvider.java
##
@@ -413,11 +411,11 @@ public ResourceBund
davoustp commented on a change in pull request #477:
URL: https://github.com/apache/struts/pull/477#discussion_r598487391
##
File path:
core/src/main/java/com/opensymphony/xwork2/util/AbstractLocalizedTextProvider.java
##
@@ -413,11 +411,11 @@ public ResourceBundle findResourc
lukaszlenart commented on pull request #476:
URL: https://github.com/apache/struts/pull/476#issuecomment-803917762
Osm! LGTM 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
lukaszlenart commented on pull request #477:
URL: https://github.com/apache/struts/pull/477#issuecomment-803918375
nice 👏
LGTM 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
lukaszlenart commented on a change in pull request #475:
URL: https://github.com/apache/struts/pull/475#discussion_r598558156
##
File path: core/src/test/java/org/apache/struts2/views/jsp/ui/HiddenTest.java
##
@@ -62,6 +62,23 @@ public void testDisabled() throws Exception {
davoustp commented on pull request #478:
URL: https://github.com/apache/struts/pull/478#issuecomment-803945975
Also available for Struts 2.5.x with #479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
coveralls commented on pull request #478:
URL: https://github.com/apache/struts/pull/478#issuecomment-804649945
[](https://coveralls.io/builds/38164476)
Coverage increased (+0.002%) to 49.901% when pulling
**cb2c67e80
coveralls commented on pull request #479:
URL: https://github.com/apache/struts/pull/479#issuecomment-804652950
[](https://coveralls.io/builds/38164614)
Coverage increased (+0.0009%) to 47.306% when pulling
**ce8b75de
lukaszlenart commented on pull request #478:
URL: https://github.com/apache/struts/pull/478#issuecomment-804662672
Looks good to me 💯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
yasserzamani commented on a change in pull request #475:
URL: https://github.com/apache/struts/pull/475#discussion_r599693052
##
File path: core/src/test/java/org/apache/struts2/views/jsp/ui/HiddenTest.java
##
@@ -62,6 +62,23 @@ public void testDisabled() throws Exception {
yasserzamani commented on pull request #478:
URL: https://github.com/apache/struts/pull/478#issuecomment-805023433
Awesome :100: thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
yasserzamani commented on pull request #479:
URL: https://github.com/apache/struts/pull/479#issuecomment-805024615
Awesome :clap: thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
lukaszlenart commented on a change in pull request #475:
URL: https://github.com/apache/struts/pull/475#discussion_r599835153
##
File path: core/src/test/java/org/apache/struts2/views/jsp/ui/HiddenTest.java
##
@@ -62,6 +62,23 @@ public void testDisabled() throws Exception {
coveralls edited a comment on pull request #475:
URL: https://github.com/apache/struts/pull/475#issuecomment-791972851
[](https://coveralls.io/builds/38198531)
Coverage increased (+0.007%) to 47.312% when pulling
**af
yasserzamani commented on a change in pull request #475:
URL: https://github.com/apache/struts/pull/475#discussion_r600332987
##
File path: core/src/test/java/org/apache/struts2/views/jsp/ui/HiddenTest.java
##
@@ -62,6 +62,23 @@ public void testDisabled() throws Exception {
lukaszlenart commented on a change in pull request #475:
URL: https://github.com/apache/struts/pull/475#discussion_r601072788
##
File path: core/src/test/java/org/apache/struts2/views/jsp/ui/HiddenTest.java
##
@@ -62,6 +62,23 @@ public void testDisabled() throws Exception {
yasserzamani commented on a change in pull request #475:
URL: https://github.com/apache/struts/pull/475#discussion_r601267884
##
File path:
core/src/main/java/org/apache/struts2/components/template/FreemarkerTemplateEngine.java
##
@@ -144,15 +144,23 @@ public void close() thro
yasserzamani commented on a change in pull request #475:
URL: https://github.com/apache/struts/pull/475#discussion_r601270882
##
File path: core/src/test/java/org/apache/struts2/views/jsp/ui/HiddenTest.java
##
@@ -62,6 +62,23 @@ public void testDisabled() throws Exception {
yasserzamani commented on a change in pull request #475:
URL: https://github.com/apache/struts/pull/475#discussion_r601267884
##
File path:
core/src/main/java/org/apache/struts2/components/template/FreemarkerTemplateEngine.java
##
@@ -144,15 +144,23 @@ public void close() thro
lukaszlenart commented on a change in pull request #475:
URL: https://github.com/apache/struts/pull/475#discussion_r601289403
##
File path:
core/src/main/java/org/apache/struts2/components/template/FreemarkerTemplateEngine.java
##
@@ -144,15 +144,23 @@ public void close() thro
yasserzamani commented on a change in pull request #475:
URL: https://github.com/apache/struts/pull/475#discussion_r601362788
##
File path:
core/src/main/java/org/apache/struts2/components/template/FreemarkerTemplateEngine.java
##
@@ -144,15 +144,20 @@ public void close() thro
lukaszlenart commented on a change in pull request #475:
URL: https://github.com/apache/struts/pull/475#discussion_r601414991
##
File path:
core/src/main/java/org/apache/struts2/components/template/FreemarkerTemplateEngine.java
##
@@ -144,15 +144,20 @@ public void close() thro
yasserzamani commented on a change in pull request #475:
URL: https://github.com/apache/struts/pull/475#discussion_r601425835
##
File path:
core/src/main/java/org/apache/struts2/components/template/FreemarkerTemplateEngine.java
##
@@ -144,15 +144,20 @@ public void close() thro
yasserzamani commented on a change in pull request #475:
URL: https://github.com/apache/struts/pull/475#discussion_r601425835
##
File path:
core/src/main/java/org/apache/struts2/components/template/FreemarkerTemplateEngine.java
##
@@ -144,15 +144,20 @@ public void close() thro
lukaszlenart commented on a change in pull request #475:
URL: https://github.com/apache/struts/pull/475#discussion_r601434876
##
File path:
core/src/main/java/org/apache/struts2/components/template/FreemarkerTemplateEngine.java
##
@@ -144,15 +144,20 @@ public void close() thro
lukaszlenart commented on pull request #475:
URL: https://github.com/apache/struts/pull/475#issuecomment-806639011
Please squash this PR if so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
yasserzamani commented on a change in pull request #475:
URL: https://github.com/apache/struts/pull/475#discussion_r601457831
##
File path:
core/src/main/java/org/apache/struts2/components/template/FreemarkerTemplateEngine.java
##
@@ -121,6 +121,10 @@ public void renderTemplat
coveralls commented on pull request #480:
URL: https://github.com/apache/struts/pull/480#issuecomment-807984873
[](https://coveralls.io/builds/38273883)
Coverage increased (+0.009%) to 49.91% when pulling
**ed3323c362
yasserzamani commented on pull request #480:
URL: https://github.com/apache/struts/pull/480#issuecomment-808063351
Thanks! LGTM:+1:
P.S. looks like apache hasn't had enough resource to build and is timed out.
Not sure if we should do anything
--
This is an automated message from t
yasserzamani commented on pull request #481:
URL: https://github.com/apache/struts/pull/481#issuecomment-811307202
@apache/struts-committers hi :)
I'm working to add tests which verify that this solution resolves all
publicly known issues googled by `Struts double evaluation`.
coveralls commented on pull request #481:
URL: https://github.com/apache/struts/pull/481#issuecomment-811419775
[](https://coveralls.io/builds/38439677)
Coverage increased (+0.02%) to 49.934% when pulling
**1b2c8ef63b
coveralls edited a comment on pull request #481:
URL: https://github.com/apache/struts/pull/481#issuecomment-811419775
[](https://coveralls.io/builds/38461991)
Coverage increased (+0.02%) to 49.934% when pulling
**ec0
coveralls commented on pull request #482:
URL: https://github.com/apache/struts/pull/482#issuecomment-812892448
[](https://coveralls.io/builds/38510915)
Coverage increased (+0.007%) to 47.32% when pulling
**f2dcda06b4
coveralls edited a comment on pull request #481:
URL: https://github.com/apache/struts/pull/481#issuecomment-811419775
[](https://coveralls.io/builds/38511738)
Coverage increased (+0.02%) to 49.928% when pulling
**caa
coveralls edited a comment on pull request #481:
URL: https://github.com/apache/struts/pull/481#issuecomment-811419775
[](https://coveralls.io/builds/38516963)
Coverage increased (+0.03%) to 49.939% when pulling
**ff0
coveralls edited a comment on pull request #482:
URL: https://github.com/apache/struts/pull/482#issuecomment-812892448
[](https://coveralls.io/builds/38533524)
Coverage increased (+0.004%) to 47.316% when pulling
**0f
yasserzamani removed a comment on pull request #481:
URL: https://github.com/apache/struts/pull/481#issuecomment-811307202
@apache/struts-committers hi :)
I'm working to add tests which verify that this solution resolves all
publicly known issues googled by `Struts double evaluation`
coveralls commented on pull request #483:
URL: https://github.com/apache/struts/pull/483#issuecomment-816754380
[](https://coveralls.io/builds/38681471)
Coverage increased (+0.008%) to 49.918% when pulling
**a7884f9df
coveralls edited a comment on pull request #483:
URL: https://github.com/apache/struts/pull/483#issuecomment-816754380
[](https://coveralls.io/builds/38698460)
Coverage increased (+0.01%) to 49.923% when pulling
**3fe
coveralls edited a comment on pull request #483:
URL: https://github.com/apache/struts/pull/483#issuecomment-816754380
[](https://coveralls.io/builds/38710148)
Coverage increased (+0.02%) to 49.932% when pulling
**a6e
coveralls edited a comment on pull request #483:
URL: https://github.com/apache/struts/pull/483#issuecomment-816754380
[](https://coveralls.io/builds/38823243)
Coverage increased (+0.04%) to 49.948% when pulling
**169
coveralls edited a comment on pull request #483:
URL: https://github.com/apache/struts/pull/483#issuecomment-816754380
[](https://coveralls.io/builds/38867748)
Coverage increased (+0.04%) to 49.953% when pulling
**b9c
lukaszlenart commented on a change in pull request #483:
URL: https://github.com/apache/struts/pull/483#discussion_r615232225
##
File path:
core/src/main/java/com/opensymphony/xwork2/interceptor/AliasInterceptor.java
##
@@ -167,7 +182,13 @@ public void setAliasesKey(String ali
lukaszlenart commented on a change in pull request #483:
URL: https://github.com/apache/struts/pull/483#discussion_r615232488
##
File path: core/src/main/java/org/apache/struts2/components/Component.java
##
@@ -571,4 +576,39 @@ public boolean isValidTagAttribute(String attrName
coveralls edited a comment on pull request #483:
URL: https://github.com/apache/struts/pull/483#issuecomment-816754380
[](https://coveralls.io/builds/38903689)
Coverage increased (+0.05%) to 49.956% when pulling
**cd9
yasserzamani commented on a change in pull request #483:
URL: https://github.com/apache/struts/pull/483#discussion_r615233956
##
File path: core/src/main/java/org/apache/struts2/components/Component.java
##
@@ -571,4 +576,39 @@ public boolean isValidTagAttribute(String attrName
yasserzamani commented on a change in pull request #483:
URL: https://github.com/apache/struts/pull/483#discussion_r615233956
##
File path: core/src/main/java/org/apache/struts2/components/Component.java
##
@@ -571,4 +576,39 @@ public boolean isValidTagAttribute(String attrName
yasserzamani commented on a change in pull request #483:
URL: https://github.com/apache/struts/pull/483#discussion_r615236192
##
File path: core/src/main/java/org/apache/struts2/components/Component.java
##
@@ -571,4 +576,39 @@ public boolean isValidTagAttribute(String attrName
yasserzamani commented on a change in pull request #483:
URL: https://github.com/apache/struts/pull/483#discussion_r615237515
##
File path:
core/src/main/java/com/opensymphony/xwork2/interceptor/AliasInterceptor.java
##
@@ -167,7 +182,13 @@ public void setAliasesKey(String ali
yasserzamani commented on a change in pull request #483:
URL: https://github.com/apache/struts/pull/483#discussion_r615238766
##
File path:
core/src/main/java/com/opensymphony/xwork2/interceptor/AliasInterceptor.java
##
@@ -167,7 +182,13 @@ public void setAliasesKey(String ali
coveralls edited a comment on pull request #483:
URL: https://github.com/apache/struts/pull/483#issuecomment-816754380
[](https://coveralls.io/builds/38907453)
Coverage increased (+0.1%) to 50.038% when pulling
**921b
yasserzamani commented on pull request #482:
URL: https://github.com/apache/struts/pull/482#issuecomment-825548370
I think the reported issue is invalid. please refer to my comment in
corresponding jira ticket
--
This is an automated message from the Apache Git Service.
To respond to the
yasserzamani commented on pull request #469:
URL: https://github.com/apache/struts/pull/469#issuecomment-825549392
I think your DMI isn't enabled at all because I see that
DefaultAcceptedPatternsChecker setAcceptedPatterns(DMI_AWARE_ACCEPTED_PATTERNS)
when DMI is enabled but in same time I
coveralls commented on pull request #484:
URL: https://github.com/apache/struts/pull/484#issuecomment-826303487
[](https://coveralls.io/builds/39105809)
Coverage remained the same at 47.312% when pulling
**20e4529e355
coveralls commented on pull request #485:
URL: https://github.com/apache/struts/pull/485#issuecomment-826338414
[](https://coveralls.io/builds/39107488)
Coverage increased (+0.003%) to 47.316% when pulling
**509663717
coveralls commented on pull request #484:
URL: https://github.com/apache/struts/pull/484#issuecomment-826303487
[](https://coveralls.io/builds/39105809)
Coverage remained the same at 47.312% when pulling
**20e4529e355
coveralls commented on pull request #485:
URL: https://github.com/apache/struts/pull/485#issuecomment-826338414
[](https://coveralls.io/builds/39107488)
Coverage increased (+0.003%) to 47.316% when pulling
**509663717
aleksandr-m commented on pull request #485:
URL: https://github.com/apache/struts/pull/485#issuecomment-827137538
@yasserzamani Can you explain why comparing with `==` is better in this
context?
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
aleksandr-m commented on pull request #483:
URL: https://github.com/apache/struts/pull/483#issuecomment-827142363
@yasserzamani Will this work with the following code?
```
```
Can we have some tests for that too?
--
This is an automated message fr
yasserzamani commented on pull request #485:
URL: https://github.com/apache/struts/pull/485#issuecomment-827339324
Thanks for the review @aleksandr-m !
TBH I don't have a strong reason. [I've asked
reporter](https://issues.apache.org/jira/browse/WW-5126?focusedCommentId=17329388&page
yasserzamani commented on pull request #483:
URL: https://github.com/apache/struts/pull/483#issuecomment-827349385
Thanks for your review @aleksandr-m ! Yes I think it will work. Assume
`itemId2` and `key->items[2].name` where both will pass accepted/excluded
patterns if they are needed to
yasserzamani commented on pull request #483:
URL: https://github.com/apache/struts/pull/483#issuecomment-829165726
@aleksandr-m as promised, [here you
are](https://github.com/apache/struts/blob/466fcfbfa2476a8c643288648bce002afa09ca3b/core/src/test/java/org/apache/struts2/views/freemarker/F
coveralls edited a comment on pull request #483:
URL: https://github.com/apache/struts/pull/483#issuecomment-816754380
[](https://coveralls.io/builds/39223422)
Coverage increased (+0.1%) to 50.043% when pulling
**466f
yasserzamani commented on a change in pull request #483:
URL: https://github.com/apache/struts/pull/483#discussion_r623122567
##
File path: core/src/main/java/org/apache/struts2/components/Component.java
##
@@ -571,4 +576,39 @@ public boolean isValidTagAttribute(String attrName
yasserzamani commented on a change in pull request #483:
URL: https://github.com/apache/struts/pull/483#discussion_r623122804
##
File path:
core/src/main/java/com/opensymphony/xwork2/interceptor/AliasInterceptor.java
##
@@ -167,7 +182,13 @@ public void setAliasesKey(String ali
lukaszlenart commented on pull request #483:
URL: https://github.com/apache/struts/pull/483#issuecomment-830781310
I have a large concern with using `*PatternsChecker`s here, they supposed to
be used as a _border pass control_ - validating if [incoming
parameters](https://struts.apache.org
lukaszlenart commented on pull request #484:
URL: https://github.com/apache/struts/pull/484#issuecomment-830782956
LGTM 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
lukaszlenart commented on pull request #485:
URL: https://github.com/apache/struts/pull/485#issuecomment-830784019
I'm good with that change, yet not sure if this supposed to be introduced
into 2.5.x branch - some users can depend on this behaviour (even false one)
and minor updates (as 2.
yasserzamani commented on pull request #483:
URL: https://github.com/apache/struts/pull/483#issuecomment-830788154
Thanks a lot! Clever catches :) I'll reform as suggested :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
301 - 400 of 966 matches
Mail list logo
