[GitHub] [struts] coveralls edited a comment on pull request #525: [WW-5117] Evaluates dynamic attributes - cherrypick

2022-01-14 Thread GitBox
coveralls edited a comment on pull request #525: URL: https://github.com/apache/struts/pull/525#issuecomment-1011979047 [![Coverage Status](https://coveralls.io/builds/45626139/badge)](https://coveralls.io/builds/45626139) Coverage increased (+0.002%) to 50.512% when pulling **7

[GitHub] [struts] yasserzamani commented on a change in pull request #525: [WW-5117] Evaluates dynamic attributes - cherrypick

2022-01-14 Thread GitBox
yasserzamani commented on a change in pull request #525: URL: https://github.com/apache/struts/pull/525#discussion_r784835687 ## File path: core/src/test/java/org/apache/struts2/views/jsp/ui/TextfieldTest.java ## @@ -346,7 +346,7 @@ public void testSimple_recursionTest() throws

[GitHub] [struts] coveralls edited a comment on pull request #496: fix double evaluations

2022-01-19 Thread GitBox
coveralls edited a comment on pull request #496: URL: https://github.com/apache/struts/pull/496#issuecomment-877038063 [![Coverage Status](https://coveralls.io/builds/45764576/badge)](https://coveralls.io/builds/45764576) Coverage increased (+0.2%) to 47.553% when pulling **8a46

[GitHub] [struts] aleksandr-m commented on pull request #496: fix double evaluations

2022-01-19 Thread GitBox
aleksandr-m commented on pull request #496: URL: https://github.com/apache/struts/pull/496#issuecomment-1016868300 @yasserzamani Why `dynamicAttributes` type is changed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [struts] yasserzamani commented on pull request #496: fix double evaluations

2022-01-19 Thread GitBox
yasserzamani commented on pull request #496: URL: https://github.com/apache/struts/pull/496#issuecomment-1016886548 @aleksandr-m thanks for asking! Now by merging upstream into this branch by me, a test of TextField has two dynamic parameters set (one added by Lukasz). Then I saw that test

[GitHub] [struts] yasserzamani commented on pull request #496: fix double evaluations

2022-01-19 Thread GitBox
yasserzamani commented on pull request #496: URL: https://github.com/apache/struts/pull/496#issuecomment-1016946352 @aleksandr-m LinkedHashMap didn't help either. I just reverted it and instead I fixed (improved) the corresponding test to be able to verify against any of multiple possibili

[GitHub] [struts] coveralls edited a comment on pull request #496: fix double evaluations

2022-01-19 Thread GitBox
coveralls edited a comment on pull request #496: URL: https://github.com/apache/struts/pull/496#issuecomment-877038063 [![Coverage Status](https://coveralls.io/builds/45770583/badge)](https://coveralls.io/builds/45770583) Coverage increased (+0.2%) to 47.553% when pulling **e783

[GitHub] [struts] coveralls edited a comment on pull request #523: [WW-5022] Sets escapeHtmlBody to false by default and defines a new flag

2022-01-23 Thread GitBox
coveralls edited a comment on pull request #523: URL: https://github.com/apache/struts/pull/523#issuecomment-1004639681 [![Coverage Status](https://coveralls.io/builds/45856772/badge)](https://coveralls.io/builds/45856772) Coverage increased (+0.008%) to 50.517% when pulling **6

[GitHub] [struts] lukaszlenart commented on pull request #482: [WW-5115] Reduce logging of ignored DMI params

2022-01-23 Thread GitBox
lukaszlenart commented on pull request #482: URL: https://github.com/apache/struts/pull/482#issuecomment-1019453792 Changes have been cherry-picked into #526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [struts] coveralls commented on pull request #526: [WW-5115] Reduces logging for ignored DMI related params when DMI is disabled

2022-01-23 Thread GitBox
coveralls commented on pull request #526: URL: https://github.com/apache/struts/pull/526#issuecomment-1019456567 [![Coverage Status](https://coveralls.io/builds/45856902/badge)](https://coveralls.io/builds/45856902) Coverage increased (+0.003%) to 50.559% when pulling **56595356

[GitHub] [struts] coveralls commented on pull request #527: [WW-5112] Reduces logging in logic around missing resource key

2022-01-23 Thread GitBox
coveralls commented on pull request #527: URL: https://github.com/apache/struts/pull/527#issuecomment-1019467667 [![Coverage Status](https://coveralls.io/builds/45857194/badge)](https://coveralls.io/builds/45857194) Coverage decreased (-0.002%) to 50.553% when pulling **0a057395

[GitHub] [struts] lukaszlenart commented on pull request #523: [WW-5022] Sets escapeHtmlBody to false by default and defines a new flag

2022-01-23 Thread GitBox
lukaszlenart commented on pull request #523: URL: https://github.com/apache/struts/pull/523#issuecomment-1019470216 Time to merge :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [struts] lukaszlenart commented on pull request #526: [WW-5115] Reduces logging for ignored DMI related params when DMI is disabled

2022-01-29 Thread GitBox
lukaszlenart commented on pull request #526: URL: https://github.com/apache/struts/pull/526#issuecomment-1024941271 LGTM 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [struts] JCgH4164838Gh792C124B5 commented on pull request #528: Potential expression cache enhancement for 2.6 series

2022-01-30 Thread GitBox
JCgH4164838Gh792C124B5 commented on pull request #528: URL: https://github.com/apache/struts/pull/528#issuecomment-1025325062 Hello Apache Struts Team. This PR contains a potential enhancement for the expression and BeanInfo cache implementation in the 2.6 branch. Others may have ot

[GitHub] [struts] coveralls commented on pull request #529: [WW-5016] Adds support for LocalDate and adjusts tests to use the new Java 8 API

2022-02-06 Thread GitBox
coveralls commented on pull request #529: URL: https://github.com/apache/struts/pull/529#issuecomment-1030815732 [![Coverage Status](https://coveralls.io/builds/46265049/badge)](https://coveralls.io/builds/46265049) Coverage increased (+0.002%) to 50.563% when pulling **804e1546

[GitHub] [struts] gregh3269 commented on pull request #530: Add submitUnchecked parameter

2022-02-07 Thread GitBox
gregh3269 commented on pull request #530: URL: https://github.com/apache/struts/pull/530#issuecomment-1031579807 think I got this wrong :-(. end("input"); Will try again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [struts] coveralls commented on pull request #528: Potential expression cache enhancement for 2.6 series

2022-02-08 Thread GitBox
coveralls commented on pull request #528: URL: https://github.com/apache/struts/pull/528#issuecomment-1033414784 [![Coverage Status](https://coveralls.io/builds/46363439/badge)](https://coveralls.io/builds/46363439) Coverage increased (+0.04%) to 50.603% when pulling **4d8108e76

[GitHub] [struts] coveralls commented on pull request #531: WW-5168 Support submit unchecked in Javatemplates and fixes logic for FTL template

2022-02-09 Thread GitBox
coveralls commented on pull request #531: URL: https://github.com/apache/struts/pull/531#issuecomment-1034029833 [![Coverage Status](https://coveralls.io/builds/46385055/badge)](https://coveralls.io/builds/46385055) Coverage increased (+0.003%) to 50.565% when pulling **b1e9eae0

[GitHub] [struts] gregh3269 commented on pull request #530: Add submitUnchecked parameter

2022-02-10 Thread GitBox
gregh3269 commented on pull request #530: URL: https://github.com/apache/struts/pull/530#issuecomment-1034617301 OK #531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [struts] coveralls edited a comment on pull request #531: WW-5168 Support submit unchecked in Javatemplates and fixes logic for FTL template

2022-02-10 Thread GitBox
coveralls edited a comment on pull request #531: URL: https://github.com/apache/struts/pull/531#issuecomment-1034029833 [![Coverage Status](https://coveralls.io/builds/46430911/badge)](https://coveralls.io/builds/46430911) Coverage increased (+0.007%) to 50.569% when pulling **1

[GitHub] [struts] JCgH4164838Gh792C124B5 commented on pull request #528: Potential expression cache enhancement for 2.6 series

2022-02-12 Thread GitBox
JCgH4164838Gh792C124B5 commented on pull request #528: URL: https://github.com/apache/struts/pull/528#issuecomment-1037479805 Hi @lukaszlenart . Thanks for the feedback and suggestions. Moving the existing cache layer into dedicated interfaces/classes is probably cleaner in th

[GitHub] [struts] JCgH4164838Gh792C124B5 commented on a change in pull request #531: WW-5168 Support submit unchecked in Javatemplates and fixes logic for FTL template

2022-02-12 Thread GitBox
JCgH4164838Gh792C124B5 commented on a change in pull request #531: URL: https://github.com/apache/struts/pull/531#discussion_r805209191 ## File path: plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxHandler.java ## @@ -35,29 +36,33 @@ public voi

[GitHub] [struts] lukaszlenart commented on a change in pull request #531: [WW-5168] Support submit unchecked in Javatemplates and fixes logic for FTL template

2022-02-13 Thread GitBox
lukaszlenart commented on a change in pull request #531: URL: https://github.com/apache/struts/pull/531#discussion_r805302874 ## File path: plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxHandler.java ## @@ -35,29 +36,33 @@ public void generate

[GitHub] [struts] gregh3269 commented on a change in pull request #531: [WW-5168] Support submit unchecked in Javatemplates and fixes logic for FTL template

2022-02-13 Thread GitBox
gregh3269 commented on a change in pull request #531: URL: https://github.com/apache/struts/pull/531#discussion_r805303520 ## File path: plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxHandler.java ## @@ -35,29 +36,33 @@ public void generate()

[GitHub] [struts] gregh3269 commented on a change in pull request #531: [WW-5168] Support submit unchecked in Javatemplates and fixes logic for FTL template

2022-02-13 Thread GitBox
gregh3269 commented on a change in pull request #531: URL: https://github.com/apache/struts/pull/531#discussion_r805303520 ## File path: plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxHandler.java ## @@ -35,29 +36,33 @@ public void generate()

[GitHub] [struts] lukaszlenart commented on pull request #528: Potential expression cache enhancement for 2.6 series

2022-02-13 Thread GitBox
lukaszlenart commented on pull request #528: URL: https://github.com/apache/struts/pull/528#issuecomment-1037946560 You can inject them via constructor if you want to or provide a factory which will be injected into `OgnlUtil` and this factory will be used to create a proper instance of ca

[GitHub] [struts] lukaszlenart edited a comment on pull request #528: Potential expression cache enhancement for 2.6 series

2022-02-13 Thread GitBox
lukaszlenart edited a comment on pull request #528: URL: https://github.com/apache/struts/pull/528#issuecomment-1037946560 You can inject them via constructor if you want to or provide a factory which will be injected into `OgnlUtil` and this factory will be used to create a proper instanc

[GitHub] [struts] lukaszlenart commented on pull request #529: [WW-5016] Adds support for LocalDate and adjusts tests to use the new Java 8 API

2022-02-13 Thread GitBox
lukaszlenart commented on pull request #529: URL: https://github.com/apache/struts/pull/529#issuecomment-1037952530 Hm... I can implement a flag to either use a new or an old formatting mechanism. Yet this will introduce unnecessary complexity and I think it's a good moment to break backwa

[GitHub] [struts] lukaszlenart commented on a change in pull request #531: [WW-5168] Support submit unchecked in Javatemplates and fixes logic for FTL template

2022-02-13 Thread GitBox
lukaszlenart commented on a change in pull request #531: URL: https://github.com/apache/struts/pull/531#discussion_r805305455 ## File path: plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxHandler.java ## @@ -35,29 +36,33 @@ public void generate

[GitHub] [struts] gregh3269 commented on a change in pull request #531: [WW-5168] Support submit unchecked in Javatemplates and fixes logic for FTL template

2022-02-13 Thread GitBox
gregh3269 commented on a change in pull request #531: URL: https://github.com/apache/struts/pull/531#discussion_r805307260 ## File path: plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxHandler.java ## @@ -35,29 +36,33 @@ public void generate()

[GitHub] [struts] coveralls edited a comment on pull request #531: [WW-5168] Support submit unchecked in Javatemplates and fixes logic for FTL template

2022-02-13 Thread GitBox
coveralls edited a comment on pull request #531: URL: https://github.com/apache/struts/pull/531#issuecomment-1034029833 [![Coverage Status](https://coveralls.io/builds/46490812/badge)](https://coveralls.io/builds/46490812) Coverage increased (+0.007%) to 50.569% when pulling **f

[GitHub] [struts] lukaszlenart commented on a change in pull request #531: [WW-5168] Support submit unchecked in Javatemplates and fixes logic for FTL template

2022-02-13 Thread GitBox
lukaszlenart commented on a change in pull request #531: URL: https://github.com/apache/struts/pull/531#discussion_r805351070 ## File path: plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxHandler.java ## @@ -35,29 +36,33 @@ public void generate

[GitHub] [struts] coveralls edited a comment on pull request #531: [WW-5168] Support submit unchecked in Javatemplates and fixes logic for FTL template

2022-02-13 Thread GitBox
coveralls edited a comment on pull request #531: URL: https://github.com/apache/struts/pull/531#issuecomment-1034029833 [![Coverage Status](https://coveralls.io/builds/46490812/badge)](https://coveralls.io/builds/46490812) Coverage increased (+0.007%) to 50.569% when pulling **f

[GitHub] [struts] JCgH4164838Gh792C124B5 commented on a change in pull request #531: WW-5168 Support submit unchecked in Javatemplates and fixes logic for FTL template

2022-02-13 Thread GitBox
JCgH4164838Gh792C124B5 commented on a change in pull request #531: URL: https://github.com/apache/struts/pull/531#discussion_r805209191 ## File path: plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxHandler.java ## @@ -35,29 +36,33 @@ public voi

[GitHub] [struts] lukaszlenart commented on pull request #528: Potential expression cache enhancement for 2.6 series

2022-02-13 Thread GitBox
lukaszlenart commented on pull request #528: URL: https://github.com/apache/struts/pull/528#issuecomment-1037946560 You can inject them via constructor if you want to or provide a factory which will be injected into `OgnlUtil` and this factory will be used to create a proper instance of ca

[GitHub] [struts] gregh3269 commented on a change in pull request #531: [WW-5168] Support submit unchecked in Javatemplates and fixes logic for FTL template

2022-02-13 Thread GitBox
gregh3269 commented on a change in pull request #531: URL: https://github.com/apache/struts/pull/531#discussion_r805303520 ## File path: plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxHandler.java ## @@ -35,29 +36,33 @@ public void generate()

[GitHub] [struts] lukaszlenart commented on a change in pull request #531: [WW-5168] Support submit unchecked in Javatemplates and fixes logic for FTL template

2022-02-13 Thread GitBox
lukaszlenart commented on a change in pull request #531: URL: https://github.com/apache/struts/pull/531#discussion_r805302874 ## File path: plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxHandler.java ## @@ -35,29 +36,33 @@ public void generate

[GitHub] [struts] JCgH4164838Gh792C124B5 commented on pull request #528: Potential expression cache enhancement for 2.6 series

2022-02-13 Thread GitBox
JCgH4164838Gh792C124B5 commented on pull request #528: URL: https://github.com/apache/struts/pull/528#issuecomment-1037479805 Hi @lukaszlenart . Thanks for the feedback and suggestions. Moving the existing cache layer into dedicated interfaces/classes is probably cleaner in th

[GitHub] [struts] lukaszlenart commented on pull request #529: [WW-5016] Adds support for LocalDate and adjusts tests to use the new Java 8 API

2022-02-13 Thread GitBox
lukaszlenart commented on pull request #529: URL: https://github.com/apache/struts/pull/529#issuecomment-1037952530 Hm... I can implement a flag to either use a new or an old formatting mechanism. Yet this will introduce unnecessary complexity and I think it's a good moment to break backwa

[GitHub] [struts] lukaszlenart edited a comment on pull request #528: Potential expression cache enhancement for 2.6 series

2022-02-13 Thread GitBox
lukaszlenart edited a comment on pull request #528: URL: https://github.com/apache/struts/pull/528#issuecomment-1037946560 You can inject them via constructor if you want to or provide a factory which will be injected into `OgnlUtil` and this factory will be used to create a proper instanc

[GitHub] [struts] gregh3269 commented on a change in pull request #531: [WW-5168] Support submit unchecked in Javatemplates and fixes logic for FTL template

2022-02-13 Thread GitBox
gregh3269 commented on a change in pull request #531: URL: https://github.com/apache/struts/pull/531#discussion_r805575244 ## File path: plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxHandler.java ## @@ -35,29 +36,33 @@ public void generate()

[GitHub] [struts] lukaszlenart commented on pull request #529: [WW-5016] Adds support for LocalDate and adjusts tests to use the new Java 8 API

2022-02-20 Thread GitBox
lukaszlenart commented on pull request #529: URL: https://github.com/apache/struts/pull/529#issuecomment-1046220750 I'm working on a version which uses `@Inject` to inject a porper formatter. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [struts] lukaszlenart commented on pull request #529: [WW-5016] Adds support for LocalDate and adjusts tests to use the new Java 8 API

2022-02-20 Thread GitBox
lukaszlenart commented on pull request #529: URL: https://github.com/apache/struts/pull/529#issuecomment-1046228304 Done, I've extended the change to use to a formatter injected by the framework based on user choice. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [struts] coveralls edited a comment on pull request #529: [WW-5016] Adds support for LocalDate and adjusts tests to use the new Java 8 API

2022-02-20 Thread GitBox
coveralls edited a comment on pull request #529: URL: https://github.com/apache/struts/pull/529#issuecomment-1030815732 [![Coverage Status](https://coveralls.io/builds/46711916/badge)](https://coveralls.io/builds/46711916) Coverage increased (+0.01%) to 50.575% when pulling **56

[GitHub] [struts] coveralls edited a comment on pull request #529: [WW-5016] Adds support for LocalDate and adjusts tests to use the new Java 8 API

2022-02-21 Thread GitBox
coveralls edited a comment on pull request #529: URL: https://github.com/apache/struts/pull/529#issuecomment-1030815732 [![Coverage Status](https://coveralls.io/builds/46723053/badge)](https://coveralls.io/builds/46723053) Coverage increased (+0.02%) to 50.583% when pulling **47

[GitHub] [struts] coveralls edited a comment on pull request #529: [WW-5016] Adds support for LocalDate and adjusts tests to use the new Java 8 API

2022-02-21 Thread GitBox
coveralls edited a comment on pull request #529: URL: https://github.com/apache/struts/pull/529#issuecomment-1030815732 [![Coverage Status](https://coveralls.io/builds/46744461/badge)](https://coveralls.io/builds/46744461) Coverage increased (+0.02%) to 50.583% when pulling **59

[GitHub] [struts] JCgH4164838Gh792C124B5 commented on pull request #528: Potential expression cache enhancement for 2.6 series

2022-03-06 Thread GitBox
JCgH4164838Gh792C124B5 commented on pull request #528: URL: https://github.com/apache/struts/pull/528#issuecomment-1060140160 Hi @lukaszlenart . The PR has been updated after refactoring to something more along the lines of what you suggested, and then resolving a merge conflict. Th

[GitHub] [struts] coveralls edited a comment on pull request #528: Potential expression cache enhancement for 2.6 series

2022-03-06 Thread GitBox
coveralls edited a comment on pull request #528: URL: https://github.com/apache/struts/pull/528#issuecomment-1033414784 [![Coverage Status](https://coveralls.io/builds/47111228/badge)](https://coveralls.io/builds/47111228) Coverage increased (+0.05%) to 50.638% when pulling **4c

[GitHub] [struts] lukaszlenart commented on pull request #528: Potential expression cache enhancement for 2.6 series

2022-03-07 Thread GitBox
lukaszlenart commented on pull request #528: URL: https://github.com/apache/struts/pull/528#issuecomment-1060741354 Brilliant 💯 👏 Do you plan updating the docs [1]? [1] https://struts.apache.org/tag-developers/ (maybe we should move the OGNL section to the Core Developers Guid

[GitHub] [struts] JCgH4164838Gh792C124B5 commented on pull request #528: Potential expression cache enhancement for 2.6 series

2022-03-13 Thread GitBox
JCgH4164838Gh792C124B5 commented on pull request #528: URL: https://github.com/apache/struts/pull/528#issuecomment-1066282164 Hi @lukaszlenart. Thanks for the additional feedback. I had not considered the documentation side of things in relation to the potential change. The e

[GitHub] [struts] lukaszlenart commented on a change in pull request #528: Potential expression cache enhancement for 2.6 series

2022-03-14 Thread GitBox
lukaszlenart commented on a change in pull request #528: URL: https://github.com/apache/struts/pull/528#discussion_r825734744 ## File path: core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java ## @@ -78,14 +78,45 @@ private boolean allowStaticMethodAccess; pr

[GitHub] [struts] lukaszlenart commented on pull request #528: Potential expression cache enhancement for 2.6 series

2022-03-14 Thread GitBox
lukaszlenart commented on pull request #528: URL: https://github.com/apache/struts/pull/528#issuecomment-1066558111 > Should we create a JIRA for tracking for the potential change as well ? Up to you, it allows users to monitor what has changed plus you can link the new documentation

[GitHub] [struts] lukaszlenart commented on pull request #496: fix double evaluations

2022-03-15 Thread GitBox
lukaszlenart commented on pull request #496: URL: https://github.com/apache/struts/pull/496#issuecomment-1067993790 LGTM 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [struts] coveralls edited a comment on pull request #528: Potential expression cache enhancement for 2.6 series

2022-03-20 Thread GitBox
coveralls edited a comment on pull request #528: URL: https://github.com/apache/struts/pull/528#issuecomment-1033414784 [![Coverage Status](https://coveralls.io/builds/47522255/badge)](https://coveralls.io/builds/47522255) Coverage increased (+0.06%) to 50.649% when pulling **08

[GitHub] [struts] JCgH4164838Gh792C124B5 commented on a change in pull request #528: Potential expression cache enhancement for 2.6 series

2022-03-20 Thread GitBox
JCgH4164838Gh792C124B5 commented on a change in pull request #528: URL: https://github.com/apache/struts/pull/528#discussion_r830729848 ## File path: core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java ## @@ -78,14 +78,45 @@ private boolean allowStaticMethodAcces

[GitHub] [struts] JCgH4164838Gh792C124B5 commented on a change in pull request #528: Potential expression cache enhancement for 2.6 series

2022-03-20 Thread GitBox
JCgH4164838Gh792C124B5 commented on a change in pull request #528: URL: https://github.com/apache/struts/pull/528#discussion_r830736137 ## File path: core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java ## @@ -78,14 +78,45 @@ private boolean allowStaticMethodAcces

[GitHub] [struts] JCgH4164838Gh792C124B5 commented on a change in pull request #528: Potential expression cache enhancement for 2.6 series

2022-03-20 Thread GitBox
JCgH4164838Gh792C124B5 commented on a change in pull request #528: URL: https://github.com/apache/struts/pull/528#discussion_r830736468 ## File path: core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java ## @@ -78,14 +78,45 @@ private boolean allowStaticMethodAcces

[GitHub] [struts] lukaszlenart commented on a change in pull request #528: Potential expression cache enhancement for 2.6 series

2022-03-21 Thread GitBox
lukaszlenart commented on a change in pull request #528: URL: https://github.com/apache/struts/pull/528#discussion_r831098550 ## File path: core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java ## @@ -78,14 +78,45 @@ private boolean allowStaticMethodAccess; pr

[GitHub] [struts] lukaszlenart commented on a change in pull request #528: Potential expression cache enhancement for 2.6 series

2022-03-21 Thread GitBox
lukaszlenart commented on a change in pull request #528: URL: https://github.com/apache/struts/pull/528#discussion_r831125065 ## File path: core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java ## @@ -78,14 +78,45 @@ private boolean allowStaticMethodAccess; pr

[GitHub] [struts] coveralls commented on pull request #533: fix WW-5165 Update spring to 5.3.x b/c 4.3.x is EOL

2022-04-03 Thread GitBox
coveralls commented on pull request #533: URL: https://github.com/apache/struts/pull/533#issuecomment-1086924287 [![Coverage Status](https://coveralls.io/builds/47949911/badge)](https://coveralls.io/builds/47949911) Coverage remained the same at 50.585% when pulling **df6e0f19d7

[GitHub] [struts] JCgH4164838Gh792C124B5 commented on pull request #528: Potential expression cache enhancement for 2.6 series

2022-04-03 Thread GitBox
JCgH4164838Gh792C124B5 commented on PR #528: URL: https://github.com/apache/struts/pull/528#issuecomment-1086978579 Hi @lukaszlenart . While attempting to put together some documentation on configuring the new caches, I found that I could not successfully register a custom implementation

[GitHub] [struts] lukaszlenart commented on pull request #528: Potential expression cache enhancement for 2.6 series

2022-04-04 Thread GitBox
lukaszlenart commented on PR #528: URL: https://github.com/apache/struts/pull/528#issuecomment-1087197928 Yeah... I'm planning to write a guideline how to use Struts DI mechanism, it can be hard to understand on the first glimpse ;-) You can try to follow my changes in this [PR](http

[GitHub] [struts] lukaszlenart commented on pull request #533: fix WW-5165 Update spring to 5.3.x b/c 4.3.x is EOL

2022-04-04 Thread GitBox
lukaszlenart commented on PR #533: URL: https://github.com/apache/struts/pull/533#issuecomment-1087288567 I would close this PR as it was branched off old master, you can follow this step to learn how to prepare a fresh branch out of Struts master branch - it's a recommended approach.

[GitHub] [struts] victorsosa commented on pull request #533: fix WW-5165 Update spring to 5.3.x b/c 4.3.x is EOL

2022-04-04 Thread GitBox
victorsosa commented on PR #533: URL: https://github.com/apache/struts/pull/533#issuecomment-1087288661 this got messy; I will commit another PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [struts] lukaszlenart commented on pull request #528: Potential expression cache enhancement for 2.6 series

2022-04-04 Thread GitBox
lukaszlenart commented on PR #528: URL: https://github.com/apache/struts/pull/528#issuecomment-1087712241 I've started preparing the guideline https://github.com/apache/struts-site/pull/160 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [struts] coveralls commented on pull request #536: safety update with EXCLUDED_PATTERNS

2022-04-22 Thread GitBox
coveralls commented on PR #536: URL: https://github.com/apache/struts/pull/536#issuecomment-1106721465 [![Coverage Status](https://coveralls.io/builds/48496807/badge)](https://coveralls.io/builds/48496807) Coverage remained the same at 47.553% when pulling **062113d887f80c8dd8757

[GitHub] [struts] coveralls commented on pull request #537: safety update with EXCLUDED_PATTERNS

2022-04-22 Thread GitBox
coveralls commented on PR #537: URL: https://github.com/apache/struts/pull/537#issuecomment-1106740517 [![Coverage Status](https://coveralls.io/builds/48497750/badge)](https://coveralls.io/builds/48497750) Coverage remained the same at 47.553% when pulling **2e0d1f4de7e19dd7d725f

[GitHub] [struts] dependabot[bot] commented on pull request #535: Bump spring-core from 4.3.30.RELEASE to 5.3.18

2022-04-22 Thread GitBox
dependabot[bot] commented on PR #535: URL: https://github.com/apache/struts/pull/535#issuecomment-1107042720 Superseded by #538. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [struts] lukaszlenart commented on pull request #539: make expressionMaxLength enabled by default

2022-04-28 Thread GitBox
lukaszlenart commented on PR #539: URL: https://github.com/apache/struts/pull/539#issuecomment-1112044383 Could you register a ticket in JIRA? This is quite important information for users https://issues.apache.org/jira/browse/WW -- This is an automated message from the Apache Git Serv

[GitHub] [struts] k4n5ha0 commented on pull request #539: make expressionMaxLength enabled by default

2022-04-28 Thread GitBox
k4n5ha0 commented on PR #539: URL: https://github.com/apache/struts/pull/539#issuecomment-1112079892 > Could you register a ticket in JIRA? This is quite important information for users https://issues.apache.org/jira/browse/WW @lukaszlenart sorry because some reason,this url is bl

[GitHub] [struts] k4n5ha0 commented on pull request #539: make expressionMaxLength enabled by default

2022-04-29 Thread GitBox
k4n5ha0 commented on PR #539: URL: https://github.com/apache/struts/pull/539#issuecomment-111325 i chose other way to protect my app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [struts] k4n5ha0 commented on pull request #537: safety update with EXCLUDED_PATTERNS

2022-04-29 Thread GitBox
k4n5ha0 commented on PR #537: URL: https://github.com/apache/struts/pull/537#issuecomment-111381 i chose other way to protect my app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [struts] coveralls commented on pull request #541: Update struts-default.xml fix security bugs

2022-05-01 Thread GitBox
coveralls commented on PR #541: URL: https://github.com/apache/struts/pull/541#issuecomment-1114221607 [![Coverage Status](https://coveralls.io/builds/48733263/badge)](https://coveralls.io/builds/48733263) Coverage remained the same at 47.553% when pulling **393f467b2e0287e7dfbdc

[GitHub] [struts] coveralls commented on pull request #543: Update struts-default.xml

2022-05-01 Thread GitBox
coveralls commented on PR #543: URL: https://github.com/apache/struts/pull/543#issuecomment-1114231760 [![Coverage Status](https://coveralls.io/builds/48733582/badge)](https://coveralls.io/builds/48733582) Coverage remained the same at 47.553% when pulling **b9f114847a04d5a7bf5ea

[GitHub] [struts] JCgH4164838Gh792C124B5 commented on pull request #528: Potential expression cache enhancement for 2.6 series

2022-05-01 Thread GitBox
JCgH4164838Gh792C124B5 commented on PR #528: URL: https://github.com/apache/struts/pull/528#issuecomment-1114334465 Hello @lukaszlenart . Thank you for the explanation concerning the DI mechanism flow, the reference example PR, and putting together the guideline in the site documentation.

[GitHub] [struts] lukaszlenart commented on pull request #534: fix WW-5165 Update spring to 5.3.x b/c 4.3.x is EOL

2022-05-01 Thread GitBox
lukaszlenart commented on PR #534: URL: https://github.com/apache/struts/pull/534#issuecomment-1114536351 Is it ok to merge this PR? //cc: @sepe81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [struts] lukaszlenart commented on pull request #542: Update SecurityMemberAccess.java fix security bugs

2022-05-01 Thread GitBox
lukaszlenart commented on PR #542: URL: https://github.com/apache/struts/pull/542#issuecomment-1114537796 @k4n5ha0 did you ever run tests? You will notice tones of WARNs and it won't work. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [struts] lukaszlenart commented on pull request #528: Potential expression cache enhancement for 2.6 series

2022-05-01 Thread GitBox
lukaszlenart commented on PR #528: URL: https://github.com/apache/struts/pull/528#issuecomment-1114539938 Let me work a bit on you PR, maybe something obvious is missing (which happens to me each time when I need to work with Struts CI ;) ) -- This is an automated message from the Apache

[GitHub] [struts] dependabot[bot] commented on pull request #538: Bump spring-core from 4.3.30.RELEASE to 5.3.19

2022-05-01 Thread GitBox
dependabot[bot] commented on PR #538: URL: https://github.com/apache/struts/pull/538#issuecomment-1114547120 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

[GitHub] [struts] victorsosa commented on pull request #534: fix WW-5165 Update spring to 5.3.x b/c 4.3.x is EOL

2022-05-02 Thread GitBox
victorsosa commented on PR #534: URL: https://github.com/apache/struts/pull/534#issuecomment-1114745858 nop, yet; still issue with lib dependencies -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [struts] victorsosa commented on pull request #534: fix WW-5165 Update spring to 5.3.x b/c 4.3.x is EOL

2022-05-02 Thread GitBox
victorsosa commented on PR #534: URL: https://github.com/apache/struts/pull/534#issuecomment-1115058978 Trying to update to servlet 3.1.0, but getting a weird not found class javax.servlet javax.servlet-api 3.1.0 provided

[GitHub] [struts] victorsosa commented on pull request #534: fix WW-5165 Update spring to 5.3.x b/c 4.3.x is EOL

2022-05-02 Thread GitBox
victorsosa commented on PR #534: URL: https://github.com/apache/struts/pull/534#issuecomment-1115070114 Ok, I fixed the servlet 3.1.0 dependency issue, now I got some class change issue in code [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compil

[GitHub] [struts] victorsosa commented on pull request #534: fix WW-5165 Update spring to 5.3.x b/c 4.3.x is EOL

2022-05-02 Thread GitBox
victorsosa commented on PR #534: URL: https://github.com/apache/struts/pull/534#issuecomment-1115141078 servlet 3.1.0 include some changes, working on it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [struts] aleksandr-m commented on pull request #545: Struts 2 5 x

2022-05-02 Thread GitBox
aleksandr-m commented on PR #545: URL: https://github.com/apache/struts/pull/545#issuecomment-1115262143 @k4n5ha0 Why `try catches`? What are you trying to solve with this PR? Can you create some unit tests? -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [struts] aleksandr-m commented on pull request #545: Struts 2 5 x

2022-05-02 Thread GitBox
aleksandr-m commented on PR #545: URL: https://github.com/apache/struts/pull/545#issuecomment-1115264217 BTW if you are trying to solve some security related issue then maybe you can post it in the security mailing list - https://struts.apache.org/security.html -- This is an automated me

[GitHub] [struts] coveralls commented on pull request #545: Struts 2 5 x

2022-05-02 Thread GitBox
coveralls commented on PR #545: URL: https://github.com/apache/struts/pull/545#issuecomment-1115393345 [![Coverage Status](https://coveralls.io/builds/48770560/badge)](https://coveralls.io/builds/48770560) Coverage increased (+0.002%) to 47.556% when pulling **d2e8ed0898fe18cf1b6

[GitHub] [struts] k4n5ha0 commented on pull request #545: Struts 2 5 x

2022-05-02 Thread GitBox
k4n5ha0 commented on PR #545: URL: https://github.com/apache/struts/pull/545#issuecomment-1115480283 > BTW if you are trying to solve some security related issue then maybe you can post it in the security mailing list - https://struts.apache.org/security.html i send to jira before.

[GitHub] [struts] k4n5ha0 commented on pull request #545: Struts 2 5 x

2022-05-02 Thread GitBox
k4n5ha0 commented on PR #545: URL: https://github.com/apache/struts/pull/545#issuecomment-1115480656 > @k4n5ha0 Why `try catches`? What are you trying to solve with this PR? Can you create some unit tests? i am sec engine , my code tech isn't well. -- This is an automated message f

[GitHub] [struts] coveralls commented on pull request #546: update isClassExcluded logic

2022-05-02 Thread GitBox
coveralls commented on PR #546: URL: https://github.com/apache/struts/pull/546#issuecomment-1115731822 [![Coverage Status](https://coveralls.io/builds/48776874/badge)](https://coveralls.io/builds/48776874) Coverage increased (+0.005%) to 47.558% when pulling **fa99a8821a03878e5d6

[GitHub] [struts] lukaszlenart commented on a diff in pull request #546: update isClassExcluded logic

2022-05-03 Thread GitBox
lukaszlenart commented on code in PR #546: URL: https://github.com/apache/struts/pull/546#discussion_r863569592 ## core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java: ## @@ -168,8 +170,20 @@ protected boolean isClassExcluded(Class clazz) { ret

[GitHub] [struts] k4n5ha0 commented on a diff in pull request #546: update isClassExcluded logic

2022-05-03 Thread GitBox
k4n5ha0 commented on code in PR #546: URL: https://github.com/apache/struts/pull/546#discussion_r863573821 ## core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java: ## @@ -168,8 +170,20 @@ protected boolean isClassExcluded(Class clazz) { return t

[GitHub] [struts] lukaszlenart commented on a diff in pull request #546: update isClassExcluded logic

2022-05-03 Thread GitBox
lukaszlenart commented on code in PR #546: URL: https://github.com/apache/struts/pull/546#discussion_r863575099 ## core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java: ## @@ -168,8 +170,20 @@ protected boolean isClassExcluded(Class clazz) { ret

[GitHub] [struts] k4n5ha0 commented on a diff in pull request #546: update isClassExcluded logic

2022-05-03 Thread GitBox
k4n5ha0 commented on code in PR #546: URL: https://github.com/apache/struts/pull/546#discussion_r863576527 ## core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java: ## @@ -168,8 +170,20 @@ protected boolean isClassExcluded(Class clazz) { return t

[GitHub] [struts] lukaszlenart commented on a diff in pull request #546: update isClassExcluded logic

2022-05-03 Thread GitBox
lukaszlenart commented on code in PR #546: URL: https://github.com/apache/struts/pull/546#discussion_r863578444 ## core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java: ## @@ -168,8 +170,20 @@ protected boolean isClassExcluded(Class clazz) { ret

[GitHub] [struts] k4n5ha0 commented on a diff in pull request #546: update isClassExcluded logic

2022-05-03 Thread GitBox
k4n5ha0 commented on code in PR #546: URL: https://github.com/apache/struts/pull/546#discussion_r863581227 ## core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java: ## @@ -168,8 +170,20 @@ protected boolean isClassExcluded(Class clazz) { return t

[GitHub] [struts] lukaszlenart commented on a diff in pull request #546: update isClassExcluded logic

2022-05-03 Thread GitBox
lukaszlenart commented on code in PR #546: URL: https://github.com/apache/struts/pull/546#discussion_r863586541 ## core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java: ## @@ -168,8 +170,20 @@ protected boolean isClassExcluded(Class clazz) { ret

[GitHub] [struts] lukaszlenart commented on a diff in pull request #546: update isClassExcluded logic

2022-05-03 Thread GitBox
lukaszlenart commented on code in PR #546: URL: https://github.com/apache/struts/pull/546#discussion_r863597663 ## core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java: ## @@ -168,8 +170,20 @@ protected boolean isClassExcluded(Class clazz) { ret

[GitHub] [struts] lukaszlenart commented on pull request #545: Struts 2 5 x

2022-05-03 Thread GitBox
lukaszlenart commented on PR #545: URL: https://github.com/apache/struts/pull/545#issuecomment-1115892354 This kind of attack can be simple prevented by setting up [struts.ognl.expressionMaxLength](https://struts.apache.org/security/#apply-a-maximum-allowed-length-on-ognl-expressions) and y

[GitHub] [struts] k4n5ha0 commented on a diff in pull request #546: update isClassExcluded logic

2022-05-03 Thread GitBox
k4n5ha0 commented on code in PR #546: URL: https://github.com/apache/struts/pull/546#discussion_r863610769 ## core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java: ## @@ -168,8 +170,20 @@ protected boolean isClassExcluded(Class clazz) { return t

[GitHub] [struts] k4n5ha0 commented on pull request #545: Struts 2 5 x

2022-05-03 Thread GitBox
k4n5ha0 commented on PR #545: URL: https://github.com/apache/struts/pull/545#issuecomment-1115910565 > This kind of attack can be simple prevented by setting up [struts.ognl.expressionMaxLength](https://struts.apache.org/security/#apply-a-maximum-allowed-length-on-ognl-expressions) and your

<    2   3   4   5   6   7   8   9   10   >