[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952994#comment-14952994 ] Hudson commented on WW-4427: SUCCESS: Integrated in Struts-JDK7-master #371 (See [https://builds.apache.org/job/Struts-JDK7-master/371/]) WW-4427 - Converters are no longer applied to values coming from the (pbruski: rev 6834b78fe9ec33e90530686e9c5101358750a854) * xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java * xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java WW-4427 - inject the converter instead of getting it directly (pbruski: rev 6a58778399dcdacbe061c55b37a581646871d4ce) * xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java WW-4427 - cleaned up UT (pbruski: rev debaaa2443b854ee0c0cd34ea61ccdc88810e13d) * xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java WW-4427 - Converters are no longer applied to values coming from the (pbruski: rev e0d72397c24542a8b83a371a36590570ccd8fd74) * xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java * xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java > Converters no longer applied to values coming from the context > -- > > Key: WW-4427 > URL: https://issues.apache.org/jira/browse/WW-4427 > Project: Struts 2 > Issue Type: Bug >Affects Versions: 2.3.16.1 >Reporter: Przemek Bruski >Assignee: Lukasz Lenart > Fix For: 2.3.24 > > Attachments: struts_patch.diff > > > As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is > no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14368723#comment-14368723 ] Hudson commented on WW-4427: SUCCESS: Integrated in Struts-JDK6-master #904 (See [https://builds.apache.org/job/Struts-JDK6-master/904/]) WW-4427 - Converters are no longer applied to values coming from the context on error path (pbruski: rev e0d72397c24542a8b83a371a36590570ccd8fd74) * xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java * xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Assignee: Lukasz Lenart Fix For: 2.3.22 Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323765#comment-14323765 ] Hudson commented on WW-4427: SUCCESS: Integrated in Struts-JDK6-develop #132 (See [https://builds.apache.org/job/Struts-JDK6-develop/132/]) WW-4427 - Converters are no longer applied to values coming from the context on error path (pbruski: rev e0d72397c24542a8b83a371a36590570ccd8fd74) * xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java * xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Assignee: Lukasz Lenart Fix For: 2.3.22 Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323740#comment-14323740 ] ASF subversion and git services commented on WW-4427: - Commit 66248a80e3b238092bf547cc196ad2f7b0225b76 in struts's branch refs/heads/develop from [~lukaszlenart] [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=66248a8 ] WW-4427 adds complete fix Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Assignee: Lukasz Lenart Fix For: 2.3.22 Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323739#comment-14323739 ] ASF subversion and git services commented on WW-4427: - Commit e0d72397c24542a8b83a371a36590570ccd8fd74 in struts's branch refs/heads/develop from [~pbruski_] [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=e0d7239 ] WW-4427 - Converters are no longer applied to values coming from the context on error path Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Assignee: Lukasz Lenart Fix For: 2.3.22 Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323741#comment-14323741 ] ASF GitHub Bot commented on WW-4427: Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/36 Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Assignee: Lukasz Lenart Fix For: 2.3.22 Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321898#comment-14321898 ] ASF GitHub Bot commented on WW-4427: GitHub user pbruski opened a pull request: https://github.com/apache/struts/pull/36 WW-4427 - Converters are no longer applied to values coming from the context on error path The previous fix was incomplete. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pbruski/struts develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/36.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #36 commit e0d72397c24542a8b83a371a36590570ccd8fd74 Author: Przemek Bruski pbru...@atlassian.com Date: 2015-02-15T09:40:13Z WW-4427 - Converters are no longer applied to values coming from the context on error path Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Assignee: Lukasz Lenart Fix For: 2.3.22 Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321924#comment-14321924 ] Hudson commented on WW-4427: SUCCESS: Integrated in Struts-JDK7-pull-request #25 (See [https://builds.apache.org/job/Struts-JDK7-pull-request/25/]) WW-4427 - Converters are no longer applied to values coming from the context on error path (pbruski: rev e0d72397c24542a8b83a371a36590570ccd8fd74) * xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java * xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Assignee: Lukasz Lenart Fix For: 2.3.22 Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14262327#comment-14262327 ] Hudson commented on WW-4427: FAILURE: Integrated in Struts-JDK6-master #901 (See [https://builds.apache.org/job/Struts-JDK6-master/901/]) WW-4427 - Converters are no longer applied to values coming from the context - fix and UT (pbruski: rev 6834b78fe9ec33e90530686e9c5101358750a854) * xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java * xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java WW-4427 - inject the converter instead of getting it directly (pbruski: rev 6a58778399dcdacbe061c55b37a581646871d4ce) * xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java WW-4427 - cleaned up UT (pbruski: rev debaaa2443b854ee0c0cd34ea61ccdc88810e13d) * xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Assignee: Lukasz Lenart Fix For: 2.3.21 Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14260015#comment-14260015 ] Hudson commented on WW-4427: SUCCESS: Integrated in Struts-JDK7-pull-request #21 (See [https://builds.apache.org/job/Struts-JDK7-pull-request/21/]) WW-4427 - Converters are no longer applied to values coming from the context - fix and UT (pbruski: rev 6834b78fe9ec33e90530686e9c5101358750a854) * xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java * xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java WW-4427 - inject the converter instead of getting it directly (pbruski: rev 6a58778399dcdacbe061c55b37a581646871d4ce) * xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java WW-4427 - cleaned up UT (pbruski: rev debaaa2443b854ee0c0cd34ea61ccdc88810e13d) * xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Assignee: Lukasz Lenart Fix For: 2.3.21 Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[
https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256734#comment-14256734
]
ASF GitHub Bot commented on WW-4427:
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/32#discussion_r22206741
--- Diff:
xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java ---
@@ -351,6 +352,7 @@ private Object tryFindValue(String expr, Class asType)
throws OgnlException {
value = getValue(expr, asType);
if (value == null) {
value = findInContext(expr);
+return converter.convertValue(getContext(), value, asType);
--- End diff --
What will happen when value from context is null? Should it be converted?
Can you add additional test case?
Converters no longer applied to values coming from the context
--
Key: WW-4427
URL: https://issues.apache.org/jira/browse/WW-4427
Project: Struts 2
Issue Type: Bug
Affects Versions: 2.3.16.1
Reporter: Przemek Bruski
Fix For: 2.3.21
Attachments: struts_patch.diff
As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is
no longer applied to values coming directly from OGNL context.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[
https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257057#comment-14257057
]
ASF GitHub Bot commented on WW-4427:
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/32#discussion_r22218137
--- Diff:
xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java ---
@@ -351,6 +352,7 @@ private Object tryFindValue(String expr, Class asType)
throws OgnlException {
value = getValue(expr, asType);
if (value == null) {
value = findInContext(expr);
+return converter.convertValue(getContext(), value, asType);
--- End diff --
I've added it, time to merge :)
Converters no longer applied to values coming from the context
--
Key: WW-4427
URL: https://issues.apache.org/jira/browse/WW-4427
Project: Struts 2
Issue Type: Bug
Affects Versions: 2.3.16.1
Reporter: Przemek Bruski
Fix For: 2.3.21
Attachments: struts_patch.diff
As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is
no longer applied to values coming directly from OGNL context.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257061#comment-14257061 ] ASF subversion and git services commented on WW-4427: - Commit debaaa2443b854ee0c0cd34ea61ccdc88810e13d in struts's branch refs/heads/develop from [~pbruski_] [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=debaaa2 ] WW-4427 - cleaned up UT Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Fix For: 2.3.21 Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257059#comment-14257059 ] ASF subversion and git services commented on WW-4427: - Commit 6834b78fe9ec33e90530686e9c5101358750a854 in struts's branch refs/heads/develop from [~pbruski_] [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=6834b78 ] WW-4427 - Converters are no longer applied to values coming from the context - fix and UT Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Fix For: 2.3.21 Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257062#comment-14257062 ] ASF subversion and git services commented on WW-4427: - Commit 60db1aadb087a71f89aa49d2b5062b02a2c2ae3f in struts's branch refs/heads/develop from [~lukaszlenart] [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=60db1aa ] WW-4427 Converts value retrieved from context Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Fix For: 2.3.21 Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257063#comment-14257063 ] ASF GitHub Bot commented on WW-4427: Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/32 Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Fix For: 2.3.21 Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257060#comment-14257060 ] ASF subversion and git services commented on WW-4427: - Commit 6a58778399dcdacbe061c55b37a581646871d4ce in struts's branch refs/heads/develop from [~pbruski_] [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=6a58778 ] WW-4427 - inject the converter instead of getting it directly Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Fix For: 2.3.21 Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257085#comment-14257085 ] Hudson commented on WW-4427: SUCCESS: Integrated in Struts-JDK6-develop #114 (See [https://builds.apache.org/job/Struts-JDK6-develop/114/]) WW-4427 - Converters are no longer applied to values coming from the context - fix and UT (pbruski: rev 6834b78fe9ec33e90530686e9c5101358750a854) * xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java * xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java WW-4427 - inject the converter instead of getting it directly (pbruski: rev 6a58778399dcdacbe061c55b37a581646871d4ce) * xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java WW-4427 - cleaned up UT (pbruski: rev debaaa2443b854ee0c0cd34ea61ccdc88810e13d) * xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Assignee: Lukasz Lenart Fix For: 2.3.21 Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[
https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257545#comment-14257545
]
ASF GitHub Bot commented on WW-4427:
Github user pbruski commented on a diff in the pull request:
https://github.com/apache/struts/pull/32#discussion_r22236102
--- Diff:
xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java ---
@@ -351,6 +352,7 @@ private Object tryFindValue(String expr, Class asType)
throws OgnlException {
value = getValue(expr, asType);
if (value == null) {
value = findInContext(expr);
+return converter.convertValue(getContext(), value, asType);
--- End diff --
thanks!
Converters no longer applied to values coming from the context
--
Key: WW-4427
URL: https://issues.apache.org/jira/browse/WW-4427
Project: Struts 2
Issue Type: Bug
Affects Versions: 2.3.16.1
Reporter: Przemek Bruski
Assignee: Lukasz Lenart
Fix For: 2.3.21
Attachments: struts_patch.diff
As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is
no longer applied to values coming directly from OGNL context.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14248408#comment-14248408 ] Hudson commented on WW-4427: UNSTABLE: Integrated in Struts-JDK7-pull-request #15 (See [https://builds.apache.org/job/Struts-JDK7-pull-request/15/]) WW-4427 - Converters are no longer applied to values coming from the context - fix and UT (pbruski: rev 6834b78fe9ec33e90530686e9c5101358750a854) * xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java * xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java WW-4427 - inject the converter instead of getting it directly (pbruski: rev 6a58778399dcdacbe061c55b37a581646871d4ce) * xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Fix For: 2.3.x Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14248418#comment-14248418 ] Hudson commented on WW-4427: UNSTABLE: Integrated in Struts-JDK7-pull-request #16 (See [https://builds.apache.org/job/Struts-JDK7-pull-request/16/]) WW-4427 - Converters are no longer applied to values coming from the context - fix and UT (pbruski: rev 6834b78fe9ec33e90530686e9c5101358750a854) * xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java * xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java WW-4427 - inject the converter instead of getting it directly (pbruski: rev 6a58778399dcdacbe061c55b37a581646871d4ce) * xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java WW-4427 - cleaned up UT (pbruski: rev debaaa2443b854ee0c0cd34ea61ccdc88810e13d) * xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Fix For: 2.3.x Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14239600#comment-14239600 ] ASF GitHub Bot commented on WW-4427: GitHub user pbruski opened a pull request: https://github.com/apache/struts/pull/32 WW-4427 - Converters are no longer applied to values coming from the context fix and UT You can merge this pull request into a Git repository by running: $ git pull https://github.com/pbruski/struts develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/32.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #32 commit 6834b78fe9ec33e90530686e9c5101358750a854 Author: Przemek Bruski pbru...@atlassian.com Date: 2014-12-09T16:17:15Z WW-4427 - Converters are no longer applied to values coming from the context - fix and UT Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Fix For: 2.3.x Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14239607#comment-14239607 ] Przemek Bruski commented on WW-4427: Done: https://github.com/apache/struts/pull/32 Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Fix For: 2.3.x Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14239608#comment-14239608 ] Hudson commented on WW-4427: UNSTABLE: Integrated in Struts-JDK7-pull-request #14 (See [https://builds.apache.org/job/Struts-JDK7-pull-request/14/]) WW-4427 - Converters are no longer applied to values coming from the context - fix and UT (pbruski: rev 6834b78fe9ec33e90530686e9c5101358750a854) * xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java * xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Fix For: 2.3.x Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[
https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14239778#comment-14239778
]
ASF GitHub Bot commented on WW-4427:
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/32#discussion_r21548312
--- Diff:
xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java ---
@@ -351,6 +351,8 @@ private Object tryFindValue(String expr, Class asType)
throws OgnlException {
value = getValue(expr, asType);
if (value == null) {
value = findInContext(expr);
+final XWorkConverter conv =
((Container)getContext().get(ActionContext.CONTAINER)).getInstance(XWorkConverter.class);
--- End diff --
Why do you looking for Converter instead of `@Inject` it? You can inject it
with
```java
private XWorkConverter conv;
@Inject
public void setXWorkConverter(XWorkConverter conv) {
this.conv = conv;
}
```
Converters no longer applied to values coming from the context
--
Key: WW-4427
URL: https://issues.apache.org/jira/browse/WW-4427
Project: Struts 2
Issue Type: Bug
Affects Versions: 2.3.16.1
Reporter: Przemek Bruski
Fix For: 2.3.x
Attachments: struts_patch.diff
As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is
no longer applied to values coming directly from OGNL context.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237783#comment-14237783 ] Przemek Bruski commented on WW-4427: BTW, if this is a proper fix, I am happy to write UTs for it. Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Fix For: 2.3.x Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237784#comment-14237784 ] Lukasz Lenart commented on WW-4427: --- Feel free! You can also use GitHub's Pull Requests - https://github.com/apache/struts/pulls Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Fix For: 2.3.x Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
