[GitHub] tajo issue #1051: TAJO-2184: Can not run Tajo with non-default $TAJO_CONF_DI...

Github user dongjinleekr commented on the issue: https://github.com/apache/tajo/pull/1051 Sure. I already checked it out. As you can see from tajo-daemon.sh and tajo-daemons.sh, only the first one takes --config parameter; the second one works as a ssh-proxy to the worker hosts

[GitHub] tajo pull request #1051: TAJO-2184: Can not run Tajo with non-default $TAJO_...

GitHub user dongjinleekr opened a pull request: https://github.com/apache/tajo/pull/1051 TAJO-2184: Can not run Tajo with non-default $TAJO_CONF_DIR start-tajo.sh was updated. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] tajo pull request #1048: TAJO-2180: Disable unsetting timezone property in H...

GitHub user dongjinleekr opened a pull request: https://github.com/apache/tajo/pull/1048 TAJO-2180: Disable unsetting timezone property in HiveCatalogStore 1. Move AbstractDBStore#unremovablePropertySet -> CatalogConstants#UNREMOVABLE_PROPERTY_SET. 2. update HiveCatalogSt

[GitHub] tajo issue #1045: TAJO-2170: Disable unsetting timezone property

Github user dongjinleekr commented on the issue: https://github.com/apache/tajo/pull/1045 Fixed!! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tajo pull request #1045: TAJO-2170: Disable unsetting timezone property

Github user dongjinleekr commented on a diff in the pull request: https://github.com/apache/tajo/pull/1045#discussion_r76527498 --- Diff: tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java --- @@ -1110,12 +1113,20 @@ private void

[GitHub] tajo pull request #1047: TAJO-2174: Implement HiveCatalogStore#alterTable

GitHub user dongjinleekr opened a pull request: https://github.com/apache/tajo/pull/1047 TAJO-2174: Implement HiveCatalogStore#alterTable You can merge this pull request into a Git repository by running: $ git pull https://github.com/dongjinleekr/tajo feature/TAJO-2174

[GitHub] tajo issue #1045: TAJO-2165: Disable unsetting timezone property

Github user dongjinleekr commented on the issue: https://github.com/apache/tajo/pull/1045 Add to this, I have another question: is there any reason you separated CreateTableExecutor from DDLExecutor? For all DDL operations except 'Create Table' are executed in DDLExecutor, which

[GitHub] tajo pull request #1045: TAJO-2165: Disable unsetting timezone property

GitHub user dongjinleekr opened a pull request: https://github.com/apache/tajo/pull/1045 TAJO-2165: Disable unsetting timezone property Hello. I just completed [TAJO-2170, Disable unsetting timezone property](https://issues.apache.org/jira/browse/TAJO-2170). However, It would

[GitHub] tajo issue #1037: TAJO-2166: Disallow csv file format in DDL Languages

Github user dongjinleekr commented on the issue: https://github.com/apache/tajo/pull/1037 I applied all your comments! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] tajo pull request #1039: TAJO-2175: Fix some glitches in source code

GitHub user dongjinleekr opened a pull request: https://github.com/apache/tajo/pull/1039 TAJO-2175: Fix some glitches in source code Fix some glitches found working on TAJO-2165: 1. Refine method signiture: CatalogUtil#renameColumn, renameTable, addNewColumn

[GitHub] tajo pull request #1037: TAJO-2166: Disallow csv file format in DDL Language...

GitHub user dongjinleekr opened a pull request: https://github.com/apache/tajo/pull/1037 TAJO-2166: Disallow csv file format in DDL Languages You can merge this pull request into a Git repository by running: $ git pull https://github.com/dongjinleekr/tajo feature/TAJO-2166

[GitHub] tajo issue #1036: TAJO-2165: Add 'ALTER TABLE UNSET PROPERTY' statement to T...

Github user dongjinleekr commented on the issue: https://github.com/apache/tajo/pull/1036 As soon as you accept this pull request, I will request another one - the fix for [the glitches discussed in this issue](https://issues.apache.org/jira/browse/TAJO-2175). I already completed

[GitHub] tajo pull request #1036: TAJO-2165: Add 'ALTER TABLE UNSET PROPERTY' stateme...

Github user dongjinleekr commented on a diff in the pull request: https://github.com/apache/tajo/pull/1036#discussion_r69733275 --- Diff: tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java --- @@ -552,6 +552,16 @@ public static AlterTableDesc

[GitHub] tajo issue #1036: TAJO-2165: Add 'ALTER TABLE UNSET PROPERTY' statement to T...

Github user dongjinleekr commented on the issue: https://github.com/apache/tajo/pull/1036 Oh, my mistake. I confused HCatalogStore and HiveCatalogStore. Let's sum up. The following is the list of tickets that should be opened. Some of them are from this discussion

[GitHub] tajo issue #1036: TAJO-2165: Add 'ALTER TABLE UNSET PROPERTY' statement to T...

Github user dongjinleekr commented on the issue: https://github.com/apache/tajo/pull/1036 Updated! Thanks for your immediate response. Followings are additional comments on this issue: 1. During updating the (potentially) broken test, one question arose

[GitHub] tajo pull request #1036: TAJO-2165: Add 'ALTER TABLE UNSET PROPERTY' stateme...

GitHub user dongjinleekr opened a pull request: https://github.com/apache/tajo/pull/1036 TAJO-2165: Add 'ALTER TABLE UNSET PROPERTY' statement to Tajo DDL You can merge this pull request into a Git repository by running: $ git pull https://github.com/dongjinleekr/tajo feature