Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/870#issuecomment-160416423
Thanks. Would you close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user eminency commented on the pull request:
https://github.com/apache/tajo/pull/870#issuecomment-160502247
Sure, I close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user eminency closed the pull request at:
https://github.com/apache/tajo/pull/870
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user eminency commented on the pull request:
https://github.com/apache/tajo/pull/870#issuecomment-160034320
@jihoonson I submitted new PR : https://github.com/apache/tajo/pull/881
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/870#discussion_r45934726
--- Diff: tajo-docs/src/main/sphinx/table_management/compression.rst ---
@@ -1,5 +1,23 @@
-*
+***
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/870#issuecomment-159767211
+1 LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/870#discussion_r45934744
--- Diff: tajo-docs/src/main/sphinx/table_management/compression.rst ---
@@ -1,5 +1,23 @@
-*
+***
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/870#issuecomment-159767610
I leaved some comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/870#issuecomment-159774134
@hyunsik, I'm sorry, but have already committed this patch.
@eminency, would you open a new Jira issue to address his comment? When you
make a PR for the new issue,
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/870#discussion_r45601276
--- Diff: tajo-docs/src/main/sphinx/table_management/compression.rst ---
@@ -1,5 +1,23 @@
-*
+***
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/870#issuecomment-158933396
@eminency, thanks for your patch. I left some comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/870#discussion_r45602368
--- Diff: tajo-docs/src/main/sphinx/table_management/compression.rst ---
@@ -1,5 +1,23 @@
-*
+***
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/870#discussion_r45602281
--- Diff: tajo-docs/src/main/sphinx/table_management/compression.rst ---
@@ -1,5 +1,23 @@
-*
+***
Github user eminency commented on the pull request:
https://github.com/apache/tajo/pull/870#issuecomment-159132318
@jihoonson ,
I updated what you mentioned and a bit further.
Please check it out.
Thanks.
---
If your project is set up for it, you can reply to this
GitHub user eminency opened a pull request:
https://github.com/apache/tajo/pull/870
TAJO-1857: Rename the section of 'File Formats' to 'Data Formats' and fill
compression section of the 'Table Management' chapter
Hi, @jihoonson.
I modified docs and wrote a compression doc
15 matches
Mail list logo
