Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/844
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/844#issuecomment-155031450
+1
The patch looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/844#issuecomment-155017340
@eminency and @hyunsik, thank you guys for your review!
I fixed the test failure.
---
If your project is set up for it, you can reply to this email and have your
Github user eminency commented on the pull request:
https://github.com/apache/tajo/pull/844#issuecomment-154697044
Thanks, it looks good. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/844#issuecomment-153982075
You can see the updated document here.
http://people.apache.org/~jihoonson/tajo-docs/
---
If your project is set up for it, you can reply to this email and have
Github user eminency commented on a diff in the pull request:
https://github.com/apache/tajo/pull/844#discussion_r44100331
--- Diff: tajo-docs/src/main/sphinx/configuration/tajo-site-xml.rst ---
@@ -2,23 +2,455 @@
The tajo-site.xml File
**
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/844#issuecomment-154281531
Thanks for your comment. I addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user eminency commented on the pull request:
https://github.com/apache/tajo/pull/844#issuecomment-154274813
I leave some comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user eminency commented on a diff in the pull request:
https://github.com/apache/tajo/pull/844#discussion_r44100456
--- Diff: tajo-docs/src/main/sphinx/configuration/tajo-site-xml.rst ---
@@ -2,23 +2,455 @@
The tajo-site.xml File
**
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/844#discussion_r44103172
--- Diff: tajo-docs/src/main/sphinx/configuration/tajo-site-xml.rst ---
@@ -2,23 +2,455 @@
The tajo-site.xml File
**
Github user eminency commented on a diff in the pull request:
https://github.com/apache/tajo/pull/844#discussion_r44098591
--- Diff: tajo-docs/src/main/sphinx/configuration/tajo-site-xml.rst ---
@@ -2,23 +2,455 @@
The tajo-site.xml File
**
GitHub user jihoonson opened a pull request:
https://github.com/apache/tajo/pull/844
TAJO-1963: Add more configuration descriptions to document
I also fixed a wrong configuration name.
You can merge this pull request into a Git repository by running:
$ git pull
12 matches
Mail list logo
