[
https://issues.apache.org/jira/browse/TEZ-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402906#comment-15402906
]
Ming Ma commented on TEZ-3303:
--
Nit: The TODO comment for TEZ_RUNTIME_REPORT_PARTITION_STATS in
[
https://issues.apache.org/jira/browse/TEZ-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374379#comment-15374379
]
Tsuyoshi Ozawa commented on TEZ-3303:
-
Thanks for your review and your committing :-)
> Have
[
https://issues.apache.org/jira/browse/TEZ-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374133#comment-15374133
]
TezQA commented on TEZ-3303:
{color:green}+1 overall{color}. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/TEZ-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373969#comment-15373969
]
Siddharth Seth commented on TEZ-3303:
-
Very minor: can we make this an "else if
[
https://issues.apache.org/jira/browse/TEZ-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15371706#comment-15371706
]
Tsuyoshi Ozawa commented on TEZ-3303:
-
[~sseth] do you have any comments?
> Have ShuffleVertexManager
[
https://issues.apache.org/jira/browse/TEZ-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367391#comment-15367391
]
Tsuyoshi Ozawa commented on TEZ-3303:
-
Thank you, Ming.
[~sseth] could you also check the patch?
>
[
https://issues.apache.org/jira/browse/TEZ-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367237#comment-15367237
]
Ming Ma commented on TEZ-3303:
--
The latest patch LGTM. Thanks [~ozawa].
> Have ShuffleVertexManager consume
[
https://issues.apache.org/jira/browse/TEZ-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15366869#comment-15366869
]
TezQA commented on TEZ-3303:
{color:green}+1 overall{color}. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/TEZ-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363072#comment-15363072
]
Ming Ma commented on TEZ-3303:
--
Thanks [~ozawa]. When detailed partition stat is set, the memory_optimized stat
[
https://issues.apache.org/jira/browse/TEZ-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360727#comment-15360727
]
Tsuyoshi Ozawa commented on TEZ-3303:
-
[~sseth] [~mingma] could you take a look?
> Have
[
https://issues.apache.org/jira/browse/TEZ-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360705#comment-15360705
]
TezQA commented on TEZ-3303:
{color:green}+1 overall{color}. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/TEZ-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360194#comment-15360194
]
Tsuyoshi Ozawa commented on TEZ-3303:
-
The test failures don't occur on my local. so kicking the CI
[
https://issues.apache.org/jira/browse/TEZ-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359891#comment-15359891
]
TezQA commented on TEZ-3303:
{color:red}-1 overall{color}. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/TEZ-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359570#comment-15359570
]
Tsuyoshi Ozawa commented on TEZ-3303:
-
[~sseth] [~mingma] thanks for your clarification. Make sense.
[
https://issues.apache.org/jira/browse/TEZ-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359222#comment-15359222
]
Ming Ma commented on TEZ-3303:
--
Thanks [~ozawa]. Yep, as [~sseth] said, for example you can provide the precise
[
https://issues.apache.org/jira/browse/TEZ-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358300#comment-15358300
]
Siddharth Seth commented on TEZ-3303:
-
[~ozawa] - I don't think the patch actually makes use of the
[
https://issues.apache.org/jira/browse/TEZ-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358196#comment-15358196
]
Tsuyoshi Ozawa commented on TEZ-3303:
-
[~sseth] could you take a look?
> Have ShuffleVertexManager
[
https://issues.apache.org/jira/browse/TEZ-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358062#comment-15358062
]
TezQA commented on TEZ-3303:
{color:green}+1 overall{color}. Here are the results of testing the latest
18 matches
Mail list logo