[
https://issues.apache.org/jira/browse/TEZ-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083824#comment-17083824
]
László Bodor commented on TEZ-4145:
---
pushed to branch-0.9, resolving this
thanks for the reviews!
>
[
https://issues.apache.org/jira/browse/TEZ-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083627#comment-17083627
]
Jonathan Turner Eagles commented on TEZ-4145:
-
[~abstractdog], thanks for the branch-0.9 patch.
[
https://issues.apache.org/jira/browse/TEZ-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083622#comment-17083622
]
TezQA commented on TEZ-4145:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime ||
[
https://issues.apache.org/jira/browse/TEZ-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083604#comment-17083604
]
László Bodor commented on TEZ-4145:
---
cool, thanks [~jeagles], [~ashutoshc], [~rajesh.balamohan]!
I'm
[
https://issues.apache.org/jira/browse/TEZ-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083458#comment-17083458
]
Jonathan Turner Eagles commented on TEZ-4145:
-
Agreed. This patch looks good to me and also has
[
https://issues.apache.org/jira/browse/TEZ-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083456#comment-17083456
]
Ashutosh Chauhan commented on TEZ-4145:
---
+1
> Reduce lock contention in TezSpillRecord
>
[
https://issues.apache.org/jira/browse/TEZ-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082914#comment-17082914
]
TezQA commented on TEZ-4145:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime ||
[
https://issues.apache.org/jira/browse/TEZ-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082893#comment-17082893
]
László Bodor commented on TEZ-4145:
---
fixed 1 more checkstyle in [^TEZ-4145.04.patch]
> Reduce lock
[
https://issues.apache.org/jira/browse/TEZ-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082885#comment-17082885
]
TezQA commented on TEZ-4145:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime ||
[
https://issues.apache.org/jira/browse/TEZ-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082847#comment-17082847
]
László Bodor commented on TEZ-4145:
---
thanks [~jeagles], [~rajesh.balamohan], addressed all of these in
[
https://issues.apache.org/jira/browse/TEZ-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082758#comment-17082758
]
Rajesh Balamohan commented on TEZ-4145:
---
Yes, {{TezSpillRecord::writeToFile}} would have similar
[
https://issues.apache.org/jira/browse/TEZ-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082683#comment-17082683
]
Jonathan Turner Eagles commented on TEZ-4145:
-
Looks like some of the checkstyle reports are
[
https://issues.apache.org/jira/browse/TEZ-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082614#comment-17082614
]
TezQA commented on TEZ-4145:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime ||
[
https://issues.apache.org/jira/browse/TEZ-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082592#comment-17082592
]
László Bodor commented on TEZ-4145:
---
thanks [~jeagles] for looking into this
fixed, please check
[
https://issues.apache.org/jira/browse/TEZ-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082540#comment-17082540
]
Jonathan Turner Eagles commented on TEZ-4145:
-
This patch fails to compile. Not sure why the
[
https://issues.apache.org/jira/browse/TEZ-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082471#comment-17082471
]
TezQA commented on TEZ-4145:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime ||
[
https://issues.apache.org/jira/browse/TEZ-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082242#comment-17082242
]
Rajesh Balamohan commented on TEZ-4145:
---
Note: TezSpillRecord is in the hot path in fetcher, ordered,
17 matches
Mail list logo