[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14129117#comment-14129117
]
Hitesh Shah commented on TEZ-850:
-
Comments on patch:
- needs a minor rebase
-
[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14129566#comment-14129566
]
Jeff Zhang commented on TEZ-850:
Attach the new patch.
* rebase it
* remove MockVertexImpl
[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14129596#comment-14129596
]
Hitesh Shah commented on TEZ-850:
-
There were minor warnings for example:
- instead of
[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14129641#comment-14129641
]
Jeff Zhang commented on TEZ-850:
[~hitesh] Update the patch removing the //TODO
Maybe it is
[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14127356#comment-14127356
]
Hitesh Shah commented on TEZ-850:
-
Mostly looks fine.
Couple of minor comments:
- for
[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14127876#comment-14127876
]
Jeff Zhang commented on TEZ-850:
Attach the new patch (add VisibleForTesting annotation)
[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102070#comment-14102070
]
Jeff Zhang commented on TEZ-850:
[~hitesh] Attach the patch.
* Recovery Unit test for DAG,
[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14095078#comment-14095078
]
Hitesh Shah commented on TEZ-850:
-
There may be other cases that may require running jobs
[
https://issues.apache.org/jira/browse/TEZ-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14090416#comment-14090416
]
Jeff Zhang commented on TEZ-850:
[~hitesh], I have done some work on this. But considering
