[jira] [Comment Edited] (TEZ-4101) Eliminate some guava dependencies by Java8+ features - Preconditions

2020-01-22 Thread Jira
[ https://issues.apache.org/jira/browse/TEZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021623#comment-17021623 ] László Bodor edited comment on TEZ-4101 at 1/22/20 11:46 PM: - actually, there

[jira] [Commented] (TEZ-4101) Eliminate some guava dependencies by Java8+ features - Preconditions

2020-01-22 Thread Jira
[ https://issues.apache.org/jira/browse/TEZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021623#comment-17021623 ] László Bodor commented on TEZ-4101: --- actually, there are very many occurrences of

[jira] [Resolved] (TEZ-4116) TestTaskSchedulerManager.testTaskBasedAffinity fails in preCommit regularly

2020-01-22 Thread Jira
[ https://issues.apache.org/jira/browse/TEZ-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] László Bodor resolved TEZ-4116. --- Resolution: Invalid seems like failures in TEZ-4101 are related to that patch, this is invalid >

[jira] [Updated] (TEZ-3391) Optimize single split MR split reader

2020-01-22 Thread Ahmed Hussein (Jira)
[ https://issues.apache.org/jira/browse/TEZ-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hussein updated TEZ-3391: --- Description: During initialization, each task creates an array of objects  \{{TaskSplitMetaInfo[]}}.

[jira] [Commented] (TEZ-4101) Eliminate some guava dependencies by Java8+ features - Preconditions

2020-01-22 Thread Jonathan Turner Eagles (Jira)
[ https://issues.apache.org/jira/browse/TEZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021581#comment-17021581 ] Jonathan Turner Eagles commented on TEZ-4101: - [~abstractdog], there are so few checkState

[jira] [Commented] (TEZ-3391) MR split file validation should be done in the AM

2020-01-22 Thread Jonathan Turner Eagles (Jira)
[ https://issues.apache.org/jira/browse/TEZ-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021570#comment-17021570 ] Jonathan Turner Eagles commented on TEZ-3391: - Actually, [~ahussein], can you update the

[jira] [Commented] (TEZ-4101) Eliminate some guava dependencies by Java8+ features - Preconditions

2020-01-22 Thread Jira
[ https://issues.apache.org/jira/browse/TEZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021569#comment-17021569 ] László Bodor commented on TEZ-4101: --- unfortunately, Objects or other Java built-in classes don't have the

[jira] [Commented] (TEZ-4101) Eliminate some guava dependencies by Java8+ features - Preconditions

2020-01-22 Thread Jonathan Turner Eagles (Jira)
[ https://issues.apache.org/jira/browse/TEZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021553#comment-17021553 ] Jonathan Turner Eagles commented on TEZ-4101: - I think I prefer the Objects implementation. It

[jira] [Updated] (TEZ-4116) TestTaskSchedulerManager.testTaskBasedAffinity fails in preCommit regularly

2020-01-22 Thread Jira
[ https://issues.apache.org/jira/browse/TEZ-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] László Bodor updated TEZ-4116: -- Attachment: patch-unit-tez-dag.txt > TestTaskSchedulerManager.testTaskBasedAffinity fails in preCommit

[jira] [Updated] (TEZ-4116) TestTaskSchedulerManager.testTaskBasedAffinity fails in preCommit regularly

2020-01-22 Thread Jira
[ https://issues.apache.org/jira/browse/TEZ-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] László Bodor updated TEZ-4116: -- Description: {code} Error Message Wanted but not invoked: taskScheduler.allocateTask( Mock for

[jira] [Commented] (TEZ-4101) Eliminate some guava dependencies by Java8+ features - Preconditions

2020-01-22 Thread Jira
[ https://issues.apache.org/jira/browse/TEZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021533#comment-17021533 ] László Bodor commented on TEZ-4101: --- I thinks TestTaskSchedulerManager.testTaskBasedAffinity is not

[jira] [Created] (TEZ-4116) TestTaskSchedulerManager.testTaskBasedAffinity fails in preCommit regularly

2020-01-22 Thread Jira
László Bodor created TEZ-4116: - Summary: TestTaskSchedulerManager.testTaskBasedAffinity fails in preCommit regularly Key: TEZ-4116 URL: https://issues.apache.org/jira/browse/TEZ-4116 Project: Apache Tez

[jira] [Comment Edited] (TEZ-4101) Eliminate some guava dependencies by Java8+ features - Preconditions

2020-01-22 Thread Jira
[ https://issues.apache.org/jira/browse/TEZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021533#comment-17021533 ] László Bodor edited comment on TEZ-4101 at 1/22/20 9:37 PM: I think

[jira] [Commented] (TEZ-3391) MR split file validation should be done in the AM

2020-01-22 Thread Jonathan Turner Eagles (Jira)
[ https://issues.apache.org/jira/browse/TEZ-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021379#comment-17021379 ] Jonathan Turner Eagles commented on TEZ-3391: - +1. Let's put this in. I spent some time

[jira] [Commented] (TEZ-4101) Eliminate some guava dependencies by Java8+ features - Preconditions

2020-01-22 Thread TezQA (Jira)
[ https://issues.apache.org/jira/browse/TEZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021220#comment-17021220 ] TezQA commented on TEZ-4101: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime ||

[jira] [Commented] (TEZ-3391) MR split file validation should be done in the AM

2020-01-22 Thread TezQA (Jira)
[ https://issues.apache.org/jira/browse/TEZ-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021148#comment-17021148 ] TezQA commented on TEZ-3391: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime ||

[jira] [Comment Edited] (TEZ-3391) MR split file validation should be done in the AM

2020-01-22 Thread Ahmed Hussein (Jira)
[ https://issues.apache.org/jira/browse/TEZ-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021119#comment-17021119 ] Ahmed Hussein edited comment on TEZ-3391 at 1/22/20 2:38 PM: - I agree with

[jira] [Commented] (TEZ-3391) MR split file validation should be done in the AM

2020-01-22 Thread Ahmed Hussein (Jira)
[ https://issues.apache.org/jira/browse/TEZ-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021119#comment-17021119 ] Ahmed Hussein commented on TEZ-3391: I agree with [~rohini] that the implementation is not efficient.

[jira] [Updated] (TEZ-3391) MR split file validation should be done in the AM

2020-01-22 Thread Ahmed Hussein (Jira)
[ https://issues.apache.org/jira/browse/TEZ-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hussein updated TEZ-3391: --- Attachment: TEZ-3391.002.patch > MR split file validation should be done in the AM >

[jira] [Commented] (TEZ-3391) MR split file validation should be done in the AM

2020-01-22 Thread TezQA (Jira)
[ https://issues.apache.org/jira/browse/TEZ-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021100#comment-17021100 ] TezQA commented on TEZ-3391: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime ||

[jira] [Updated] (TEZ-4101) Eliminate some guava dependencies by Java8+ features - Preconditions

2020-01-22 Thread Jira
[ https://issues.apache.org/jira/browse/TEZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] László Bodor updated TEZ-4101: -- Attachment: TEZ-4101.03.patch > Eliminate some guava dependencies by Java8+ features - Preconditions >

[jira] [Commented] (TEZ-4101) Eliminate some guava dependencies by Java8+ features - Preconditions

2020-01-22 Thread TezQA (Jira)
[ https://issues.apache.org/jira/browse/TEZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17020875#comment-17020875 ] TezQA commented on TEZ-4101: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime ||