[
https://issues.apache.org/jira/browse/TEZ-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15652670#comment-15652670
]
Siddharth Seth commented on TEZ-3269:
-
+1. Looks good. Thanks [~mingma]
> Provide basic fair routing
[
https://issues.apache.org/jira/browse/TEZ-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622970#comment-15622970
]
Siddharth Seth commented on TEZ-3269:
-
Will take a look, hopefully, soon.
bq. Will the parallelism ever
[
https://issues.apache.org/jira/browse/TEZ-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622958#comment-15622958
]
TezQA commented on TEZ-3269:
{color:green}+1 overall{color}. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/TEZ-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15621538#comment-15621538
]
TezQA commented on TEZ-3269:
{color:red}-1 overall{color}. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/TEZ-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15578791#comment-15578791
]
Siddharth Seth commented on TEZ-3269:
-
Apologies for the long delay in the review.
Mostly looks good.
[
https://issues.apache.org/jira/browse/TEZ-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569378#comment-15569378
]
Zhiyuan Yang commented on TEZ-3269:
---
+1 (non-binding)
> Provide basic fair routing and scheduling
[
https://issues.apache.org/jira/browse/TEZ-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569234#comment-15569234
]
Ming Ma commented on TEZ-3269:
--
[~aplusplus] [~sseth] or anyone else, any additional comments? If it looks
[
https://issues.apache.org/jira/browse/TEZ-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15546088#comment-15546088
]
Zhiyuan Yang commented on TEZ-3269:
---
Patch looks good to me.
> Provide basic fair routing and scheduling
[
https://issues.apache.org/jira/browse/TEZ-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544146#comment-15544146
]
TezQA commented on TEZ-3269:
{color:green}+1 overall{color}. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/TEZ-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15542944#comment-15542944
]
Zhiyuan Yang commented on TEZ-3269:
---
I'm sorry for the late review...
Generally code looks good as core
[
https://issues.apache.org/jira/browse/TEZ-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15460260#comment-15460260
]
TezQA commented on TEZ-3269:
{color:green}+1 overall{color}. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/TEZ-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15440355#comment-15440355
]
TezQA commented on TEZ-3269:
{color:red}-1 overall{color}. Here are the results of testing the latest
12 matches
Mail list logo