[GitHub] asfgit commented on issue #2314: Remove deliveryservice.org_server_fqdn column/compute it from Origin table

asfgit commented on issue #2314: Remove deliveryservice.org_server_fqdn column/compute it from Origin table URL: https://github.com/apache/incubator-trafficcontrol/pull/2314#issuecomment-394893286 Refer to this link for build results (access rights to CI server needed):

Jenkins build is back to normal : incubator-trafficcontrol-PR #1780

See

Build failed in Jenkins: incubator-trafficcontrol-PR #1779

See -- GitHub pull request #2314 of commit e507f3eed1c06602ae4155ad3c941e30334d5104, no merge conflicts. Setting status of e507f3eed1c06602ae4155ad3c941e30334d5104 to

[GitHub] asfgit commented on issue #2314: Remove deliveryservice.org_server_fqdn column/compute it from Origin table

asfgit commented on issue #2314: Remove deliveryservice.org_server_fqdn column/compute it from Origin table URL: https://github.com/apache/incubator-trafficcontrol/pull/2314#issuecomment-394892096 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2300: Add TO Go cachegroups/id/deliveryservices

asfgit commented on issue #2300: Add TO Go cachegroups/id/deliveryservices URL: https://github.com/apache/incubator-trafficcontrol/pull/2300#issuecomment-394888436 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2306: Add TO Go cdns/capacity

asfgit commented on issue #2306: Add TO Go cdns/capacity URL: https://github.com/apache/incubator-trafficcontrol/pull/2306#issuecomment-394885063 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: incubator-trafficcontrol-PR #1776

See Changes: [rob] Add TO Go cdns/capacity -- [...truncated 152.19 KB...] Install 7 Packages (+18 Dependent packages) Total download size: 50 M Installed

[GitHub] rob05c closed pull request #2375: Fix go delivery service API validation

rob05c closed pull request #2375: Fix go delivery service API validation URL: https://github.com/apache/incubator-trafficcontrol/pull/2375 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] rob05c commented on issue #2375: Fix go delivery service API validation

rob05c commented on issue #2375: Fix go delivery service API validation URL: https://github.com/apache/incubator-trafficcontrol/pull/2375#issuecomment-394884621 Tested, works This is an automated message from the Apache Git

[GitHub] asfgit commented on issue #2369: To go deletednsseckeys

asfgit commented on issue #2369: To go deletednsseckeys URL: https://github.com/apache/incubator-trafficcontrol/pull/2369#issuecomment-394878089 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1775/

[GitHub] rawlinp opened a new pull request #2375: Fix go delivery service API validation

rawlinp opened a new pull request #2375: Fix go delivery service API validation URL: https://github.com/apache/incubator-trafficcontrol/pull/2375 Validate v1.3 DS PUT requests, and fix the "required if type X" validation.

[GitHub] rob05c opened a new pull request #2374: Fix TO Go compile error from merge issue

rob05c opened a new pull request #2374: Fix TO Go compile error from merge issue URL: https://github.com/apache/incubator-trafficcontrol/pull/2374 This is an automated message from the Apache Git Service. To respond to the

[GitHub] asfgit commented on issue #2365: Add TO Go api helpers

asfgit commented on issue #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#issuecomment-394843350 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1772/

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #677

See Changes: [jeffrey_elsloo] Add TO Go cachegroups/id/queue_update [jeffrey_elsloo] Change To Go cg/queue to accept string or int ids [jeffrey_elsloo] Add TO Go Divisions name

[GitHub] elsloo closed pull request #2341: Add TO Go Divisions name

elsloo closed pull request #2341: Add TO Go Divisions name URL: https://github.com/apache/incubator-trafficcontrol/pull/2341 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] rob05c commented on issue #2301: Add TO Go cachegroups/id/queue_update

rob05c commented on issue #2301: Add TO Go cachegroups/id/queue_update URL: https://github.com/apache/incubator-trafficcontrol/pull/2301#issuecomment-394812854 >perl supports both an int or string as the cdnId in the request body. Changed

[GitHub] rob05c commented on issue #2301: Add TO Go cachegroups/id/queue_update

rob05c commented on issue #2301: Add TO Go cachegroups/id/queue_update URL: https://github.com/apache/incubator-trafficcontrol/pull/2301#issuecomment-394812854 >Tested, this works as expected other than the noted difference that perl supports both an int or string as the cdnId in the

[GitHub] asfgit commented on issue #2301: Add TO Go cachegroups/id/queue_update

asfgit commented on issue #2301: Add TO Go cachegroups/id/queue_update URL: https://github.com/apache/incubator-trafficcontrol/pull/2301#issuecomment-394810161 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #676

See Changes: [jeffrey_elsloo] Add TO Go cdns/configs [jeffrey_elsloo] Add TO Go phys_locations/trimmed [jeffrey_elsloo] Add TO Go profiles/trimmed [jeffrey_elsloo] Add TO Go

[GitHub] asfgit commented on issue #2301: Add TO Go cachegroups/id/queue_update

asfgit commented on issue #2301: Add TO Go cachegroups/id/queue_update URL: https://github.com/apache/incubator-trafficcontrol/pull/2301#issuecomment-394779764 Refer to this link for build results (access rights to CI server needed):

[GitHub] elsloo closed pull request #2304: Add TO Go cdns/id/queue_updates

elsloo closed pull request #2304: Add TO Go cdns/id/queue_updates URL: https://github.com/apache/incubator-trafficcontrol/pull/2304 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] elsloo closed pull request #2352: Add TO Go profiles/trimmed

elsloo closed pull request #2352: Add TO Go profiles/trimmed URL: https://github.com/apache/incubator-trafficcontrol/pull/2352 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] elsloo closed pull request #2354: Add TO Go phys_locations/trimmed

elsloo closed pull request #2354: Add TO Go phys_locations/trimmed URL: https://github.com/apache/incubator-trafficcontrol/pull/2354 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] rawlinp commented on issue #2373: Missing validation in Golang Delivery Service API

rawlinp commented on issue #2373: Missing validation in Golang Delivery Service API URL: https://github.com/apache/incubator-trafficcontrol/issues/2373#issuecomment-394772252 I'll handle item 5 in #2314 because it requires valid `orgServerFqdn` input at a minimum.

[GitHub] rawlinp opened a new issue #2373: Missing validation in Golang Delivery Service API

rawlinp opened a new issue #2373: Missing validation in Golang Delivery Service API URL: https://github.com/apache/incubator-trafficcontrol/issues/2373 Delivery Service API validation that was done in the Perl API is missing from the current Golang API: 1. `typeId` is a valid

Jenkins build is back to normal : incubator-trafficcontrol-PR #1767

See

[GitHub] dewrich closed pull request #2371: Fixed Go API tests for Types

dewrich closed pull request #2371: Fixed Go API tests for Types URL: https://github.com/apache/incubator-trafficcontrol/pull/2371 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] asfgit commented on issue #2314: Remove deliveryservice.org_server_fqdn column/compute it from Origin table

asfgit commented on issue #2314: Remove deliveryservice.org_server_fqdn column/compute it from Origin table URL: https://github.com/apache/incubator-trafficcontrol/pull/2314#issuecomment-394766274 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: incubator-trafficcontrol-PR #1766

See -- GitHub pull request #2314 of commit 906de8c56a980a0b946398c0f67b1ff5052d4f98, no merge conflicts. Setting status of 906de8c56a980a0b946398c0f67b1ff5052d4f98 to

[GitHub] asfgit commented on issue #2249: Add CRConfig DS Modified fields

asfgit commented on issue #2249: Add CRConfig DS Modified fields URL: https://github.com/apache/incubator-trafficcontrol/pull/2249#issuecomment-394765964 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c commented on issue #2341: Add TO Go Divisions name

rob05c commented on issue #2341: Add TO Go Divisions name URL: https://github.com/apache/incubator-trafficcontrol/pull/2341#issuecomment-394758211 Changed to use "CRUDer" interfaces. This is an automated message from the

[GitHub] rob05c commented on a change in pull request #2341: Add TO Go Divisions name

rob05c commented on a change in pull request #2341: Add TO Go Divisions name URL: https://github.com/apache/incubator-trafficcontrol/pull/2341#discussion_r193121819 ## File path: traffic_ops/traffic_ops_golang/routes.go ## @@ -122,6 +122,7 @@ func Routes(d ServerData)

Jenkins build is back to normal : incubator-trafficcontrol-PR-rat #1034

See

[GitHub] rob05c closed pull request #2372: Remove dead delivery service Handler code

rob05c closed pull request #2372: Remove dead delivery service Handler code URL: https://github.com/apache/incubator-trafficcontrol/pull/2372 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] rawlinp opened a new pull request #2372: Remove dead delivery service Handler code

rawlinp opened a new pull request #2372: Remove dead delivery service Handler code URL: https://github.com/apache/incubator-trafficcontrol/pull/2372 These files are no longer used. This is an automated message from the

[GitHub] DylanVolz commented on issue #2301: Add TO Go cachegroups/id/queue_update

DylanVolz commented on issue #2301: Add TO Go cachegroups/id/queue_update URL: https://github.com/apache/incubator-trafficcontrol/pull/2301#issuecomment-394687847 Tested, this works as expected other than the noted difference that perl supports both an int or string as the cdnId in the

[GitHub] asfgit commented on issue #2307: Add TO Go cdns/routing

asfgit commented on issue #2307: Add TO Go cdns/routing URL: https://github.com/apache/incubator-trafficcontrol/pull/2307#issuecomment-394754223 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1762/

[GitHub] asfgit commented on issue #2371: Fixed Go API tests for Types

asfgit commented on issue #2371: Fixed Go API tests for Types URL: https://github.com/apache/incubator-trafficcontrol/pull/2371#issuecomment-394754041 Can one of the admins verify this patch? This is an automated message

[GitHub] rob05c commented on a change in pull request #2341: Add TO Go Divisions name

rob05c commented on a change in pull request #2341: Add TO Go Divisions name URL: https://github.com/apache/incubator-trafficcontrol/pull/2341#discussion_r193117295 ## File path: traffic_ops/traffic_ops_golang/routes.go ## @@ -122,6 +122,7 @@ func Routes(d ServerData)

[GitHub] asfgit commented on issue #2371: Fixed Go API tests for Types

asfgit commented on issue #2371: Fixed Go API tests for Types URL: https://github.com/apache/incubator-trafficcontrol/pull/2371#issuecomment-394752534 Can one of the admins verify this patch? This is an automated message

[GitHub] ajschmidt opened a new pull request #2371: Fixed Go API tests for Types

ajschmidt opened a new pull request #2371: Fixed Go API tests for Types URL: https://github.com/apache/incubator-trafficcontrol/pull/2371 This fixes all of the client api tests for the Types API in Go This is an automated

[GitHub] asfgit commented on issue #2305: Add TO Go cdns/health

asfgit commented on issue #2305: Add TO Go cdns/health URL: https://github.com/apache/incubator-trafficcontrol/pull/2305#issuecomment-394752287 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1761/

[GitHub] rob05c commented on a change in pull request #2301: Add TO Go cachegroups/id/queue_update

rob05c commented on a change in pull request #2301: Add TO Go cachegroups/id/queue_update URL: https://github.com/apache/incubator-trafficcontrol/pull/2301#discussion_r193114556 ## File path: traffic_ops/traffic_ops_golang/cachegroup/queueupdate.go ## @@ -0,0 +1,164 @@

[GitHub] DylanVolz commented on issue #2357: Add TO Go cdns/configs

DylanVolz commented on issue #2357: Add TO Go cdns/configs URL: https://github.com/apache/incubator-trafficcontrol/pull/2357#issuecomment-394689561 Tested, works as expected, sorting is different (I don't think it is an issue as order isn't specified).

[GitHub] DylanVolz commented on issue #2354: Add TO Go phys_locations/trimmed

DylanVolz commented on issue #2354: Add TO Go phys_locations/trimmed URL: https://github.com/apache/incubator-trafficcontrol/pull/2354#issuecomment-394688606 Tested, works as expected, looks good. This is an automated