Jenkins build is back to normal : trafficcontrol-PR #2436

See

[GitHub] asfgit commented on issue #2306: Add TO Go cdns/capacity

asfgit commented on issue #2306: Add TO Go cdns/capacity URL: https://github.com/apache/trafficcontrol/pull/2306#issuecomment-421170128 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2436/ Test PASSed.

[GitHub] rob05c commented on issue #2306: Add TO Go cdns/capacity

rob05c commented on issue #2306: Add TO Go cdns/capacity URL: https://github.com/apache/trafficcontrol/pull/2306#issuecomment-421169035 Rebased, should be good to merge. This is an automated message from the Apache Git

[GitHub] rob05c commented on issue #2306: Add TO Go cdns/capacity

rob05c commented on issue #2306: Add TO Go cdns/capacity URL: https://github.com/apache/trafficcontrol/pull/2306#issuecomment-421168919 What does this PR do? Add TO Go cdns/capacity Which TC components are affected by this PR? - [ ] Documentation - [ ]

Build failed in Jenkins: trafficcontrol-PR #2435

See Changes: [dewrich] Add TO Go cachegroups/id/deliveryservices [dewrich] Add TO Go cachegroups/dses API test, client funcs [dewrich] Remove TO unused func [mitchell852] removes TP v1

[GitHub] rob05c commented on a change in pull request #2803: Add Traffic Ops Golang Steering Targets

rob05c commented on a change in pull request #2803: Add Traffic Ops Golang Steering Targets URL: https://github.com/apache/trafficcontrol/pull/2803#discussion_r217544690 ## File path: lib/go-tc/steeringtarget.go ## @@ -47,9 +47,6 @@ type SteeringTargetNullable struct {

[GitHub] mitchell852 opened a new pull request #2819: removes TP v1

mitchell852 opened a new pull request #2819: removes TP v1 URL: https://github.com/apache/trafficcontrol/pull/2819 What does this PR do? It removes TP v1. TP v1 was a very simple UI with a few charts. It had no ability to update anything in TO. Which TC components

[GitHub] dewrich commented on a change in pull request #2803: Add Traffic Ops Golang Steering Targets

dewrich commented on a change in pull request #2803: Add Traffic Ops Golang Steering Targets URL: https://github.com/apache/trafficcontrol/pull/2803#discussion_r217162169 ## File path: lib/go-tc/steeringtarget.go ## @@ -47,9 +47,6 @@ type SteeringTargetNullable struct {

[GitHub] asfgit commented on issue #2249: Add CRConfig DS Modified fields

asfgit commented on issue #2249: Add CRConfig DS Modified fields URL: https://github.com/apache/trafficcontrol/pull/2249#issuecomment-421155083 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2434/ Test

[GitHub] rob05c commented on issue #2249: Add CRConfig DS Modified fields

rob05c commented on issue #2249: Add CRConfig DS Modified fields URL: https://github.com/apache/trafficcontrol/pull/2249#issuecomment-421153866 What does this PR do? Add CRConfig DS Modified fields Which TC components are affected by this PR? - [ ]

[GitHub] rob05c commented on issue #2249: Add CRConfig DS Modified fields

rob05c commented on issue #2249: Add CRConfig DS Modified fields URL: https://github.com/apache/trafficcontrol/pull/2249#issuecomment-421153592 Rebased, migration renamed, builds, tests pass. This is an automated message from

[GitHub] asfgit commented on issue #2249: Add CRConfig DS Modified fields

asfgit commented on issue #2249: Add CRConfig DS Modified fields URL: https://github.com/apache/trafficcontrol/pull/2249#issuecomment-421150688 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2433/ Test

Jenkins build is back to normal : trafficcontrol-PR #2433

See

[GitHub] asfgit commented on issue #2818: WIP Doc updates

asfgit commented on issue #2818: WIP Doc updates URL: https://github.com/apache/trafficcontrol/pull/2818#issuecomment-421141107 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2432/ Test FAILed.

Build failed in Jenkins: trafficcontrol-PR #2432

See Changes: [Brennan_WilliamFieck] Various minor improvements [Brennan_WilliamFieck] merged with stash [ocket] removed placeholder file [ocket] Lots of minor changes [ocket] Fixed

[GitHub] ocket8888 opened a new pull request #2818: WIP Doc updates

ocket opened a new pull request #2818: WIP Doc updates URL: https://github.com/apache/trafficcontrol/pull/2818 What does this PR do? Various documentation changes. - Tables in reST source will not take up more than 215 characters per line - Space indentation will

[GitHub] dewrich closed pull request #2300: Add TO Go cachegroups/id/deliveryservices

dewrich closed pull request #2300: Add TO Go cachegroups/id/deliveryservices URL: https://github.com/apache/trafficcontrol/pull/2300 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] asfgit commented on issue #2300: Add TO Go cachegroups/id/deliveryservices

asfgit commented on issue #2300: Add TO Go cachegroups/id/deliveryservices URL: https://github.com/apache/trafficcontrol/pull/2300#issuecomment-421131819 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2431/

[GitHub] rob05c commented on a change in pull request #2300: Add TO Go cachegroups/id/deliveryservices

rob05c commented on a change in pull request #2300: Add TO Go cachegroups/id/deliveryservices URL: https://github.com/apache/trafficcontrol/pull/2300#discussion_r217511257 ## File path: traffic_ops/traffic_ops_golang/cachegroup/dspost.go ## @@ -0,0 +1,290 @@ +package

[GitHub] dewrich commented on a change in pull request #2300: Add TO Go cachegroups/id/deliveryservices

dewrich commented on a change in pull request #2300: Add TO Go cachegroups/id/deliveryservices URL: https://github.com/apache/trafficcontrol/pull/2300#discussion_r217508429 ## File path: traffic_ops/traffic_ops_golang/cachegroup/dspost.go ## @@ -0,0 +1,290 @@ +package

[GitHub] asfgit commented on issue #2791: Add Traffic Ops Golang Enforcing Capabilities

asfgit commented on issue #2791: Add Traffic Ops Golang Enforcing Capabilities URL: https://github.com/apache/trafficcontrol/pull/2791#issuecomment-421082922 Refer to this link for build results (access rights to CI server needed):

[GitHub] dneuman64 opened a new issue #2817: Traffic Router /crs/stats access via HTTPS

dneuman64 opened a new issue #2817: Traffic Router /crs/stats access via HTTPS URL: https://github.com/apache/trafficcontrol/issues/2817 The /crs/stats API in Traffic Router is very useful to get stats related to Traffic Router and how Traffic Router is routing traffic. The API currently

[GitHub] rob05c edited a comment on issue #2816: "Routing Disabled" Doesn't Really Make Sense on Profiles

rob05c edited a comment on issue #2816: "Routing Disabled" Doesn't Really Make Sense on Profiles URL: https://github.com/apache/trafficcontrol/issues/2816#issuecomment-421079464 +1 The right solution is to make a new table, either `cache_server` or `cache_profile` (possibly both),

[GitHub] rob05c edited a comment on issue #2816: "Routing Disabled" Doesn't Really Make Sense on Profiles

rob05c edited a comment on issue #2816: "Routing Disabled" Doesn't Really Make Sense on Profiles URL: https://github.com/apache/trafficcontrol/issues/2816#issuecomment-421079464 +1 The right solution is to make a new table, either `cache_servers` or `cache_profile` (possibly both),

[GitHub] rob05c edited a comment on issue #2816: "Routing Disabled" Doesn't Really Make Sense on Profiles

rob05c edited a comment on issue #2816: "Routing Disabled" Doesn't Really Make Sense on Profiles URL: https://github.com/apache/trafficcontrol/issues/2816#issuecomment-421079464 +1 The right solution is to make a new table, either `cache_servers` or `cache_profiles` (possibly

[GitHub] rob05c commented on issue #2816: "Routing Disabled" Doesn't Really Make Sense on Profiles

rob05c commented on issue #2816: "Routing Disabled" Doesn't Really Make Sense on Profiles URL: https://github.com/apache/trafficcontrol/issues/2816#issuecomment-421079464 +1 The right solution is to make a new table, `cache_servers`, which only applies to caches (you say ATS, but I

[GitHub] ocket8888 opened a new issue #2816: "Routing Disabled" Doesn't Really Make Sense on Profiles

ocket opened a new issue #2816: "Routing Disabled" Doesn't Really Make Sense on Profiles URL: https://github.com/apache/trafficcontrol/issues/2816 The disabling of routing to a particular server ought to be constrained to either server objects, or possibly on the routers themselves.

[GitHub] asfgit commented on issue #2300: Add TO Go cachegroups/id/deliveryservices

asfgit commented on issue #2300: Add TO Go cachegroups/id/deliveryservices URL: https://github.com/apache/trafficcontrol/pull/2300#issuecomment-421063191 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2429/

[GitHub] rob05c commented on issue #2300: Add TO Go cachegroups/id/deliveryservices

rob05c commented on issue #2300: Add TO Go cachegroups/id/deliveryservices URL: https://github.com/apache/trafficcontrol/pull/2300#issuecomment-421062813 Rebased, API tests pass, unit tests pass. This is an automated message

[GitHub] dewrich commented on issue #2670: /api/1.3/servers error - "getting servers: sql: Rows are closed"

dewrich commented on issue #2670: /api/1.3/servers error - "getting servers: sql: Rows are closed" URL: https://github.com/apache/trafficcontrol/issues/2670#issuecomment-421027579 There's been ongoing discussions that this issue is caused by the Go Postgres Driver lib/pq when a Context is