Build failed in Jenkins: trafficcontrol-PR #4660

2019-10-28 Thread Apache Jenkins Server
See Changes: [ocket] Add top-level vendor dir to TO-Go and TM unit test containers (#4009) [ocket] accounts for null arrays (#4008) [mitchell852] Rewrote /user/reset_password to Go (#3929)

[GitHub] [trafficcontrol] asf-ci commented on issue #4010: Port legacy perl TO extension checks from perl to go

2019-10-28 Thread GitBox
asf-ci commented on issue #4010: Port legacy perl TO extension checks from perl to go URL: https://github.com/apache/trafficcontrol/pull/4010#issuecomment-547208476 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] guzzijason commented on issue #4010: Port legacy perl TO extension checks from perl to go

2019-10-28 Thread GitBox
guzzijason commented on issue #4010: Port legacy perl TO extension checks from perl to go URL: https://github.com/apache/trafficcontrol/pull/4010#issuecomment-547207926 I'm satisfied that the code in this PR is now building and running satisfactorily with the go client library version

[GitHub] [trafficcontrol] asf-ci commented on issue #4010: Port legacy perl TO extension checks from perl to go

2019-10-28 Thread GitBox
asf-ci commented on issue #4010: Port legacy perl TO extension checks from perl to go URL: https://github.com/apache/trafficcontrol/pull/4010#issuecomment-547206547 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: trafficcontrol-PR #4659

2019-10-28 Thread Apache Jenkins Server
See Changes: [Jason_Tucker] Port TO Extension Checks from perl to go [Jason_Tucker] update extension check doc [Jason_Tucker] Update CHANGELOG.md [Jason_Tucker] change UpdateCheckStatus() to

Build failed in Jenkins: trafficcontrol-PR #4658

2019-10-28 Thread Apache Jenkins Server
See Changes: [ocket] Moved some images, unset executable bit and shebang on non-executable [ocket] Fixed some documentation warnings generated from Python files [ocket] Added kickstart setup QHT

[GitHub] [trafficcontrol] asf-ci commented on issue #4037: Docs/influx fix

2019-10-28 Thread GitBox
asf-ci commented on issue #4037: Docs/influx fix URL: https://github.com/apache/trafficcontrol/pull/4037#issuecomment-547200062 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4658/

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #4037: Docs/influx fix

2019-10-28 Thread GitBox
ocket opened a new pull request #4037: Docs/influx fix URL: https://github.com/apache/trafficcontrol/pull/4037 ## What does this PR (Pull Request) do? - [x] This PR is not related to any Issue This fixes an issue where Influx connections were defaulting to secure,

Build failed in Jenkins: trafficcontrol-PR #4657

2019-10-28 Thread Apache Jenkins Server
See Changes: [ocket] Add top-level vendor dir to TO-Go and TM unit test containers (#4009) [ocket] accounts for null arrays (#4008) [mitchell852] Rewrote /user/reset_password to Go (#3929)

[GitHub] [trafficcontrol] asf-ci commented on issue #4015: Rewrite /federations to Go - POST/PUT/DELETE

2019-10-28 Thread GitBox
asf-ci commented on issue #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#issuecomment-547198250 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] asf-ci commented on issue #4010: Port legacy perl TO extension checks from perl to go

2019-10-28 Thread GitBox
asf-ci commented on issue #4010: Port legacy perl TO extension checks from perl to go URL: https://github.com/apache/trafficcontrol/pull/4010#issuecomment-547198110 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] asf-ci commented on issue #4015: Rewrite /federations to Go - POST/PUT/DELETE

2019-10-28 Thread GitBox
asf-ci commented on issue #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#issuecomment-547196925 Refer to this link for build results (access rights to CI server needed):

Jenkins build is back to normal : trafficcontrol-PR #4655

2019-10-28 Thread Apache Jenkins Server
See

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

2019-10-28 Thread GitBox
ocket commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r339835934 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -86,7 +86,7 @@ func

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

2019-10-28 Thread GitBox
ocket commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r339835857 ## File path: traffic_ops/traffic_ops_golang/federations/federations.go ## @@ -167,3 +206,296

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

2019-10-28 Thread GitBox
ocket commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r339835100 ## File path: traffic_ops/traffic_ops_golang/dbhelpers/db_helpers.go ## @@ -346,3 +430,17 @@

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

2019-10-28 Thread GitBox
ocket commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r339834865 ## File path: traffic_ops/traffic_ops_golang/dbhelpers/db_helpers.go ## @@ -42,6 +42,75 @@

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

2019-10-28 Thread GitBox
ocket commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r339834661 ## File path: lib/go-tc/federation.go ## @@ -67,36 +80,85 @@ type FederationMapping struct {

[GitHub] [trafficcontrol] zrhoffman commented on issue #3965: Traffic Router inconsistent behavior on HTTP HEAD requests

2019-10-28 Thread GitBox
zrhoffman commented on issue #3965: Traffic Router inconsistent behavior on HTTP HEAD requests URL: https://github.com/apache/trafficcontrol/issues/3965#issuecomment-547179715 Most of the API's mappings return a ResponseEntity, which guarantees setting `Content-Length` for any status

Build failed in Jenkins: trafficcontrol-PR #4654

2019-10-28 Thread Apache Jenkins Server
See Changes: [Jason_Tucker] Port TO Extension Checks from perl to go [Jason_Tucker] update extension check doc [Jason_Tucker] Update CHANGELOG.md [Jason_Tucker] change UpdateCheckStatus() to

[GitHub] [trafficcontrol] asf-ci commented on issue #4010: Port legacy perl TO extension checks from perl to go

2019-10-28 Thread GitBox
asf-ci commented on issue #4010: Port legacy perl TO extension checks from perl to go URL: https://github.com/apache/trafficcontrol/pull/4010#issuecomment-547177039 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

2019-10-28 Thread GitBox
mhoppa commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r339822218 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -86,7 +86,7 @@ func WriteRespRaw(w

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

2019-10-28 Thread GitBox
mhoppa commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r339808566 ## File path: traffic_ops/traffic_ops_golang/federations/federations.go ## @@ -167,3 +206,296 @@

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

2019-10-28 Thread GitBox
mhoppa commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r339600297 ## File path: traffic_ops/traffic_ops_golang/dbhelpers/db_helpers.go ## @@ -346,3 +430,17 @@ func

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

2019-10-28 Thread GitBox
mhoppa commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r339566176 ## File path: lib/go-tc/federation.go ## @@ -67,36 +80,85 @@ type FederationMapping struct {

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

2019-10-28 Thread GitBox
mhoppa commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r339599291 ## File path: traffic_ops/traffic_ops_golang/dbhelpers/db_helpers.go ## @@ -42,6 +42,75 @@ const

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1610

2019-10-28 Thread Apache Jenkins Server
See Changes: [ocket] Fix query parameter name (#4031) -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables.

Build failed in Jenkins: trafficcontrol-master-build #1567

2019-10-28 Thread Apache Jenkins Server
See Changes: [ocket] Fix query parameter name (#4031) -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables.

[GitHub] [trafficcontrol] ocket8888 merged pull request #4031: Fix query parameter name

2019-10-28 Thread GitBox
ocket merged pull request #4031: Fix query parameter name URL: https://github.com/apache/trafficcontrol/pull/4031 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4029: Rewrite cache_stats to Golang

2019-10-28 Thread GitBox
mhoppa commented on a change in pull request #4029: Rewrite cache_stats to Golang URL: https://github.com/apache/trafficcontrol/pull/4029#discussion_r339806416 ## File path: traffic_ops/traffic_ops_golang/trafficstats/cache.go ## @@ -0,0 +1,207 @@ +package trafficstats +

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4029: Rewrite cache_stats to Golang

2019-10-28 Thread GitBox
ocket commented on a change in pull request #4029: Rewrite cache_stats to Golang URL: https://github.com/apache/trafficcontrol/pull/4029#discussion_r339803463 ## File path: traffic_ops/traffic_ops_golang/trafficstats/cache.go ## @@ -0,0 +1,207 @@ +package trafficstats

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

2019-10-28 Thread GitBox
mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r339798927 ## File path:

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

2019-10-28 Thread GitBox
mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r339796187 ## File path: traffic_ops/traffic_ops_golang/routing/routes.go

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

2019-10-28 Thread GitBox
mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r339794527 ## File path:

[GitHub] [trafficcontrol] asf-ci commented on issue #3980: Add atscfg logic for Server Capabilities

2019-10-28 Thread GitBox
asf-ci commented on issue #3980: Add atscfg logic for Server Capabilities URL: https://github.com/apache/trafficcontrol/pull/3980#issuecomment-547144411 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4653/

Build failed in Jenkins: trafficcontrol-PR #4653

2019-10-28 Thread Apache Jenkins Server
See Changes: [rob] Add atscfg logic for Server Capabilities. -- GitHub pull request #3980 of commit 44e2ac3a4bb45b3fef0cf7172412ef3b175038e3, no merge conflicts.

[GitHub] [trafficcontrol] asf-ci commented on issue #4029: Rewrite cache_stats to Golang

2019-10-28 Thread GitBox
asf-ci commented on issue #4029: Rewrite cache_stats to Golang URL: https://github.com/apache/trafficcontrol/pull/4029#issuecomment-547144224 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4652/

Build failed in Jenkins: trafficcontrol-PR #4652

2019-10-28 Thread Apache Jenkins Server
See Changes: -- GitHub pull request #4029 of commit 4bc7f3e026fff26379842067e3c40a73ff1a8bb6, no merge conflicts. Running as SYSTEM Setting status of

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

2019-10-28 Thread GitBox
mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r339790033 ## File path:

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

2019-10-28 Thread GitBox
mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r339789893 ## File path:

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

2019-10-28 Thread GitBox
mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r339789856 ## File path:

Build failed in Jenkins: trafficcontrol-PR #4651

2019-10-28 Thread Apache Jenkins Server
See Changes: [rob] Add atscfg logic for Server Capabilities. -- GitHub pull request #3980 of commit b3adc06c1c8a5f25846ec178087ed05cbdd62ec9, no merge conflicts.

[GitHub] [trafficcontrol] asf-ci commented on issue #3980: Add atscfg logic for Server Capabilities

2019-10-28 Thread GitBox
asf-ci commented on issue #3980: Add atscfg logic for Server Capabilities URL: https://github.com/apache/trafficcontrol/pull/3980#issuecomment-547142612 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4651/

Build failed in Jenkins: trafficcontrol-PR #4650

2019-10-28 Thread Apache Jenkins Server
See Changes: -- GitHub pull request #4029 of commit 8bd336df432939593de9fe1ced7c72233f22a4d2, no merge conflicts. Running as SYSTEM Setting status of

[GitHub] [trafficcontrol] asf-ci commented on issue #4029: Rewrite cache_stats to Golang

2019-10-28 Thread GitBox
asf-ci commented on issue #4029: Rewrite cache_stats to Golang URL: https://github.com/apache/trafficcontrol/pull/4029#issuecomment-547142437 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4650/

[GitHub] [trafficcontrol] ocket8888 commented on issue #4033: To: INternal server error when server capability associated with Server is deleted

2019-10-28 Thread GitBox
ocket commented on issue #4033: To: INternal server error when server capability associated with Server is deleted URL: https://github.com/apache/trafficcontrol/issues/4033#issuecomment-547140878 Error code should be `409 Conflict` IMO.

[GitHub] [trafficcontrol] ocket8888 commented on issue #4036: TO: alert message on create server should be fixed.

2019-10-28 Thread GitBox
ocket commented on issue #4036: TO: alert message on create server should be fixed. URL: https://github.com/apache/trafficcontrol/issues/4036#issuecomment-547140418 Could be further improved using names not IDs, IMO. Though the IDs are what the request specifies, so maybe can't be

[GitHub] [trafficcontrol] ocket8888 commented on issue #4034: TO API: Message returned from API in Server server capabilities should be corrected

2019-10-28 Thread GitBox
ocket commented on issue #4034: TO API: Message returned from API in Server server capabilities should be corrected URL: https://github.com/apache/trafficcontrol/issues/4034#issuecomment-547140117 I believe that's a limitation of the "CRUDer", and probably manifests in many endpoints.

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

2019-10-28 Thread GitBox
ocket commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r339784309 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/autorenewcerts.go

[GitHub] [trafficcontrol] asf-ci commented on issue #3980: WIP Add atscfg logic for Server Capabilities.

2019-10-28 Thread GitBox
asf-ci commented on issue #3980: WIP Add atscfg logic for Server Capabilities. URL: https://github.com/apache/trafficcontrol/pull/3980#issuecomment-547133983 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] ajschmidt commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

2019-10-28 Thread GitBox
ajschmidt commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r339778718 ## File path: docs/source/admin/traffic_router.rst ## @@ -681,8

Build failed in Jenkins: trafficcontrol-PR #4648

2019-10-28 Thread Apache Jenkins Server
See Changes: [mitchell852] adds the ability to add or remove required server capabilities from a [mitchell852] adds context menu items for viewing a server capability's servers and

[GitHub] [trafficcontrol] asf-ci commented on issue #4035: TP: adds the ability to add/remove required server capabilities from DS

2019-10-28 Thread GitBox
asf-ci commented on issue #4035: TP: adds the ability to add/remove required server capabilities from DS URL: https://github.com/apache/trafficcontrol/pull/4035#issuecomment-547133789 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: trafficcontrol-PR #4649

2019-10-28 Thread Apache Jenkins Server
See Changes: [rob] Add atscfg logic for Server Capabilities. -- GitHub pull request #3980 of commit ac8668b5bf3984b7f9c1bc57a7c43cb56db0485e, no merge conflicts.

[GitHub] [trafficcontrol] asf-ci commented on issue #4029: Rewrite cache_stats to Golang

2019-10-28 Thread GitBox
asf-ci commented on issue #4029: Rewrite cache_stats to Golang URL: https://github.com/apache/trafficcontrol/pull/4029#issuecomment-547133599 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4647/

[GitHub] [trafficcontrol] asf-ci commented on issue #4035: TP: adds the ability to add/remove required server capabilities from DS

2019-10-28 Thread GitBox
asf-ci commented on issue #4035: TP: adds the ability to add/remove required server capabilities from DS URL: https://github.com/apache/trafficcontrol/pull/4035#issuecomment-547133426 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: trafficcontrol-PR #4647

2019-10-28 Thread Apache Jenkins Server
See Changes: [Michael_Hoppal] Rewrite cache_stats from Perl to Golang [Michael_Hoppal] Back out test/dev code [Michael_Hoppal] Run gofmt -- GitHub pull request #4029

Build failed in Jenkins: trafficcontrol-PR #4646

2019-10-28 Thread Apache Jenkins Server
See Changes: -- GitHub pull request #4035 of commit 0be3cd29b6640cc6f34a36e2998153ac524a70f9, no merge conflicts. Running as SYSTEM Setting status of

Build failed in Jenkins: trafficcontrol-PR #4645

2019-10-28 Thread Apache Jenkins Server
See Changes: [ocket] Add top-level vendor dir to TO-Go and TM unit test containers (#4009) [ocket] accounts for null arrays (#4008) [mitchell852] Rewrote /user/reset_password to Go (#3929)

[GitHub] [trafficcontrol] asf-ci commented on issue #4035: TP: adds the ability to add/remove required server capabilities from DS

2019-10-28 Thread GitBox
asf-ci commented on issue #4035: TP: adds the ability to add/remove required server capabilities from DS URL: https://github.com/apache/trafficcontrol/pull/4035#issuecomment-547133243 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

2019-10-28 Thread GitBox
rawlinp commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r339772000 ## File path: traffic_ops/app/db/migrations/20191016_add_dns_challenges.sql

[GitHub] [trafficcontrol] lbathina opened a new issue #4036: TO: alert message on create server should be fixed.

2019-10-28 Thread GitBox
lbathina opened a new issue #4036: TO: alert message on create server should be fixed. URL: https://github.com/apache/trafficcontrol/issues/4036 ## I'm submitting a ... - [ ] bug report - [ ] new feature / enhancement request - [X] improvement request

[GitHub] [trafficcontrol] guzzijason commented on issue #4010: Port legacy perl TO extension checks from perl to go

2019-10-28 Thread GitBox
guzzijason commented on issue #4010: Port legacy perl TO extension checks from perl to go URL: https://github.com/apache/trafficcontrol/pull/4010#issuecomment-547123443 Do not merge - there were changes in #ccff78a that broke the code in this PR, that I was not anticipating. I need to

[GitHub] [trafficcontrol] mitchell852 commented on issue #4034: TP: Message displayed in Server server capabilities page should be corrected

2019-10-28 Thread GitBox
mitchell852 commented on issue #4034: TP: Message displayed in Server server capabilities page should be corrected URL: https://github.com/apache/trafficcontrol/issues/4034#issuecomment-547123497 This is really something that has to be changed in the TO API and not TP. TP only displays

[GitHub] [trafficcontrol] guzzijason edited a comment on issue #4010: Port legacy perl TO extension checks from perl to go

2019-10-28 Thread GitBox
guzzijason edited a comment on issue #4010: Port legacy perl TO extension checks from perl to go URL: https://github.com/apache/trafficcontrol/pull/4010#issuecomment-547123443 Do not merge - there were changes in ccff78a that broke the code in this PR, that I was not anticipating. I need

[GitHub] [trafficcontrol] mitchell852 opened a new pull request #4035: TP: adds the ability to add/remove required server capabilities from DS

2019-10-28 Thread GitBox
mitchell852 opened a new pull request #4035: TP: adds the ability to add/remove required server capabilities from DS URL: https://github.com/apache/trafficcontrol/pull/4035 DRAFT ## What does this PR (Pull Request) do? - [ ] This PR fixes #REPLACE_ME OR is not related

[GitHub] [trafficcontrol] mitchell852 closed pull request #4028: DRAFT: TP: Adds the ability to add/remove required server capabilities to/from a DS

2019-10-28 Thread GitBox
mitchell852 closed pull request #4028: DRAFT: TP: Adds the ability to add/remove required server capabilities to/from a DS URL: https://github.com/apache/trafficcontrol/pull/4028 This is an automated message from the Apache

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

2019-10-28 Thread GitBox
mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r339763826 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/keys.go

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

2019-10-28 Thread GitBox
mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r339762801 ## File path:

[GitHub] [trafficcontrol] lbathina opened a new issue #4034: TP: Message displayed in Server server capabilities page should be corrected

2019-10-28 Thread GitBox
lbathina opened a new issue #4034: TP: Message displayed in Server server capabilities page should be corrected URL: https://github.com/apache/trafficcontrol/issues/4034 ## I'm submitting a ... - [ ] bug report - [ ] new feature / enhancement request - [X]

[GitHub] [trafficcontrol] lbathina opened a new issue #4033: To: INternal server error when server capability associated with Server is deleted

2019-10-28 Thread GitBox
lbathina opened a new issue #4033: To: INternal server error when server capability associated with Server is deleted URL: https://github.com/apache/trafficcontrol/issues/4033 ## I'm submitting a ... - [X] bug report - [ ] new feature / enhancement request

[GitHub] [trafficcontrol] ocket8888 commented on issue #4032: Missing DELETE servers in documentation

2019-10-28 Thread GitBox
ocket commented on issue #4032: Missing DELETE servers in documentation URL: https://github.com/apache/trafficcontrol/issues/4032#issuecomment-547108382 Related: #2726 and #3443 This is an automated message from the

Build failed in Jenkins: trafficcontrol-PR #4644

2019-10-28 Thread Apache Jenkins Server
See Changes: [Jason_Tucker] Port TO Extension Checks from perl to go [Jason_Tucker] update extension check doc [Jason_Tucker] Update CHANGELOG.md [Jason_Tucker] change UpdateCheckStatus() to

[GitHub] [trafficcontrol] asf-ci commented on issue #4010: Port legacy perl TO extension checks from perl to go

2019-10-28 Thread GitBox
asf-ci commented on issue #4010: Port legacy perl TO extension checks from perl to go URL: https://github.com/apache/trafficcontrol/pull/4010#issuecomment-547107889 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] ZugNZwang opened a new issue #4032: Missing DELETE servers in documentation

2019-10-28 Thread GitBox
ZugNZwang opened a new issue #4032: Missing DELETE servers in documentation URL: https://github.com/apache/trafficcontrol/issues/4032 ## I'm submitting a ... - [ ] bug report - [ ] new feature / enhancement request - [ ] improvement request (usability,

[GitHub] [trafficcontrol] ChrisHines commented on issue #4031: Fix query parameter name

2019-10-28 Thread GitBox
ChrisHines commented on issue #4031: Fix query parameter name URL: https://github.com/apache/trafficcontrol/pull/4031#issuecomment-547104653 @mhoppa PTAL This is an automated message from the Apache Git Service. To respond to

[GitHub] [trafficcontrol] asf-ci commented on issue #4031: Fix query parameter name

2019-10-28 Thread GitBox
asf-ci commented on issue #4031: Fix query parameter name URL: https://github.com/apache/trafficcontrol/pull/4031#issuecomment-547095815 Can one of the admins verify this patch? This is an automated message from the Apache

[GitHub] [trafficcontrol] ChrisHines opened a new pull request #4031: Fix query parameter name

2019-10-28 Thread GitBox
ChrisHines opened a new pull request #4031: Fix query parameter name URL: https://github.com/apache/trafficcontrol/pull/4031 ## What does this PR (Pull Request) do? - [x] This PR updates documentation to match implementation in #4026 ## Which Traffic Control components are

Build failed in Jenkins: trafficcontrol-master-build #1566

2019-10-28 Thread Apache Jenkins Server
See Changes: [ocket] Feature/add deliveryservice required capability (#4026) -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1609

2019-10-28 Thread Apache Jenkins Server
See Changes: [ocket] Feature/add deliveryservice required capability (#4026) -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node

[GitHub] [trafficcontrol] ocket8888 merged pull request #4026: Feature/add deliveryservice required capability

2019-10-28 Thread GitBox
ocket merged pull request #4026: Feature/add deliveryservice required capability URL: https://github.com/apache/trafficcontrol/pull/4026 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [trafficcontrol] smalenfant commented on issue #4010: Port legacy perl TO extension checks from perl to go

2019-10-28 Thread GitBox
smalenfant commented on issue #4010: Port legacy perl TO extension checks from perl to go URL: https://github.com/apache/trafficcontrol/pull/4010#issuecomment-547089027 Can we add those to the Traffic Ops build? Would be nice to be available and compiled when installing traffic_ops RPM.

[GitHub] [trafficcontrol] jheitz200 commented on a change in pull request #4026: Feature/add deliveryservice required capability

2019-10-28 Thread GitBox
jheitz200 commented on a change in pull request #4026: Feature/add deliveryservice required capability URL: https://github.com/apache/trafficcontrol/pull/4026#discussion_r339727160 ## File path:

Build failed in Jenkins: trafficcontrol-PR #4643

2019-10-28 Thread Apache Jenkins Server
See Changes: [rawlin_peters] Make /deliveryservice_stats accessible to read-only users (#4004) [ocket] Fix deliveryservice_stats API to use already-vendored influxdb client, [rawlin_peters] Rewrote

[GitHub] [trafficcontrol] asf-ci commented on issue #4030: Rewrite PUT /api/1.1/servers/:id/status to Go

2019-10-28 Thread GitBox
asf-ci commented on issue #4030: Rewrite PUT /api/1.1/servers/:id/status to Go URL: https://github.com/apache/trafficcontrol/pull/4030#issuecomment-547075320 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

2019-10-28 Thread GitBox
mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r339701370 ## File path:

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

2019-10-28 Thread GitBox
mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r339700181 ## File path:

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4026: Feature/add deliveryservice required capability

2019-10-28 Thread GitBox
mhoppa commented on a change in pull request #4026: Feature/add deliveryservice required capability URL: https://github.com/apache/trafficcontrol/pull/4026#discussion_r339697208 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/cookie.txt ## @@ -0,0 +1,5 @@ +#

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4026: Feature/add deliveryservice required capability

2019-10-28 Thread GitBox
mhoppa commented on a change in pull request #4026: Feature/add deliveryservice required capability URL: https://github.com/apache/trafficcontrol/pull/4026#discussion_r339690499 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices_required_capabilities.go

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

2019-10-28 Thread GitBox
mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r339699937 ## File path:

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

2019-10-28 Thread GitBox
mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r339699191 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

2019-10-28 Thread GitBox
mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r339697322 ## File path:

[GitHub] [trafficcontrol] guzzijason commented on issue #3965: Traffic Router inconsistent behavior on HTTP HEAD requests

2019-10-28 Thread GitBox
guzzijason commented on issue #3965: Traffic Router inconsistent behavior on HTTP HEAD requests URL: https://github.com/apache/trafficcontrol/issues/3965#issuecomment-547049866 Sorry... actually, `Content-Length` is one of the payload headers that MAY be omitted in a HEAD response. At any

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

2019-10-28 Thread GitBox
mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r339685416 ## File path: docs/source/admin/traffic_router.rst ## @@ -681,8

[GitHub] [trafficcontrol] guzzijason commented on issue #3965: Traffic Router inconsistent behavior on HTTP HEAD requests

2019-10-28 Thread GitBox
guzzijason commented on issue #3965: Traffic Router inconsistent behavior on HTTP HEAD requests URL: https://github.com/apache/trafficcontrol/issues/3965#issuecomment-547047350 Per RFC 7231: ``` The server SHOULD send the same header fields in response to a HEAD request as it

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

2019-10-28 Thread GitBox
mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r339683197 ## File path: docs/source/admin/traffic_router.rst ## @@ -681,8

[GitHub] [trafficcontrol] jheitz200 commented on a change in pull request #4026: Feature/add deliveryservice required capability

2019-10-28 Thread GitBox
jheitz200 commented on a change in pull request #4026: Feature/add deliveryservice required capability URL: https://github.com/apache/trafficcontrol/pull/4026#discussion_r339675402 ## File path: traffic_ops/app/db/seeds.sql ## @@ -541,6 +541,10 @@ insert into

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4026: Feature/add deliveryservice required capability

2019-10-28 Thread GitBox
mhoppa commented on a change in pull request #4026: Feature/add deliveryservice required capability URL: https://github.com/apache/trafficcontrol/pull/4026#discussion_r339667097 ## File path: traffic_ops/app/db/seeds.sql ## @@ -541,6 +541,10 @@ insert into api_capability

[GitHub] [trafficcontrol] zrhoffman commented on issue #3965: Traffic Router inconsistent behavior on HTTP HEAD requests

2019-10-28 Thread GitBox
zrhoffman commented on issue #3965: Traffic Router inconsistent behavior on HTTP HEAD requests URL: https://github.com/apache/trafficcontrol/issues/3965#issuecomment-546920662 The wait itself is wontfix cURL-specific behavior. From [a curl-users mailing list