Build failed in Jenkins: trafficcontrol-PR #4789

See Changes: [ocket] go fmt -- [...truncated 3.61 MB...] traffic_portal_build_1 | | | | `-- tape@2.3.3 traffic_portal_build_1 | | | |

[GitHub] [trafficcontrol] asf-ci commented on issue #3761: Improvements to Server-to-Delivery Service assignments

asf-ci commented on issue #3761: Improvements to Server-to-Delivery Service assignments URL: https://github.com/apache/trafficcontrol/pull/3761#issuecomment-554589020 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3768: Codecov

ocket commented on a change in pull request #3768: Codecov URL: https://github.com/apache/trafficcontrol/pull/3768#discussion_r347025411 ## File path: traffic_monitor/tests/gocover.bash ## @@ -0,0 +1,36 @@ +#!/usr/bin/env bash + +# Licensed under the Apache License,

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3768: Codecov

ocket commented on a change in pull request #3768: Codecov URL: https://github.com/apache/trafficcontrol/pull/3768#discussion_r347064327 ## File path: traffic_monitor/tests/gocover.bash ## @@ -0,0 +1,36 @@ +#!/usr/bin/env bash + +# Licensed under the Apache License,

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3768: Codecov

ocket commented on a change in pull request #3768: Codecov URL: https://github.com/apache/trafficcontrol/pull/3768#discussion_r347020709 ## File path: traffic_monitor/tests/gocover.bash ## @@ -0,0 +1,36 @@ +#!/usr/bin/env bash + +# Licensed under the Apache License,

[GitHub] [trafficcontrol] rawlinp commented on issue #4119: TO: Consistently set Expires and Max-Age cookie headers

rawlinp commented on issue #4119: TO: Consistently set Expires and Max-Age cookie headers URL: https://github.com/apache/trafficcontrol/pull/4119#issuecomment-554558865 Oh, good call. I forgot stuff like `Set-Cookie` headers are included in the examples. Maybe I should update _all_ the

[GitHub] [trafficcontrol] asf-ci commented on issue #3761: Improvements to Server-to-Delivery Service assignments

asf-ci commented on issue #3761: Improvements to Server-to-Delivery Service assignments URL: https://github.com/apache/trafficcontrol/pull/3761#issuecomment-554540497 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: trafficcontrol-master-build #1607

See Changes: [mitchell852] Removed restangular from ./FormProfileController.js (#3599) -- [...truncated 3.05 MB...] traffic_portal_build_1 |

[GitHub] [trafficcontrol] asf-ci commented on issue #4119: TO: Consistently set Expires and Max-Age cookie headers

asf-ci commented on issue #4119: TO: Consistently set Expires and Max-Age cookie headers URL: https://github.com/apache/trafficcontrol/pull/4119#issuecomment-554538069 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] mitchell852 merged pull request #3599: Removed restangular from FormProfileController.js

mitchell852 merged pull request #3599: Removed restangular from FormProfileController.js URL: https://github.com/apache/trafficcontrol/pull/3599 This is an automated message from the Apache Git Service. To respond to the

Jenkins build is back to normal : trafficcontrol-PR #4786

See

[GitHub] [trafficcontrol] asf-ci commented on issue #3761: Improvements to Server-to-Delivery Service assignments

asf-ci commented on issue #3761: Improvements to Server-to-Delivery Service assignments URL: https://github.com/apache/trafficcontrol/pull/3761#issuecomment-554528006 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] ocket8888 commented on issue #3761: Improvements to Server-to-Delivery Service assignments

ocket commented on issue #3761: Improvements to Server-to-Delivery Service assignments URL: https://github.com/apache/trafficcontrol/pull/3761#issuecomment-554527029 > _"Also, (sorry i keep adding to this), i think this is valid: POST --data '[]' if you want to wipe them all out so

[GitHub] [trafficcontrol] mitchell852 removed a comment on issue #3761: Improvements to Server-to-Delivery Service assignments

mitchell852 removed a comment on issue #3761: Improvements to Server-to-Delivery Service assignments URL: https://github.com/apache/trafficcontrol/pull/3761#issuecomment-554522883 sorry, i heavily edited my comment above. not sure if you saw what i added.

[GitHub] [trafficcontrol] mitchell852 commented on issue #3761: Improvements to Server-to-Delivery Service assignments

mitchell852 commented on issue #3761: Improvements to Server-to-Delivery Service assignments URL: https://github.com/apache/trafficcontrol/pull/3761#issuecomment-554526927 > `curl -k -v -H "Accept: application/json" --cookie cookie.txt -X POST --data '[42]'

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3761: Improvements to Server-to-Delivery Service assignments

mitchell852 commented on a change in pull request #3761: Improvements to Server-to-Delivery Service assignments URL: https://github.com/apache/trafficcontrol/pull/3761#discussion_r347009244 ## File path: traffic_ops/traffic_ops_golang/server/servers_assignment.go ## @@

[GitHub] [trafficcontrol] rawlinp opened a new pull request #4119: TO: Consistently set Expires and Max-Age cookie headers

rawlinp opened a new pull request #4119: TO: Consistently set Expires and Max-Age cookie headers URL: https://github.com/apache/trafficcontrol/pull/4119 ## What does this PR (Pull Request) do? Include the Expires and Max-Age cookie headers in the Set-Cookie response header for:

[GitHub] [trafficcontrol] mitchell852 commented on issue #3761: Improvements to Server-to-Delivery Service assignments

mitchell852 commented on issue #3761: Improvements to Server-to-Delivery Service assignments URL: https://github.com/apache/trafficcontrol/pull/3761#issuecomment-554522883 sorry, i heavily edited my comment above. not sure if you saw what i added.

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #3761: Improvements to Server-to-Delivery Service assignments

mitchell852 edited a comment on issue #3761: Improvements to Server-to-Delivery Service assignments URL: https://github.com/apache/trafficcontrol/pull/3761#issuecomment-554519380 `curl -k -v -H "Accept: application/json" --cookie cookie.txt -X POST --data '[42]'

[GitHub] [trafficcontrol] ocket8888 commented on issue #3761: Improvements to Server-to-Delivery Service assignments

ocket commented on issue #3761: Improvements to Server-to-Delivery Service assignments URL: https://github.com/apache/trafficcontrol/pull/3761#issuecomment-554522417 I wrote that error message with the intention of mimicking the `/deliveryservices` endpoint's behavior of not

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #3761: Improvements to Server-to-Delivery Service assignments

mitchell852 edited a comment on issue #3761: Improvements to Server-to-Delivery Service assignments URL: https://github.com/apache/trafficcontrol/pull/3761#issuecomment-554519380 `curl -k -v -H "Accept: application/json" --cookie cookie.txt -X POST --data '[42]'

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #3761: Improvements to Server-to-Delivery Service assignments

mitchell852 edited a comment on issue #3761: Improvements to Server-to-Delivery Service assignments URL: https://github.com/apache/trafficcontrol/pull/3761#issuecomment-554519380 `curl -k -v -H "Accept: application/json" --cookie cookie.txt -X POST --data '[42]'

[GitHub] [trafficcontrol] mitchell852 commented on issue #3761: Improvements to Server-to-Delivery Service assignments

mitchell852 commented on issue #3761: Improvements to Server-to-Delivery Service assignments URL: https://github.com/apache/trafficcontrol/pull/3761#issuecomment-554519380 `curl -k -v -H "Accept: application/json" --cookie cookie.txt -X POST --data '[10840]'

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #3761: Improvements to Server-to-Delivery Service assignments

mitchell852 edited a comment on issue #3761: Improvements to Server-to-Delivery Service assignments URL: https://github.com/apache/trafficcontrol/pull/3761#issuecomment-554519380 `curl -k -v -H "Accept: application/json" --cookie cookie.txt -X POST --data '[42]'

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #3761: Improvements to Server-to-Delivery Service assignments

mitchell852 edited a comment on issue #3761: Improvements to Server-to-Delivery Service assignments URL: https://github.com/apache/trafficcontrol/pull/3761#issuecomment-554519380 `curl -k -v -H "Accept: application/json" --cookie cookie.txt -X POST --data '[42]'

[GitHub] [trafficcontrol] ocket8888 commented on issue #3761: Improvements to Server-to-Delivery Service assignments

ocket commented on issue #3761: Improvements to Server-to-Delivery Service assignments URL: https://github.com/apache/trafficcontrol/pull/3761#issuecomment-554514127 I don't think it should be too hard. I can give that a go.

[GitHub] [trafficcontrol] mhoppa commented on issue #4114: Rewrite current stats from Perl to Golang

mhoppa commented on issue #4114: Rewrite current stats from Perl to Golang URL: https://github.com/apache/trafficcontrol/pull/4114#issuecomment-554513909 @ocket this is ready for review. The perl code did replace on \,',",\n in the CDN names prior to going to influxdb but all are

[GitHub] [trafficcontrol] mitchell852 commented on issue #3761: Improvements to Server-to-Delivery Service assignments

mitchell852 commented on issue #3761: Improvements to Server-to-Delivery Service assignments URL: https://github.com/apache/trafficcontrol/pull/3761#issuecomment-554511191 When trying to assign a ds to a server that is in a different cdn, the message is: `Delivery Service 42 is not

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #3761: Improvements to Server-to-Delivery Service assignments

mitchell852 edited a comment on issue #3761: Improvements to Server-to-Delivery Service assignments URL: https://github.com/apache/trafficcontrol/pull/3761#issuecomment-554511191 When trying to assign a ds to a server that is in a different cdn, the message is: `Delivery Service 42

Build failed in Jenkins: trafficcontrol-PR #4785

See Changes: [Michael_Hoppal] Remove unused TO API test files [Michael_Hoppal] Test files did not all have _test appended -- GitHub pull request #4118 of commit

[GitHub] [trafficcontrol] asf-ci commented on issue #4118: Clean up TO API tests

asf-ci commented on issue #4118: Clean up TO API tests URL: https://github.com/apache/trafficcontrol/pull/4118#issuecomment-554456759 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4785/

[GitHub] [trafficcontrol] mhoppa opened a new pull request #4118: Clean up TO API tests

mhoppa opened a new pull request #4118: Clean up TO API tests URL: https://github.com/apache/trafficcontrol/pull/4118 ## What does this PR (Pull Request) do? Removes unused go files and make sure all go files in package have _test appended. ## Which Traffic

Build failed in Jenkins: trafficcontrol-master-build #1606

See Changes: [ocket] Clean up Experimental code (#4095) -- [...truncated 3.68 MB...] traffic_portal_build_1 | | +-- bcrypt-pbkdf@1.0.2

[GitHub] [trafficcontrol] asf-ci commented on issue #4117: Remove unused dated infrastructure test suites

asf-ci commented on issue #4117: Remove unused dated infrastructure test suites URL: https://github.com/apache/trafficcontrol/pull/4117#issuecomment-554449162 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: trafficcontrol-PR #4784

See Changes: [Michael_Hoppal] Clean up unused dated infrastructure test suites -- [...truncated 2.80 MB...] traffic_portal_build_1 | | | +--

[GitHub] [trafficcontrol] lbathina commented on issue #4116: Delivery Services can be assigned servers from a different CDN

lbathina commented on issue #4116: Delivery Services can be assigned servers from a different CDN URL: https://github.com/apache/trafficcontrol/issues/4116#issuecomment-554448535 this is exactly duplicate of https://github.com/apache/trafficcontrol/issues/4085 which is closed saying its

Build failed in Jenkins: trafficcontrol-PR #4783

See Changes: [Michael_Hoppal] Remove code that is not used [ocket] adds deep coverage zone routed percentage to TP's routing widget (#4108) [Michael_Hoppal] Add back code [Michael_Hoppal] Cleanup

[GitHub] [trafficcontrol] asf-ci commented on issue #4095: Clean up Experimental code

asf-ci commented on issue #4095: Clean up Experimental code URL: https://github.com/apache/trafficcontrol/pull/4095#issuecomment-554447622 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4783/

[GitHub] [trafficcontrol] mhoppa commented on issue #4095: Clean up Experimental code

mhoppa commented on issue #4095: Clean up Experimental code URL: https://github.com/apache/trafficcontrol/pull/4095#issuecomment-554443469 btw broke out all the infra test clean up to https://github.com/apache/trafficcontrol/pull/4117 as requested in a comment in this pr

[GitHub] [trafficcontrol] ocket8888 merged pull request #4095: Clean up Experimental code

ocket merged pull request #4095: Clean up Experimental code URL: https://github.com/apache/trafficcontrol/pull/4095 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4107: Adding ability to use zone root records

rawlinp commented on a change in pull request #4107: Adding ability to use zone root records URL: https://github.com/apache/trafficcontrol/pull/4107#discussion_r346917978 ## File path: traffic_ops/traffic_ops_golang/staticdnsentry/staticdnsentry.go ## @@ -106,7 +107,7 @@

[GitHub] [trafficcontrol] mhoppa opened a new pull request #4117: Remove unused dated infrastructure test suites

mhoppa opened a new pull request #4117: Remove unused dated infrastructure test suites URL: https://github.com/apache/trafficcontrol/pull/4117 ## What does this PR (Pull Request) do? This PR goes through and removes infrastructure test suites that are unused now.

[GitHub] [trafficcontrol] mitchell852 commented on issue #4116: Delivery Services can be assigned servers from a different CDN

mitchell852 commented on issue #4116: Delivery Services can be assigned servers from a different CDN URL: https://github.com/apache/trafficcontrol/issues/4116#issuecomment-554438140 just for the record, TP prevents this. When assigning DS's to a Server, only DS's in the same cdn are

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4107: Adding ability to use zone root records

ocket commented on a change in pull request #4107: Adding ability to use zone root records URL: https://github.com/apache/trafficcontrol/pull/4107#discussion_r346908384 ## File path: traffic_ops/traffic_ops_golang/staticdnsentry/staticdnsentry.go ## @@ -106,7 +107,7

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4107: Adding ability to use zone root records

rawlinp commented on a change in pull request #4107: Adding ability to use zone root records URL: https://github.com/apache/trafficcontrol/pull/4107#discussion_r346897202 ## File path: traffic_ops/traffic_ops_golang/staticdnsentry/staticdnsentry.go ## @@ -106,7 +107,7 @@

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4107: Adding ability to use zone root records

rawlinp commented on a change in pull request #4107: Adding ability to use zone root records URL: https://github.com/apache/trafficcontrol/pull/4107#discussion_r346897202 ## File path: traffic_ops/traffic_ops_golang/staticdnsentry/staticdnsentry.go ## @@ -106,7 +107,7 @@

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4107: Adding ability to use zone root records

rawlinp commented on a change in pull request #4107: Adding ability to use zone root records URL: https://github.com/apache/trafficcontrol/pull/4107#discussion_r346897202 ## File path: traffic_ops/traffic_ops_golang/staticdnsentry/staticdnsentry.go ## @@ -106,7 +107,7 @@

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4107: Adding ability to use zone root records

ocket commented on a change in pull request #4107: Adding ability to use zone root records URL: https://github.com/apache/trafficcontrol/pull/4107#discussion_r346894468 ## File path: traffic_ops/traffic_ops_golang/staticdnsentry/staticdnsentry.go ## @@ -106,7 +107,7