[GitHub] [trafficcontrol] zrhoffman commented on pull request #7100: Traffic Router tests GHA: Include integration tests

zrhoffman commented on PR #7100: URL: https://github.com/apache/trafficcontrol/pull/7100#issuecomment-1263985694 Switched back to the old annotations we were using that echoes annotations instead of using the API (I wish more of them did that) in 7483eaa032 -- This is an automated

[GitHub] [trafficcontrol] github-code-scanning[bot] commented on a diff in pull request #7102: Tpv2 server fix

github-code-scanning[bot] commented on code in PR #7102: URL: https://github.com/apache/trafficcontrol/pull/7102#discussion_r984908529 ## experimental/traffic-portal/server.ts: ## @@ -198,10 +196,18 @@ return;

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7102: Tpv2 server fix

ocket opened a new pull request, #7102: URL: https://github.com/apache/trafficcontrol/pull/7102 Fixed the TPv2 server not running as intended. It also now handles more gracefully the common case of bind permissions being denied on port 80 when running in SSL mode. Instead of the

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7100: Traffic Router tests GHA: Include integration tests

ocket commented on PR #7100: URL: https://github.com/apache/trafficcontrol/pull/7100#issuecomment-1263932500 So you're saying that once this is merged it'll add annotations? Lemme check that out. Or, well, at least check if the warning and error go away. -- This is an

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7100: Traffic Router tests GHA: Include integration tests

zrhoffman commented on PR #7100: URL: https://github.com/apache/trafficcontrol/pull/7100#issuecomment-1263910426 But we can get annotations on PRs. See the annotations generated from the PR I linked above: https://github.com/apache/unomi/actions/runs/3129456290 -- This is an automated

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7100: Traffic Router tests GHA: Include integration tests

ocket commented on PR #7100: URL: https://github.com/apache/trafficcontrol/pull/7100#issuecomment-1263905693 Well if we can't get annotations on PRs, why have the step for converting JUnit to annotations? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7100: Traffic Router tests GHA: Include integration tests

zrhoffman commented on PR #7100: URL: https://github.com/apache/trafficcontrol/pull/7100#issuecomment-1263899975 > Also it's not caching Maven dependencies because it can't find the directory at the end of the run: > > > Warning: Path Validation Error: Path(s) specified in the action

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7100: Traffic Router tests GHA: Include integration tests

zrhoffman commented on PR #7100: URL: https://github.com/apache/trafficcontrol/pull/7100#issuecomment-1263896968 > I'm still seeing the same annotations in the latest run on that JUnit-to-annotation conversion. I think that that is because the *mikepenz/action-junit-report* action is

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7100: Traffic Router tests GHA: Include integration tests

ocket commented on PR #7100: URL: https://github.com/apache/trafficcontrol/pull/7100#issuecomment-1263853338 I'm still seeing the same annotations in the latest run on that JUnit-to-annotation conversion. Also it's not caching Maven dependencies because it can't find the

[GitHub] [trafficcontrol] jhg03a opened a new issue, #7101: Traffic portal values should be loaded on click versus on page load

jhg03a opened a new issue, #7101: URL: https://github.com/apache/trafficcontrol/issues/7101 ## This Improvement request (usability, performance, tech debt, etc.) affects these Traffic Control components: - Traffic Portal ## Current behavior: Right now when

[GitHub] [trafficcontrol] rimashah25 commented on pull request #7075: Add Last Updated field to Traffic Portal

rimashah25 commented on PR #7075: URL: https://github.com/apache/trafficcontrol/pull/7075#issuecomment-1263765624 I see the `Last Updated` field in the form correctly  but in

[GitHub] [trafficcontrol] ocket8888 merged pull request #7084: TP fix filtering on Delivery Service "Targets For" column

ocket merged PR #7084: URL: https://github.com/apache/trafficcontrol/pull/7084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7100: Traffic Router tests GHA: Inclue integration tests

zrhoffman opened a new pull request, #7100: URL: https://github.com/apache/trafficcontrol/pull/7100 This Pull Request * renames the [*Traffic Router Unit Tests*](https://github.com/apache/trafficcontrol/actions/workflows/tr.unit.tests.yaml) workflow to [*Traffic Router