[GitHub] [trafficcontrol] srijeet0406 opened a new pull request, #7118: Remove ASN from servers

2022-10-10 Thread GitBox
srijeet0406 opened a new pull request, #7118: URL: https://github.com/apache/trafficcontrol/pull/7118 This PR is not related to any issue. It removes the previously added (in https://github.com/apache/trafficcontrol/pull/7023) `asns` field from the `server` struct. ##

[GitHub] [trafficcontrol] TaylorCFrey commented on a diff in pull request #7050: Add configuration setting for TO client request timeout

2022-10-10 Thread GitBox
TaylorCFrey commented on code in PR #7050: URL: https://github.com/apache/trafficcontrol/pull/7050#discussion_r991675941 ## infrastructure/ansible/roles/traffic_stats/templates/traffic_stats.cfg.j2: ## @@ -15,6 +15,7 @@ "toUser": "{{ ts_toUser }}", "toPasswd":

[GitHub] [trafficcontrol] zrhoffman merged pull request #7117: Remove unused TR profile params from docs

2022-10-10 Thread GitBox
zrhoffman merged PR #7117: URL: https://github.com/apache/trafficcontrol/pull/7117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] rawlinp opened a new pull request, #7117: Remove unused TR profile params from docs

2022-10-10 Thread GitBox
rawlinp opened a new pull request, #7117: URL: https://github.com/apache/trafficcontrol/pull/7117 These "TR profile parameters" do not actually exist. ## Which Traffic Control components are affected by this PR? - Documentation ## What is the best way to

[GitHub] [trafficcontrol] rimashah25 commented on pull request #7079: Assign multiple servers to a capability

2022-10-10 Thread GitBox
rimashah25 commented on PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#issuecomment-1273536182 > Sorry just seeing this, where are those checks? I usually do a POST followed by a GET to make sure whether or not the operation actually went through to the database or

[GitHub] [trafficcontrol] srijeet0406 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-10-10 Thread GitBox
srijeet0406 commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r991409061 ## traffic_ops/traffic_ops_golang/server/servers_server_capability.go: ## @@ -453,77 +454,166 @@ func AssignMultipleServerCapabilities(w

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-10-10 Thread GitBox
rimashah25 commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r991381409 ## traffic_ops/traffic_ops_golang/server/servers_server_capability.go: ## @@ -453,77 +454,166 @@ func AssignMultipleServerCapabilities(w http.ResponseWriter,

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-10-10 Thread GitBox
rimashah25 commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r991379510 ## docs/source/api/v4/multiple_servers_capabilities.rst: ## @@ -0,0 +1,190 @@ +.. +.. +.. Licensed under the Apache License, Version 2.0 (the "License"); +..

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-10-10 Thread GitBox
rimashah25 commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r991379034 ## traffic_ops/traffic_ops_golang/server/servers_server_capability.go: ## @@ -443,8 +444,8 @@ func getDSTenantIDsByIDs(tx *sqlx.Tx, dsIDs []int64)