[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7068: Renamed rascal to tm/traffic_monitor

2022-10-20 Thread GitBox
ocket commented on code in PR #7068: URL: https://github.com/apache/trafficcontrol/pull/7068#discussion_r1001067763 ## traffic_ops/traffic_ops_golang/server/servers.go: ## @@ -856,6 +856,12 @@ func getServers(h http.Header, params map[string]string, tx *sqlx.Tx, user *auth

[GitHub] [trafficcontrol] zrhoffman merged pull request #7144: Use Generics in TO Integration Tests

2022-10-20 Thread GitBox
zrhoffman merged PR #7144: URL: https://github.com/apache/trafficcontrol/pull/7144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7150: Retract versions v1.1.0 through v1.1.5 from Go modules

2022-10-20 Thread GitBox
zrhoffman commented on PR #7150: URL: https://github.com/apache/trafficcontrol/pull/7150#issuecomment-1285947757 We could also tag it something like `v1.1.5-retraction`, it doesn't need to be named only `v1.1.5` -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7150: Retract versions v1.1.0 through v1.1.5 from Go modules

2022-10-20 Thread GitBox
zrhoffman opened a new pull request, #7150: URL: https://github.com/apache/trafficcontrol/pull/7150 This PR retracts `v1.1.0`, `v1.1.1`, `v1.1.2`, `v1.1.3`, `v1.1.4`, and `v1.1.5` from Go modules. If this PR is merged, it should be tagged version `v1.1.5`. Without this PR

[GitHub] [trafficcontrol] ocket8888 merged pull request #7118: Remove ASN from servers

2022-10-20 Thread GitBox
ocket merged PR #7118: URL: https://github.com/apache/trafficcontrol/pull/7118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ericholguin commented on a diff in pull request #7144: Use Generics in TO Integration Tests

2022-10-20 Thread GitBox
ericholguin commented on code in PR #7144: URL: https://github.com/apache/trafficcontrol/pull/7144#discussion_r1000939988 ## traffic_ops/testing/api/v5/servers_hostname_update_status_test.go: ## @@ -1,18 +1,17 @@ package v5 /* + Licensed under the Apache License,

[GitHub] [trafficcontrol] ericholguin commented on a diff in pull request #7144: Use Generics in TO Integration Tests

2022-10-20 Thread GitBox
ericholguin commented on code in PR #7144: URL: https://github.com/apache/trafficcontrol/pull/7144#discussion_r1000939559 ## traffic_ops/testing/api/v4/server_server_capabilities_test.go: ## @@ -216,25 +189,26 @@ func TestServerServerCapabilities(t *testing.T) {

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7144: Use Generics in TO Integration Tests

2022-10-20 Thread GitBox
zrhoffman commented on code in PR #7144: URL: https://github.com/apache/trafficcontrol/pull/7144#discussion_r1000915015 ## traffic_ops/testing/api/v4/server_server_capabilities_test.go: ## @@ -216,25 +189,26 @@ func TestServerServerCapabilities(t *testing.T) {