[GitHub] [trafficcontrol] srijeet0406 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-10-27 Thread GitBox
srijeet0406 commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r1007454984 ## traffic_ops/traffic_ops_golang/server/servers_server_capability.go: ## @@ -453,77 +443,185 @@ func AssignMultipleServerCapabilities(w

[GitHub] [trafficcontrol] srijeet0406 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-10-27 Thread GitBox
srijeet0406 commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r1007454708 ## traffic_ops/traffic_ops_golang/server/servers_server_capability.go: ## @@ -453,77 +443,185 @@ func AssignMultipleServerCapabilities(w

[GitHub] [trafficcontrol] ocket8888 merged pull request #7160: Consider DS Regional field for MaxOriginConnections of Edge Caches

2022-10-27 Thread GitBox
ocket merged PR #7160: URL: https://github.com/apache/trafficcontrol/pull/7160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7162: updated tomcat version to 1.2.35

2022-10-27 Thread GitBox
zrhoffman commented on PR #7162: URL: https://github.com/apache/trafficcontrol/pull/7162#issuecomment-1293800151 Although this works, the next time the tomcat-native version is updated, it should be something like `tomcat-native-1.*`, since any tomcat-native version 1 will work (version 2

[GitHub] [trafficcontrol] zrhoffman merged pull request #7162: updated tomcat version to 1.2.35

2022-10-27 Thread GitBox
zrhoffman merged PR #7162: URL: https://github.com/apache/trafficcontrol/pull/7162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ragen14 opened a new pull request, #7162: updated tomcat version to 1.2.35

2022-10-27 Thread GitBox
ragen14 opened a new pull request, #7162: URL: https://github.com/apache/trafficcontrol/pull/7162 ## Which Traffic Control components are affected by this PR? - Traffic Router - Automation ## What is the best way to verify this PR? install

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7160: Consider DS Regional field for MaxOriginConnections of Edge Caches

2022-10-27 Thread GitBox
zrhoffman commented on code in PR #7160: URL: https://github.com/apache/trafficcontrol/pull/7160#discussion_r1007114313 ## lib/go-atscfg/headerrewritedotconfig_test.go: ## @@ -496,42 +407,91 @@ func TestGetAssignedMids(t *testing.T) { ID:

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7160: Consider DS Regional field for MaxOriginConnections of Edge Caches

2022-10-27 Thread GitBox
ocket commented on code in PR #7160: URL: https://github.com/apache/trafficcontrol/pull/7160#discussion_r1007048872 ## lib/go-atscfg/headerrewritedotconfig_test.go: ## @@ -496,42 +407,91 @@ func TestGetAssignedMids(t *testing.T) { ID:

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-10-27 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1006437034 ## traffic_ops/testing/api/v4/tc-fixtures.json: ## @@ -907,7 +907,7 @@ "regexRemap": null, "regionalGeoBlocking": false,

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-10-27 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1006436587 ## traffic_ops/v5-client/deliveryservice_requests.go: ## @@ -58,31 +58,31 @@ func (to *Session) CreateDeliveryServiceRequest(dsr