[GitHub] [trafficcontrol] ocket8888 commented on issue #3503: Comparison using is when operands support __eq__

2019-09-17 Thread GitBox
ocket commented on issue #3503: Comparison using is when operands support __eq__ URL: https://github.com/apache/trafficcontrol/pull/3503#issuecomment-532310719 Obsolete as of #3691 This is an automated message from the

[GitHub] [trafficcontrol] ocket8888 commented on issue #3503: Comparison using is when operands support __eq__

2019-04-18 Thread GitBox
ocket commented on issue #3503: Comparison using is when operands support __eq__ URL: https://github.com/apache/trafficcontrol/pull/3503#issuecomment-484700819 I disagree. One of the big things pushed for in the new template was "what versions of TC are affected by this bug?". This

[GitHub] [trafficcontrol] ocket8888 commented on issue #3503: Comparison using is when operands support __eq__

2019-04-18 Thread GitBox
ocket commented on issue #3503: Comparison using is when operands support __eq__ URL: https://github.com/apache/trafficcontrol/pull/3503#issuecomment-484683232 I didn't realize there was a size limit on integers. Wonder how it handles negative integers?

[GitHub] [trafficcontrol] ocket8888 commented on issue #3503: Comparison using is when operands support __eq__

2019-04-18 Thread GitBox
ocket commented on issue #3503: Comparison using is when operands support __eq__ URL: https://github.com/apache/trafficcontrol/pull/3503#issuecomment-484681524 That is a good change, but an interesting tidbit: in CPython this actually works properly because the interpreter will cache